Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Guangya Liu]

> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote:
> > src/master/validation.cpp, lines 692-711
> > 
> >
> > Can you please add some test cases to cover those scenarios?
> > 
> > 1) authentication is enabled and reservation does not have principal.
> > 2) authentication is enabled and reservation pricipal does not same as 
> > authentication principal.
> > 3) authentication is disabled but reservation has principal.

Seems 2) was covered by `ReservationEndpointsTest, NonMatchingPrincipal`, but 
1) and 3) was not covered for now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review119589
---


On 二月 17, 2016, 8:45 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated 二月 17, 2016, 8:45 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> This isn't necessary, and removing that requirement is tracked in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/#review119589
---




src/master/validation.cpp (lines 675 - 694)


Can you please add some test cases to cover those scenarios?

1) authentication is enabled and reservation does not have principal.
2) authentication is enabled and reservation pricipal does not same as 
authentication principal.
3) authentication is disabled but reservation has principal.



src/tests/master_validation_tests.cpp (line 385)


s/principal/`principal`


- Guangya Liu


On 二月 17, 2016, 8:45 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43639/
> ---
> 
> (Updated 二月 17, 2016, 8:45 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed dynamic reservation without a principal.
> 
> The `ReservationInfo.principal` field has been migrated to `optional`, which 
> means we can now allow dynamic reservation and unreservation without a 
> principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
> endpoints when HTTP authentication is disabled.
> 
> Note that we still require that frameworks/operators set the 
> `ReservationInfo.principal` field to match their own principal, if present. 
> This isn't necessary, and removing that requirement is tracked in MESOS-4696.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
> 
> Diff: https://reviews.apache.org/r/43639/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Also manually reserved/unreserved resources using curl, with a command like 
> this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
> resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
> "role": "ads", "reservation": { } } ]'  -X POST 
> http://127.0.0.1:5050/master/reserve`
> 
> Inspecting `/master/state` before & after these operations confirmed that the 
> reserve/unreserve operations were successful.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43712: Documented how the replicated log works.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43712/#review119591
---



Bad patch!

Reviews applied: [43712]

Failed command: ./support/apply-review.sh -n -r 43712

Error:
2016-02-18 06:37:55 URL:https://reviews.apache.org/r/43712/diff/raw/ 
[24560/24560] -> "43712.patch" [1]
error: missing binary patch data for 'docs/images/log-architecture.png'
error: binary patch does not apply to 'docs/images/log-architecture.png'
error: docs/images/log-architecture.png: patch does not apply
error: missing binary patch data for 'docs/images/log-cluster.png'
error: binary patch does not apply to 'docs/images/log-cluster.png'
error: docs/images/log-cluster.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11508/console

- Mesos ReviewBot


On Feb. 18, 2016, 6:19 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43712/
> ---
> 
> (Updated Feb. 18, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-1471
> https://issues.apache.org/jira/browse/MESOS-1471
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is closely based on an (unpublished) blog post by Jie Yu.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/images/log-architecture.png PRE-CREATION 
>   docs/images/log-cluster.png PRE-CREATION 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/replicated-log-internals.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43712/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43712: Documented how the replicated log works.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43712/
---

Review request for mesos, Anand Mazumdar, Jie Yu, and Timothy Chen.


Bugs: MESOS-1471
https://issues.apache.org/jira/browse/MESOS-1471


Repository: mesos


Description
---

This is closely based on an (unpublished) blog post by Jie Yu.


Diffs
-

  docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
  docs/high-availability-framework-guide.md 
f21f95f24c0e9f3c4376b64e6a5776aafec39172 
  docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
  docs/images/log-architecture.png PRE-CREATION 
  docs/images/log-cluster.png PRE-CREATION 
  docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
  docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
  docs/replicated-log-internals.md PRE-CREATION 

Diff: https://reviews.apache.org/r/43712/diff/


Testing
---

Previewed on github gist.


Thanks,

Neil Conway

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/
---

(Updated Feb. 18, 2016, 5:49 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703


Repository: mesos


Description
---

CMake:[1/3] Move Stout configuration to its own file.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
a27cb98fa45cbd135ebfeca65e215fb3ff054739 

Diff: https://reviews.apache.org/r/43697/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Abhishek Dasgupta]

> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote:
> > I see you send TASK_KILLING once the killTask() is invoked. However, 
> > according to the description of MESOS-4140, we may need to send such status 
> > update after SIGTERM is sent to the task and before SIGKILL is sent. So 
> > maybe you should send TASK_KILLING in shutdown() instead?

Okay, i see. but in the case of docker executor, TASK_KILLING should come after 
docker stop. Does it sound good??


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
---


On Feb. 16, 2016, 10:23 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119584
---




src/launcher/http_executor.cpp (line 118)


this method and other methods not implementation of the virtual method 
should be private



src/launcher/http_executor.cpp (line 202)


should this block be put in a separate function?


- Jian Qiu


On 二月 18, 2016, 1:09 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated 二月 18, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40567, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs
-

  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b 

Diff: https://reviews.apache.org/r/43707/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40582, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
3d074a5296b4435b29792201cb9a1b021673fd97 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
3c65d0422dc6e198180d53d1c9e6cb2839137434 

Diff: https://reviews.apache.org/r/43709/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4704
https://issues.apache.org/jira/browse/MESOS-4704


Repository: mesos


Description
---

This review was originally at #40568, put up by Dario Bazan. Dario went
on paternity leave, so I've dusted it off, rebased it against the state
of the art, and gotten it ready for submission. It remains mostly
unchanged, with only minor alterations from the original.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 

Diff: https://reviews.apache.org/r/43708/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43701: Added a command executor based on the new V1 API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119583
---



Patch looks great!

Reviews applied: [43701]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 1:09 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> ---
> 
> (Updated Feb. 18, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/
---

(Updated Feb. 18, 2016, 4:54 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Moved from `process::Owned` to `std::shared_ptr` similar to 
`MesosSchedulerDriver`. This also helps when passing a `MasterDetector` object 
while testing.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Moved the detector pointer to `process::Owned` so that it is cleaned up later.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43657/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703


Repository: mesos


Description
---

CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 

Diff: https://reviews.apache.org/r/43698/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43699/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703


Repository: mesos


Description
---

CMake:[3/3] Used Stout config script in agent build.


Diffs
-

  CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 
  src/slave/cmake/SlaveConfigure.cmake a8270a9ac6ceee4f370e185bee82126c309ec134 

Diff: https://reviews.apache.org/r/43699/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703


Repository: mesos


Description
---

CMake:[1/3] Move Stout configuration to its own file.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
a27cb98fa45cbd135ebfeca65e215fb3ff054739 

Diff: https://reviews.apache.org/r/43697/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43686: Added a benchmark for allocation with labeled resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43686/#review119581
---



Patch looks great!

Reviews applied: [43684, 43685, 43686]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 12:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43686/
> ---
> 
> (Updated Feb. 18, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4691
> https://issues.apache.org/jira/browse/MESOS-4691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the particular workload exercised by the benchmark, this suggests that
> adding a 12-element label to a resource slows down allocation by about 5% on 
> my
> local machine.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 
> 
> Diff: https://reviews.apache.org/r/43686/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> FYI, results on my laptop:
> 
> _Original benchmark (unlabeled resources)_
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.DeclineOffers
> Using 2000 slaves and 200 frameworks
> round 0 allocate took 2.028175secs to make 200 offers
> round 1 allocate took 2.006791secs to make 200 offers
> round 2 allocate took 2.033723secs to make 200 offers
> round 3 allocate took 2.017508secs to make 200 offers
> round 4 allocate took 2.037235secs to make 200 offers
> round 5 allocate took 2.054095secs to make 200 offers
> round 6 allocate took 2.048884secs to make 200 offers
> round 7 allocate took 2.044252secs to make 200 offers
> round 8 allocate took 2.060256secs to make 200 offers
> round 9 allocate took 2.07121secs to make 200 offers
> round 10 allocate took 2.066261secs to make 200 offers
> round 11 allocate took 2.034805secs to make 200 offers
> round 12 allocate took 2.053705secs to make 200 offers
> round 13 allocate took 2.042106secs to make 200 offers
> round 14 allocate took 2.082704secs to make 200 offers
> 
> _New benchmark (two labeled resources with different labels)_
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
> Using 2000 slaves and 200 frameworks
> round 0 allocate took 2.128709secs to make 200 offers
> round 1 allocate took 2.188029secs to make 200 offers
> round 2 allocate took 2.145937secs to make 200 offers
> round 3 allocate took 2.171442secs to make 200 offers
> round 4 allocate took 2.153106secs to make 200 offers
> round 5 allocate took 2.151484secs to make 200 offers
> round 6 allocate took 2.136182secs to make 200 offers
> round 7 allocate took 2.152105secs to make 200 offers
> round 8 allocate took 2.187842secs to make 200 offers
> round 9 allocate took 2.13839secs to make 200 offers
> round 10 allocate took 2.237216secs to make 200 offers
> round 11 allocate took 2.164702secs to make 200 offers
> round 12 allocate took 2.143296secs to make 200 offers
> round 13 allocate took 2.198839secs to make 200 offers
> round 14 allocate took 2.179931secs to make 200 offers
> 
> For fun, I tried running the benchmark with the modified equality operator 
> for `Labels` that uses `unordered_multiset` to produce the correct results 
> for labels that contain duplicates:
> 
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
> Using 2000 slaves and 200 frameworks
> round 0 allocate took 2.190051secs to make 200 offers
> round 1 allocate took 2.169332secs to make 200 offers
> round 2 allocate took 2.156235secs to make 200 offers
> round 3 allocate took 2.15506secs to make 200 offers
> round 4 allocate took 2.133953secs to make 200 offers
> round 5 allocate took 2.18325secs to make 200 offers
> round 6 allocate took 2.164478secs to make 200 offers
> round 7 allocate took 2.192077secs to make 200 offers
> round 8 allocate took 2.14688secs to make 200 offers
> round 9 allocate took 2.172333secs to make 200 offers
> round 10 allocate took 2.199906secs to make 200 offers
> round 11 allocate took 2.16384secs to make 200 offers
> round 12 allocate took 2.200181secs to make 200 offers
> round 13 allocate took 2.138463secs to make 200 offers
> round 14 allocate took 2.184699secs to make 200 offers
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake: Fixed Find* scripts to not explode if invoked twice.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 
4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 
  3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 
c975a16975e76b38f028d7575775abd31c9090f5 

Diff: https://reviews.apache.org/r/43700/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43689: CMake: Begin to require 64-bit builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43689/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

CMake: Candidate compilation configuration finalization.


Diffs
-

  cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b 

Diff: https://reviews.apache.org/r/43689/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43695/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

Windows:[4/4] Included Socket library for 64-bit builds.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
a27cb98fa45cbd135ebfeca65e215fb3ff054739 

Diff: https://reviews.apache.org/r/43695/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43694/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

Windows:[3/4] Transitioned to static-everything builds on Windows.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/src/CMakeLists.txt 
12dfaf61b801372b6ec70c535080fde350866fb8 

Diff: https://reviews.apache.org/r/43694/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43693/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

CMake:[2/4] Transitioned ZK build to be 64-bit and static.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat 
8da05bcf8e6b2335770cff7c43218b823721d50c 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake 
632696e883e8ccb9bfa82288f62e7ad3771b043e 

Diff: https://reviews.apache.org/r/43693/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/#review119575
---



Patch looks great!

Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43664, 43667]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 10:46 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43667/
> ---
> 
> (Updated Feb. 17, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing tests to handle the new 
> `connected/disconnected` semantics that were introduced as a result of the 
> pipelining change.
> 
> Now `connected` is possible to invoked more then once i.e. during test 
> shutdown, the master closed the event stream making us call the 
> `disconnected` callback. However, the master detector can still detect the 
> same master and establish a connection to it while it is shutting down 
> leading to `connected` callback be invoked again in some cases.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43667/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43692/
---

(Updated Feb. 18, 2016, 2:26 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3525
https://issues.apache.org/jira/browse/MESOS-3525


Repository: mesos


Description
---

CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.


Diffs
-

  3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/zookeeper-06d3f3f.patch 8f8f72cb712c4bca328bf865ab082926106fbd94 
  cmake/MesosConfigure.cmake 9a4fdb57e1281d9ec421e639819de5786c11744a 
  src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 

Diff: https://reviews.apache.org/r/43692/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43691/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake:[2/2] Fixed http-parser library directory for Windows builds.


Diffs
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 

Diff: https://reviews.apache.org/r/43691/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43415/
---

(Updated Feb. 18, 2016, 2:08 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake: Moved Windows build to version of glog that builds with CMake.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 

Diff: https://reviews.apache.org/r/43415/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Guangya Liu]

> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 598
> > 
> >
> > s/Labels/One label?
> > 
> > I think that here we should use `one label` but not `labels`, becauase 
> > this can only happen if one label include duplicate key-value pairs.
> 
> Neil Conway wrote:
> Among all the key-value pairs in a `Labels`, no two pairs should be the 
> same. So I think the current text expresses that better than talking about an 
> individual label.
> 
> Guangya Liu wrote:
> May be we need to be more accurate, if `Labels should not contain 
> duplicate key-value pairs`, then how can mesos define same labels?
> 
> Neil Conway wrote:
> "Among all the key-value pairs in a Labels, no two pairs should be the 
> same." -- i.e., "[foo -> bar, foo -> bar]" is not supported. "[foo -> bar, 
> foo -> baz]" will work (although debatable whether it is a good idea).

Yes, I mean the following case: I want to define two same labels, label1 
[foo->bar], label2 [foo->bar], those are two same labels, but i think that 
current description is good enough, thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119399
---


On 二月 17, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated 二月 17, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Neil Conway]

> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 598
> > 
> >
> > s/Labels/One label?
> > 
> > I think that here we should use `one label` but not `labels`, becauase 
> > this can only happen if one label include duplicate key-value pairs.
> 
> Neil Conway wrote:
> Among all the key-value pairs in a `Labels`, no two pairs should be the 
> same. So I think the current text expresses that better than talking about an 
> individual label.
> 
> Guangya Liu wrote:
> May be we need to be more accurate, if `Labels should not contain 
> duplicate key-value pairs`, then how can mesos define same labels?

"Among all the key-value pairs in a Labels, no two pairs should be the same." 
-- i.e., "[foo -> bar, foo -> bar]" is not supported. "[foo -> bar, foo -> 
baz]" will work (although debatable whether it is a good idea).


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119399
---


On Feb. 17, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated Feb. 17, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Guangya Liu]

> On 二月 17, 2016, 1:57 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 598
> > 
> >
> > s/Labels/One label?
> > 
> > I think that here we should use `one label` but not `labels`, becauase 
> > this can only happen if one label include duplicate key-value pairs.
> 
> Neil Conway wrote:
> Among all the key-value pairs in a `Labels`, no two pairs should be the 
> same. So I think the current text expresses that better than talking about an 
> individual label.

May be we need to be more accurate, if `Labels should not contain duplicate 
key-value pairs`, then how can mesos define same labels?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119399
---


On 二月 17, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated 二月 17, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43489/#review119568
---



I see you send TASK_KILLING once the killTask() is invoked. However, according 
to the description of MESOS-4140, we may need to send such status update after 
SIGTERM is sent to the task and before SIGKILL is sent. So maybe you should 
send TASK_KILLING in shutdown() instead?

- Qian Zhang


On Feb. 16, 2016, 6:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43489/
> ---
> 
> (Updated Feb. 16, 2016, 6:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> KillTask introduces TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 
>   src/launcher/executor.cpp c27e0792e4b9bcec0829a46be4232c013d965cf9 
> 
> Diff: https://reviews.apache.org/r/43489/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/#review119567
---



Patch looks great!

Reviews applied: [43613, 43614, 43629, 43630, 43615]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 10:34 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43615/
> ---
> 
> (Updated Feb. 17, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Includes the following changes:
> 
> * Added the `` header where appropriate.
> * Added the namespace `using process::Owned;` where appropriate.
> * Generally replaced `Try` with `Owned`.  And 
> `Try` with `Owned`.
> * Added the (now required) `MasterDetector` argument to all slaves.  Before, 
> this was fetched from the first master in `Cluster`.
> * Removed `Shutdown();` from all tests.
> * Replaced `Stop(...)` with the appropriate master/slave destruction calls.
> * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
> launchers, etc).
> * Replace `CHECK` in tests with `ASSERT`.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/container_logger_tests.cpp 
> 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 1e6cb05144995c1cc12e3caa9825761fd9a0e21a 
>   src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
>   src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
>   src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
>   src/tests/executor_http_api_tests.cpp 
> 36a042ed103271ca873450236f39a8152fbbf07e 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 255ab8119a04b55bb4f1b61dee19c4be64499376 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 
>   src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 6069ca1e9ed278459c5182e438417e95955b1924 
>   src/tests/persistent_volume_tests.cpp 
> e169e1b141a38dc389eefd42c11a078c413123d5 
>   src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
>   src/tests/registrar_zookeeper_tests.cpp 
> 3df9779ee5d076e16f6a538326693a36f986b6d0 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
>   src/tests/resource_offers_tests.cpp 
> 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
>   

Review Request 43701: Added a command executor based on the new V1 API.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added a command executor based on the new V1 API.


Diffs
-

  docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
  src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
  src/launcher/http_executor.cpp PRE-CREATION 
  src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
  src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
  src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 

Diff: https://reviews.apache.org/r/43701/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43418/
---

(Updated Feb. 18, 2016, 1:01 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Added slave/status_update_manager.cpp and other files.


Diffs (updated)
-

  src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 

Diff: https://reviews.apache.org/r/43418/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake:[1/2] Allow downloading third-party dependencies from mirror.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 3253da73aa517a335be94148d567510147dae08d 
  CMakeLists.txt 7f83dc84997d3b824d1f63012894bd9fc5284053 

Diff: https://reviews.apache.org/r/43413/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Marked functions in headers `inline` to avoid linker errors.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
046388189823c0c41ce6cc135d5d3838e9131087 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
9a592c4ec9f45fdd8ae8c724c3cab67876de72f5 

Diff: https://reviews.apache.org/r/43417/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43410: Windows: Added support for dynamic library loading.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43410/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4496
https://issues.apache.org/jira/browse/MESOS-4496


Repository: mesos


Description
---

Originally review #40583, this was resurrected when Dario went on
paternity leave. Minor changes were made, the review itself remains
largely in tact.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
166c97d3e4b07451b8b4c01092cecb69315c691a 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/43410/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43416/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Removed ambiguous call to `::write`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
88b355e09f76f0412c74ad69556572f0079deb8f 

Diff: https://reviews.apache.org/r/43416/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43414/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

CMake:[2/2] Canonicalize location of third-party dependencies.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 

Diff: https://reviews.apache.org/r/43414/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43409/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

Windows: Added `src/resource_estimator.cpp` to build.


Diffs (updated)
-

  src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 

Diff: https://reviews.apache.org/r/43409/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43411/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4496
https://issues.apache.org/jira/browse/MESOS-4496


Repository: mesos


Description
---

Windows: Added dynamic library loading tests to build.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
3c65d0422dc6e198180d53d1c9e6cb2839137434 
  3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 
27626ae28db090f1a002239ff5c674b82e8fc9a8 

Diff: https://reviews.apache.org/r/43411/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/
---

(Updated Feb. 18, 2016, 12:59 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

CMake: Force GMock to build and link statically.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
9b61376ea6aad304607c20c9823d9ef19013eca0 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 

Diff: https://reviews.apache.org/r/43407/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119564
---


Ship it!




[~kdevroede] Your patch looks nice. Could you ask [~tnachen] or other 
committers whether he have cycles to shepherd you in this ticket? Then he could 
help you review and commit this.

- haosdent huang


On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> ---
> 
> (Updated Feb. 17, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-4693
> https://issues.apache.org/jira/browse/MESOS-4693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
> 
> 
> Diffs
> -
> 
>   src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42 
>   src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae 
> 
> Diff: https://reviews.apache.org/r/43676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Devroede
> 
>

Review Request 43686: Added a benchmark for allocation with labeled resources.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43686/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Bugs: MESOS-4691
https://issues.apache.org/jira/browse/MESOS-4691


Repository: mesos


Description
---

For the particular workload exercised by the benchmark, this suggests that
adding a 12-element label to a resource slows down allocation by about 5% on my
local machine.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 

Diff: https://reviews.apache.org/r/43686/diff/


Testing
---

make check

FYI, results on my laptop:

_Original benchmark (unlabeled resources)_
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.DeclineOffers
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.028175secs to make 200 offers
round 1 allocate took 2.006791secs to make 200 offers
round 2 allocate took 2.033723secs to make 200 offers
round 3 allocate took 2.017508secs to make 200 offers
round 4 allocate took 2.037235secs to make 200 offers
round 5 allocate took 2.054095secs to make 200 offers
round 6 allocate took 2.048884secs to make 200 offers
round 7 allocate took 2.044252secs to make 200 offers
round 8 allocate took 2.060256secs to make 200 offers
round 9 allocate took 2.07121secs to make 200 offers
round 10 allocate took 2.066261secs to make 200 offers
round 11 allocate took 2.034805secs to make 200 offers
round 12 allocate took 2.053705secs to make 200 offers
round 13 allocate took 2.042106secs to make 200 offers
round 14 allocate took 2.082704secs to make 200 offers

_New benchmark (two labeled resources with different labels)_
[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.128709secs to make 200 offers
round 1 allocate took 2.188029secs to make 200 offers
round 2 allocate took 2.145937secs to make 200 offers
round 3 allocate took 2.171442secs to make 200 offers
round 4 allocate took 2.153106secs to make 200 offers
round 5 allocate took 2.151484secs to make 200 offers
round 6 allocate took 2.136182secs to make 200 offers
round 7 allocate took 2.152105secs to make 200 offers
round 8 allocate took 2.187842secs to make 200 offers
round 9 allocate took 2.13839secs to make 200 offers
round 10 allocate took 2.237216secs to make 200 offers
round 11 allocate took 2.164702secs to make 200 offers
round 12 allocate took 2.143296secs to make 200 offers
round 13 allocate took 2.198839secs to make 200 offers
round 14 allocate took 2.179931secs to make 200 offers

For fun, I tried running the benchmark with the modified equality operator for 
`Labels` that uses `unordered_multiset` to produce the correct results for 
labels that contain duplicates:

[ RUN  ] HierarchicalAllocator_BENCHMARK_Test.ResourceLabels
Using 2000 slaves and 200 frameworks
round 0 allocate took 2.190051secs to make 200 offers
round 1 allocate took 2.169332secs to make 200 offers
round 2 allocate took 2.156235secs to make 200 offers
round 3 allocate took 2.15506secs to make 200 offers
round 4 allocate took 2.133953secs to make 200 offers
round 5 allocate took 2.18325secs to make 200 offers
round 6 allocate took 2.164478secs to make 200 offers
round 7 allocate took 2.192077secs to make 200 offers
round 8 allocate took 2.14688secs to make 200 offers
round 9 allocate took 2.172333secs to make 200 offers
round 10 allocate took 2.199906secs to make 200 offers
round 11 allocate took 2.16384secs to make 200 offers
round 12 allocate took 2.200181secs to make 200 offers
round 13 allocate took 2.138463secs to make 200 offers
round 14 allocate took 2.184699secs to make 200 offers


Thanks,

Neil Conway

Review Request 43685: Refactored test helper code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

Refactored test helper code.


Diffs
-

  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 

Diff: https://reviews.apache.org/r/43685/diff/


Testing
---

make check


Thanks,

Neil Conway

Review Request 43684: Cleaned up allocator benchmark code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43684/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

Cleaned up allocator benchmark code.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 

Diff: https://reviews.apache.org/r/43684/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

[Klaus Ma]

> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote:
> > General questions:
> > 
> > - Besides removing the possibility for overcommit, does this change give us 
> > anything else?
> > - What happens if a master sends this modified `TaskInfo` to an agent that 
> > does not have this chain of patches?
> > - Have you considered completely converting a `CommandInfo` to 
> > `ExecutorInfo`?  If we do that, it may be possible to remove all the other 
> > places with special logic for command tasks.
> 
> Klaus Ma wrote:
> * It's more for evicting executor by master, there's several EPICs about 
> sharing resources between frameworks; and all of them need the feature to let 
> resources owner get resouces back: MESOS-4303 (reclaim/preemption in Mesos), 
> "Optimsitic Offer Phase 2", "Borrow/Lend policy on Quota" (draft idea in my 
> mind)
> 
> * Good point! If did not get required info, e.g. `launch_dir`, we should 
> keep the same behaviour as before: let salve trace the executor info.
> 
> * Yes, I'm used to add `taskCommand` into `ExecutorInfo`; but when launch 
> docker executor, it need task info which is different with normal executor. 
> In this patch, I'd like to focus on moving the executor info into master.

@Joseph, any more comments?


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
---


On Feb. 18, 2016, 7:45 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
> ---
> 
> (Updated Feb. 18, 2016, 7:45 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-1718
> https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-1718: move getExecutorInfo from slave to master
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/slave.hpp ced835dec797bcc5640422468487a4289a737e38 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/41305/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41302/
---

(Updated Feb. 18, 2016, 7:46 a.m.)


Review request for mesos, Ben Mahler, Ian Downes, Joseph Wu, and Vinod Kone.


Changes
---

rebase


Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718


Repository: mesos


Description
---

MESOS-1718: add slave's configuration into SlaveInfo


Diffs (updated)
-

  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/41302/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41308/
---

(Updated Feb. 18, 2016, 7:45 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

rebase for code conflict


Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718


Repository: mesos


Description
---

MESOS-1718: Unit Test for moving getExecutorInfo from slave to master


Diffs (updated)
-

  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
  src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 

Diff: https://reviews.apache.org/r/41308/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/
---

(Updated Feb. 18, 2016, 7:45 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

rebase for code conflict


Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718


Repository: mesos


Description
---

MESOS-1718: move getExecutorInfo from slave to master


Diffs (updated)
-

  src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/slave.hpp ced835dec797bcc5640422468487a4289a737e38 
  src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 

Diff: https://reviews.apache.org/r/41305/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41306/
---

(Updated Feb. 18, 2016, 7:45 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

rebase for code conflict


Bugs: MESOS-1718
https://issues.apache.org/jira/browse/MESOS-1718


Repository: mesos


Description
---

MESOS-1718: use command line executor to launch tasks


Diffs (updated)
-

  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 

Diff: https://reviews.apache.org/r/41306/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119551
---



Patch looks great!

Reviews applied: [43676]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> ---
> 
> (Updated Feb. 17, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-4693
> https://issues.apache.org/jira/browse/MESOS-4693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
> 
> 
> Diffs
> -
> 
>   src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42 
>   src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae 
> 
> Diff: https://reviews.apache.org/r/43676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Devroede
> 
>

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
---

(Updated Feb. 17, 2016, 10:46 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Modified Maintenance tests.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change modifies the existing tests to handle the new 
`connected/disconnected` semantics that were introduced as a result of the 
pipelining change.

Now `connected` is possible to invoked more then once i.e. during test 
shutdown, the master closed the event stream making us call the `disconnected` 
callback. However, the master detector can still detect the same master and 
establish a connection to it while it is shutting down leading to `connected` 
callback be invoked again in some cases.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43667/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43664/
---

(Updated Feb. 17, 2016, 10:45 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change modifies the existing `SchedulerTest.Subscribe` to just test if we 
are able to subscribe with the master instead of also testing for scheduler 
failover. 

Added a `TODO` to add a separate test for testing scheduler failover once 
MESOS-3339 is resolved. The reasoning for doing so was that the callback 
interface would simplify writing the test.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43664/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43642: Updated comments and docs for '/(un)reserve' without principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
---

(Updated Feb. 17, 2016, 10:36 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Summary (updated)
-

Updated comments and docs for '/(un)reserve' without principal.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Updated comments and docs for '/reserve' and '/unreserve' without principal.


Diffs
-

  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/43642/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review119540
---



Bad patch!

Reviews applied: [43639, 43641, 43642]

Failed command: ./support/apply-review.sh -n -r 43642

Error:
2016-02-17 22:35:45 URL:https://reviews.apache.org/r/43642/diff/raw/ 
[3158/3158] -> "43642.patch" [1]
No files to lint

Error: Commit message summary (the first line) must not exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/11499/console

- Mesos ReviewBot


On Feb. 17, 2016, 8:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43642/
> ---
> 
> (Updated Feb. 17, 2016, 8:56 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3940
> https://issues.apache.org/jira/browse/MESOS-3940
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated comments and docs for '/reserve' and '/unreserve' without principal.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/
---

(Updated Feb. 17, 2016, 2:34 p.m.)


Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Changes
---

Fix some extra spaces that snuck in.  Update test results.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Includes the following changes:

* Added the `` header where appropriate.
* Added the namespace `using process::Owned;` where appropriate.
* Generally replaced `Try` with `Owned`.  And 
`Try` with `Owned`.
* Added the (now required) `MasterDetector` argument to all slaves.  Before, 
this was fetched from the first master in `Cluster`.
* Removed `Shutdown();` from all tests.
* Replaced `Stop(...)` with the appropriate master/slave destruction calls.
* Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
launchers, etc).
* Replace `CHECK` in tests with `ASSERT`.


Diffs (updated)
-

  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
  src/tests/containerizer/docker_containerizer_tests.cpp 
645bdcf095145097d8b8c65d592c787417883145 
  src/tests/containerizer/external_containerizer_test.cpp 
8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
  src/tests/containerizer/isolator_tests.cpp 
653b037c489072f43e53dec01a811a9249dcd660 
  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
  src/tests/containerizer/port_mapping_tests.cpp 
1e6cb05144995c1cc12e3caa9825761fd9a0e21a 
  src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
  src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
  src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
  src/tests/executor_http_api_tests.cpp 
36a042ed103271ca873450236f39a8152fbbf07e 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
  src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
  src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 
  src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/persistent_volume_endpoints_tests.cpp 
6069ca1e9ed278459c5182e438417e95955b1924 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 
  src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/registrar_zookeeper_tests.cpp 
3df9779ee5d076e16f6a538326693a36f986b6d0 
  src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
  src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
  src/tests/scheduler_driver_tests.cpp f6dc25d82ae5f1e77fc6ede7ff2660ed0d9ea039 
  src/tests/scheduler_event_call_tests.cpp 
bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
  src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 
  src/tests/status_update_manager_tests.cpp 
d64d3b8c96270478f6b681c038de77c3a9eb68fe 
  src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 

Diff: 

Re: Review Request 43673: Searialized invocation of `await` in the status method.

[Avinash sridharan]

> On Feb. 17, 2016, 9:18 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1330
> > 
> >
> > Why this change?
> 
> Avinash sridharan wrote:
> During debugging was finding it hard to ascertain if the 
> `MesosContainerizer` was successfully able to complete the status request, 
> and hence thought will bump up the log to make sure we are able to track 
> every stage of the pipe line.

Removed the log level. Will create a separate patch if required.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43673/#review119525
---


On Feb. 17, 2016, 10:20 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43673/
> ---
> 
> (Updated Feb. 17, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4671
> https://issues.apache.org/jira/browse/MESOS-4671
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Searialized invocation of `await` in the status method.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 3de214d6c71773f5deb5db9fe3f527dd5064737f 
> 
> Diff: https://reviews.apache.org/r/43673/diff/
> 
> 
> Testing
> ---
> 
> make, make check and `sudo make check`
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43673: Searialized invocation of `await` in the status method.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43673/
---

(Updated Feb. 17, 2016, 10:20 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Fixed review comments.


Bugs: MESOS-4671
https://issues.apache.org/jira/browse/MESOS-4671


Repository: mesos


Description
---

Searialized invocation of `await` in the status method.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
3de214d6c71773f5deb5db9fe3f527dd5064737f 

Diff: https://reviews.apache.org/r/43673/diff/


Testing (updated)
---

make, make check and `sudo make check`


Thanks,

Avinash sridharan

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

[Mark Cavage]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/
---

(Updated Feb. 17, 2016, 10:10 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Once more, with rebasing...


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description
---

MasterContender/MasterDetector loadable as modules.


Diffs (updated)
-

  include/mesos/master/contender.hpp PRE-CREATION 
  include/mesos/master/detector.hpp PRE-CREATION 
  include/mesos/module/contender.hpp PRE-CREATION 
  include/mesos/module/detector.hpp PRE-CREATION 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/examples/test_contender_module.cpp PRE-CREATION 
  src/examples/test_detector_module.cpp PRE-CREATION 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
  src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 
  src/slave/slave.hpp ced835dec797bcc5640422468487a4289a737e38 
  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 
  src/tests/oversubscription_tests.cpp d4ae81972fd218c58a413d1968a4e9acbee52fd3 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/persistent_volume_tests.cpp 
e169e1b141a38dc389eefd42c11a078c413123d5 
  src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
  src/tests/scheduler_event_call_tests.cpp 
bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 
  src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a 

Diff: https://reviews.apache.org/r/43269/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Mark Cavage

Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

[Kevin Devroede]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/
---

Review request for mesos and haosdent huang.


Bugs: MESOS-4693
https://issues.apache.org/jira/browse/MESOS-4693


Repository: mesos


Description
---

Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.


Diffs
-

  src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42 
  src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae 

Diff: https://reviews.apache.org/r/43676/diff/


Testing
---


Thanks,

Kevin Devroede

Re: Review Request 43672: Introduced `Sequence` in container.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43672/
---

(Updated Feb. 17, 2016, 9:28 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4671
https://issues.apache.org/jira/browse/MESOS-4671


Repository: mesos


Description
---

The `Sequence` will be used to serialize the invocation for status
requests from isolators for a given container.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
7aa53f6b25384f72a8bae247f3b75e0f95db18c2 

Diff: https://reviews.apache.org/r/43672/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
---

(Updated Feb. 17, 2016, 8:56 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description (updated)
---

Updated comments and docs for '/reserve' and '/unreserve' without principal.


Diffs
-

  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/43642/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43642: Updated comments and docs for '/reserve' and '/unreserve' without principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
---

(Updated Feb. 17, 2016, 8:56 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Summary (updated)
-

Updated comments and docs for '/reserve' and '/unreserve' without principal.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Updated comments and docs for '/reserve' without principal.


Diffs
-

  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/43642/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43336: Introduced Appc image fetcher.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43336/#review119522
---


Ship it!




Ship It!

- Jie Yu


On Feb. 16, 2016, 11:36 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43336/
> ---
> 
> (Updated Feb. 16, 2016, 11:36 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3193
> https://issues.apache.org/jira/browse/MESOS-3193
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation for simple image discovery for Appc images.
> 
> TODO: Add tests.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9ab84c0898b3adce6063cc50b04ee74cf1471609 
>   src/Makefile.am 5813ab2c33a7de6b612064e894e5f15b5a474e2b 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 
> 
> Diff: https://reviews.apache.org/r/43336/diff/
> 
> 
> Testing
> ---
> 
> Tested with local http(s) server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 43642: Updated comments and docs for '/reserve' without principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/
---

Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Updated comments and docs for '/reserve' without principal.


Diffs
-

  docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 

Diff: https://reviews.apache.org/r/43642/diff/


Testing
---


Thanks,

Greg Mann

Review Request 43641: Removed unnecessary parameter from validation function.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/
---

Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Removed unnecessary parameter from validation function.

Since unreserve operations are now possible without a principal, the `bool 
hasPrincipal` parameter to the Unreserve operation validation function is no 
longer necessary.


Diffs
-

  src/master/http.cpp f92212bf69f9db51d729347fb553e74e28e105fd 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c 
  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 

Diff: https://reviews.apache.org/r/43641/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 43639: Allowed dynamic reservation without a principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/
---

(Updated Feb. 17, 2016, 8:45 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description (updated)
---

Allowed dynamic reservation without a principal.

The `ReservationInfo.principal` field has been migrated to `optional`, which 
means we can now allow dynamic reservation and unreservation without a 
principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
endpoints when HTTP authentication is disabled.

Note that we still require that frameworks/operators set the 
`ReservationInfo.principal` field to match their own principal, if present. 
This isn't necessary, and removing that requirement is tracked in MESOS-4696.


Diffs
-

  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 

Diff: https://reviews.apache.org/r/43639/diff/


Testing
---

`make check`

Also manually reserved/unreserved resources using curl, with a command like 
this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
"role": "ads", "reservation": { } } ]'  -X POST 
http://127.0.0.1:5050/master/reserve`

Inspecting `/master/state` before & after these operations confirmed that the 
reserve/unreserve operations were successful.


Thanks,

Greg Mann

Review Request 43639: Allowed dynamic reservation without a principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43639/
---

Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3940
https://issues.apache.org/jira/browse/MESOS-3940


Repository: mesos


Description
---

Allowed dynamic reservation without a principal.

The `ReservationInfo.principal` field has been migrated to `optional`, which 
means we can now allow dynamic reservation and unreservation without a 
principal. This allows the use of the `/reserve` and `/unreserve` HTTP 
endpoints when HTTP authentication is disabled.

Note that we still require that frameworks/operators set the 
`ReservationInfo.principal` field to match their own principal, if present. 
This isn't necessary, and is tracked in MESOS-4696.


Diffs
-

  src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca 
  src/tests/master_validation_tests.cpp 
6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
  src/tests/reservation_endpoints_tests.cpp 
afe81b1d38a1b3a82583720f26482ddcde8f5e85 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 

Diff: https://reviews.apache.org/r/43639/diff/


Testing
---

`make check`

Also manually reserved/unreserved resources using curl, with a command like 
this: `curl -i -d slaveId="8288b2f0-e33d-4547-a2b4-5230ba6e5279-S0" -d 
resources='[ { "name": "cpus",  "type": "SCALAR", "scalar": { "value": 3 }, 
"role": "ads", "reservation": { } } ]'  -X POST 
http://127.0.0.1:5050/master/reserve`

Inspecting `/master/state` before & after these operations confirmed that the 
reserve/unreserve operations were successful.


Thanks,

Greg Mann

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119520
---



Patch looks great!

Reviews applied: [43616]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated Feb. 17, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/
---

(Updated Feb. 17, 2016, 12:27 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
Harutyunyan.


Changes
---

Accidentally used a default capture by reference.  Changed to default capture 
by value.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope of 
test objects to the test body.

Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  The 
`Slave` object performs cleanup originally found in `cluster::Slave::stop`.  
`cluster::Master::start` and `cluster::Slave::start` were changed to factory 
methods.


Diffs (updated)
-

  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 

Diff: https://reviews.apache.org/r/43613/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Moved the detector pointer to `process::Owned` so that it is cleaned up later.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43657/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43661: Added check to not Subscribe if we are already subscribed.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43661/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change adds a check to ensure that we don't `Subscribe` again in case we 
already have a `SubscribedResponse` stream set. With pipelining, we won't be 
able to send more then 1 subscribe calls on the `Subscribe` connection.

In case, the scheduler sends two subscribe calls simultaneously before the 
subscribed response stream could be established. We would invoke the 
`disconnected`/`connected` callback, making the scheduler subscribe again.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43661/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43660: Renamed Connection to SubscribedResponse.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43660/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change renames the `Connection` object that existed previously to 
`SubscribedResponse`. This would be needed later in the review chain when we 
implement pipelining.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43660/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change modifies the existing tests to handle the new 
`connected/disconnected` semantics that were introduced as a result of the 
pipelining change.

Now `connected` is possible to invoked more then once i.e. during test 
shutdown, the master closed the event stream making us call the `disconnected` 
callback. However, the master detector can still detect the same master and 
establish a connection to it while it is shutting down leading to `connected` 
callback be invoked again in some cases.


Diffs
-

  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43667/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43658: Modified the received callback argument to be ref.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43658/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

See summary.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43658/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43664/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change modifies the existing `SchedulerTest.Subscribe` to just test if we 
are able to subscribe with the master instead of also testing for scheduler 
failover. 

Added a `TODO` to add a separate test for testing scheduler failover once 
MESOS-3339 is resolved. The reasoning for doing so was that the callback 
interface would simplify writing the test.


Diffs
-

  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43664/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43659: Cleaned up the previous queueing Calls logic.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43659/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

This change cleans up the previous queueing calls logic in favor of HTTP 
connection pipelining in the scheduler library. This review clears up the noise 
of the pipelining diff in subsequent reviews.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43659/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 43662: Added support for pipelining calls to the scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43662/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Previously, the scheduler library used to chain calls on previous call 
responses. This was inherently slow. This change adds support for pipelining 
all calls to the master on a single connection via the `http::Connection` 
abstraction in libprocess.

This change also adds support for handling various error scenarios when we 
notice a disconnection instead of just relying on the master detector for 
invoking the `disconnected` callback.


Diffs
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43662/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43546: Added common compression utilities.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43546/#review119514
---


Ship it!




Ship It!

- Jie Yu


On Feb. 13, 2016, 4:30 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43546/
> ---
> 
> (Updated Feb. 13, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4669
> https://issues.apache.org/jira/browse/MESOS-4669
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for GZIP compress and uncompress.
> 
> 
> Diffs
> -
> 
>   src/common/command_utils.hpp 738c309eac6bb2dffd517298a5105d23fc9bf371 
>   src/common/command_utils.cpp 68b7facf62b867ac831ae616dad6623ac271110e 
>   src/tests/common/command_utils_tests.cpp 
> 9207a1bd6e53a8094db47ddecdcb9d39089c4c51 
> 
> Diff: https://reviews.apache.org/r/43546/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43615/#review119512
---



Patch looks great!

Reviews applied: [43613, 43614, 43629, 43630, 43615]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 6:26 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43615/
> ---
> 
> (Updated Feb. 17, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Includes the following changes:
> 
> * Added the `` header where appropriate.
> * Added the namespace `using process::Owned;` where appropriate.
> * Generally replaced `Try` with `Owned`.  And 
> `Try` with `Owned`.
> * Added the (now required) `MasterDetector` argument to all slaves.  Before, 
> this was fetched from the first master in `Cluster`.
> * Removed `Shutdown();` from all tests.
> * Replaced `Stop(...)` with the appropriate master/slave destruction calls.
> * Wrap various slave objects in `Owned` (i.e. containerizers, isolators, 
> launchers, etc).
> * Replace `CHECK` in tests with `ASSERT`.
> 
> 
> Diffs
> -
> 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/container_logger_tests.cpp 
> 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> d8c3c81c3d5a4c4093b3d4b27bb5c123c77accfc 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 1e6cb05144995c1cc12e3caa9825761fd9a0e21a 
>   src/tests/credentials_tests.cpp 7edcc857e0f6f8e80e265deeec59d6349d392224 
>   src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012 
>   src/tests/exception_tests.cpp 6b71316d545e97f14a45daa14d0fd95204befd3b 
>   src/tests/executor_http_api_tests.cpp 
> 36a042ed103271ca873450236f39a8152fbbf07e 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 255ab8119a04b55bb4f1b61dee19c4be64499376 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
>   src/tests/master_validation_tests.cpp 
> 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 
>   src/tests/metrics_tests.cpp 106bea58b0714ae745df73597c702e4815523938 
>   src/tests/monitor_tests.cpp 869c9e032817e8859a968232d4a61556a3d53d45 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 6069ca1e9ed278459c5182e438417e95955b1924 
>   src/tests/persistent_volume_tests.cpp 
> e169e1b141a38dc389eefd42c11a078c413123d5 
>   src/tests/rate_limiting_tests.cpp caced732ded05a334861a53488ef6391885b2263 
>   src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 
>   src/tests/registrar_zookeeper_tests.cpp 
> 3df9779ee5d076e16f6a538326693a36f986b6d0 
>   src/tests/repair_tests.cpp bb104562659e135492f9857e5b452c8a0a9e97da 
>   src/tests/reservation_endpoints_tests.cpp 
> afe81b1d38a1b3a82583720f26482ddcde8f5e85 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
>   src/tests/resource_offers_tests.cpp 
> 0bad45dd1dabecc88fef1ab46e8ea26718070b33 
>   

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review119507
---



In general, I prefer scripts with a bunch of helper functions and a compact 
main() that steps through each of them. I'm not sure what the general concensus 
for the Mesos code base is, but I generally find this easier to walk through.  
Example: support/generate-endpoint-help.py


support/push-reviews.py (line 19)


need to import sys



support/push-reviews.py (lines 27 - 30)


Do we have guidelines for indentation here?  When writing the 
support/generate-endpoints-help.py script, bmahler suggested something 
different than what you have here.



support/push-reviews.py (lines 32 - 39)


If the tracking branch is reauired to be of the form `remote/branch` (as 
mentioned in a later comment), what do we need the `remote` flag for?



support/push-reviews.py (line 52)


We need some sort of way to enforce that the tracking branch is always of 
the form `remote/branch`. Otherwise, if we run e.g.

```
$ klueska@c99:~/projects/mesos$ support/push-reviews.py -t master
```

remote gets set to `master` here, which obviously breaks things later on.



support/push-reviews.py (lines 108 - 112)


As we close the review, we should also post a comment to reviewboard with 
the commit message we actually pushed to master.

You can use the --description flag:

https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/


- Kevin Klues


On Feb. 17, 2016, 12:31 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43552/
> ---
> 
> (Updated Feb. 17, 2016, 12:31 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-3929
> https://issues.apache.org/jira/browse/MESOS-3929
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script allows committers to push locally applied review chain to the ASF
> git repo and mark the reviews as submitted.
> 
> 
> Diffs
> -
> 
>   support/push-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43552/diff/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/
---

(Updated Feb. 17, 2016, 6:49 p.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Address some more code review comments.


Bugs: MESOS-4687
https://issues.apache.org/jira/browse/MESOS-4687


Repository: mesos


Description
---

Scalar resource values are represented using floating point. As a result, users
could see unexpected results when accepting offers and making reservations for
fractional resources: values like "0.1" cannot be precisely represented using
standard floating point, and the resource values returned to frameworks might
contain an unpredictable amount of roundoff error.

This commit adjusts the master to use fixed-point when doing internal
computations on scalar resource values. The fixed-point format only supports
three decimal digits of precision: that is, fractional resource values like
"0.001" will be supported, but "0.0001" will not be.


Diffs (updated)
-

  docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
  docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
  include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
  include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
  src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
  src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
  src/master/allocator/mesos/hierarchical.cpp 
a9d2c23162892e0f97d89a076d2311091d91 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
  src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 

Diff: https://reviews.apache.org/r/43635/diff/


Testing
---

make check

Manually verified that some of the floating point oddities in 
https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
is applied, although I wasn't able to reproduce the crash described in that 
ticket.

REVIEW NOTES:

* We don't currently emit a warning when discarding additional digits of 
precision from input scalar resource values. Should we? That would require 
identifying all the points where a resource value is seemed to be 
"user-provided", and also runs the risk of generating a ton of log messages 
when an old framework is used.
* Similarly, if the user gives us a resource value and we don't do anything to 
it, we won't discard any additional precision that appears in the value -- the 
precision only gets discarded when we apply an operator like `+` or `-`. 
Unclear if we should trim additional precision from all scalar resource values 
more aggressively.


Thanks,

Neil Conway

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

[Neil Conway]

> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote:
> > src/common/values.cpp, line 67
> > 
> >
> > Let's add check on overflow; it will be helpful if scalar value was 
> > big. Scalar is a general type, there maybe used with a big value, e.g. 
> > total size of distributed filesystem.
> 
> Neil Conway wrote:
> What should we do in case of overflow?
> 
> Note that we don't check for overflow in operator+ (or for negative 
> result values in operator-)...
> 
> Klaus Ma wrote:
> `CHECK` or warning log should be fine, it only improves the debugability; 
> it different with `operator+` because `max_double/2` should be big enough for 
> us; but for `double * 1000 -> long`, I'm not sure of that.
> 
> And I think we need to use `long long` or `int64` instead of `long`; 
> `long` is not garantee to be 64bit in c++.

re: `long`, good point -- we only officially support 64-bit OSX, Linux, and 
Windows, but `long` is 32-bit on Windows.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43635/#review119382
---


On Feb. 17, 2016, 12:49 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43635/
> ---
> 
> (Updated Feb. 17, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-4687
> https://issues.apache.org/jira/browse/MESOS-4687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Scalar resource values are represented using floating point. As a result, 
> users
> could see unexpected results when accepting offers and making reservations for
> fractional resources: values like "0.1" cannot be precisely represented using
> standard floating point, and the resource values returned to frameworks might
> contain an unpredictable amount of roundoff error.
> 
> This commit adjusts the master to use fixed-point when doing internal
> computations on scalar resource values. The fixed-point format only supports
> three decimal digits of precision: that is, fractional resource values like
> "0.001" will be supported, but "0.0001" will not be.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   include/mesos/mesos.proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/common/resources.cpp 5d731870542166cec11f9956ccdf16207b2d22cc 
>   src/common/values.cpp c64407bc97ad858300f4661d616e0480920fc541 
>   src/master/allocator/mesos/hierarchical.cpp 
> a9d2c23162892e0f97d89a076d2311091d91 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/v1/resources.cpp 207eb61d6a6d03d314539d42751cac65fcffa9af 
>   src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
> 
> Diff: https://reviews.apache.org/r/43635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Manually verified that some of the floating point oddities in 
> https://issues.apache.org/jira/browse/MESOS-4071 do not occur when this patch 
> is applied, although I wasn't able to reproduce the crash described in that 
> ticket.
> 
> REVIEW NOTES:
> 
> * We don't currently emit a warning when discarding additional digits of 
> precision from input scalar resource values. Should we? That would require 
> identifying all the points where a resource value is seemed to be 
> "user-provided", and also runs the risk of generating a ton of log messages 
> when an old framework is used.
> * Similarly, if the user gives us a resource value and we don't do anything 
> to it, we won't discard any additional precision that appears in the value -- 
> the precision only gets discarded when we apply an operator like `+` or `-`. 
> Unclear if we should trim additional precision from all scalar resource 
> values more aggressively.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43616: Documented that labels should not contain duplicate key-value pairs.

[Neil Conway]

> On Feb. 17, 2016, 1:57 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 598
> > 
> >
> > s/Labels/One label?
> > 
> > I think that here we should use `one label` but not `labels`, becauase 
> > this can only happen if one label include duplicate key-value pairs.

Among all the key-value pairs in a `Labels`, no two pairs should be the same. 
So I think the current text expresses that better than talking about an 
individual label.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43616/#review119399
---


On Feb. 16, 2016, 7:15 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43616/
> ---
> 
> (Updated Feb. 16, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The implementation of the equality operator for `Labels` is buggy for labels
> that contain duplicates. We might want to revisit fixing the implementation of
> that operator (which might be expensive; MESOS-4445), but in the short-term we
> should document that duplicates should not be specified.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0bd5abadb5abe052161963ca995c396f1ed832f2 
>   include/mesos/v1/mesos.proto 38e04cb19e303d1c71d2afad6ea73137aaa7403a 
> 
> Diff: https://reviews.apache.org/r/43616/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/
---

(Updated Feb. 17, 2016, 10:25 a.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
Harutyunyan.


Changes
---

Moved `populate` private helper functions into lambda closures.  Expanded on 
cleanup comments.


Bugs: MESOS-4633 and MESOS-4634
https://issues.apache.org/jira/browse/MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4634


Repository: mesos


Description
---

Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope of 
test objects to the test body.

Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  The 
`Slave` object performs cleanup originally found in `cluster::Slave::stop`.  
`cluster::Master::start` and `cluster::Slave::start` were changed to factory 
methods.


Diffs (updated)
-

  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 

Diff: https://reviews.apache.org/r/43613/diff/


Testing
---

Tests are run at the end of this review chain.


Thanks,

Joseph Wu

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119501
---




src/slave/containerizer/docker.cpp (lines 1785 - 1790)


the destroy can be initiated by the slave, right? it's possible that 
`docker->stop` above failed (meaning that the container is still running). You 
should not remove mounts in that case, isn't it?


- Jie Yu


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 1785-1790
> > 
> >
> > Hum, I think we shouldn't remove the volumes if the container might be 
> > still running. So can we move the cleanup logics to `___destroy()`?

We don't unmount when it's running, it's only running when it's in the RUNNING 
state.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 1701-1708
> > 
> >
> > Why do you need to do this? Looks like we don't mount until pulling is 
> > done. Am I missing something?

The reason is that I didn't add a new state that distinguishes mounting the 
persistent volumes from pulling, so when we destroy when a container is in 
PULLING state I assume we might already mounted volumes. I've added a new state 
so we're now more explicit.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 473-488
> > 
> >
> > There's a os::exists check in linux fs isolator which you removed. This 
> > is fine because we won't update volumes when containerizer->update is 
> > called. I think we should at least drop a TODO here
> > so that we don't forget that when we want to support 
> > containerizer->update.
> > 
> > Alternatively, we can kill updatePersistentVolumes and inline it into 
> > mountPersistentVolumes.
> 
> Timothy Chen wrote:
> I think I simply forgot about it, let me add them.

Actually I'll just drop a TODO since we don't support update as you mentioned.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119490
---



Patch looks great!

Reviews applied: [43608, 42696, 43367]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 17, 2016, 4:55 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 17, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Joseph Wu]

> On Feb. 17, 2016, 8:32 a.m., Bernd Mathiske wrote:
> > src/tests/cluster.hpp, line 91
> > 
> >
> > What do you mean by "some" of its state?

In both of these objects, we don't do everything possible to cleanup.  Some 
things might be left behind (i.e. files in the sandbox, docker stuff, etc).  

I'll expand the comment to include exactly what we clean up:

* We call the destructors of each owned individual injection.
* For master, we unset an authenticator.
* For agent, we destroy containers and undo some cgroups.


> On Feb. 17, 2016, 8:32 a.m., Bernd Mathiske wrote:
> > src/tests/cluster.cpp, line 106
> > 
> >
> > How about using an inline closure with return type void here? Then you 
> > don't have to declare populate in the header and you don't have to pass all 
> > these parameters, you can capture them.
> > 
> > AFAIK we are merely solving a syntactical problem here: macro ASSERT_* 
> > contains "return ..." with a return type that does not match start(). Right?

Yeah, that seems neater.  Changing...


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/#review119464
---


On Feb. 16, 2016, 2:15 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43613/
> ---
> 
> (Updated Feb. 16, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
> Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope 
> of test objects to the test body.
> 
> Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  
> The `Slave` object performs cleanup originally found in 
> `cluster::Slave::stop`.  `cluster::Master::start` and `cluster::Slave::start` 
> were changed to factory methods.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
> 
> Diff: https://reviews.apache.org/r/43613/diff/
> 
> 
> Testing
> ---
> 
> Tests are run at the end of this review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

[Mark Cavage]

> On Feb. 15, 2016, 6:25 p.m., Benjamin Hindman wrote:
> > src/master/contender.cpp, line 80
> > 
> >
> > Why the removal of the `Option`? Conveying the information via an empty 
> > string is far less explicit and not our preferred approach in the code 
> > base. Can you elaborate?

I thought it best to make the interface an "outside" consumer not depend on the 
stout package, but I didn't realize those headers are all shipped with mesos 
anyway, and there's precedence. Changed back to using `Option`.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/#review119232
---


On Feb. 17, 2016, 4:56 p.m., Mark Cavage wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43269/
> ---
> 
> (Updated Feb. 17, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender/MasterDetector loadable as modules.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
>   include/mesos/module/contender.hpp PRE-CREATION 
>   include/mesos/module/detector.hpp PRE-CREATION 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
>   src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
>   src/examples/test_contender_module.cpp PRE-CREATION 
>   src/examples/test_detector_module.cpp PRE-CREATION 
>   src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
>   src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 
>   src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 6375586c31b1fd406529bf299dad6e321b945de8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_tests.cpp 
> cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
>   src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
>   src/tests/scheduler_event_call_tests.cpp 
> bd8920fa9d5475e5f6533c8424ebff1588bfe645 
>   src/tests/scheduler_http_api_tests.cpp 
> 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
>   src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43269/diff/
> 
> 
> Testing
> ---
> 
> In addition to all unit tests passing, we are currently using this 
> functionality in our environment with a custom consensus stack. In our world, 
> we have a C++ plugin that calls out to an HTTP REST service (implemented in 
> Java/Scala, not that it matters).
> 
> 
> Thanks,
> 
> Mark Cavage
> 
>

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

[Mark Cavage]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/
---

(Updated Feb. 17, 2016, 4:56 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

All feedback incorporated


Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610


Repository: mesos


Description (updated)
---

MasterContender/MasterDetector loadable as modules.


Diffs (updated)
-

  include/mesos/master/contender.hpp PRE-CREATION 
  include/mesos/master/detector.hpp PRE-CREATION 
  include/mesos/module/contender.hpp PRE-CREATION 
  include/mesos/module/detector.hpp PRE-CREATION 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
  src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
  src/examples/test_contender_module.cpp PRE-CREATION 
  src/examples/test_detector_module.cpp PRE-CREATION 
  src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
  src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
  src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
  src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
  src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
  src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
  src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
  src/slave/main.cpp 22b833044dc3f900e3b5ea509e6e545148649f48 
  src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
  src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/fault_tolerance_tests.cpp 982468f851cd9d95eb6cde7c57f2d737d46a827c 
  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 
  src/tests/master_authorization_tests.cpp 
29c89fb11da792c3e71eb880a19657ea225b3cc8 
  src/tests/master_contender_detector_tests.cpp 
6375586c31b1fd406529bf299dad6e321b945de8 
  src/tests/master_slave_reconciliation_tests.cpp 
d41178eb41df519073fc0890c5716bbc9fed6ad2 
  src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
  src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
  src/tests/persistent_volume_tests.cpp 
cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
  src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897 
  src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
  src/tests/scheduler_event_call_tests.cpp 
bd8920fa9d5475e5f6533c8424ebff1588bfe645 
  src/tests/scheduler_http_api_tests.cpp 
9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
  src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
  src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 

Diff: https://reviews.apache.org/r/43269/diff/


Testing
---

In addition to all unit tests passing, we are currently using this 
functionality in our environment with a custom consensus stack. In our world, 
we have a C++ plugin that calls out to an HTTP REST service (implemented in 
Java/Scala, not that it matters).


Thanks,

Mark Cavage

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 17, 2016, 4:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @guangya @bernd's comments.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 413-414
> > 
> >
> > Should we ignore those volumes that have absolute/nested container path 
> > (like we did in linux fs isolator). What's the reason removing it?

Ah yes I think we should. Let me update this.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 473-488
> > 
> >
> > There's a os::exists check in linux fs isolator which you removed. This 
> > is fine because we won't update volumes when containerizer->update is 
> > called. I think we should at least drop a TODO here
> > so that we don't forget that when we want to support 
> > containerizer->update.
> > 
> > Alternatively, we can kill updatePersistentVolumes and inline it into 
> > mountPersistentVolumes.

I think I simply forgot about it, let me add them.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 197
> > 
> >
> > Having run multiple test suite runs, I am not convinced this has much 
> > of an effect. I got results between 20 and 28 seconds for all FetcherCache 
> > tests combined no matter what allocation interval I used: default, 500, 
> > 100. If there is an effect, it is less than the variance.
> 
> haosdent huang wrote:
> Looks weird, let me double check this.
> 
> haosdent huang wrote:
> I use `./bin/mesos-tests.sh --gtest_filter="FetcherCache*" 
> --gtest_repeat=10 2>&1 |grep total` to test. Could find use 
> allocation_interval from 1s to 200ms bring effect as the allocation_interval 
> decrease.
> 
> Use 1 s
> ```
> [==] 11 tests from 2 test cases ran. (21652 ms total)
> [==] 11 tests from 2 test cases ran. (21278 ms total)
> [==] 11 tests from 2 test cases ran. (21077 ms total)
> [==] 11 tests from 2 test cases ran. (21447 ms total)
> [==] 11 tests from 2 test cases ran. (21594 ms total)
> [==] 11 tests from 2 test cases ran. (21364 ms total)
> [==] 11 tests from 2 test cases ran. (21085 ms total)
> [==] 11 tests from 2 test cases ran. (21773 ms total)
> [==] 11 tests from 2 test cases ran. (21737 ms total)
> [==] 11 tests from 2 test cases ran. (21075 ms total)
> ```
> 
> Use 500 ms
> ```
> [==] 11 tests from 2 test cases ran. (18028 ms total)
> [==] 11 tests from 2 test cases ran. (18438 ms total)
> [==] 11 tests from 2 test cases ran. (18636 ms total)
> [==] 11 tests from 2 test cases ran. (18470 ms total)
> [==] 11 tests from 2 test cases ran. (17913 ms total)
> [==] 11 tests from 2 test cases ran. (18842 ms total)
> [==] 11 tests from 2 test cases ran. (18785 ms total)
> [==] 11 tests from 2 test cases ran. (18312 ms total)
> [==] 11 tests from 2 test cases ran. (18216 ms total)
> [==] 11 tests from 2 test cases ran. (18827 ms total)
> ```
> 
> Use 200 ms
> ```
> [==] 11 tests from 2 test cases ran. (16630 ms total)
> [==] 11 tests from 2 test cases ran. (17993 ms total)
> [==] 11 tests from 2 test cases ran. (17282 ms total)
> [==] 11 tests from 2 test cases ran. (17588 ms total)
> [==] 11 tests from 2 test cases ran. (16502 ms total)
> [==] 11 tests from 2 test cases ran. (17218 ms total)
> [==] 11 tests from 2 test cases ran. (17744 ms total)
> [==] 11 tests from 2 test cases ran. (17136 ms total)
> [==] 11 tests from 2 test cases ran. (17178 ms total)
> [==] 11 tests from 2 test cases ran. (17613 ms total)
> ```
> 
> Use 100 ms
> ```
> [==] 11 tests from 2 test cases ran. (16305 ms total)
> [==] 11 tests from 2 test cases ran. (16093 ms total)
> [==] 11 tests from 2 test cases ran. (16345 ms total)
> [==] 11 tests from 2 test cases ran. (16898 ms total)
> [==] 11 tests from 2 test cases ran. (16517 ms total)
> [==] 11 tests from 2 test cases ran. (16005 ms total)
> [==] 11 tests from 2 test cases ran. (21150 ms total)
> [==] 11 tests from 2 test cases ran. (16650 ms total)
> [==] 11 tests from 2 test cases ran. (16287 ms total)
> [==] 11 tests from 2 test cases ran. (16617 ms total)
> ```
> 
> haosdent huang wrote:
> 400 ms
> ```
> [==] 11 tests from 2 test cases ran. (17678 ms total)
> [==] 11 tests from 2 test cases ran. (17093 ms total)
> [==] 11 tests from 2 test cases ran. (17174 ms total)
> [==] 11 tests from 2 test cases ran. (17396 ms total)
> [==] 11 tests from 2 test cases ran. (18095 ms total)
> [==] 11 tests from 2 test cases ran. (17404 ms total)
> [==] 11 tests from 2 test cases ran. (17480 ms total)
> [==] 11 tests from 2 test cases ran. (17110 ms total)
> [==] 11 tests from 2 test cases ran. (17352 ms total)
> [==] 11 tests from 2 test cases ran. (17219 ms total)
> ```
> 
> 300 ms
> ```
> [==] 11 tests from 2 test cases ran. (17165 ms total)
> [==] 11 tests from 2 test cases ran. (18067 ms total)
> [==] 11 tests from 2 test cases ran. (17951 ms total)
> [==] 11 tests from 2 test cases ran. (17602 ms total)
> [==] 11 tests from 2 test cases ran. (16994 ms total)
> [==] 11 tests from 2 test cases ran. (18004 ms total)
> [==] 11 tests from 2 test cases ran. (18533 ms total)
> [==] 11 tests from 2 test cases ran. 

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[Bernd Mathiske]

> On Feb. 17, 2016, 7:21 a.m., Bernd Mathiske wrote:
> > Are a couple of seconds wirth the extra code complexity? Opinions, please!
> 
> haosdent huang wrote:
> Yes, @bernd, as you see here, this patch don't bring too much effects. 
> How about let's discard it and reopen it if really necessary?

Agreed! Thanks!


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/#review119462
---


On Feb. 16, 2016, 6:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43608/
> ---
> 
> (Updated Feb. 16, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4685
> https://issues.apache.org/jira/browse/MESOS-4685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by disable framework checkpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43608/diff/
> 
> 
> Testing
> ---
> 
> When we enable checkpoint for frameworks, StatusUpdateManager would waiting 
> for write StatusUpdateRecord to file and then boardcast it. This cause 
> uncessary disk operations and bring unstable delay if our test cases don't 
> depends on recovery.  
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2645 ms)
> [   OK ] FetcherCacheTest.LocalCached (2653 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1110 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2516 ms)
> [   OK ] FetcherCacheTest.CachedFallback (957 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
> ```
> 
> And test the recovery test manually:
> ```
> ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

> On Feb. 17, 2016, 3:21 p.m., Bernd Mathiske wrote:
> > Are a couple of seconds wirth the extra code complexity? Opinions, please!

Yes, @bernd, as you see here, this patch don't bring too much effects. How 
about let's discard it and reopen it if really necessary?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/#review119462
---


On Feb. 17, 2016, 2:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43608/
> ---
> 
> (Updated Feb. 17, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4685
> https://issues.apache.org/jira/browse/MESOS-4685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by disable framework checkpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43608/diff/
> 
> 
> Testing
> ---
> 
> When we enable checkpoint for frameworks, StatusUpdateManager would waiting 
> for write StatusUpdateRecord to file and then boardcast it. This cause 
> uncessary disk operations and bring unstable delay if our test cases don't 
> depends on recovery.  
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2645 ms)
> [   OK ] FetcherCacheTest.LocalCached (2653 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1110 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2516 ms)
> [   OK ] FetcherCacheTest.CachedFallback (957 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
> ```
> 
> And test the recovery test manually:
> ```
> ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43613/#review119464
---




src/tests/cluster.hpp (line 77)


What do you mean by "some" of its state?



src/tests/cluster.cpp (line 100)


How about using an inline closure with return type void here? Then you 
don't have to declare populate in the header and you don't have to pass all 
these parameters, you can capture them.

AFAIK we are merely solving a syntactical problem here: macro ASSERT_* 
contains "return ..." with a return type that does not match start(). Right?


- Bernd Mathiske


On Feb. 16, 2016, 2:15 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43613/
> ---
> 
> (Updated Feb. 16, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem 
> Harutyunyan.
> 
> 
> Bugs: MESOS-4633 and MESOS-4634
> https://issues.apache.org/jira/browse/MESOS-4633
> https://issues.apache.org/jira/browse/MESOS-4634
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope 
> of test objects to the test body.
> 
> Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  
> The `Slave` object performs cleanup originally found in 
> `cluster::Slave::stop`.  `cluster::Master::start` and `cluster::Slave::start` 
> were changed to factory methods.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
> 
> Diff: https://reviews.apache.org/r/43613/diff/
> 
> 
> Testing
> ---
> 
> Tests are run at the end of this review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

[Timothy Chen]

> On Feb. 16, 2016, 11:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 161-162
> > 
> >
> > Can you wrap using 70 char width here?

Sure, I thought we removed that restriction now?


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---


On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
> 
> (Updated Feb. 16, 2016, 3:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed persistent volumes with docker tasks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 645bdcf095145097d8b8c65d592c787417883145 
> 
> Diff: https://reviews.apache.org/r/43015/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>