Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

> On Feb. 29, 2016, 10:58 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 125-127 > > > > > > I think you should be able to use `foreach` here The problem here is that we

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/ --- (Updated March 1, 2016, 7:59 p.m.) Review request for mesos and Jie Yu.

Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44225/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4829

Review Request 44222: Removed `grace_period_seconds` field from executor API protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44222/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.

Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44224/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.

Review Request 44226: Modified tests to remove `Shutdown` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44226/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4829

Review Request 44223: Modified executor library to read grace period from environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.

Re: Review Request 44222: Removed `grace_period_seconds` field from executor API protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44222/#review121487 --- Ship it! Ship It! - Vinod Kone On March 1, 2016, 8:04 p.m.,

Re: Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44224/#review121486 --- src/slave/containerizer/containerizer.cpp (line 332)

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review121353 --- Ship it! - Joris Van Remoortere On Feb. 29, 2016, 6:42 p.m.,

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review121354 --- Ship it! - Joris Van Remoortere On Feb. 29, 2016, 6:15 p.m.,

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review121347 --- Fix it, then Ship it!

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review121352 --- Ship it! - Joris Van Remoortere On Feb. 18, 2016, 2:27 a.m.,

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review121355 --- Ship it! - Joris Van Remoortere On Feb. 18, 2016, 4:35 a.m.,

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review121348 --- Ship it! - Joris Van Remoortere On Feb. 18, 2016, 2:31 a.m.,

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review121349 --- Ship it! - Joris Van Remoortere On Feb. 18, 2016, 2:28 a.m.,

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review121351 --- Ship it! - Joris Van Remoortere On March 1, 2016, 8:38 a.m.,

Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-4712

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated March 1, 2016, 7:55 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated March 1, 2016, 7:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44225/#review121490 --- Ship it! Rename the env variable per my previous comment. -

Re: Review Request 44226: Modified tests to remove `Shutdown` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44226/#review121491 --- Ship it! Ship It! - Vinod Kone On March 1, 2016, 8:04 p.m.,

Review Request 44221: Added runtime isolator check if docker is image provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44221/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44182/ --- (Updated March 1, 2016, 7:59 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44221: Added runtime isolator check if docker is image provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44221/ --- (Updated March 1, 2016, 12:24 p.m.) Review request for mesos, Artem

Re: Review Request 44223: Modified executor library to read grace period from environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44223/#review121489 --- Ship it! Ship It! - Vinod Kone On March 1, 2016, 8:04 p.m.,

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/#review121478 --- docs/mesos-containerizer.md (lines 89 - 92)

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review121346 --- Fix it, then Ship it! cmake/CompilationConfigure.cmake (line

Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-4712

Re: Review Request 44221: Added runtime isolator check if docker is image provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44221/#review121479 --- Fix it, then Ship it!

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/#review121484 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated March 1, 2016, 7:58 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

> On March 1, 2016, 5:13 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 387 > > > > > > I think we set a default for the secondary so that you don't have to do > > this here? Updated the

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121543 --- Ship it! Ship It! - Yi Sun On March 1, 2016, 8:58 p.m.,

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/ --- (Updated March 1, 2016, 11:50 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > > > > > The second param for strcpy_s is the number of chars to be copied. It > > doesn't seem right

Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4834

Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 12:52 a.m.) Review request for mesos, Artem

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/ --- (Updated March 1, 2016, 5:11 p.m.) Review request for mesos, Artem

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/ --- (Updated March 2, 2016, 1:11 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated March 1, 2016, 11:58 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121561 --- 3rdparty/CMakeLists.txt (line 30)

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/ --- (Updated March 2, 2016, 1:09 a.m.) Review request for mesos, Anand Mazumdar

Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44243/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-4712

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

> On March 1, 2016, 10:32 p.m., Anand Mazumdar wrote: > > src/internal/devolve.cpp, line 123 > > > > > > Nit: s/but `Call::Subscribe` has// > > > > Since we are inside `devolve` for conversion to

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/ --- (Updated March 1, 2016, 5:42 p.m.) Review request for mesos, Artem

Re: Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44247/#review121564 --- Ship it! Ship It! - Timothy Chen On March 2, 2016, 1:44

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 1, 2016, 11:56 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121560 --- Ship it! - Alex Clemmer On March 2, 2016, 12:52 a.m., Diana

Re: Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/#review121566 --- Patch looks great! Reviews applied: [44236] Passed command:

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review121557 --- Patch looks great! Reviews applied: [44227] Passed command:

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44122/ --- (Updated March 1, 2016, 5:08 p.m.) Review request for mesos, Artem

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121505 --- Fix it, then Ship it! Split the commit.

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/#review121521 --- Fix it, then Ship it! LGTM. docs/scheduler-http-api.md (line

Re: Review Request 44231: Added rmdir error string to Appc store fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44231/#review121525 --- Ship it! Ship It! - Jie Yu On March 1, 2016, 10:02 p.m.,

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121540 --- Bad patch! Reviews applied: [44141, 44140] Failed command:

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 --- 3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated March 1, 2016, 11:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/#review121554 --- Ship it! Ship It! - Timothy Chen On March 1, 2016, 11:50

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 2, 2016, 12:41 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

> On March 2, 2016, 1:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/docker.cpp, lines 585-586 > > > > > > It would be a slightly stronger check if you include this as well: > > ``` > >

Re: Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/ --- (Updated March 2, 2016, 8:01 a.m.) Review request for mesos and Joris Van

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121535 --- Ship it! Ship It! - Greg Mann On March 1, 2016, 7:47 p.m.,

Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44247/ --- Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Repository: mesos

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

> On March 1, 2016, 10:10 a.m., Alex Clemmer wrote: > > Ship It! Ah, oops, sorry folks. :( Meant to click this for a different review. - Alex --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review121412 --- Ship it! Ship It! - Alex Clemmer On Jan. 7, 2016, 9:47

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/#review121411 --- Patch looks great! Reviews applied: [44200] Passed command:

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/ --- (Updated March 1, 2016, 8:38 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44182/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44226: Modified tests to remove `Shutdown` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44226/#review121531 --- Patch looks great! Reviews applied: [44222, 44224, 44223, 44225,

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121530 ---

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/ --- (Updated March 1, 2016, 10:04 p.m.) Review request for mesos. Changes

Re: Review Request 44222: Removed `grace_period_seconds` field from executor API protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44222/ --- (Updated March 1, 2016, 9:27 p.m.) Review request for mesos, Alexander

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review121472 --- Ship it! - Joris Van Remoortere On Feb. 25, 2016, 7:13 p.m.,

Re: Review Request 44225: Modified docs to add info on `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44225/ --- (Updated March 1, 2016, 9:28 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44225: Modified docs to add info on `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`.

> On March 1, 2016, 8:25 p.m., Vinod Kone wrote: > > Rename the env variable per my previous comment. Can update the summary? - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review121499 --- Ship it! - Joris Van Remoortere On Feb. 25, 2016, 7:17 p.m.,

Re: Review Request 44112: Updated tests to use /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44112/ --- (Updated March 1, 2016, 9:39 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/ --- (Updated March 1, 2016, 9:39 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/ --- (Updated March 1, 2016, 10:07 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121516 --- Fix it, then Ship it! LGTM. src/internal/devolve.cpp (line

Re: Review Request 44071: Added documentation for new libprocess environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/ --- (Updated March 1, 2016, 10:04 p.m.) Review request for mesos, Alexander

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/#review121519 --- Fix it, then Ship it! verified nothing changed in the posix

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/#review121518 --- Fix it, then Ship it!

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/#review121493 --- Patch looks great! Reviews applied: [44218, 44220] Passed

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121502 --- Ship it! Ship It! - Vinod Kone On Feb. 29, 2016, 7:43 p.m.,

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated March 1, 2016, 9:42 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/#review121508 --- Patch looks great! Reviews applied: [43914, 43915, 44182, 43916]

Review Request 44230: Added FS_DEFAULT case in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44222: Removed `grace_period_seconds` field from executor API protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44222/ --- (Updated March 1, 2016, 9:14 p.m.) Review request for mesos, Alexander

Re: Review Request 44225: Modified docs to add info on `MESOS_SHUTDOWN_GRACE_PERIOD`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44225/ --- (Updated March 1, 2016, 9:14 p.m.) Review request for mesos and Vinod Kone.

Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/ --- Review request for mesos, Anand Mazumdar and Michael Park. Bugs: MESOS-4002

Re: Review Request 44112: Updated tests to use /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44112/#review121504 --- Ship it! Ship It! - Vinod Kone On Feb. 27, 2016, 2:18 a.m.,

Re: Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44224/#review121497 --- Ship it! Can you update the title to reflect the new env name?

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review121496 --- Ship it! Ship It! - Anand Mazumdar On March 1, 2016, 9:24

Review Request 44231: Added rmdir error string to Appc store fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44231/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

  1   2   >