Re: Review Request 46146: Fixed libprocess tests to use smart pointers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/#review128864 --- Ship it! - Benjamin Bannier On April 13, 2016, 4:24 p.m.,

Review Request 46189: Slave rename - Update strings in error messages and other strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46189/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: MESOS-5057

Re: Review Request 46165: Removed dependency on Boost.Foreach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/#review128851 --- LGTM and is a very nice C++11 update in the spirit of the

Re: Review Request 46188: Added the missing 'break' when handling ERROR event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46188/#review128853 --- Patch looks great! Reviews applied: [46187, 46188] Passed

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 14, 2016, 8:57 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46193/#review128865 --- Bad patch! Reviews applied: [46193, 46192, 46191, 46015, 46014,

Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/ --- (Updated April 14, 2016, 3:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46204: Updated slave recovery tests with HTTP command executor.

Can you run the tests in a loop (100 iterations) to check for flakiness? @vinodkone > On Apr 14, 2016, at 8:14 AM, Qian Zhang wrote: > > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 45670: Updated tests for HTTP command executor.

Anand might have ideas. If we can get its os pid we could do kill on it? @vinodkone > On Apr 14, 2016, at 8:21 AM, Qian Zhang wrote: > > > >>> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: >>> Are you also planning to update slave recovery tests? Those are the most

Re: Review Request 44454: Checkpointed the external mount info for container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44454/ --- (Updated 四月 14, 2016, 3:45 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45360: Added volume client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review128931 ---

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

> On April 12, 2016, 3:09 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/env_tests.cpp, lines 26-27 > > > > > > Please use plain names that are self descriptive. > > Alex Clemmer

Re: Review Request 45991: Fixed memory leak in Route::Route() in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45991/#review128954 --- Ship it! Ship It! - Joseph Wu On April 10, 2016, 6:38 p.m.,

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

> On Dec. 2, 2015, 8:08 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/process.cpp, line 993 > > > > > > Once you use a proper smart pointer for `process_route` this comment > > will be right (maybe

Re: Review Request 46246: Log executor commands w/o verbose logs enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46246/#review129066 --- Patch looks great! Reviews applied: [46246] Passed command:

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 15, 2016, 5:58 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46149: Speed up DynamicReservationFramework.

> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? @Bannier, how did you check the time in `resourceOffers`? - Klaus

Re: Review Request 46149: Speed up DynamicReservationFramework.

> On April 14, 2016, 1:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? > > Klaus Ma wrote: > @Bannier, how did you check the time in

Re: Review Request 46149: Speed up ExamplesTest.DynamicReservationFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/#review128883 --- Bad patch! Reviews applied: [46149] Failed command:

Re: Review Request 46149: Speed up DynamicReservationFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/ --- (Updated April 14, 2016, 8:59 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46180: Implemented create() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 14, 2016, 1:40 p.m.) Review request for mesos, David vonThenen,

Review Request 46214: Valided role when framework subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5184

Re: Review Request 45955: Added CNI helper subcommand to `mesos-containerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/#review128907 --- Ship it! Ship It! - Jie Yu On April 14, 2016, 3:24 p.m.,

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128908 --- Ship it! Ship It! - Jie Yu On April 14, 2016, 3:26 p.m.,

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review128913 --- Ship it! Ship It! - Jie Yu On April 14, 2016, 4:37 a.m.,

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 14, 2016, 6:16 p.m.) Review request for mesos, Adam B and

Re: Review Request 45922: Added agent authorization flags.

> On April 12, 2016, 11:31 a.m., Adam B wrote: > > docs/configuration.md, line 886 > > > > > > None of these examples apply to an agent. Maybe we need to implement an > > ACL (e.g. GET_ENDPOINT_WITH_PATH "/flags")

Re: Review Request 46204: Updated slave recovery tests with HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46204/#review128911 --- Patch looks great! Reviews applied: [46187, 46188, 46204]

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review128916 --- src/launcher/http_command_executor.cpp

Re: Review Request 45377: Updated prepare() logic for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 四月 14, 2016, 4:30 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 14, 2016, 6:51 p.m.) Review request for mesos, Adam B and

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/#review128919 --- Ship it! Ship It! - Gilbert Song On April 13, 2016, 5:32

Review Request 46204: Updated slave recovery tests with HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46204/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 45670: Updated tests for HTTP command executor.

> On April 13, 2016, 5:11 a.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/ --- (Updated April 14, 2016, 3:26 p.m.) Review request for mesos, Jie Yu and Qian

Review Request 46209: Explicitly set `FrameworkInfo.principal` if AuthN is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46209/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5214

Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/ --- (Updated April 14, 2016, 3:34 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45955: Added CNI helper subcommand to `mesos-containerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/ --- (Updated April 14, 2016, 3:24 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

> On April 13, 2016, 7:04 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 5944-5947 > > > > > > We were discussing about this in another context this morning. I think > > we should just set

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 14, 2016, 3:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

> On April 14, 2016, 12:47 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 165-168 > > > > > > Please wrap this with ifdef linux Thanks for catching this. Wrapped in `#ifdef` and ran

Review Request 46211: Added flags for authenticating HTTP frameworks to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review128914 --- Looks good! A couple small things below. src/master/http.cpp

Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46162/#review128923 --- include/mesos/log/log.hpp (line 50)

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review128922 --- src/slave/containerizer/mesos/isolators/docker/volume/spec.proto

Re: Review Request 46212: Added documentation around using AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46212/#review128926 --- Could we add a section to 'docs/authentication.md' about

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review128925 --- src/master/flags.cpp (lines 225 - 226)

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 14, 2016, 5:46 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

> On April 14, 2016, 5:10 p.m., Greg Mann wrote: > > src/master/validation.hpp, line 47 > > > > > > Do we really want to have a default value for an argument to a > > validation function? It makes me a bit uneasy;

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/#review128932 --- Patch looks great! Reviews applied: [46113, 46209, 46114, 46211,

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/#review128935 --- include/mesos/state/state.hpp (line 82)

Re: Review Request 46163: Exposed state/{state,storage}.hpp files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/#review128929 --- src/Makefile.am (line 174)

<    1   2