Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/#review146820 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Re: Review Request 51446: Fixed typo in health_checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/#review146908 --- Ship it! Ship It! - haosdent huang On Aug. 26, 2016, 1:33

Re: Review Request 51405: Updated some tests to use the CreateSlaveFlags() helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/ --- (Updated Aug. 26, 2016, 1:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 1:52 a.m.) Review request for mesos and Jie Yu.

Review Request 51447: Killed a line in master/validation.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51447/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/#review146853 --- Ship it! Ship It! - Vinod Kone On Aug. 25, 2016, 5:58 p.m.,

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Aug. 25, 2016, 8:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review146859 --- Patch looks great! Reviews applied: [51009] Passed command:

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Aug. 25, 2016, 9 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1055 > > > > > > We should use a `continuation` here, you can refer to > >

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/#review146854 --- src/slave/containerizer/docker.cpp (lines 1028 - 1034)

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/#review146825 --- src/slave/containerizer/mesos/provisioner/paths.hpp (line 83)

Re: Review Request 50661: Documentation: fix broken links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50661/#review146856 --- Pierre, still working on this? If yes, can you please address

Re: Review Request 51402: Added nested container check in provisioner destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/#review146845 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp (line

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review146841 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 51124: Support more layers through symlink for overlay backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146833 --- Patch looks great! Reviews applied: [51124] Passed command:

Review Request 51437: Added validation test for task group task using NetworkInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/ --- Review request for mesos, Anand Mazumdar and Guangya Liu. Repository: mesos

Re: Review Request 51428: Removed friendship between ProcessCapabilities and Capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51428/#review146846 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 3:17 p.m.,

Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/#review146789 --- Fix it, then Ship it! > This is being added to allow for

Re: Review Request 51433: Added test case MasterAuthorizationTest, UnauthorizedTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51433/#review146850 --- Fix it, then Ship it! I'll fix the issues while committing.

Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

> On Aug. 25, 2016, 10:57 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 204 > > > > > > Why this change? Where is the error checking? I removed the error check because it

Re: Review Request 51257: Add external process container logger.

> On Aug. 22, 2016, 11:03 a.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 171 > > > > > > Can you un-remove all these un-related `cpuacct` changes? > > Will Rouesnel wrote: > Weird, my local branch history

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

> On Aug. 25, 2016, 12:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/paths.hpp, line 83 > > > > > > What does 'parentId' mean here? I'd suggest we don't expose that > > parameter to the

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 5:21 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51446: Fixed typo in health_checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/#review146918 --- Patch looks great! Reviews applied: [51446] Passed command:

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 25, 2016, 10:04 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146873 --- Patch looks great! Reviews applied: [51437] Passed command:

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50868/#review146878 --- I don't know. Making such distinction feels like splitting hairs

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146887 --- Fix it, then Ship it! src/master/validation.cpp (line 1003)

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 25, 2016, 11:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/#review146874 --- src/slave/containerizer/mesos/isolators/network/cni/spec.proto

Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6088

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/ --- (Updated Aug. 25, 2016, 11:34 p.m.) Review request for mesos and Jie Yu.

Review Request 51442: Added missing Launcher mock for getExitStatusCheckpointPath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51442/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6051

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146888 --- src/tests/master_validation_tests.cpp (line 1811)

Re: Review Request 46821: Avoided slicing of flags in subprocess in libprocess and stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/#review146876 --- Fix it, then Ship it! 3rdparty/libprocess/src/subprocess.cpp

Re: Review Request 46822: Avoided slicing of flags in subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46822/#review146877 --- Fix it, then Ship it!

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/ --- (Updated Aug. 25, 2016, 11:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review146831 --- src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines

Re: Review Request 51393: Added unit test for provisioner recursive listContainers().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/#review146839 --- Fix it, then Ship it!

Re: Review Request 51043: Added support for reading out the bounding capability set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/#review146847 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 3:18 p.m.,

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146903 --- Bad patch! Reviews applied: [46187] Failed command:

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review146901 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 504)

Review Request 51446: Fixed typo in health_checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/ --- Review request for mesos, Alexander Rukletsov and haosdent huang. Repository:

Re: Review Request 51442: Added missing Launcher mock for getExitStatusCheckpointPath.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51442/#review146893 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2016, 11:35 p.m.,

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/ --- (Updated Aug. 26, 2016, 12:26 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 26, 2016, 12:29 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/#review146896 --- src/tests/containerizer/isolator_tests.cpp (lines 215 - 218)

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- (Updated Aug. 26, 2016, 12:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

> On Aug. 25, 2016, 5:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 502 > > > > > > I'd avoid using subprocess here. Using subprocess here means that we'll > > initialize libprocess,

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

> On Aug. 26, 2016, 12:31 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 215-218 > > > > > > Can you call CreateSlaveFlags instead? I tried doing this and it gave me the error: ```

Re: Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

> On Aug. 26, 2016, 12:31 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 215-218 > > > > > > Can you call CreateSlaveFlags instead? > > Kevin Klues wrote: > I tried doing this and it

Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/#review146900 --- Fix it, then Ship it!

Re: Review Request 51210: Update mesos-executor name for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51210/ --- (Updated Aug. 25, 2016, 11:50 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51217: Added `os::execvp' in `stout` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- (Updated Aug. 25, 2016, 11:59 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51213: Used `os::execvp` instead of `::execvp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51213/ --- (Updated Aug. 25, 2016, 11:59 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51217: Added `os::execlp' in `stout` library.

> On Aug. 22, 2016, 6:39 p.m., Joseph Wu wrote: > > Note: Your summary/description says `execlp`, but the code is for `execvp` > > :P I will change the summary. - Daniel --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/#review146891 --- Patch looks great! Reviews applied: [51434] Passed command:

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146913 --- Bad patch! Reviews applied: [51097, 51096, 51095] Failed

Review Request 51450: Fixed a capabilities test failure on Fedora 23.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51450/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

<    1   2