Re: Review Request 64495: Fixed a typo in resource provider config API and added validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64495/#review193389 --- Ship it! Ship It! - James DeFelice On Dec. 11, 2017, 6:55

Re: Review Request 64462: Edited some comments in the master for style and grammar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64462/#review193387 --- Ship it! Ship It! - Benjamin Bannier On Dec. 8, 2017, 10:23

Review Request 64496: Avoided unnecessary work in contains checks in hashset and hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64496/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 64434: Windows: Fixed `os::stat::size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/#review193394 --- FAIL: Some Mesos tests failed. Reviews applied: `['64434']`

Re: Review Request 64477: Refactored agent to keep track of local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64477/#review193380 --- src/resource_provider/manager.cpp Lines 656-660 (original),

Re: Review Request 64494: Sent resource version uuid only for agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64494/#review193384 --- Fix it, then Ship it! src/master/master.cpp Lines 6300

Re: Review Request 64487: Passed the message directly to the Master::registerSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64487/#review193385 --- Fix it, then Ship it! Let's adjust all handlers in a separate

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/#review193396 --- I still see a few resource version-related UUIDs in

Re: Review Request 64380: Stout: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64380/#review193395 --- Ship it! Let's move this commit after

Re: Review Request 64381: Mesos: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/#review193399 --- Ship it! - Benjamin Bannier On Dec. 8, 2017, 4:14 p.m., Jan

Re: Review Request 64472: Improved the logging in `StatusUpdateManagerProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64472/#review193297 --- Fix it, then Ship it!

Re: Review Request 63901: Added operator API to update and remove resource provider configs.

> On Dec. 11, 2017, 2:36 a.m., James DeFelice wrote: > > include/mesos/agent/agent.proto > > Lines 366 (patched) > > > > > > s/Update/Add/ > > Chun-Hung Hsiao wrote: > Oops. Fixed in r64475. Sorry for my ypo

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/#review193400 --- FAIL: Some Mesos tests failed. Reviews applied: `['64439',

Re: Review Request 64473: Fixed naming of a variable in `status_update_manager_process.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64473/#review193402 --- Ship it! Ship It! - Greg Mann On Dec. 9, 2017, 12:25 a.m.,

Re: Review Request 64464: Made master reconcile known offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64464/#review193408 --- FAIL: Some Mesos tests failed. Reviews applied: `['64457',

Re: Review Request 64473: Fixed naming of a variable in `status_update_manager_process.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64473/#review193404 --- FAIL: Some Mesos tests failed. Reviews applied: `['64472',

Re: Review Request 64434: Windows: Fixed `os::stat::size()`.

> On Dec. 11, 2017, 6:42 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['64434']` > > > > Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose` > > > > All the build artifacts available at: > >

Re: Review Request 64496: Avoided unnecessary work in contains checks in hashset and hashmap.

> On Dec. 11, 2017, 10 a.m., Andrew Schwartzmeyer wrote: > > Ship It! Hm, I might take this back. The hypothesis: > In order to count elements a complete traversal of the container is required, while a contains check already has an answer when the first element has been found. While it sounds

Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64461/#review193414 --- FAIL: Some Mesos tests failed. Reviews applied: `['64461']`

Re: Review Request 64496: Avoided unnecessary work in contains checks in hashset and hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64496/#review193411 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 11, 2017,

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64432/ --- (Updated Dec. 11, 2017, 10:13 a.m.) Review request for mesos, Akash Gupta and

Re: Review Request 64477: Refactored agent to keep track of local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64477/ --- (Updated Dec. 11, 2017, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64431: Updated Windows documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/ --- (Updated Dec. 11, 2017, 10:31 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 64495: Fixed a typo in resource provider config API and added validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64495/#review193428 --- FAIL: Some Mesos tests failed. Reviews applied: `['64439',

Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.

> On Dec. 8, 2017, 5:47 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 354 (patched) > > > > > > Does this flag exist on older versions of Windows? You might

Re: Review Request 64494: Sent resource version uuid only for agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64494/#review193415 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64487: Passed the message directly to the Master::registerSlave handler.

> On Dec. 11, 2017, 12:42 p.m., Benjamin Bannier wrote: > > src/master/master.hpp > > Lines 588 (patched) > > > > > > Let's just pass a `const` ref here, and instead adjust all handlers in > > a separate patch.

Review Request 64504: Avoided returning prematurely in an agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64504/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/#review193438 --- docs/configuration/master.md Lines 490 (patched)

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/#review193434 --- Fix it, then Ship it!

Review Request 64506: Correctly reset slave status when aborting a registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64506/ --- Review request for mesos. Repository: mesos Description --- Previously,

Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Re: Review Request 64494: Sent resource version uuid only for agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64494/ --- (Updated Dec. 11, 2017, 8:31 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64432/#review193439 --- FAIL: Some Mesos tests failed. Reviews applied: `['64432']`

Re: Review Request 64477: Refactored agent to keep track of local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64477/#review193426 --- Ship it! Ship It! - Benjamin Bannier On Dec. 11, 2017, 7:44

Re: Review Request 64494: Sent resource version uuid only for agent default resources.

> On Dec. 11, 2017, 12:38 p.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 6300 (patched) > > > > > > Let's init this with `None()` for consistency. oh? I never initialize an Option to None()

Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/ --- Review request for mesos. Bugs: MESOS-8115

Re: Review Request 64098: Send status updates when agent re-registers.

> On Dec. 7, 2017, 1:36 p.m., Ilya Pronin wrote: > > src/tests/master_tests.cpp > > Lines 7477 (patched) > > > > > > Ditto re replicated log based registry. > > Megha Sharma wrote: > I added this specifically

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/#review193451 --- `require_agent_domains` sounds weird because there is only one

Re: Review Request 64431: Updated Windows documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/#review193448 --- FAIL: Some Mesos tests failed. Reviews applied: `['64431']`

Re: Review Request 64472: Improved the logging in `StatusUpdateManagerProcess`.

> On Dec. 11, 2017, 4:38 p.m., Greg Mann wrote: > > src/status_update_manager/status_update_manager_process.hpp > > Line 112 (original), 112 (patched) > > > > > > Let's make the process ID

Review Request 64509: Made the `StatusUpdateManagerProcess` process ID configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64509/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 64472: Improved the logging in `StatusUpdateManagerProcess`.

> On Dec. 11, 2017, 8:38 a.m., Greg Mann wrote: > > src/status_update_manager/status_update_manager_process.hpp > > Line 112 (original), 112 (patched) > > > > > > Let's make the process ID

Re: Review Request 64506: Correctly reset slave status when aborting a registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64506/#review193449 --- Fix it, then Ship it! src/master/master.cpp Lines 6433-6434

Re: Review Request 64507: Added a master flag to disallow agents without domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64507/#review193452 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 64473: Fixed naming of a variable in `status_update_manager_process.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64473/ --- (Updated Dec. 11, 2017, 1:37 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64479: Added a test for `MODIFY_RESOURE_PROVIDER_CONFIG` authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64479/#review193461 --- Ship it! Ship It! - Jie Yu On Dec. 9, 2017, 3:28 p.m.,

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/#review193463 --- FAIL: Some Mesos tests failed. Reviews applied: `['64504',

Review Request 64516: Improved documentation on resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64516/ --- Review request for mesos, Alexander Rojas, James Peach, and Michael Park.

Re: Review Request 64434: Windows: Fixed `os::stat::size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/ --- (Updated Dec. 11, 2017, 1:37 p.m.) Review request for mesos, Akash Gupta and

Re: Review Request 64431: Updated Windows documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/#review193457 --- Ship it! Ship It! - Greg Mann On Dec. 11, 2017, 6:31 p.m.,

Re: Review Request 64469: Added unit tests for resource provider config modification API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64469/ --- (Updated Dec. 11, 2017, 10:44 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193460 --- LGTM sans Ilya's comment about only use `replicated_log` flag

Re: Review Request 64434: Windows: Fixed `os::stat::size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/#review193445 --- Fix it, then Ship it!

Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/#review193437 --- Fix it, then Ship it! src/resource_provider/daemon.cpp Lines

Re: Review Request 64469: Added unit tests for resource provider config modification API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64469/#review193440 --- Fix it, then Ship it!

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/#review193476 --- src/slave/slave.cpp Lines 7296-7298 (patched)

Re: Review Request 64495: Fixed a typo in resource provider config API and added validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64495/#review193462 --- Ship it! Ship It! - Jie Yu On Dec. 11, 2017, 6:55 a.m.,

Re: Review Request 64431: Updated Windows documentation.

> On Dec. 11, 2017, 2:13 p.m., Greg Mann wrote: > > docs/cmake-examples.md > > Line 356 (original), 356 (patched) > > > > > > Make sure you fix the spelling of "resolved" in the commit message :) Ah damn it I

Review Request 64515: Used `reserve_resources` ACL for static reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/ --- Review request for mesos, Alexander Rojas and James Peach. Bugs: MESOS-8306

Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64514/ --- Review request for mesos, Alexander Rojas and James Peach. Bugs: MESOS-8306

Review Request 64518: Fixed a bug introduced by code merging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64518/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 64504: Avoided returning prematurely in an agent handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64504/#review193474 --- Ship it! Ship It! - Jie Yu On Dec. 11, 2017, 8:15 p.m.,

Re: Review Request 64464: Made master reconcile known offer operations with agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64464/#review193473 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 11:46 p.m.,

Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64517/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/ --- (Updated Dec. 11, 2017, 10:44 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193466 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64494: Sent resource version uuid only for agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64494/#review193465 --- FAIL: Some Mesos tests failed. Failed command:

Re: Review Request 64431: Updated Windows documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/#review193458 --- docs/cmake-examples.md Line 356 (original), 356 (patched)

Re: Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64517/#review193471 --- Fix it, then Ship it!

Re: Review Request 64472: Improved the logging in `StatusUpdateManagerProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64472/ --- (Updated Dec. 11, 2017, 1:36 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64463: Added the OFFER_OPERATION_DROPPED state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64463/#review193468 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 11:40 p.m.,

Re: Review Request 64509: Made the `StatusUpdateManagerProcess` process ID configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64509/#review193455 --- Ship it! Ship It! - Greg Mann On Dec. 11, 2017, 9:37 p.m.,

Re: Review Request 64303: Tracked resource reservations in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64303/#review193472 --- Fix it, then Ship it! Looks good! Thanks for spelling out the

Re: Review Request 64517: Added pause/resume methods to `OfferOperationStatusUpdateManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64517/ --- (Updated Dec. 11, 2017, 4:57 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64493/#review193481 --- Thanks for testing this! I left comments in the first test that

Re: Review Request 64516: Improved documentation on resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64516/#review193483 --- FAIL: Mesos tests failed to build. Reviews applied: `['64514',

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/ --- (Updated Dec. 11, 2017, 6:33 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64467/#review193497 --- Can you also describe how it worked before in the description? I

Review Request 64521: Made `StatusUpdateManagerProcess` fill-in the latest status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64521/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. Repository:

Review Request 64520: Fixed the agent state endpoint to show proper agent capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64520/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Repository:

Re: Review Request 64003: Made quota resource allocation fine-grained.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64003/#review193488 --- FAIL: Failed to apply the dependent review: 64465. Failed

Re: Review Request 64522: WIP: try to make tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review193487 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 64518: Fixed a bug introduced by code merging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64518/#review193470 --- Ship it! Ship It! - Chun-Hung Hsiao On Dec. 12, 2017, 12:37

Re: Review Request 64477: Refactored agent to keep track of local resource providers.

> On Dec. 11, 2017, 11:24 a.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 7294 (patched) > > > > > > Since it is possible to e.g., `RESERVE` an empty `Resources`, I believe > > we could currently

Review Request 64522: WIP: try to make tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/ --- Review request for mesos. Repository: mesos Description --- WIP: try to

Re: Review Request 63953: Added logging based on container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review193480 --- FAIL: Some Mesos tests failed. Reviews applied: `['63953']`

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review193484 --- Fix it, then Ship it! Looks good! Just some comments related