Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8536

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

> On Jan. 26, 2018, 5:01 a.m., Greg Mann wrote: > > src/common/http.hpp > > Lines 57 (patched) > > > > > > Is this case needed for type deduction? clang seems to build this code > > fine without it. >From the

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/ --- (Updated Feb. 2, 2018, 4:01 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6280 (patched) > > > > > > Could you leave a comment here saying that we do this simply to make it > > easier to handle resource

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 2, 2018, 2:30 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6349-6352 (patched) > > > > > > Are these necessary? I think that framework registration may be > > sufficient to produce an

Re: Review Request 65470: Added metrics for showing number of subscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65470/#review196703 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review196716 --- src/python/cli_new/tox.ini Lines 21 (patched)

Re: Review Request 65467: Windows: Added `internal::windows::enable_inherit(WindowsFD)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/ --- (Updated Feb. 2, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 65469: Windows: Made `IO::OWNED` file descriptors inheritable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/ --- (Updated Feb. 2, 2018, 12:12 p.m.) Review request for mesos, Akash Gupta, Jie

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review196734 --- src/checks/checker_process.cpp Lines 523-525 (original), 523-526

Re: Review Request 65437: Added documentation for fault domains.

> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote: > > docs/fault-domains.md > > Lines 63 (patched) > > > > > > s/The default/By default, the/ > > Benno Evers wrote: > Are you sure about this? It would imply to me

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196727 --- src/checks/checks_runtime.hpp Lines 32-66 (patched)

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/ --- (Updated Feb. 2, 2018, 7:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/#review196732 --- src/checks/checker_process.cpp Lines 523-525 (patched)

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

> On Feb. 1, 2018, 10:04 p.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this

Re: Review Request 65437: Added documentation for fault domains.

> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote: > > docs/fault-domains.md > > Lines 63 (patched) > > > > > > s/The default/By default, the/ Are you sure about this? It would imply to me as a reader that this

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/ --- (Updated Feb. 3, 2018, 4:48 a.m.) Review request for . Repository: mesos

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review196728 --- src/checks/checker.hpp Lines 92-93 (original), 62-63 (patched)

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review196735 --- src/checks/checker_process.hpp Lines 45 (patched)

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/ --- (Updated Feb. 3, 2018, 4:48 a.m.) Review request for . Repository: mesos

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196781 --- FAIL: Failed to apply the current review. Failed command:

Review Request 65491: Added metrics for CSI plugin terminations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65491/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

> On Feb. 2, 2018, 6:04 a.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this error

Re: Review Request 65492: Changed the SLRP test fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65492/#review196766 --- FAIL: The file

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review196777 --- FAIL: Failed to apply the dependent review: 65496. Failed

Re: Review Request 65491: Added metrics for CSI plugin terminations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65491/#review196750 --- FAIL: The file

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196755 --- Ship it! Per discussion with Andy, I'm ok with either

Re: Review Request 65447: Refactored couple of launch task sanity checks into a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65447/#review196739 --- src/slave/slave.cpp Line 2033 (original), 2033 (patched)

Re: Review Request 65464: Introduced `mesos-build` along with pre-built docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65464/#review196770 --- FAIL: Failed to apply the dependent review: 65463. Failed

Re: Review Request 65474: Updated socket shutdown to return SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65474/#review196769 --- 3rdparty/libprocess/include/process/socket.hpp Line 192

Review Request 65496: Fixed a bug where task-less v1 executor could linger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65496/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8411

Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8411

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196740 --- Fix it, then Ship it! docs/fault-domains.md Line 74

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196745 --- FAIL: Failed to apply the dependent review: 65043. Failed

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196746 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196747 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

> On Feb. 2, 2018, 6:04 a.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this error

Re: Review Request 65474: Updated socket shutdown to return SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65474/#review196756 --- Ship it! 3rdparty/libprocess/src/libevent_ssl_socket.cpp Line

Re: Review Request 65495: Fixed clang compilation problem for the SLRP metrics test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65495/#review196772 --- FAIL: The file

Re: Review Request 65495: Fixed clang compilation problem for the SLRP metrics test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65495/#review196774 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2018, 12:56 a.m.,

Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65499/ --- Review request for mesos, Alexander Rukletsov, Gaston Kleiman, Greg Mann, and

Re: Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65499/#review196779 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65449: Fixed an issue where executor info linger on master if failed to launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65449/#review196665 --- partial review. src/master/master.hpp Lines 867-871 (patched)

Review Request 65492: Changed the SLRP test fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65492/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 65492: Changed the SLRP test fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65492/#review196767 --- Ship it! Ship It! - Chun-Hung Hsiao On Feb. 3, 2018, 12:08

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review196738 --- src/tests/environment.cpp Lines 350-356 (patched)

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review196742 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 4, 2018,

Re: Review Request 65437: Added documentation for fault domains.

> On Feb. 2, 2018, 10:11 p.m., Vinod Kone wrote: > > Fixed the issues before committing. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196740

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196744 --- FAIL: The file

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196753 --- src/master/master.cpp Lines 7596 (patched)

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196752 --- src/master/master.cpp Lines 7594-7597 (original), 7609-7612

Re: Review Request 65491: Added metrics for CSI plugin terminations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65491/#review196751 --- Fix it, then Ship it!

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review196764 --- 3rdparty/libprocess/include/process/process.hpp Lines 325-352

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/ --- (Updated Feb. 3, 2018, 1:37 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65464: WIP: Introduced `mesos-build`, along with pre-built docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65464/#review196694 --- Fix it, then Ship it! Thanks for these patches mpark. I left