Review Request 65932: Added a generic mechanism to check for isolator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/ --- Review request for mesos, Andrew Schwartzmeyer and Jie Yu. Bugs: MESOS-6555

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

> On March 6, 2018, 6:34 p.m., Benjamin Bannier wrote: > > I left two open questions: > > > > * do we want to continue using `root` as the giant bag of priviledges or > > can we be more fine-grained in the future. > > * can we build tooling so isolators do not just declare the widest possible

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198712 --- src/master/http.cpp Lines 878-880 (original), 880-882 (patched)

Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/ --- (Updated March 6, 2018, 12:05 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/ --- (Updated March 6, 2018, 12:05 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198714 --- Ship it! Ship It! - Jason Lai On March 6, 2018, 4:57 p.m.,

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198725 --- PASS: Mesos patch 65932 was successfully built and tested.

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198716 --- I left two open questions: * do we want to continue using `root`

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198721 --- PASS: Mesos patch 65930 was successfully built and tested.

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198722 --- Patch looks great! Reviews applied: [65930] Passed command:

Re: Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65719/ --- (Updated March 6, 2018, 12:04 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65863: Updated mesos code with the new `os::system`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65863/#review198735 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018,

Re: Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65719/#review198746 --- Ship it! Ship It! - Akash Gupta On March 6, 2018, 8:04

Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/#review198747 --- Ship it! Ship It! - Akash Gupta On March 6, 2018, 8:05

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198740 --- PASS: Mesos patch 65930 was successfully built and tested.

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/#review198748 --- Ship it! Ship It! - Akash Gupta On March 6, 2018, 8:05

Review Request 65938: Replaced "re-register" terminology with "reregister".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65938/ --- Review request for mesos and Greg Mann. Bugs: MESOS-6128

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/ --- (Updated March 6, 2018, 9:07 p.m.) Review request for mesos, Greg Mann, Jason

Re: Review Request 65842: Stout: Changed `os::spawn` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/#review198734 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018,

Re: Review Request 65938: Replaced "re-register" terminology with "reregister".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65938/#review198754 --- PASS: Mesos patch 65938 was successfully built and tested.

Review Request 65939: Updated role endpoints for hierarchical accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and

Review Request 65940: Added test validating hierarchical role accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and

Re: Review Request 65841: Stout: Changed `os::system` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65841/#review198733 --- Ship it! 3rdparty/stout/include/stout/os/posix/shell.hpp

Re: Review Request 65932: Added a generic mechanism to check for isolator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65932/#review198738 --- Patch looks great! Reviews applied: [65932] Passed command:

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/#review198732 --- PASS: Mesos patch 65720 was successfully built and tested.

Re: Review Request 65864: Updated mesos code with the new `os::spawn`.

> On March 1, 2018, 3:13 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['65839', '65861', '65862', '65840', '65841', '65863', > > '65842', '65864']` > > > > Failed command: `Start-MesosCITesting` > > >

Re: Review Request 65864: Updated mesos code with the new `os::spawn`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65864/#review198737 --- Ship it! - Andrew Schwartzmeyer On March 1, 2018, 1:48 a.m.,

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/#review198750 --- Patch looks great! Reviews applied: [65719, 65721, 65720]

Re: Review Request 65938: Replaced "re-register" terminology with "reregister".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65938/#review198765 --- Patch looks great! Reviews applied: [65938] Passed command:

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review198759 --- src/slave/containerizer/mesos/launch.cpp Lines 583 (patched)

Re: Review Request 63862: Windows: Ported docker_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review198756 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 5, 2018,

Re: Review Request 65940: Added test validating hierarchical role accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review198757 --- PASS: Mesos patch 65940 was successfully built and tested.

Re: Review Request 65940: Added test validating hierarchical role accounting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review198774 --- Patch looks great! Reviews applied: [65939, 65940] Passed

Re: Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198760 --- Patch looks great! Reviews applied: [65930] Passed command:

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review198741 --- Thanks Benjamin - this is a nice improvement!

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On March 6, 2018, 2:44 a.m., Zhitao Li wrote: > > src/master/http.cpp > > Lines 845-857 (original), 845-861 (patched) > > > > > > I believe this is a behavior change. > > > > Previous,

Re: Review Request 59987: Added protobuf map support.

> On March 1, 2018, 12:10 p.m., Benjamin Mahler wrote: > > Chun and I went over this together, so feel free to reach out to either of > > us for discussion! Just some suggestions to clean up the code below. > > > > In the description, could we mention that this is for stout's json <-> > >

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated March 6, 2018, 5:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/ --- (Updated March 6, 2018, 5:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65917: Added a test `TaskValidationTest.TaskMissingDockerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65917/#review198682 --- PASS: Mesos patch 65917 was successfully built and tested.

Re: Review Request 65310: Added lambda::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65310/ --- (Updated March 6, 2018, 11:11 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

> On March 2, 2018, 9:33 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/tests/protobuf_tests.cpp > > Lines 675-676 (patched) > > > > > > Do you want to use a raw string literal here to avoid all the escaping? > >

Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65919/#review198685 --- PASS: Mesos patch 65919 was successfully built and tested.

Review Request 65928: Improved handling of many roles in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-8503

Re: Review Request 65921: Simplified system requirements of balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65921/#review198692 --- Ship it! Ship It! - Till Toenshoff On March 6, 2018, 2:07

Re: Review Request 65921: Simplified system requirements of balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65921/#review198693 --- PASS: Mesos patch 65921 was successfully built and tested.

Re: Review Request 65921: Simplified system requirements of balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65921/ --- (Updated March 6, 2018, 3:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65928: Improved handling of many roles in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/#review198708 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65590/ --- (Updated March 6, 2018, 5:47 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

> On March 6, 2018, 2:44 a.m., Zhitao Li wrote: > > src/master/http.cpp > > Lines 845-857 (original), 845-861 (patched) > > > > > > I believe this is a behavior change. > > > > Previous,

Re: Review Request 65928: Improved handling of many roles in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/#review198710 --- Patch looks great! Reviews applied: [65928] Passed command:

Review Request 65930: Start heartbeater after SUBSCRIBED event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/ --- Review request for mesos, Greg Mann, Jason Lai, Quinn Leng, and Vinod Kone.

Review Request 65918: Made sure no `name` parameter exists in container's Docker info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65918/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8497

Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65919/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8497

Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65919/#review198686 --- Patch looks great! Reviews applied: [65915, 65916, 65917, 65918,

Re: Review Request 65917: Added a test `TaskValidationTest.TaskMissingDockerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65917/#review198683 --- Patch looks great! Reviews applied: [65915, 65916, 65917]

Re: Review Request 65921: Simplified system requirements of balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65921/ --- (Updated March 6, 2018, 2:08 p.m.) Review request for mesos, Chun-Hung Hsiao