Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/#review86767 --- Bad patch! Reviews applied: [34968, 34969, 34970] Failed command:

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review86765 --- Thanks guys! docs/mesos-c++-style-guide.md

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/ --- (Updated June 5, 2015, 5:52 a.m.) Review request for mesos, Jie Yu and Vinod Ko

Review Request 35108: Passed allocated resources to the resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35108/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs: MES

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 4, 2015, 11:47 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review86741 --- Bad patch! Reviews applied: [35088, 35089, 35090, 35091, 35092, 350

Re: Review Request 35097: Update mesos executor to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review86738 --- LGTM - Cody Maloney On June 4, 2015, 7:31 p.m., James Peach wrote

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review86736 --- Bad patch! Reviews applied: [35088, 35089, 35090, 35091, 35092, 350

Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35099: Update cram_md5 to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35099/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35097: Update mesos executor to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35101: Update zookeeper tests to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35101/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35094: Update libprocess gate to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35094/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35092: Rebase master_contender_detector_tests with gmock synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35092/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35100: Update hook manager to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35100/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35098: Update module manager to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35098/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35096: Update mesos scheduler to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35096/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35095: Update linux fs to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35095/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35093: Update libprocess once to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35093/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35091: Update libprocess gmock to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35091/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35089: Replace lock_guard with synchronized in fetcher_cache_test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35089/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35090: Update libprocess process to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35090/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Review Request 35088: Add dependent include to synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35088/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs: MESOS-2805

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

> On June 4, 2015, 5:52 p.m., Adam B wrote: > > docs/getting-started.md, lines 24-26 > > > > > > It was suggested that we should keep this document short&sweet and only > > reference the latest Ubuntu LTS release, and

Re: Review Request 32664: Add port mapping isolator statistics tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/#review86732 --- let's break this down into three pieces? 1 the refactoring and clea

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review86731 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633, 34

Re: Review Request 34984: Added help for files

> On June 3, 2015, 7:01 p.m., Niklas Nielsen wrote: > > Thanks for taking this on, Aditi! > > > > I listed a few suggestions below Aditi, can you please resolve the issues by clicking the "Fixed" button on the issues below? Please see the guidelines here: http://mesos.apache.org/documentation

Re: Review Request 35064: Added help for slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35064/#review86729 --- Ship it! Ship It! - Vinod Kone On June 4, 2015, 11:21 a.m., Adit

Re: Review Request 35064: Added help for slave

> On June 4, 2015, 6:30 p.m., Niklas Nielsen wrote: > > Did you mean to create a new review request? Remember to add the line with > > 'Review: https://reviews.apache.org/r/XYZ/' to the commit message, to > > update the review with post reviews :) Yes. Please use post-reviews instead of rbt di

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86722 --- Ship it! src/slave/resource_estimator.cpp

Re: Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35079/ --- (Updated June 4, 2015, 2:28 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 2:25 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34633: Added QoS Controller test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- (Updated June 4, 2015, 2:24 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 2:23 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/#review86720 --- Ship it! Ship It! - Niklas Nielsen On June 4, 2015, 10:55 a.m.,

Re: Review Request 35084: Provided consistent behavior for bundled packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/#review86717 --- Patch looks great! Reviews applied: [33752, 35084] All tests passe

Re: Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/#review86714 --- Ship it! Ship It! - Vinod Kone On June 4, 2015, 5:55 p.m., Jie Y

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 10:58 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf.

Re: Review Request 11914: Get EC2 scripts into workable state

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11914/#review86707 --- Bad patch! Reviews applied: [11914] Failed command: ./support/appl

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On May 1, 2015, 7:30 p.m., Cody Maloney wrote: > > configure.ac, line 1407 > > > > > > I worry this changes the behavior some when --disable-bundled is set > > (Previously it seems like it would see if it could fin

Re: Review Request 35084: Provided consistent behavior for bundled packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/ --- (Updated June 4, 2015, 7:36 p.m.) Review request for mesos, Benjamin Hindman, C

Review Request 35084: Provided consistent behavior for bundled packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/ --- Review request for mesos. Repository: mesos Description --- Add the MESO

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated June 4, 2015, 7:31 p.m.) Review request for mesos, Cody Maloney and Ti

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86703 --- Patch looks great! Reviews applied: [35028] All tests passed. - M

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 5:58 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf. H

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 10:58 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf.

Re: Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/#review86691 --- Patch looks great! Reviews applied: [35082] All tests passed. - M

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 5:58 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf. H

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review86687 --- >From our last conversation, it sounds like you want to change the a

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review86675 --- src/slave/containerizer/mesos/launch.cpp

Re: Review Request 35064: Added help for slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35064/#review86685 --- Did you mean to create a new review request? Remember to add the lin

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 10:58 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf.

Re: Review Request 34633: Added QoS Controller test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86679 --- src/tests/oversubscription_tests.cpp

Re: Review Request 34720: Added kill executor correction to slave.

> On June 4, 2015, 5:58 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4400-4413 > > > > > > This is getting a little hairy. As the TODO says we really ought bubble > > this up via the Termination protobuf. H

Re: Review Request 34632: Added QoS Controller in slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86677 --- Ship it! Ship It! - Jie Yu On June 4, 2015, 5:42 p.m., Niklas Ni

Re: Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35079/#review86676 --- Ship it! include/mesos/slave/oversubscription.hpp

Re: Review Request 11914: Get EC2 scripts into workable state

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11914/#review86673 --- Stale review: Charles, still want this in? - Niklas Nielsen On Ju

Re: Review Request 11605: Add --enable-debug configure flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11605/#review86672 --- Stale review: Brenden, still want this in? - Niklas Nielsen On Ju

Re: Review Request 11121: Shuffle offers before sending to frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11121/#review86671 --- Stale review: Brenden, still want this in? - Niklas Nielsen On Ju

Re: Review Request 35080: Fix comments in routing_tests.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35080/#review86670 --- Ship it! Thanks! - Jie Yu On June 4, 2015, 5:51 p.m., Cong Wang

Re: Review Request 34720: Added kill executor correction to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/#review86669 --- src/slave/slave.cpp

Re: Review Request 35028: Added a fixed resource estimator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- (Updated June 4, 2015, 5:56 p.m.) Review request for mesos, Bartek Plotka, Nikl

Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos De

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review86667 --- docs/getting-started.md

Review Request 35080: Fix comments in routing_tests.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35080/ --- Review request for mesos, Jie Yu and Paul Brett. Repository: mesos Descriptio

Re: Review Request 34633: Added QoS Controller test.

> On June 3, 2015, 4:33 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, lines 339-340 > > > > > > Can you use initalization list here? > > > > ``` > > list expected = { QosCorrection() }; > >

Re: Review Request 34632: Added QoS Controller in slave

> On June 3, 2015, 4:26 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 344-345 > > > > > > Can you explain why you want to start receiving/acting on corrections > > even before the slave is recovered? How do you k

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 66 > > > > > > We have const char* in for example > > https://github.com/apache/mesos/blob/master/src/tests/hook_tests

Re: Review Request 34631: Added QoS Controller.

> On June 3, 2015, 4:02 p.m., Jie Yu wrote: > > include/mesos/slave/qos_controller.hpp, lines 25-26 > > > > > > Can you add a wrapper header > > mesos/slave/oversubscription.hpp > > > > similar to what we d

Re: Review Request 34721: Added QoS kill executor correction test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34719: Added QOS_KILLED as status reason

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34719/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34633: Added QoS Controller test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34632: Added QoS Controller in slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34720: Added kill executor correction to slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka, Jie

Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35079/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, line 66 > > > > > > We have const char* in for example > > https://github.com/apache/mesos/blob/master/src/tests/hook_tests

Re: Review Request 35028: Added a fixed resource estimator.

> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: > > src/slave/resource_estimator.cpp, lines 46-48 > > > > > > How about wrapping like: > > > > ``` > > return Error( > > "Could not creat

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On May 1, 2015, 7:30 p.m., Cody Maloney wrote: > > configure.ac, line 1407 > > > > > > I worry this changes the behavior some when --disable-bundled is set > > (Previously it seems like it would see if it could fin

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

> On June 3, 2015, 10:35 p.m., Jie Yu wrote: > > src/linux/routing/queueing/internal.hpp, line 320 > > > > > > Why <=? > > Paul Brett wrote: > The definition for RTNL_TC_STATS_MAX comes from libnl and looks like

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

> On June 4, 2015, 3:22 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/configure.ac, line 692 > > > > > > I think you meant != here. ;-) How did this pass for you!? That for fixing that. I think what happened w

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86628 --- 3rdparty/libprocess/configure.ac

Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

> On June 4, 2015, 3:10 p.m., Till Toenshoff wrote: > > Ship It! Thanks Joerg! - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35075/#review86626 --

Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35075/#review86626 --- Ship it! Ship It! - Till Toenshoff On June 4, 2015, 3:08 p.m., J

Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35075/ --- Review request for mesos, Alexander Rojas and Till Toenshoff. Repository: mesos

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

> On May 19, 2015, 8:13 p.m., Vinod Kone wrote: > > src/cli/mesos.cpp, line 31 > > > > > > So basename can never return an error? When did ::basename() return > > NULL? > > Alexander Rojas wrote: > I checked in th

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33849/#review86617 --- Ship it! Ship It! - Benjamin Hindman On May 5, 2015, 5:52 p.m.,

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

> On May 5, 2015, 4:29 p.m., Cody Maloney wrote: > > configure.ac, line 575 > > > > > > Can you check ax_cxx_compiler_version >= Clang/LLVM 3.5 here? Or does > > that not work on both OS X and Linux? > > James Peach

Re: Review Request 33331: Added file headers section to the C++ style guide.

> On June 4, 2015, 2:48 p.m., Joerg Schad wrote: > > docs/mesos-c++-style-guide.md, line 198 > > > > > > Please make this a list item (same below). > > must or should? Makes sense indeed. - Till --

Re: Review Request 33331: Added file headers section to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review86615 --- docs/mesos-c++-style-guide.md

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

> On June 4, 2015, 2:44 p.m., Benjamin Hindman wrote: > > Ship It! Like another patch you submitted you went from +2 to +4 indentation here, please be on the look out for that in the future. Thanks! - Benjamin --- This is an automatica

Re: Review Request 33755: Remove the unused acx_pthread autoconf macro from stout.

> On June 4, 2015, 1:47 p.m., Benjamin Hindman wrote: > > Ship It! Note that I also had to update stout/Makefile.am to remove the usage of the 'm4' directory. I'm not sure how this didn't break running 'bootstrap' for you? - Benjamin -

Re: Review Request 33331: Added file headers section to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated June 4, 2015, 2:37 p.m.) Review request for mesos. Changes ---

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: > > Just a heads up, you went from the +2 indentation in this file to +4 when you moved stuff around. I fixed it for you, but please keep the style consistent in the future, thanks! - Benjamin ---

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/configure.ac, line 694 > > > > > > s/Mesos/libprocess/ I took care of this fix for you James before committing. Thanks! - Benjamin

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86602 --- Ship it! 3rdparty/libprocess/configure.ac

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

> On May 18, 2015, 6:20 p.m., haosdent huang wrote: > > configure.ac, line 650 > > > > > > Should we change acx_pthread.m4 to ax_pthread.m4 here? > > James Peach wrote: > Updated the patch to alter the comments to

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

> On May 18, 2015, 6:24 p.m., haosdent huang wrote: > > 3rdparty/libprocess/configure.ac, line 745 > > > > > > Maybe we could search the whole project and replace acx_pthread.m4 -> > > ax_pthread.m4 I fixed this for

  1   2   >