Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review95508 --- Patch looks great! Reviews applied: [37479] All tests passed. - M

Re: Review Request 37468: Removed allocation types to mesos::master namespace

> On Aug. 14, 2015, 12:21 p.m., Guangya Liu wrote: > > Code looks good, but pls check what is wrong with the build Solved! There is an issue in the apply-review.sh. The script crashes because my name has "é". After I changed my name in the review board the script runs fine - Jose Guilherme

Re: Review Request 37489: Make scheduler tests parameterized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/#review95505 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2015, 2:13 a.m., Anan

Re: Review Request 37489: Make scheduler tests parameterized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 15, 2015, 2:13 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37493: Detect gflags when present and link when building Python module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/#review95504 --- Patch looks great! Reviews applied: [37493] All tests passed. - M

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 15, 2015, 2:02 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review95503 --- what's the status of this one? Should it be closed/discarded? - Mar

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review95502 --- And this one too. See my other comments. - Marco Massenzio On Jul

Re: Review Request 36125: Removing '.json' extension in master endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review95501 --- After @vinodkone (correct) comments, there has been no activity on t

Re: Review Request 36127: Removing '.json' extension in files endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review95500 --- Is this patch still needed? both this and the associated Jira have n

Re: Review Request 36040: Change Server closing connections for every request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/#review95498 --- This has not been touched in more than a month. Should it be discard

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated 八月 15, 2015, 1:44 a.m.) Review request for mesos, Niklas Nielsen and V

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 15, 2015, 1:27 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/#review95494 --- Ship it! LGTM 3rdparty/libprocess/3rdparty/stout/include/stout/js

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/#review95495 --- Patch looks great! Reviews applied: [37494] All tests passed. - M

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 15, 2015, 12:55 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 15, 2015, 12:54 a.m.) Review request for mesos and Timothy Chen.

Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- Review request for mesos. Repository: mesos Description --- Move docker

Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- Review request for mesos. Repository: mesos Description --- Added Docker

Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- Review request for mesos. Repository: mesos Description --- Docker provi

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 15, 2015, 12:46 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37246: Refactor store to use updated DockerImage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37246/ --- (Updated Aug. 15, 2015, 12:44 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/ --- (Updated Aug. 15, 2015, 12:41 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 15, 2015, 12:40 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- (Updated Aug. 15, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 15, 2015, 12:39 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 15, 2015, 12:38 a.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 37489: Make scheduler tests parameterized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/#review95490 --- Patch looks great! Reviews applied: [37489] All tests passed. - M

Re: Review Request 37491: Added a trivial test on how the protobuf->json string don't match due to incorrect escaping of bytes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/#review95485 --- Patch looks great! Reviews applied: [37491] All tests passed. - M

Review Request 37493: Detect gflags when present and link when building Python module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37493/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-

Review Request 37494: Fixed JSON wrapper to properly encode bytes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37494/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3267 h

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote: > > [mmm turns out that it matters WHICH boxes you put your general comments in :) - copied here, as they make sense *before* the nitpicking that follows] Again, sorry it's taken so long to get round to doing this review and s many th

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95473 --- src/examples/java/TestPersistentVolumeFramework.java (line 34)

Re: Review Request 37490: Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/#review95481 --- Ship it! Ship It! - Jie Yu On Aug. 14, 2015, 10 p.m., Paul Brett

Re: Review Request 37490: Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 10 p.m.) Review request for mesos and Jie Yu. Summary

Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/#review95480 --- Patch looks great! Reviews applied: [37490] All tests passed. - M

Re: Review Request 37382: Introduced provisioner Backend interface.

> On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.

Re: Review Request 37382: Introduced provisioner Backend interface.

> On Aug. 14, 2015, 6:15 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.e

Re: Review Request 37382: Introduced provisioner Backend interface.

> On Aug. 14, 2015, 11:15 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backend.hpp, lines 55-57 > > > > > > Hum, what do yo mean here? > > > > I think the backend should be container aware. I.

Re: Review Request 37382: Introduced provisioner Backend interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95471 --- Patch looks great! Reviews applied: [37382] All tests passed. - M

Re: Review Request 37489: Make scheduler tests parameterized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- (Updated Aug. 14, 2015, 8:23 p.m.) Review request for mesos, Ben Mahler and Vin

Review Request 37491: Added a trivial test on how the protobuf->json string don't match due to incorrect escaping of bytes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3263 https

Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for mesos and Jie Yu. Chang

Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3254 https://issues.apache

Re: Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37488/#review95464 --- Patch looks great! Reviews applied: [37488] All tests passed. - M

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95460 --- Ship it! Per Greg, the underlying issue will be tracked here: http

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95459 --- Ship it! Per Greg, the underlying issue will be tracked here: http

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95457 --- Patch looks great! Reviews applied: [37426, 37427] All tests passe

Re: Review Request 37382: Introduced provisioner Backend interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95455 --- src/slave/containerizer/provisioners/backend.hpp (line 49)

Re: Review Request 37382: Introduced provisioner Backend interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/ --- (Updated Aug. 14, 2015, 10:51 a.m.) Review request for mesos, Lily Chen, Ian Do

Re: Review Request 37382: Introduced provisioner Backend interface.

> On Aug. 12, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/backend.hpp, line 48 > > > > > > Should we just use Path here? Path is still hard to use in an interface particularly when i

Review Request 37489: Make scheduler tests parameterized

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos Descri

Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37488/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: M

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review95454 --- Patch looks great! Reviews applied: [37479] All tests passed. - M

Re: Review Request 37487: Fixed flaky HTTPTest.NestedGet test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37487/#review95453 --- Ship it! Ship It! - Ben Mahler On Aug. 14, 2015, 5:23 p.m., Vino

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 14, 2015, 5:28 p.m.) Review request for mesos, Lily Chen, Joris V

Review Request 37487: Fixed flaky HTTPTest.NestedGet test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37487/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Bugs: MESOS-3262 h

Re: Review Request 37457: Add --ip_discovery_command to Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37457/#review95448 --- Ship it! I'll fix these up and commit. src/slave/main.cpp (line 1

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated 八月 14, 2015, 4:57 p.m.) Review request for mesos and Vinod Kone. Bug

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

> On Aug. 14, 2015, 12:12 p.m., James DeFelice wrote: > > failing unit test from mesos built bot seems completely unrelated (evil > > agent!): > > ``` > > ../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure > > Value of: response.get().status > > Actual: "202 Accepted" > > Expec

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review95435 --- Bad patch! Reviews applied: [37479] Failed command: make -j3 distc

Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3261 https://issues.ap

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 14, 2015, 2:43 p.m.) Review request for mesos, Lily Chen, Joris V

Re: Review Request 37445: Fix typos in style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37445/#review95419 --- Ship it! Ship It! - Guangya Liu On 八月 13, 2015, 9:58 p.m., Neil

Re: Review Request 37468: Removed allocation types to mesos::master namespace

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95418 --- Code looks good, but pls check what is wrong with the build - Guang

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95417 --- failing unit test from mesos built bot seems completely unrelated (e

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:58 a.m.) Review request for mesos, Adam B, Connor Do

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

> On Aug. 14, 2015, 1:49 p.m., Alexander Rojas wrote: > > src/tests/fault_tolerance_tests.cpp, line 1834 > > > > > > Line length is 81 characters. > > James DeFelice wrote: > assuming that 80 is the limit? is t

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

> On Aug. 14, 2015, 11:49 a.m., Alexander Rojas wrote: > > src/tests/fault_tolerance_tests.cpp, line 1834 > > > > > > Line length is 81 characters. assuming that 80 is the limit? is there a common linter that you g

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95411 --- Ship it! src/tests/fault_tolerance_tests.cpp (line 1834)

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/ --- (Updated Aug. 14, 2015, 11:29 a.m.) Review request for mesos, Adam B, Connor Do

Re: Review Request 37475: Fixed a wrong comparison.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/#review95412 --- Patch looks great! Reviews applied: [37475] All tests passed. - M

Re: Review Request 36847: Added HTTP Delete Method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95410 --- Ship it! Ship It! - Bernd Mathiske On Aug. 13, 2015, 9:19 a.m.,

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95409 --- src/master/http.cpp (line 239)

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95408 --- Ship it! These mini issues can easily be fixed while committing. Gr

Re: Review Request 18723: Prevent gflags detection from glog configuration phase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18723/ --- (Updated Aug. 14, 2015, 10:34 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 37475: Fixed a wrong comparison.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/#review95407 --- Ship it! Ship It! - Till Toenshoff On Aug. 14, 2015, 10:21 a.m.,

Review Request 37475: Fixed a wrong comparison.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37475/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 14, 2015, 8:20 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 14, 2015, 8:17 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95405 --- Patch looks great! Reviews applied: [37415] All tests passed. - M

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review95396 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416, 37