Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107047
---



src/master/quota_handler.cpp (line 224)


As discussed offline I would prefere a single json object per request which 
is discussed by MESOS-3914. Until then I am ok with having the flag in the 
request body.



src/tests/master_quota_tests.cpp (lines 129 - 134)


I will merge both functions.


- Joerg Schad


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> ---
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
> https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107042
---


Thanks for working on this. This functionality has been missing for some-time 
now. 

Just some minor comments around style and an alternate suggestion for the 
method name to be on parity with the existing `lostSlave` method.


src/sched/sched.cpp (line 594)


We generally avoid redundant/self-explanatory comments. Remove this:
s/Notify scheduler for exited executor./



src/sched/sched.cpp (line 595)


s/executorExited/lostExecutor

Let's name this method `lostExecutor` to be on parity with the already 
existing `lostSlave` method.

Also, let's change the signature of the function to:

```
  void executorExited(
  const UPID& from,
  const SlaveID& slaveId,
  const ExecutorID& executorId,
  int32_t status) {
```



src/sched/sched.cpp (line 598)


Note that the `status` field is an optional now in the new `V1` Call/Event 
API:


https://github.com/apache/mesos/blob/master/include/mesos/v1/scheduler/scheduler.proto#L126

If it's not set, let's set it to `-1` i.e. a special status when the 
`status` is unknown. This is similar to how the Slave does it.

https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L3544

```
int32_t status = -1;
if (event.failure().has_status()) {
  status = event.failure().status();
}

lostExecutor(
from,
event.failure().slave_id(),
event.failure().executor_id(),
status);
```



src/sched/sched.cpp (line 1051)


We prefer braces on new-line for function definitions:
```
 void lostExecutor(
  const UPID& from,
  const SlaveID& slaveId,
  const ExecutorID& executorId,
  int32_t status)
 {
 }
```



src/sched/sched.cpp (line 1053)


s/Ignoring framework message/Ignoring lost executor message



src/sched/sched.cpp (line 1056)


Let's have another check to see if the driver is not disconnected here:

```
if (!connected) {
  VLOG(1) << "Ignoring lost executor message because the driver is 
disconnected!";
  return;
}
```
^^ My bad for the bad indent. RB was not letting me indent this properly.

Also, let's add another check to see if the message was received from the 
leading master:

```
CHECK_SOME(master);

if (from != master.get().pid()) {
  VLOG(1) << "Ignoring lost executor message because it was sent "
  << "from '" << from << "' instead of the leading master '"
  << master.get().pid() << "'";
  return;
}
```



src/sched/sched.cpp (line 1069)


s/executorExited/executorLost



src/tests/scheduler_event_call_tests.cpp (line 592)


New line before this line.



src/tests/scheduler_event_call_tests.cpp (line 593)


You can just do:

`ExecutorID executorID = DEFAULT_EXECUTOR_ID;`



src/tests/scheduler_event_call_tests.cpp (line 595)


`const int32_t status = 255;`



src/tests/scheduler_event_call_tests.cpp (line 608)


New line before this line


- Anand Mazumdar


On Nov. 18, 2015, 7:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Nov. 18, 2015, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for 

Re: Review Request 40392: Added force flag to override quota capacityHeuristic check.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107041
---



src/master/quota_handler.cpp (line 224)


I'm a bit concerned whether it's a good solution to put this flag in the 
request body. I'd say better alternatives are:
- A single JSON object per request (with the `force` flag inside);
- `force` flag in the URL.
 
What do you think?



src/tests/master_quota_tests.cpp (lines 129 - 134)


I assume you introduce a separate function because you want to allow (and 
test) `force=false` as well, otherwise a single method suffices:
```
  string createRequestBody(const Resources& resources, bool force = false) 
const
  {
string request = strings::format("resources=%s", JSON::protobuf(
static_cast&>(resources))).get();

if (force) {
  request + "=" + stringify(force);
}

return request;
  }
```

However, we may still use a single method:
```
string createRequestBody(const Resources& resources, Option force) 
const
```

I think having a single method is cleaner and allow the reader to grasp all 
possibilities at once.



src/tests/master_quota_tests.cpp (line 456)


This is not necessary any more.


- Alexander Rukletsov


On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> ---
> 
> (Updated Nov. 17, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
> https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 38233: os: add swap information to memory().

[Chi Zhang]

> On Nov. 17, 2015, 7:20 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, lines 708-759
> > 
> >
> > do these calculations work irrespective of whether swap is enabled or 
> > disabled?

if swap is disabled, xsu_total will be 0


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review106917
---


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

Review request for mesos, Benjamin Hindman and Marco Massenzio.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs
-

  support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
  support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
  support/mesos-license.py PRE-CREATION 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


Thanks,

Benjamin Bannier

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39591/
---

(Updated Nov. 18, 2015, 4:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Just used C++-style comments for license headers.

This was suggested by benh; the strong argument for this approach instead of 
C-style block comments is that reduces the number of typically used comment 
styles (C-style block comments with `/**  */` for Doxygen, and C++-style 
comments `//` for almost everything else).


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This commit adjusts license headers of C++ source and header files.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
064e84ee97ba8c875a740223bd0012b3a8293a31 
  3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp 
27087041d8255b96159bb10c184f00cf5bc9c34e 
  3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 
4893e7ba0b7d83fd3ba36bf18aa541c60293cc23 
  3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp 
b9a9c20125229c8150660e5969e136b07cecb169 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
e9cf85637157f98a0eac166096bb18fa5652c669 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
0d51c8d418acb49b52cebfb644ee0476d6ec4502 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 
b550bfee696c85c0ade3feaf5d38e20eb4c1ce78 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
e58ee43623d72b52dd8682e3d976da74e8bec9e8 
  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
5d0970fe9f712d7162eec522c83905292892c94d 
  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
1845b1ed8214c5d35697a812181f97f799484838 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
38dabd45aa1d7f02e9991ce4ae28b44cd39db87c 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp 
ab609a0d7922298eaf89648200fabd843f8201e0 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 
3c320a319edce83af0287b0b014234f7e7ec6e0b 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
a289f8303740394ec1a0900e643d33e3c18a831d 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
7cf4feff87dd08201a410596d2862383c29021af 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
25252015d04884dae7238129e2d7313a615967ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
d9d0fd4febd540252ae53fb4af7eb061983d0133 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
642bd4ce640cfdbf3c122cec64d72c9434d89fa3 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
f766359fdd5a75e3a80d19be3e5c233e87357bde 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
85c773ac675c88b313dffda7a9c32bac42ebe62d 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
51ec75868e614042c339ab0eaa995c9996ddf124 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
d207dc5ad7558818da7fd0d04c6ef8df217b78c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
6709f5e7f6233983f389203278a0e42694591230 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
9625894b69417faa796be5c4313b759cbcc1ce90 
  3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp 
6cbb2ac50dd23d78465e8690112fc01114ada07b 
  3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 
89340fd79167a311c698740454db19e83c286952 
  3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 
60f0c8c67317872883857a1cd8f39d6d6a45d0c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
5748c9e6d39551eee287f3e9804505cb2fd3fdd0 
  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
52d1eea6d04092caa8eba39ad69c2a474f854a8d 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp 
ce94fef4aeeb098668decc36606ee667915a15cd 
  3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp 
95b730c83ec357b33afae0d04182f7a72ffd28c4 
  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
ddd3dd9e015c583e04d72ac9a9b5a5ed6f1d49d5 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
db5e33220844d20ef08a7324f641eeb1ff6d2052 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp 

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39592/
---

(Updated Nov. 18, 2015, 4:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Just used C++-style comments for license headers.

This was suggested by benh; the strong argument for this approach instead of 
C-style block comments is that reduces the number of typically used comment 
styles (C-style block comments with `/** */` for Doxygen, and C++-style 
comments `//` for almost everything else).


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This commit adjusts license headers of C++ source and header files.


Diffs (updated)
-

  3rdparty/libprocess/examples/example.cpp 
22ae083d8b5bf59cf52e18405e005cfe94edb81d 
  3rdparty/libprocess/include/process/address.hpp 
7b94979716fed0e2e93967335112835c4b6720a6 
  3rdparty/libprocess/include/process/async.hpp 
676aa4c6849487b2d91b4a2ce458c719396f22f0 
  3rdparty/libprocess/include/process/check.hpp 
4b43b704d6a87725bdde040cbc981dd2da1ad709 
  3rdparty/libprocess/include/process/clock.hpp 
1107a329caf77f15901d87808eee72818601510c 
  3rdparty/libprocess/include/process/collect.hpp 
2a8547b939dda08ce1debbf422654fa9f4593125 
  3rdparty/libprocess/include/process/defer.hpp 
c9caf58aab58c5ed8b5288a43405f88ba3b19c03 
  3rdparty/libprocess/include/process/deferred.hpp 
00072e014159761c18aa7b21fa15dfdbb95f2271 
  3rdparty/libprocess/include/process/delay.hpp 
65e316e12b96f96058292faa4fc7a7f34c5c1c73 
  3rdparty/libprocess/include/process/dispatch.hpp 
c5b8137586113016d702451260c18ff5cfa7c0a2 
  3rdparty/libprocess/include/process/event.hpp 
4b7db0da84d7f46186dacad014cd482d30278fa7 
  3rdparty/libprocess/include/process/executor.hpp 
0693e4e362aafe208847651bcf83956c26643de7 
  3rdparty/libprocess/include/process/filter.hpp 
db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/firewall.hpp 
b5c7d9976b7a5cbf3cc621559dc361e15059ee67 
  3rdparty/libprocess/include/process/future.hpp 
3916150691e9a0880b8b826734fa74bd33d18cfd 
  3rdparty/libprocess/include/process/gc.hpp 
72fde54ce2f727c89ca49485a0dfee124cb6fc2f 
  3rdparty/libprocess/include/process/gmock.hpp 
575f1ecb3dfbfb7d8f011d408c1e24619406c2b0 
  3rdparty/libprocess/include/process/gtest.hpp 
2ae2a5a16e61304c969c4802990b31beb3964f25 
  3rdparty/libprocess/include/process/help.hpp 
2412db913207b8d6953297870e41a657c742b2a1 
  3rdparty/libprocess/include/process/http.hpp 
d718090fe041c23d0040da2eb54da9ecd4ee9151 
  3rdparty/libprocess/include/process/id.hpp 
a0bb5dbd93bc7e2f245e012032d54969eefd1d3e 
  3rdparty/libprocess/include/process/io.hpp 
73bf30b97c342632e753658fb1f283aa362ce48b 
  3rdparty/libprocess/include/process/latch.hpp 
8a9d12165ea7442ddc68d20d15c8458b388bb679 
  3rdparty/libprocess/include/process/limiter.hpp 
f2efe84212e3a98e5a29e2ec07adc73b5da1ad14 
  3rdparty/libprocess/include/process/logging.hpp 
03fb1bd51e105d0070760af6232dab03e85127d2 
  3rdparty/libprocess/include/process/message.hpp 
e9c7e050a771ff88cbec49f5adb37c04138479be 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
  3rdparty/libprocess/include/process/metrics/gauge.hpp 
13934b8c48012a4ef38ba587deb1bce058425ccc 
  3rdparty/libprocess/include/process/metrics/metric.hpp 
c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f2e84d8e62df58812b660c858eb3b0366db4 
  3rdparty/libprocess/include/process/metrics/timer.hpp 
08f16b89b436eda86418974c5ef16c6ad0e74a5d 
  3rdparty/libprocess/include/process/mime.hpp 
decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
  3rdparty/libprocess/include/process/mutex.hpp 
46e25df66325b029cb3e9bbc5e94d66aa5bac4e8 
  3rdparty/libprocess/include/process/network.hpp 
61bfa8243728dc19ab0e6fb43d33ca83fb3709c3 
  3rdparty/libprocess/include/process/once.hpp 
cbb18680037bac148d7e915081c484791bd6f892 
  3rdparty/libprocess/include/process/owned.hpp 
1b41477d555ce567c58033f8993dc2ae0ac80a05 
  3rdparty/libprocess/include/process/pid.hpp 
e87cfcaf0f93cd9dd0ce7df7299a58fa58982fa7 
  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/include/process/profiler.hpp 
4082b8ae579aa11c688da961e126a94d8f121762 
  3rdparty/libprocess/include/process/protobuf.hpp 
91b51b0ffbdbe791183afacd3fd16238f3af135e 
  3rdparty/libprocess/include/process/queue.hpp 
7e3538763659dd3ca6c8cd61d17abb3af32bb01b 
  3rdparty/libprocess/include/process/reap.hpp 
ca5acc4c8f5a62a49b7fde83946e283ea40baa65 
  3rdparty/libprocess/include/process/run.hpp 
98de0fd30cc1dc5561c924a0e5e5fc18e24cf7a1 
  3rdparty/libprocess/include/process/sequence.hpp 
41da6978c7f2ec198587f024f0fc02f882082cc5 
  

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 18, 2015, 4:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Just used C++-style comments for license headers.

This was suggested by benh; the strong argument for this approach instead of 
C-style block comments is that reduces the number of typically used comment 
styles (C-style block comments with `/**  */` for Doxygen, and C++-style 
comments `//` for almost everything else).


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This commit adjusts license headers of C++ source and header files, and 
protobuf definitions.

Also, reflect the changed style in the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/quota/quota.hpp 38a5cbabe803611f7181a54ca52fbf2ccfb42773 
  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 

Re: Review Request 40445: Added linter for license headers in some file types.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
---



support/hooks/post-rewrite (line 33)


instead of calling this script directly, i would recommend calling it from 
mesos-style.py. this way users and tools (review bot) can run just one script 
to test compliance.


- Vinod Kone


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

[Cong Wang]

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405
> > 
> >
> > Why not add a 0x prefix if it's not present so you can use numify?
> > 
> > if (!strings::startsWith(tokens[0], "0x")) {
> > ...
> > }
> 
> Cong Wang wrote:
> This should work too, but I don't feel it is better than my code.
> 
> Ian Downes wrote:
> I really think it's necessary to use stout's conversion functions here.

Sure, I will change it, although I still don't have any preference.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review104119
---


On Oct. 29, 2015, 12:12 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39417/
> ---
> 
> (Updated Oct. 29, 2015, 12:12 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When --egress_unique_flow_per_container is enabled, we need to install a flow 
> classifier (fq_codel) qdisc on egress side. This flag specifies where to 
> install it in the hierarchy. By default, we install it at root. But, for 
> example, if you have already installed HTB qdisc at root, you may want this 
> to be installed in other place than root, specify an HTB class ID as its 
> parent here.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md ae9f2612b11447eff92ea85d4191e7011d71b2b2 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 1911ba6518190cbff6d72b56aaa477d508dbd391 
>   src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
>   src/slave/flags.cpp 1362dcebef799399739025171696230bded447dd 
> 
> Diff: https://reviews.apache.org/r/39417/diff/
> 
> 
> Testing
> ---
> 
> Manual tests, with and without a pre-installed HTB qdisc and classes.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 38233: os: add swap information to memory().

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review107062
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> ---
> 
> (Updated Sept. 10, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> os: add swap information to memory().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp 
> 82ccd766bd22393f48be4554c7da46338dd92d1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/38233/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

[James Peach]

> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 4244-4247
> > 
> >
> > why do it here instead of in recoverFramework() #4363? that feels more 
> > consistent with #1345.
> 
> James Peach wrote:
> I did this after recovery because the original code did not write 
> framework checkpoints if the slave was in RECOVERING state. I did not see a 
> reason for that, but decided to preserve the behavior as much as possible 
> just in case.
> 
> Vinod Kone wrote:
> originally, the slave didn't checkpoint framework during recovery stage 
> because it was not needed. if it is creating a framework object during 
> recovery, it is because it read the checkpointed data. so no need to 
> checkpoint again. 
> 
> but due to the compatibility issue you found, the slave can re-checkpoint 
> framework info during recovery because the framework info is *updated*. so i 
> would recommend moving this down to #1345 and do re-checkpoint if necessary.

Fixed and re-tested. We now upgrade the checkpoint during recovery but only if 
we need to.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review106142
---


On Nov. 12, 2015, 5:41 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40177/
> ---
> 
> (Updated Nov. 12, 2015, 5:41 a.m.)
> 
> 
> Review request for mesos, Kapil Arya and Vinod Kone.
> 
> 
> Bugs: MESOS-3834
> https://issues.apache.org/jira/browse/MESOS-3834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When performing an upgrade cycle, it is possible for a 0.24 and
> later agent to recover from a framework checkpoint written by 0.22
> or earlier. In this case, we need to compatibly accept a missing
> FrameworkID, and then rewrite the framework checkpoint so that
> subsequent upgrades don't hit the same problem.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp ac2d0e0153721a66495cd6539b25f5b3cee9d979 
> 
> Diff: https://reviews.apache.org/r/40177/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS 6.7.
> Manual testing with a rolling upgrade from 0.22
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/
---

(Updated Nov. 18, 2015, 6:49 p.m.)


Review request for mesos, Kapil Arya and Vinod Kone.


Bugs: MESOS-3834
https://issues.apache.org/jira/browse/MESOS-3834


Repository: mesos


Description
---

When performing an upgrade cycle, it is possible for a 0.24 and
later agent to recover from a framework checkpoint written by 0.22
or earlier. In this case, we need to compatibly accept a missing
FrameworkID, and then rewrite the framework checkpoint so that
subsequent upgrades don't hit the same problem.


Diffs (updated)
-

  src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
  src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 

Diff: https://reviews.apache.org/r/40177/diff/


Testing
---

make check on CentOS 6.7.
Manual testing with a rolling upgrade from 0.22


Thanks,

James Peach

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review107070
---



src/slave/slave.cpp (line 4321)


pull this down to #4344

s/upgradeCheckpoint/recheckpoint/



src/slave/slave.cpp (line 4344)


How about:

// In this case, we update `FrameworkInfo.framework_id`  from the directory 
name and re-checkpoint it.



src/slave/slave.cpp (line 4365)


is it possibel for framework->info.checkpoint() to be false if we are here? 
if not, this should be a CHECK instead.



src/slave/slave.cpp (line 4366)


kill this log line.


- Vinod Kone


On Nov. 18, 2015, 6:49 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40177/
> ---
> 
> (Updated Nov. 18, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Vinod Kone.
> 
> 
> Bugs: MESOS-3834
> https://issues.apache.org/jira/browse/MESOS-3834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When performing an upgrade cycle, it is possible for a 0.24 and
> later agent to recover from a framework checkpoint written by 0.22
> or earlier. In this case, we need to compatibly accept a missing
> FrameworkID, and then rewrite the framework checkpoint so that
> subsequent upgrades don't hit the same problem.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40177/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS 6.7.
> Manual testing with a rolling upgrade from 0.22
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40305: Added URI fetcher interface.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/#review107073
---

Ship it!



include/mesos/uri/fetcher.hpp (line 49)


Plugin might be confusing with Module.

Not sure what's a better alternative name is, Downloader? Schema?


- Vinod Kone


On Nov. 16, 2015, 7:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40305/
> ---
> 
> (Updated Nov. 16, 2015, 7:06 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added URI fetcher interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/fetcher.hpp PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/uri/fetcher.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40305/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/
---

(Updated Nov. 18, 2015, 7:20 p.m.)


Review request for mesos, Adam B and Vinod Kone.


Changes
---

Addressing review comments.


Bugs: MESOS-313
https://issues.apache.org/jira/browse/MESOS-313


Repository: mesos


Description
---

Report executor exit to framework schedulers. This is a MVP to start the work 
of notifying scheduler on scheduler refresh.

Next step would be sending this message reliabily, and/or splitting 
Event::FAILURE for slave failure and executor termination.


Diffs (updated)
-

  src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
  src/tests/scheduler_event_call_tests.cpp 
39f67a8243db8073d1c9c92c7aeb71854143131d 

Diff: https://reviews.apache.org/r/40429/diff/


Testing
---

Modified test for SchedulerDriverEventTest.Failure, which verifies that 
MockScheduler::executorLost is invoked.


Thanks,

Zhitao Li

Re: Review Request 40403: Added streaming and construction methods for URI.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/#review107074
---

Ship it!



src/uri/schemes/http.hpp (line 38)


consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single 
`src/uri.cpp` file.


- Vinod Kone


On Nov. 17, 2015, 9:27 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40403/
> ---
> 
> (Updated Nov. 17, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added streaming and construction methods for URI.
> 
> 
> Diffs
> -
> 
>   include/mesos/uri/uri.hpp PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/uri_tests.cpp PRE-CREATION 
>   src/uri/schemes/file.hpp PRE-CREATION 
>   src/uri/schemes/http.hpp PRE-CREATION 
>   src/uri/utils.hpp PRE-CREATION 
>   src/uri/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40403/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107076
---

Ship it!


LGTM! 

Just some minor newline nits.


src/sched/sched.cpp (line 598)


Nit: Newline before this line.



src/sched/sched.cpp (line 1063)


Nit: Newline before this line.



src/sched/sched.cpp (line 1082)


nit: kill the newline here.


- Anand Mazumdar


On Nov. 18, 2015, 7:20 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Nov. 18, 2015, 7:20 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 40418: Added curl based URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40418/
---

(Updated Nov. 18, 2015, 8:56 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Checked HTTP response code. Fixed the compile issue on some GCCs.


Repository: mesos


Description
---

Added curl based URI fetcher plugin.


Diffs (updated)
-

  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/uri_fetcher_tests.cpp PRE-CREATION 
  src/uri/fetcher.cpp PRE-CREATION 
  src/uri/fetchers/curl.hpp PRE-CREATION 
  src/uri/fetchers/curl.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40418/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review106999
---


Do we also need to add this support in v1/mesos.proto?

- Qian Zhang


On Nov. 18, 2015, 2:58 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> ---
> 
> (Updated Nov. 18, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40244/
---

(Updated Nov. 18, 2015, 11:27 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Clarified comments in Master::Http::_operation.


Diffs (updated)
-

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 

Diff: https://reviews.apache.org/r/40244/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40246: Removed unused "using" statement from test code.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

(Updated Nov. 18, 2015, 11:27 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs (updated)
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40245: Fixed typos in comments.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40245/
---

(Updated Nov. 18, 2015, 11:27 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Fixed typos in comments.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 

Diff: https://reviews.apache.org/r/40245/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Improved docs for dynamic reservation HTTP endpoints.


Diffs (updated)
-

  docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 

Diff: https://reviews.apache.org/r/40242/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Documented "role" field in Resource protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/40243/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/#review107000
---



3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 232)


For (local) consistence this whole block should probably be indented by two 
spaces.



3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 233)


You didn't start this, but any `struct` token here is unnecessary noise 
since this is C++, not C; this antipattern should probably not be proliferated 
further.

If you wanted you could even write lines like this one here as

const auto addr = reinterpret_cast();



3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 237)


Indent this block by two spaces.



3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line 240)


Would it make sense to (locally) specialize `stringify` for `sa_family_t` 
here for this use case and the one above?


LGTM, added minor points nevertheless.

- Benjamin Bannier


On Nov. 18, 2015, 9:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40435/
> ---
> 
> (Updated Nov. 18, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3939
> https://issues.apache.org/jira/browse/MESOS-3939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous code took the address of a "struct sockaddr", and then cast the
> resulting pointer to "struct sockaddr_storage *". The alignment requirements 
> for
> "struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
> hence this code produced undefined behavior per ubsan in GCC 5.2.
> 
> Along the way, tweak the code to use reinterpret_cast rather than a C-style
> cast, and not to unnecessarily cast-away constness.
> 
> MESOS-3939.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 6709f5e7f6233983f389203278a0e42694591230 
> 
> Diff: https://reviews.apache.org/r/40435/diff/
> 
> 
> Testing
> ---
> 
> "make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
> error. With fix, ubsan does not report (this) error.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

[Neil Conway]

> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 233
> > 
> >
> > You didn't start this, but any `struct` token here is unnecessary noise 
> > since this is C++, not C; this antipattern should probably not be 
> > proliferated further.
> > 
> > If you wanted you could even write lines like this one here as
> > 
> > const auto addr = reinterpret_cast();

Re: "struct", interesting point. You could argue that for code that interfaces 
with C, using "struct sockaddr" and similar types has some value because it 
matches the C API declarations more closely. I don't feel strongly either way, 
but since the current code uses "struct sockaddr" (as well as "struct stat" and 
so on), I'm inclined to leave as-is unless/until we end up changing things 
consistently.

Re: "auto", in this case I think being more explicit/redundant is probably 
worth it.


> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 237
> > 
> >
> > Indent this block by two spaces.

Thanks! Good catch.


> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 240
> > 
> >
> > Would it make sense to (locally) specialize `stringify` for 
> > `sa_family_t` here for this use case and the one above?

Perhaps? :) Please open a RR for it if you think it's worth doing.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/#review107000
---


On Nov. 18, 2015, 9:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40435/
> ---
> 
> (Updated Nov. 18, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3939
> https://issues.apache.org/jira/browse/MESOS-3939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous code took the address of a "struct sockaddr", and then cast the
> resulting pointer to "struct sockaddr_storage *". The alignment requirements 
> for
> "struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
> hence this code produced undefined behavior per ubsan in GCC 5.2.
> 
> Along the way, tweak the code to use reinterpret_cast rather than a C-style
> cast, and not to unnecessarily cast-away constness.
> 
> MESOS-3939.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 6709f5e7f6233983f389203278a0e42694591230 
> 
> Diff: https://reviews.apache.org/r/40435/diff/
> 
> 
> Testing
> ---
> 
> "make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
> error. With fix, ubsan does not report (this) error.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/
---

(Updated Nov. 18, 2015, 11:09 a.m.)


Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.


Changes
---

Address review comments: whitespace.


Bugs: MESOS-3939
https://issues.apache.org/jira/browse/MESOS-3939


Repository: mesos


Description
---

The previous code took the address of a "struct sockaddr", and then cast the
resulting pointer to "struct sockaddr_storage *". The alignment requirements for
"struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
hence this code produced undefined behavior per ubsan in GCC 5.2.

Along the way, tweak the code to use reinterpret_cast rather than a C-style
cast, and not to unnecessarily cast-away constness.

MESOS-3939.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
6709f5e7f6233983f389203278a0e42694591230 

Diff: https://reviews.apache.org/r/40435/diff/


Testing
---

"make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
error. With fix, ubsan does not report (this) error.


Thanks,

Neil Conway

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/#review107013
---


Patch looks great!

Reviews applied: [40435]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 11:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40435/
> ---
> 
> (Updated Nov. 18, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3939
> https://issues.apache.org/jira/browse/MESOS-3939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous code took the address of a "struct sockaddr", and then cast the
> resulting pointer to "struct sockaddr_storage *". The alignment requirements 
> for
> "struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
> hence this code produced undefined behavior per ubsan in GCC 5.2.
> 
> Along the way, tweak the code to use reinterpret_cast rather than a C-style
> cast, and not to unnecessarily cast-away constness.
> 
> MESOS-3939.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 6709f5e7f6233983f389203278a0e42694591230 
> 
> Diff: https://reviews.apache.org/r/40435/diff/
> 
> 
> Testing
> ---
> 
> "make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
> error. With fix, ubsan does not report (this) error.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107022
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

[Neil Conway]

> On Nov. 18, 2015, 12:02 a.m., Michael Park wrote:
> > include/mesos/mesos.proto, line 583
> > 
> >
> > How about `The role that this resource is reserved for.`? In the sense 
> > that it's not the role that reserves a resource, per se.

Yes, definitely better!


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106962
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Neil Conway]

> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/home.md, line 40
> > 
> >
> > `s/for use by a role/for a role/`? `to be used by a role`?

Personally, I think "for use by a role" is the clearest way to phrase this.


> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/reservation.md, lines 244-262
> > 
> >
> > Do these backslashes need to be removed in order for copy/paste to work?

Yes.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106960
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/#review107004
---


Patch looks great!

Reviews applied: [40435]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 9:39 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40435/
> ---
> 
> (Updated Nov. 18, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3939
> https://issues.apache.org/jira/browse/MESOS-3939
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous code took the address of a "struct sockaddr", and then cast the
> resulting pointer to "struct sockaddr_storage *". The alignment requirements 
> for
> "struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
> hence this code produced undefined behavior per ubsan in GCC 5.2.
> 
> Along the way, tweak the code to use reinterpret_cast rather than a C-style
> cast, and not to unnecessarily cast-away constness.
> 
> MESOS-3939.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 6709f5e7f6233983f389203278a0e42694591230 
> 
> Diff: https://reviews.apache.org/r/40435/diff/
> 
> 
> Testing
> ---
> 
> "make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
> error. With fix, ubsan does not report (this) error.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 18, 2015, 11:43 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Updated summary and description.


Summary (updated)
-

Introduced an Authenticator interface and an AuthenticationRouter in libprocess.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description (updated)
---

The Authenticator interface allows us to implement different
authenticators based on the scheme (e.g. Basic, Digest, SPNEGO).
The AuthenticationRouter manages the authentication realms and
the mapping from endpoints to realms. It is then used by the
ProcessManager to route requests to the authenticator for the
realm, if applicable.


Diffs
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/Makefile.am 
e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
28ce1928877084f0e1a73fdad789224c86e53f46 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authentication_router.hpp PRE-CREATION 
  3rdparty/libprocess/src/authentication_router.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp 7abdf21a5784920251c3627f9820c12fdc356c6e 
  3rdparty/libprocess/src/process_reference.hpp 
e6110bba2a54948be68e58ab9de988565b7d95a8 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 40244: Clarified comments in Master::Http::_operation.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40244/#review106992
---



src/master/http.cpp (line 2096)


This comment may not be related to this patch. I am just curious, for 
```required```, we have called ```flatten()``` to remove role from it when 
passing it into ```Master::Http::_operation()```. But here for 
```offer->resources()```, we do not call ```flatten()``` to remove its role, so 
is it subtractable between ```required``` and ```offer->resources()```?


- Qian Zhang


On Nov. 13, 2015, 8:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40244/
> ---
> 
> (Updated Nov. 13, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified comments in Master::Http::_operation.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 
> 
> Diff: https://reviews.apache.org/r/40244/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/#review106998
---


Patch looks great!

Reviews applied: [40431]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 8:19 a.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40431/
> ---
> 
> (Updated Nov. 18, 2015, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B and Qian Zhang.
> 
> 
> Bugs: MESOS-3944
> https://issues.apache.org/jira/browse/MESOS-3944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move RoleInfo message out of allocator.proto
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   include/mesos/master/allocator.proto 
> 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
>   include/mesos/role/role.hpp PRE-CREATION 
>   include/mesos/role/role.proto PRE-CREATION 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
>   src/master/allocator/mesos/hierarchical.cpp 
> f2e3b639f210eb06c70584ee7294609d9fd978ad 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
>   src/tests/hierarchical_allocator_tests.cpp 
> 740cfa801ee90417c038308192d1f4f2416f8315 
> 
> Diff: https://reviews.apache.org/r/40431/diff/
> 
> 
> Testing
> ---
> 
> 1. Make Check successfully;
> 
> 2. $ curl http://9.110.48.168:5050/roles
> {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review106993
---


Patch looks great!

Reviews applied: [40429]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 7:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Nov. 18, 2015, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 18, 2015, 10:15 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/Makefile.am 
e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
28ce1928877084f0e1a73fdad789224c86e53f46 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authentication_router.hpp PRE-CREATION 
  3rdparty/libprocess/src/authentication_router.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp 7abdf21a5784920251c3627f9820c12fdc356c6e 
  3rdparty/libprocess/src/process_reference.hpp 
e6110bba2a54948be68e58ab9de988565b7d95a8 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Review Request 40435: Fixed pointer alignment error in IP::create().

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/
---

Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.


Bugs: MESOS-3939
https://issues.apache.org/jira/browse/MESOS-3939


Repository: mesos


Description
---

The previous code took the address of a "struct sockaddr", and then cast the
resulting pointer to "struct sockaddr_storage *". The alignment requirements for
"struct sockaddr_storage *" are more strict than for "struct sockaddr *", and
hence this code produced undefined behavior per ubsan in GCC 5.2.

Along the way, tweak the code to use reinterpret_cast rather than a C-style
cast, and not to unnecessarily cast-away constness.

MESOS-3939.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
6709f5e7f6233983f389203278a0e42694591230 

Diff: https://reviews.apache.org/r/40435/diff/


Testing
---

"make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an 
error. With fix, ubsan does not report (this) error.


Thanks,

Neil Conway

Review Request 40431: Move RoleInfo message out of allocator.proto

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---

Review request for mesos, Adam B and Qian Zhang.


Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944


Repository: mesos


Description
---

Move RoleInfo message out of allocator.proto


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/role/role.hpp PRE-CREATION 
  include/mesos/role/role.proto PRE-CREATION 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
  src/tests/hierarchical_allocator_tests.cpp 
740cfa801ee90417c038308192d1f4f2416f8315 

Diff: https://reviews.apache.org/r/40431/diff/


Testing
---

1. Make Check successfully;

2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107001
---



src/slave/slave.cpp (lines 4419 - 4427)


Suggest to add some comments for these newly added code, e.g., why do we 
set type as USAGE_SLACK? This will help other devs better understand this 
feature.


- Qian Zhang


On Nov. 17, 2015, 4:41 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> ---
> 
> (Updated Nov. 17, 2015, 4:41 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK 
> for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps 
> to update `RevocableInfo::type` for Oversubscription.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> ---
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Review Request 40434: Fixed a problem when an HTTP response cannot be delivered and a promise was broken.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40434/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Fixed a problem when an HTTP response cannot be delivered and a promise was 
broken.


Diffs
-

  3rdparty/libprocess/include/process/event.hpp 
28ce1928877084f0e1a73fdad789224c86e53f46 

Diff: https://reviews.apache.org/r/40434/diff/


Testing
---


Thanks,

Alexander Rojas

Re: Review Request 40434: Fixed a problem when an HTTP response cannot be delivered and a promise was broken.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40434/#review107002
---

Ship it!


It would have been great to clarify in the description that this isn't relevant 
in the existing code, right? In particular, if someone calls `deliver` and no 
process is found, we will drop and delete the event. In the case of an 
HttpEvent, this would stall the pipeline forever. And also, in your subsequent 
patches, we will introduce the possibility of triggering this code when a 
process terminates while HTTP authentication is in process.

- Ben Mahler


On Nov. 18, 2015, 9:15 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40434/
> ---
> 
> (Updated Nov. 18, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a problem when an HTTP response cannot be delivered and a promise was 
> broken.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/event.hpp 
> 28ce1928877084f0e1a73fdad789224c86e53f46 
> 
> Diff: https://reviews.apache.org/r/40434/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39484/#review107028
---


I dont feel that we are really matching the intension of the ticket - even 
though it may be left unclear.

In any case, this user document is not a good place for documenting a single 
containerizer API function on a developer level.

Will try to find out what the original intension really was...

- Till Toenshoff


On Nov. 10, 2015, 7:17 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39484/
> ---
> 
> (Updated Nov. 10, 2015, 7:17 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3113
> https://issues.apache.org/jira/browse/MESOS-3113
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add resource usage section to MesosContainerizer and DockerContainerizer 
> documentation
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 
> 
> Diff: https://reviews.apache.org/r/39484/diff/
> 
> 
> Testing
> ---
> 
> Github gist
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Nov. 18, 2015, 3:51 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Summary (updated)
-

Introduced support for user interaction with HTTP AuthenticationRouter.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description (updated)
---

Adds functions which allow libprocess users to register HTTP authenticators.
Overloads `ProcesBase::route()` to allow for registering of authenticating 
endpoints.
Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp f1ae455b509c854869a056c5f59de537f5a4eb81 
  3rdparty/libprocess/src/tests/http_tests.cpp 
5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39892: Added ExternalResourceInfo to v1/mesos.proto.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39892/
---

(Updated Nov. 18, 2015, 2:58 p.m.)


Review request for mesos and Joerg Schad.


Bugs: MESOS-3857
https://issues.apache.org/jira/browse/MESOS-3857


Repository: mesos


Description
---

Added ExternalResourceInfo to v1/mesos.proto.


Diffs (updated)
-

  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/39892/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 37999: Introduced an Authenticator interface and an AuthenticationRouter in libprocess.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/#review107003
---

Ship it!


Was great sitting down and going over all of this stuff with you over the past 
week, thanks for the patience! Just some final adjustments that we discussed 
based on pulling this down and getting ready to commit.


3rdparty/libprocess/include/process/authenticator.hpp (line 52)


Let's maybe say here that this allows us to implement different 
authenticators based on the scheme and include the examples below (Basic, 
Digest, SPNEGO, etc).



3rdparty/libprocess/include/process/authenticator.hpp (line 65)


Whoops, stale now that you have the namespace.



3rdparty/libprocess/include/process/http.hpp (lines 545 - 552)


As we discussed, should we have a TODO to remove these?



3rdparty/libprocess/src/authentication_router.hpp (lines 35 - 37)


A little bit stale now that we called this router instead of realm manager, 
right?



3rdparty/libprocess/src/authentication_router.hpp (line 48)


How about unset for symettry? I see why you called this 'set' and 'unset' 
and that does describe the single authenticator per-realm constraint. Thinking 
over this again though, let's also add a small comment to describe this 
constraint.



3rdparty/libprocess/src/authentication_router.hpp (line 57)


Whoops, "either" here is orphaned.



3rdparty/libprocess/src/authentication_router.hpp (line 69)


Whoops, stale comment.



3rdparty/libprocess/src/authentication_router.cpp (line 96)


Hm.. perhaps we also need something here to mention that we're assuming 
absolute paths, which is ensured by libprocess. Should consider maybe returning 
a failure here when a relative path is detected.



3rdparty/libprocess/src/authentication_router.cpp (line 107)


Whoops, should have a space before the brace here.



3rdparty/libprocess/src/authentication_router.cpp (line 111)


Perhaps we should handle the "error" logging case first, as that tends to 
be how we structure the code and we can avoid an else more clearly



3rdparty/libprocess/src/authentication_router.cpp (lines 114 - 116)


How about we validate that the Result is valid before we send it up to 
libprocess? We can CHECK validity in libprocess since we control the code here, 
and avoid having to do validity checking (which we weren't really doing 
currently).



3rdparty/libprocess/src/authentication_router.cpp (line 136)


Why the 'if' here? 'process' should not be null here, unless there is a 
bug. We could add a check but for now I'll just remove the 'if' guard to be 
consistent with the rest of the process wrapper code FWICT.



3rdparty/libprocess/src/process.cpp (line 60)


What was this for? The result? Hm.. should be ok in this case to just 
include the router since we are only using signatures from the router.



3rdparty/libprocess/src/process.cpp (line 109)


Alphabetical?



3rdparty/libprocess/src/process.cpp (line 128)


We should consider just making this authentication::Router, but I'll leave 
it for now.



3rdparty/libprocess/src/process.cpp (line 953)


Even though there whould probably be just one comment above all these 
saying we're creating the globals, let's add another comment here to be 
consistent with the current code:

```
// Create the global HTTP authentication router.
authentication_router = new AuthenticationRouter();
```



3rdparty/libprocess/src/process_reference.hpp (line 52)


This should be in a separate patch, much like we did for the promise 
setting bug we noticed.


- Ben Mahler


On Nov. 18, 2015, 10:43 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37999/
> ---
> 
> (Updated Nov. 18, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin 

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107092
---



docs/persistent-volume.md (line 235)


Should we update this line to specify the latest version, since this 
feature hasn't come yet?


- Greg Mann


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40371/
---

(Updated Nov. 19, 2015, 12:39 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

review addressed.


Repository: mesos


Description
---

Since docker_image option could be used for mesos and docker containerizer,
introduced a  new option 'containerizer' to disambiguate the two containerizers.

New usage:
mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
--name=test_docker --docker_image=ubuntu --containerizer=DOCKER

mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
--name=test_mesos --docker_image=ubuntu --containerizer=MESOS


Diffs (updated)
-

  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 

Diff: https://reviews.apache.org/r/40371/diff/


Testing
---

tested the two containerizer locally with simple commands.


Thanks,

Jojy Varghese

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40459/#review107119
---



docs/configuration.md (lines 37 - 54)


I think that the master/main.cpp should also be updated for those flages.


- Guangya Liu


On 十一月 19, 2015, 12:58 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40459/
> ---
> 
> (Updated 十一月 19, 2015, 12:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Timothy Chen.
> 
> 
> Bugs: MESOS-3809
> https://issues.apache.org/jira/browse/MESOS-3809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If set, these IP/Port shall be advertised by libprocess (although bind is not 
> done on this IP/Port). If not set, libprocess advertises the IP/Port on which 
> bind was done.
> 
> Command line arguments added:
> advertise_ip: IP address advertised to reach mesos slave.
> advertise_port: Port advertised to reach mesos slave (used with advertise_ip).
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0 
>   src/slave/main.cpp 746eec684a0c9119f85506022676d276f808b6ea 
> 
> Diff: https://reviews.apache.org/r/40459/diff/
> 
> 
> Testing
> ---
> 
> make check run successfully.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 40246: Removed unused "using" statement from test code.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review107120
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 18, 2015, 11:27 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated 十一月 18, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40340/#review107112
---


Good stuff!
Sorry for the delay in reviewing this: only got halfway through - will finish 
it off on the train.


support/cpplint.py (line 4734)


function names should be `lower_case` according to 
[PEP8](https://www.python.org/dev/peps/pep-0008/#function-names)



support/cpplint.py (lines 4741 - 4745)


can we use a format that Python automated doc tools will understand?

`@param` / `@type` / `@return`

or the `:param` equivalent.



support/cpplint.py (line 4763)


not your code, admittedly, but it would be awesome to drag our Python 
scripts into the 21st century and use `argparse` instead :)



support/cpplint.py (line 4766)


this does not make any sense at all, IMO
(do we really have a wrapper script that checks `$?` and echoes the number 
of errors?)



support/mesos-style.py (line 11)


I am not familiar with `cStringIO` - the name would seem to indicate (a) 
it's not a standard library and (b) that it requires some amount of C 
compilation.

This is usually a pain "on some OS" (eg, OSX) - can you please confirm 
whether it's in the standard libraries and, if not, what are the steps involved 
in getting it installed on various OSes?

This may break building/committing everywhere, right?



support/mesos-style.py (line 63)


I have a suspicion it's just *one* OS that does not support this, but lets' 
not be picky here :)



support/mesos-style.py (lines 71 - 76)


same comment as before



support/mesos-style.py (line 97)


unnecessary parentheses


- Marco Massenzio


On Nov. 16, 2015, 9:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40340/
> ---
> 
> (Updated Nov. 16, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, Joseph Wu, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Windows support to `support/post-reviews.py`.
> 
> Early draft of the update to the Windows-compatible `post-reviews.py`. I'd 
> like to get early feedback from people in case this is entirely the wrong 
> direction.
> 
> At the outset, I will say that the "right way" to do this would be to 
> refactor `cppylint.py` and `post-reviews.py` entirely so that they are more 
> modular (for example, make `post-reviews.py` function-oriented, instead of a 
> pile of statements and expressions, and `cpplint.py` should be a module 
> proper). I didn't do this the "right way" because it is blocking for our 
> Windows friends. If it's really important to do this the "right way", we may 
> need to break it into a couple reviews.
> 
> Note that the most questionable part of this is the point at which we 
> redirect `stderr` in `cpplint.py` to a string capture it for use in 
> `post-reviews.py`. This is certainly the quickest way to do it, but it is not 
> the best -- the best way would be to refactor `cpplint.py` to be a module, at 
> least, and to handle error logging in a more pluggable way. We aimed for the 
> shortest diff because there are no tests for any of these scripts, and to be 
> honest, I was afraid of changing them without tests.
> 
> 
> Diffs
> -
> 
>   .gitignore-template 90b6697d19a5e0a68805b23b587b362731a1df25 
>   support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/40340/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39780/
---

(Updated Nov. 19, 2015, 12:47 a.m.)


Review request for mesos.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Update OversubscriptionTest to not assume dynamic dlopen search.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp 0d0bf7e0b9a4028ed116e00b56d59b670510c5ce 

Diff: https://reviews.apache.org/r/39780/diff/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/
---

(Updated Nov. 19, 2015, 12:48 a.m.)


Review request for mesos.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Update ModuleTest to not assume dynamic dlopen search.


Diffs (updated)
-

  src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e 

Diff: https://reviews.apache.org/r/39781/diff/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107117
---



docs/reservation.md (line 242)


This will not work if end user did not enable autheration, a JIRA ticket is 
tracing this MESOS-3940, shall we highlight the issue here before get resolved?


- Guangya Liu


On 十一月 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> ---
> 
> (Updated 十一月 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40340/#review107116
---



support/mesos-style.py (line 104)


unnecessary parentheses



support/mesos-style.py (lines 105 - 106)


Mesos-style indenting doesn't apply (I think) here:
```
errors_found, captured_stderr = lint_and_capture_stderr(
rules_filter, source_paths)
```



support/mesos-style.py (line 112)


not your code, but could you please remove the unnecessary `is not None`



support/mesos-style.py (line 113)


what was wrong with: `print(line)`
(and please be a good man, if it's not already there, can you please add 
-at the very top of this file-):
```
from __future__ import print_function
```
so this works with both 2.7 and 3.x?



support/mesos-style.py (line 134)


+10
thanks!



support/post-reviews.py (line 71)


missing "user"
also note that epydoc support markdown; I would enumerate the various 
options as a bulleted list.

```
can respond with:

  - foo
  - bar
  - ...
```



support/post-reviews.py (lines 71 - 73)


is the user input case-insensitive? if not, worth mentioning



support/post-reviews.py (lines 81 - 91)


+1
this is awesome - I wish all our methods were documented in this depth!



support/post-reviews.py (line 106)


```
while not choice in ['y', 'n', ctrl_d]:
```


- Marco Massenzio


On Nov. 16, 2015, 9:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40340/
> ---
> 
> (Updated Nov. 16, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, Joseph Wu, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Windows support to `support/post-reviews.py`.
> 
> Early draft of the update to the Windows-compatible `post-reviews.py`. I'd 
> like to get early feedback from people in case this is entirely the wrong 
> direction.
> 
> At the outset, I will say that the "right way" to do this would be to 
> refactor `cppylint.py` and `post-reviews.py` entirely so that they are more 
> modular (for example, make `post-reviews.py` function-oriented, instead of a 
> pile of statements and expressions, and `cpplint.py` should be a module 
> proper). I didn't do this the "right way" because it is blocking for our 
> Windows friends. If it's really important to do this the "right way", we may 
> need to break it into a couple reviews.
> 
> Note that the most questionable part of this is the point at which we 
> redirect `stderr` in `cpplint.py` to a string capture it for use in 
> `post-reviews.py`. This is certainly the quickest way to do it, but it is not 
> the best -- the best way would be to refactor `cpplint.py` to be a module, at 
> least, and to handle error logging in a more pluggable way. We aimed for the 
> shortest diff because there are no tests for any of these scripts, and to be 
> honest, I was afraid of changing them without tests.
> 
> 
> Diffs
> -
> 
>   .gitignore-template 90b6697d19a5e0a68805b23b587b362731a1df25 
>   support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/40340/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
---

(Updated Nov. 19, 2015, 12:48 a.m.)


Review request for mesos.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Add a comment for os::libraries::setPaths.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 

Diff: https://reviews.apache.org/r/39782/diff/


Testing
---

No code changes.


Thanks,

James Peach

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

[Guangya Liu]

> On 十一月 17, 2015, 3:12 a.m., Guangya Liu wrote:
> > src/cli/execute.cpp, lines 216-228
> > 
> >
> > Can you please explain more why using mesos containerizer can also run 
> > a docker container? Thanks!
> 
> Jojy Varghese wrote:
> The '''Image::DOCKER''' in this context is image type and not container 
> type. Image type could be '''docker''' or '''appc'''.

Thanks Jojy, but what is the difference of those two command?

mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
--name=test_docker --docker_image=ubuntu --containerizer=DOCKER
The above command will make the task running in docker containers.

mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
--name=test_mesos --docker_image=ubuntu --containerizer=MESOS
What does this one?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40371/#review106789
---


On 十一月 19, 2015, 12:39 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40371/
> ---
> 
> (Updated 十一月 19, 2015, 12:39 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since docker_image option could be used for mesos and docker containerizer,
> introduced a  new option 'containerizer' to disambiguate the two 
> containerizers.
> 
> New usage:
> mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
> --name=test_docker --docker_image=ubuntu --containerizer=DOCKER
> 
> mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
> --name=test_mesos --docker_image=ubuntu --containerizer=MESOS
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
> 
> Diff: https://reviews.apache.org/r/40371/diff/
> 
> 
> Testing
> ---
> 
> tested the two containerizer locally with simple commands.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38234: Check if swap is enabled before running memory pressure related tests.

[Chi Zhang]

> On Nov. 17, 2015, 7:27 p.m., Vinod Kone wrote:
> > src/tests/containerizer/cgroups_tests.cpp, lines 560-568
> > 
> >
> > instead of asserting, it would be better if we can disable the test 
> > automatically if we detect that swap is enabled.
> > 
> > for example, we can change the test name to ROOT_CGROUPS_OOM_Listen
> > 
> > and in environment.cpp, disable the test if 'OOM' token is present in 
> > the test name and swap is enabled.
> > 
> > 
> > also, does the swap issue not affect the balloon framewok test?

Yeah, I wanted to do that to disable other tests dymaically before and final 
result was just to use this style, so I did the same to be consistent.

re-read the code again for balloon frame tests: slave has 96MB memory, executor 
uses 64MB, 32 left to the task, balloon() allocates 64MB at a time, which 
basically means first allocation request will cause OOM (64 > 32).

If the step was set to say do 3 times 16MBs, (3x16 > 32), the extra 16MB will 
be eaten by swap and not cause a OOM if swap is enabled.


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38234/#review106919
---


On Sept. 9, 2015, 9:33 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38234/
> ---
> 
> (Updated Sept. 9, 2015, 9:33 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
> https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check if swap is enabled before running memory pressure related tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 75a3bc0009c037dc18ce319db2eb44630f083e8c 
> 
> Diff: https://reviews.apache.org/r/38234/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 40305: Added URI fetcher interface.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40305/
---

(Updated Nov. 18, 2015, 11:25 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-3922
https://issues.apache.org/jira/browse/MESOS-3922


Repository: mesos


Description
---

Added URI fetcher interface.


Diffs
-

  include/mesos/uri/fetcher.hpp PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/uri/fetcher.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40305/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40403: Added streaming and construction methods for URI.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40403/
---

(Updated Nov. 18, 2015, 11:25 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-3924
https://issues.apache.org/jira/browse/MESOS-3924


Repository: mesos


Description
---

Added streaming and construction methods for URI.


Diffs
-

  include/mesos/uri/uri.hpp PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/uri_tests.cpp PRE-CREATION 
  src/uri/schemes/file.hpp PRE-CREATION 
  src/uri/schemes/http.hpp PRE-CREATION 
  src/uri/utils.hpp PRE-CREATION 
  src/uri/utils.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40403/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40418: Added curl based URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40418/
---

(Updated Nov. 18, 2015, 11:25 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-3924
https://issues.apache.org/jira/browse/MESOS-3924


Repository: mesos


Description
---

Added curl based URI fetcher plugin.


Diffs
-

  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/uri_fetcher_tests.cpp PRE-CREATION 
  src/uri/fetcher.cpp PRE-CREATION 
  src/uri/fetchers/curl.hpp PRE-CREATION 
  src/uri/fetchers/curl.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40418/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40371/#review107104
---



src/cli/execute.cpp (line 237)


As suggested below, driver->abort() here and print the unsupported 
containerizer.

The advantage is that we only have one place to add or remove 
containerizers.



src/cli/execute.cpp (line 418)


IMO it's simpler to just have one place to check this that's happening in 
the CommandScheduler code, as you already have a check for mesos or docker.

I think it's not necessary to add checks in both places, because then it's 
not clear when someone else comes and add another containerizer support, that 
why they need to add here in line 417 but also in the resourceOffer callback.

How about just pass the flag in without any checks here, and in the 
CommandScheduler you can detect a unsupported containerizer and abort the 
driver.


- Timothy Chen


On Nov. 17, 2015, 3:01 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40371/
> ---
> 
> (Updated Nov. 17, 2015, 3:01 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since docker_image option could be used for mesos and docker containerizer,
> introduced a  new option 'containerizer' to disambiguate the two 
> containerizers.
> 
> New usage:
> mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
> --name=test_docker --docker_image=ubuntu --containerizer=DOCKER
> 
> mesos-execute --master=127.0.0.1:5050 --command="uname -a" \
> --name=test_mesos --docker_image=ubuntu --containerizer=MESOS
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
> 
> Diff: https://reviews.apache.org/r/40371/diff/
> 
> 
> Testing
> ---
> 
> tested the two containerizer locally with simple commands.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40268/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3820
https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description
---

This is only needed for tests that utilize the test-only 
`process::reinitialize` function.

Note: This is part of a review chain draft, so ignore any links in "Depends On" 
or "Blocks".  This commit revealed some incomplete cleanup in tests, which is 
fixed here:
https://reviews.apache.org/r/40453/


Diffs
-

  3rdparty/libprocess/include/process/socket.hpp 
ebee78909feb5a4032da68f51d08dbf11b03b332 
  3rdparty/libprocess/src/socket.cpp 6ac834e7459f5958b7c788ccdc60cbed90530183 

Diff: https://reviews.apache.org/r/40268/diff/


Testing
---


Thanks,

Joseph Wu

Review Request 40453: Add a TearDownTestCase method for cleaning up after tests that reinitialize SSL configuration.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40453/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

Tests that reinitiailize SSL configuration only change environment variables 
upon setup.  This means the changed environment will stay intact after the 
test.  This may lead to unexpected results in subsequent tests.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
54885ec359df947f6d31375d4c2a32cae587f845 

Diff: https://reviews.apache.org/r/40453/diff/


Testing
---

See next review.


Thanks,

Joseph Wu

Review Request 40454: Add calls to parent teardown methods in child teardown methods.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/
---

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/containerizer/provisioner_docker_tests.cpp 
edfbb6fe932173dcbb15133e0eb685d86dd09c00 
  src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9 
  src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e 

Diff: https://reviews.apache.org/r/40454/diff/


Testing
---

Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after 
SSL-reinitializing tests.

Then:
`make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`

The `RegistryClientTest` involve some reinitialization of SSL variables.  The 
`ExecutorHttpApiTest` spawns sockets.  If the SSL variables are not cleaned up, 
the second test will try to use SSL sockets against non-SSL endpoints.


Thanks,

Joseph Wu

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review107098
---

Ship it!


Ship It!

- Greg Mann


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40246: Removed unused "using" statement from test code.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review107099
---

Ship it!


Ship It!

- Greg Mann


On Nov. 18, 2015, 11:27 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated Nov. 18, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40285: Changed untar process to pipe STDERR.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review107106
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 17, 2015, 6:57 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
> 
> (Updated Nov. 17, 2015, 6:57 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> ---
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40253: Added URI protobuf definition.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
---

(Updated Nov. 18, 2015, 11:26 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-3921
https://issues.apache.org/jira/browse/MESOS-3921


Repository: mesos


Description
---

Added URI protobuf definition.


Diffs
-

  include/mesos/uri/uri.hpp PRE-CREATION 
  include/mesos/uri/uri.proto PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40418: Added curl based URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40418/
---

(Updated Nov. 18, 2015, 11:10 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Fixed the compile issue.


Repository: mesos


Description
---

Added curl based URI fetcher plugin.


Diffs (updated)
-

  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/tests/uri_fetcher_tests.cpp PRE-CREATION 
  src/uri/fetcher.cpp PRE-CREATION 
  src/uri/fetchers/curl.hpp PRE-CREATION 
  src/uri/fetchers/curl.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40418/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 40463: Moved HDFS wrapper implementation to a cpp file.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40463/
---

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
---

Moved HDFS wrapper implementation to a cpp file.


Diffs
-

  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
  src/hdfs/hdfs.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40463/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 40461: Changed HDFS wrapper from a struct to a class.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40461/
---

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
---

Changed HDFS wrapper from a struct to a class.


Diffs
-

  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 

Diff: https://reviews.apache.org/r/40461/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 40462: Fixed the license header in hdfs.hpp.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40462/
---

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
---

Fixed the license header in hdfs.hpp.


Diffs
-

  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 

Diff: https://reviews.apache.org/r/40462/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 40429: Report executor exit to framework schedulers.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107122
---



src/sched/sched.cpp (line 1072)


I think that we also need to check master.isNone() here.

if (master.isNone() || from != master.get().pid()) {



src/sched/sched.cpp (line 1073)


s/VLOG(1)/LOG(WARNING)



src/sched/sched.cpp (lines 1079 - 1081)


Just a question, does their are any guidelines for when to use VLOG(1), 
VLOG(2) etc? Thanks!


- Guangya Liu


On 十一月 18, 2015, 9:50 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated 十一月 18, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107101
---


Patch looks great!

Reviews applied: [40429]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 9:50 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Nov. 18, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107121
---



docs/persistent-volume.md (line 258)


I think that the http endpoint should also works without autherization, for 
such case, the principal and password are not needed.



docs/persistent-volume.md (line 296)


ditto


- Guangya Liu


On 十一月 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Zhitao Li]

> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, line 1073
> > 
> >
> > s/VLOG(1)/LOG(WARNING)

The logging level here is consistent with lostSlave above:
```

if (from != master.get().pid()) {
  VLOG(1) << "Ignoring lost slave message because it was sent "
  << "from '" << from << "' instead of the leading master '"
  << master.get().pid() << "'";
  return;
}
```


> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, lines 1079-1081
> > 
> >
> > Just a question, does their are any guidelines for when to use VLOG(1), 
> > VLOG(2) etc? Thanks!

Probably someone could document the convention in some getting started document?


> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, line 1072
> > 
> >
> > I think that we also need to check master.isNone() here.
> > 
> > if (master.isNone() || from != master.get().pid()) {

The `CHECK_SOME(master)` above should already ensures that master is not None. 
This is also consistent with `lostSlave()`


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107122
---


On Nov. 18, 2015, 9:50 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Nov. 18, 2015, 9:50 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
>   src/tests/scheduler_event_call_tests.cpp 
> 39f67a8243db8073d1c9c92c7aeb71854143131d 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 40459: Added 2 slave flags --advertise_ip and --advertise_port.

[Guangya Liu]

> On 十一月 19, 2015, 2:57 a.m., Guangya Liu wrote:
> > docs/configuration.md, lines 37-54
> > 
> >
> > I think that the master/main.cpp should also be updated for those 
> > flages.
> 
> Anindya Sinha wrote:
> It is already there added as a part of MESOS-809. Refer 
> https://github.com/apache/mesos/blob/master/src/master/main.cpp#L131 and 
> https://github.com/apache/mesos/blob/master/src/master/main.cpp#L138.

I mean this part should also be updated to use the latest description as here 
you have updated "mesos master" to "mesos master/slave"


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40459/#review107119
---


On 十一月 19, 2015, 12:58 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40459/
> ---
> 
> (Updated 十一月 19, 2015, 12:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Timothy Chen.
> 
> 
> Bugs: MESOS-3809
> https://issues.apache.org/jira/browse/MESOS-3809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If set, these IP/Port shall be advertised by libprocess (although bind is not 
> done on this IP/Port). If not set, libprocess advertises the IP/Port on which 
> bind was done.
> 
> Command line arguments added:
> advertise_ip: IP address advertised to reach mesos slave.
> advertise_port: Port advertised to reach mesos slave (used with advertise_ip).
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0 
>   src/slave/main.cpp 746eec684a0c9119f85506022676d276f808b6ea 
> 
> Diff: https://reviews.apache.org/r/40459/diff/
> 
> 
> Testing
> ---
> 
> make check run successfully.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---

(Updated Nov. 19, 2015, 6:46 a.m.)


Review request for mesos, Adam B and Qian Zhang.


Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944


Repository: mesos


Description
---

Move RoleInfo message out of allocator.proto


Diffs (updated)
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/role/role.hpp PRE-CREATION 
  include/mesos/role/role.proto PRE-CREATION 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
  src/tests/hierarchical_allocator_tests.cpp 
740cfa801ee90417c038308192d1f4f2416f8315 

Diff: https://reviews.apache.org/r/40431/diff/


Testing
---

1. Make Check successfully;

2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}


Thanks,

Yong Qiao Wang

Review Request 40469: Update Allocator interface to support dynamic roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

Review request for mesos.


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 

Diff: https://reviews.apache.org/r/40469/diff/


Testing
---


Thanks,

Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/
---

(Updated Nov. 19, 2015, 6:48 a.m.)


Review request for mesos, Adam B and Qian Zhang.


Bugs: MESOS-3956
https://issues.apache.org/jira/browse/MESOS-3956


Repository: mesos


Description
---

Update Allocator interface to support dynamic roles


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 
  src/master/allocator/mesos/hierarchical.cpp 
f2e3b639f210eb06c70584ee7294609d9fd978ad 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 

Diff: https://reviews.apache.org/r/40469/diff/


Testing (updated)
---

Make check successfully.


Thanks,

Yong Qiao Wang

Re: Review Request 40429: Report executor exit to framework schedulers.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/
---

(Updated Nov. 18, 2015, 9:50 p.m.)


Review request for mesos, Adam B and Vinod Kone.


Changes
---

Whitesplace line fixes.


Bugs: MESOS-313
https://issues.apache.org/jira/browse/MESOS-313


Repository: mesos


Description
---

Report executor exit to framework schedulers. This is a MVP to start the work 
of notifying scheduler on scheduler refresh.

Next step would be sending this message reliabily, and/or splitting 
Event::FAILURE for slave failure and executor termination.


Diffs (updated)
-

  src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 
  src/tests/scheduler_event_call_tests.cpp 
39f67a8243db8073d1c9c92c7aeb71854143131d 

Diff: https://reviews.apache.org/r/40429/diff/


Testing
---

Modified test for SchedulerDriverEventTest.Failure, which verifies that 
MockScheduler::executorLost is invoked.


Thanks,

Zhitao Li

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/
---

(Updated Nov. 18, 2015, 9:56 p.m.)


Review request for mesos, Kapil Arya and Vinod Kone.


Bugs: MESOS-3834
https://issues.apache.org/jira/browse/MESOS-3834


Repository: mesos


Description
---

When performing an upgrade cycle, it is possible for a 0.24 and
later agent to recover from a framework checkpoint written by 0.22
or earlier. In this case, we need to compatibly accept a missing
FrameworkID, and then rewrite the framework checkpoint so that
subsequent upgrades don't hit the same problem.


Diffs (updated)
-

  src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
  src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 

Diff: https://reviews.apache.org/r/40177/diff/


Testing
---

make check on CentOS 6.7.
Manual testing with a rolling upgrade from 0.22


Thanks,

James Peach

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40177/#review107087
---


Patch looks great!

Reviews applied: [40177]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 6:49 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40177/
> ---
> 
> (Updated Nov. 18, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Vinod Kone.
> 
> 
> Bugs: MESOS-3834
> https://issues.apache.org/jira/browse/MESOS-3834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When performing an upgrade cycle, it is possible for a 0.24 and
> later agent to recover from a framework checkpoint written by 0.22
> or earlier. In this case, we need to compatibly accept a missing
> FrameworkID, and then rewrite the framework checkpoint so that
> subsequent upgrades don't hit the same problem.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40177/diff/
> 
> 
> Testing
> ---
> 
> make check on CentOS 6.7.
> Manual testing with a rolling upgrade from 0.22
> 
> 
> Thanks,
> 
> James Peach
> 
>