Review Request 41920: Aligned the format of log for recoverResources().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41920/
---

Review request for mesos and Adam B.


Repository: mesos


Description
---

Aligned the format of log for recoverResources().


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 

Diff: https://reviews.apache.org/r/41920/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 35711: Disallow special characters in role name.

[Guangya Liu]

> On 一月 5, 2016, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/roles.hpp, lines 29-49
> > 
> >
> > It is better use /**/ for comments in a header file.
> 
> haosdent huang wrote:
> According resources.hpp, seems it is OK here. 
> https://github.com/apache/mesos/blob/master/include/mesos/resources.hpp#L166
> 
> Guangya Liu wrote:
> The final goal should be /**/, please refer to 
> https://github.com/apache/mesos/blob/master/docs/doxygen-style-guide.md for 
> detail
> 
> haosdent huang wrote:
> Thank you very much. Already updated, could you help review again?

Thanks for the update ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112771
---


On 一月 5, 2016, 6:58 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated 一月 5, 2016, 6:58 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112789
---


Patch looks great!

Reviews applied: [40429]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 1:14 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Jan. 5, 2016, 1:14 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 
> 4f048830a2c47f747033c60730cc770cb2578815 
>   src/python/interface/src/mesos/interface/__init__.py 
> 4be502fd83029ad5fc798696caf9e27fd95f7482 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 9afa826006fa7129da1a9c1ac8c389c0e051f717 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 
> 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Jan. 5, 2016, 7:24 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Update the code diff due to the UpdateWeight() interface changes.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
f61613948b7b5c5c2118f1782a0c5f8ff7e8e057 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 5, 2016, 7:23 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

> On Jan. 5, 2016, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/roles.hpp, lines 29-49
> > 
> >
> > It is better use /**/ for comments in a header file.
> 
> haosdent huang wrote:
> According resources.hpp, seems it is OK here. 
> https://github.com/apache/mesos/blob/master/include/mesos/resources.hpp#L166
> 
> Guangya Liu wrote:
> The final goal should be /**/, please refer to 
> https://github.com/apache/mesos/blob/master/docs/doxygen-style-guide.md for 
> detail

Thank you very much. Already updated, could you help review again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112771
---


On Jan. 5, 2016, 6:58 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated Jan. 5, 2016, 6:58 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---

(Updated Jan. 5, 2016, 6:58 a.m.)


Review request for mesos, Adam B, Jie Yu, and Michael Park.


Changes
---

Update comments style


Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210


Repository: mesos


Description
---

Disallow special characters in role name.


Diffs (updated)
-

  docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
  include/mesos/roles.hpp PRE-CREATION 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/common/roles.cpp PRE-CREATION 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
  src/tests/roles_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35711/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

[Guangya Liu]

> On 一月 5, 2016, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/roles.hpp, lines 29-49
> > 
> >
> > It is better use /**/ for comments in a header file.
> 
> haosdent huang wrote:
> According resources.hpp, seems it is OK here. 
> https://github.com/apache/mesos/blob/master/include/mesos/resources.hpp#L166

The final goal should be /**/, please refer to 
https://github.com/apache/mesos/blob/master/docs/doxygen-style-guide.md for 
detail


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112771
---


On 一月 5, 2016, 2:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated 一月 5, 2016, 2:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

> On Jan. 5, 2016, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/roles.hpp, lines 29-49
> > 
> >
> > It is better use /**/ for comments in a header file.

According resources.hpp, seems it is OK here. 
https://github.com/apache/mesos/blob/master/include/mesos/resources.hpp#L166


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112771
---


On Jan. 5, 2016, 2:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated Jan. 5, 2016, 2:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 6:43 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Tweak "typical" # of instances.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

> On Jan. 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, line 81
> > 
> >
> > Can you please also identify "odd number" here, such as "three or five 
> > instances is typical but should be a odd number"
> 
> Neil Conway wrote:
> Is an odd number of scheduler instances actually required? Offhand, I 
> don't see why, as long as you can reliably elect a leader -- e.g., if you 
> have Zk configured on 3/5 nodes, it seems to me you could use, say, 2, 4, or 
> 6 scheduler instances.
> 
> Guangya Liu wrote:
> I mistake this as Zk cofniguration. So can you please add some comments 
> here for why "three or five instances is typical"?

I'll just say "three instances is typical" -- typical tradeoff between resource 
utilization and fault tolerance. I don't think we need to go into more detail, 
but there's value in giving people a typical # of replicas.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On Jan. 5, 2016, 3:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated Jan. 5, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

> On Jan. 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, lines 117-118
> > 
> >
> > What will be the final state of this task? Does the framework need to 
> > re-launch this task again even though this task might already been finished 
> > in agent. Can you please add some best practise for this case?
> 
> Neil Conway wrote:
> I'm not sure what else we can say here: the best practice we're 
> recommending is to avoid this situation entirely by ensuring that when a new 
> framework leader is elected, it knows about (a superset of) all the tasks the 
> previous leader might have launched.
> 
> Guangya Liu wrote:
> Can we clarify that the framework may need to re-launch task for such 
> case?

Well, if the framework instance doesn't know about the task (because it hasn't 
persisted state correctly before failing over), it isn't clear what they should 
do in general -- maybe kill the unknown task, maybe let it run and page an 
admin. This is why we don't recommend that this situation be allowed in the 
first place :)


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On Jan. 5, 2016, 3:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated Jan. 5, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Guangya Liu]

> On 一月 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, line 81
> > 
> >
> > Can you please also identify "odd number" here, such as "three or five 
> > instances is typical but should be a odd number"
> 
> Neil Conway wrote:
> Is an odd number of scheduler instances actually required? Offhand, I 
> don't see why, as long as you can reliably elect a leader -- e.g., if you 
> have Zk configured on 3/5 nodes, it seems to me you could use, say, 2, 4, or 
> 6 scheduler instances.

I mistake this as Zk cofniguration. So can you please add some comments here 
for why "three or five instances is typical"?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On 一月 5, 2016, 3:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated 一月 5, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/#review112778
---


Bad patch!

Reviews applied: [41002, 41003, 41004, 41061, 4, 41166, 41167, 41169, 
41560, 41294, 41370, 41378, 41779]

Failed command: ./support/apply-review.sh -n -r 41779

Error:
 2016-01-05 06:30:37 URL:https://reviews.apache.org/r/41779/diff/raw/ 
[3222/3222] -> "41779.patch" [1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must not exceed 72 characters.

- Mesos ReviewBot


On Jan. 5, 2016, 2:21 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41783/
> ---
> 
> (Updated Jan. 5, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a non-default ContainerLogger that constrains total log size by rotating 
> logs (i.e. renaming the head log file).
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/rotate.hpp PRE-CREATION 
>   src/slave/container_loggers/rotate.cpp PRE-CREATION 
>   src/slave/container_loggers/rotating.hpp PRE-CREATION 
>   src/slave/container_loggers/rotating.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41783/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

(Updated Jan. 5, 2016, 6:28 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Based on MPark's review comments. Left the decision whether or not to make the 
copy upon the user and not the library similar to what Boost `Optional` does.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

> On Jan. 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, line 81
> > 
> >
> > Can you please also identify "odd number" here, such as "three or five 
> > instances is typical but should be a odd number"

Is an odd number of scheduler instances actually required? Offhand, I don't see 
why, as long as you can reliably elect a leader -- e.g., if you have Zk 
configured on 3/5 nodes, it seems to me you could use, say, 2, 4, or 6 
scheduler instances.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On Jan. 5, 2016, 3:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated Jan. 5, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Guangya Liu]

> On 一月 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, lines 117-118
> > 
> >
> > What will be the final state of this task? Does the framework need to 
> > re-launch this task again even though this task might already been finished 
> > in agent. Can you please add some best practise for this case?
> 
> Neil Conway wrote:
> I'm not sure what else we can say here: the best practice we're 
> recommending is to avoid this situation entirely by ensuring that when a new 
> framework leader is elected, it knows about (a superset of) all the tasks the 
> previous leader might have launched.

Can we clarify that the framework may need to re-launch task for such case?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On 一月 5, 2016, 3:14 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated 一月 5, 2016, 3:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/#review112774
---


Patch looks great!

Reviews applied: [41862]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 2:11 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41862/
> ---
> 
> (Updated Jan. 5, 2016, 2:11 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4268
> https://issues.apache.org/jira/browse/MESOS-4268
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix containerizer-internals Posix launcher TBD.
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c 
> 
> Diff: https://reviews.apache.org/r/41862/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 35711: Disallow special characters in role name.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review112771
---



include/mesos/roles.hpp (lines 29 - 49)


It is better use /**/ for comments in a header file.


- Guangya Liu


On 一月 5, 2016, 2:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35711/
> ---
> 
> (Updated 一月 5, 2016, 2:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2210
> https://issues.apache.org/jira/browse/MESOS-2210
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disallow special characters in role name.
> 
> 
> Diffs
> -
> 
>   docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
>   include/mesos/roles.hpp PRE-CREATION 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/common/roles.cpp PRE-CREATION 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/tests/roles_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35711/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112772
---

Ship it!


Ship It!

- Jie Yu


On Jan. 5, 2016, 5:09 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> ---
> 
> (Updated Jan. 5, 2016, 5:09 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor 
> info, so this check should handle both command tasks and custom executors.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 
> 
> Diff: https://reviews.apache.org/r/41909/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41672: Test case(s) for weights + allocation behavior

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41672/
---

(Updated Jan. 5, 2016, 5:46 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Update this patch due to the UpdateWeight() interface change.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Test case(s) for weights + allocation behavior


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
e044f832c2c16e53e663c6ced5452649bb0dcb59 

Diff: https://reviews.apache.org/r/41672/diff/


Testing
---

Make check done:
Yongs-MacBook-Pro:build yqwyq$ ./src/mesos-tests 
--gtest_filter=HierarchicalAllocatorTest.UpdateWeight
Source directory: /Users/yqwyq/Desktop/mesos
Build directory: /Users/yqwyq/Desktop/mesos/build
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from HierarchicalAllocatorTest
[ RUN  ] HierarchicalAllocatorTest.UpdateWeight
[   OK ] HierarchicalAllocatorTest.UpdateWeight (87 ms)
[--] 1 test from HierarchicalAllocatorTest (87 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (176 ms total)
[  PASSED  ] 1 test.


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 5, 2016, 5:45 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Review Request 41787: Speed up Speed up SlaveRecoveryTest.*

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Jan. 5, 2016, 5:27 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Address the comments of Adam.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
  include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
---

(Updated Jan. 5, 2016, 5:09 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290


Repository: mesos


Description
---

Fixed posix filesystem isolator to not allow executors with image.
Note that command tasks with image also creates a volume in the executor info, 
so this check should handle both command tasks and custom executors.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 

Diff: https://reviews.apache.org/r/41909/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 41891: Renaming offers to outstanding offers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112764
---


Patch looks great!

Reviews applied: [41891]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 1:35 a.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 5, 2016, 1:35 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Review Request 41906: Fixed docker containerizer usage to check for cgroup result.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/
---

Review request for mesos, Jie Yu and Jojy Varghese.


Bugs: MESOS-4031
https://issues.apache.org/jira/browse/MESOS-4031


Repository: mesos


Description
---

Fixed docker containerizer usage to check for cgroup result.


Diffs
-

  src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 

Diff: https://reviews.apache.org/r/41906/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 41595: mesos: Updated `Master::Http::state` to use `jsonify`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41595/#review112759
---


Bad patch!

Reviews applied: [41593]

Failed command: ./support/apply-review.sh -n -r 41593

Error:
 2016-01-05 04:00:47 URL:https://reviews.apache.org/r/41593/diff/raw/ 
[27498/27498] -> "41593.patch" [1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must start with a capital letter.

- Mesos ReviewBot


On Jan. 4, 2016, 11:53 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41595/
> ---
> 
> (Updated Jan. 4, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 4f4cbf6e53588b72204f9628dea5696c71eb66a5 
>   src/common/http.cpp 7165551321bedb8a4d711a64d0d6d8fd15215424 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
> 
> Diff: https://reviews.apache.org/r/41595/diff/
> 
> 
> Testing
> ---
> 
> # Some preliminery numbers
> 
> These numbers are from my Ubuntu VM on my Mac OS X with @vinodkone's 
> benchmark test: [r40844](https://reviews.apache.org/r/40844/).
> 
> ### Before
> 
> ```
> [==] Running 36 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 36 tests from SlaveAndFrameworkCount/MasterState_BENCHMARK_Test
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0
> Added 1000 slaves and 1 frameworks
> Received state.json response in 683.138216ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0 (1436 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1
> Added 1000 slaves and 50 frameworks
> Received state.json response in 550.636939ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1 (1474 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2
> Added 1000 slaves and 100 frameworks
> Received state.json response in 632.835236ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2 (1491 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3
> Added 1000 slaves and 200 frameworks
> Received state.json response in 584.035771ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3 (1431 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4
> Added 1000 slaves and 500 frameworks
> Received state.json response in 688.404348ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4 (1586 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5
> Added 1000 slaves and 1000 frameworks
> Received state.json response in 666.713683ms
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5 (1590 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6
> Added 5000 slaves and 1 frameworks
> Received state.json response in 3.916201532secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6 (7852 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7
> Added 5000 slaves and 50 frameworks
> Received state.json response in 3.362618796secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7 (8315 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8
> Added 5000 slaves and 100 frameworks
> Received state.json response in 3.126815189secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8 (7153 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9
> Added 5000 slaves and 200 frameworks
> Received state.json response in 3.079956539secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9 (7534 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10
> Added 5000 slaves and 500 frameworks
> Received state.json response in 3.222014521secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10 (8129 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11
> Added 5000 slaves and 1000 frameworks
> Received state.json response in 3.286657158secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11 (8133 
> ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12
> Added 1 slaves and 1 frameworks
> Received state.json response in 7.332592151secs
> [   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12 
> (15639 ms)
> [ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13
> Added 1 slave

Re: Review Request 41911: Added a test case for corrupt packets

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41911/
---

(Updated Jan. 5, 2016, 3:59 a.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
---

Cleanup


Repository: mesos


Description
---

Add a test case to ensure no corrupt packet could be delivered to application


Diffs (updated)
-

  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 

Diff: https://reviews.apache.org/r/41911/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 39060: Create master detector per url & not per framework

[Mandeep Chadha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/
---

(Updated Jan. 5, 2016, 3:17 a.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-3595
https://issues.apache.org/jira/browse/MESOS-3595


Repository: mesos


Description
---

If the number of framework created exceeds the lib process
threads then during master failover the zookeeper updates can
cause deadlock.


Diffs (updated)
-

  include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
  src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 

Diff: https://reviews.apache.org/r/39060/diff/


Testing
---

make check successful 
Created 100 framework instances on a 24 CPU machine. Master failover detected 
by the framework process and continue to work as expected.


Thanks,

Mandeep Chadha

Re: Review Request 41881: Provided constexpr Duration min and max values.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41881/#review112754
---


Patch looks great!

Reviews applied: [41881]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 6:43 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41881/
> ---
> 
> (Updated Jan. 4, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Till Toenshoff, and Jiang Yan 
> Xu.
> 
> 
> Bugs: MESOS-4277
> https://issues.apache.org/jira/browse/MESOS-4277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For that we need to provide a constexpr constructor for Nanoseconds at
> least; make all constructors of Duration types constexpr if possible.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 41911: Added a test case for corrupt packets

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41911/
---

Review request for mesos, Ian Downes and Jie Yu.


Repository: mesos


Description
---

Add a test case to ensure no corrupt packet could be delivered to application


Diffs
-

  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 

Diff: https://reviews.apache.org/r/41911/diff/


Testing
---

make check


Thanks,

Cong Wang

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review112752
---

Ship it!


Ship It!

- Guangya Liu


On 一月 5, 2016, 2:49 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated 一月 5, 2016, 2:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `DEFAULT_ROLE` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 3:14 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Address comments.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs (updated)
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

> On Jan. 5, 2016, 1:45 a.m., Guangya Liu wrote:
> > docs/high-availability-framework-guide.md, lines 117-118
> > 
> >
> > What will be the final state of this task? Does the framework need to 
> > re-launch this task again even though this task might already been finished 
> > in agent. Can you please add some best practise for this case?

I'm not sure what else we can say here: the best practice we're recommending is 
to avoid this situation entirely by ensuring that when a new framework leader 
is elected, it knows about (a superset of) all the tasks the previous leader 
might have launched.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---


On Jan. 5, 2016, 12:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated Jan. 5, 2016, 12:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

[Guangya Liu]

> On 一月 4, 2016, 6:35 p.m., Vinod Kone wrote:
> > docs/oversubscription.md, line 204
> > 
> >
> > s/controller/the `load` qos controller/

s/controller/, the load qos controller/?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
---


On 十二月 8, 2015, 1:24 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> ---
> 
> (Updated 十二月 8, 2015, 1:24 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  
> oversubscription_ sections.
> 
> 
> Diffs
> -
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

[Adam B]

> On Jan. 4, 2016, 2:23 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 1669
> > 
> >
> > Let's make it `optional`, in case we later want to add weights per 
> > principal, frameworkId, etc. Experienced protobuffers say "`required` is 
> > forever" and usually only recommend one required field per protobuf 
> > message. Since this is a WeightInfo, only `weight` needs to be required.
> 
> Yongqiao Wang wrote:
> Agree. But how to handle the case that end user does not specify role 
> (only specify weight) in the JSON when update weight? two proposal as below:
> 1. Return an error.
> 2. Update the weight of * role.
> 
> I prefer #1 due to it can avoid the careless of end user. @adam, what is 
> your comments?

Agreed with #1. Updates must be explicit about what role they're updating, and 
a missing role is an error.


> On Jan. 4, 2016, 2:23 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 1676-1678
> > 
> >
> > Do we really need this message? Can't we just use `repeated WeightInfo 
> > weightInfos` in any other protobuf that needs this, or use 
> > `vector` in the allocator API?
> 
> Yongqiao Wang wrote:
> I refered the other message difination in mesos.proto, such as Labels, 
> Ports, Credentials, Parameters, etc. in addition, this message is also used 
> in weights persist and authrization interface (Refer patch #41681 for the 
> details), and I think define this message is simple that vector.

We've started to realize that these collection wrapper messages make 
json/protobuf serialization unnecessarily more verbose, without adding any 
valuable flexibility for extending the WeightInfos message later.
Looking at patch #41681, you're actually persisting `repeated Weight weights;` 
(not sure why it isn't `repeated WeightInfo weights;`) in registry.proto. And 
the authorizer uses `ACL::UpdateWeights` instead, so neither registry nor 
authorizer use WeightInfos. I can't see any reason why you can't use 
`vector` or `RepeatedPtrField` instead.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/#review112528
---


On Jan. 4, 2016, 5:52 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41597/
> ---
> 
> (Updated Jan. 4, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the interface in allocator to support updating weight
> at runtime, and the allocator is invoked to allocate the
> resources based on the updated weights later.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
>   include/mesos/mesos.proto 158e08774c4a4fa5ec667388c61e55dbdafc7f67 
>   include/mesos/v1/mesos.proto c6c5a81eb9282d188d90fe395e1c16633a2a64cf 
>   src/master/allocator/mesos/allocator.hpp 
> 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
>   src/master/allocator/mesos/hierarchical.hpp 
> 86ea5a402ed67f8f22f11d5730147cd907d66a08 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 
> 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 
> 
> Diff: https://reviews.apache.org/r/41597/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> Test case: https://reviews.apache.org/r/41672/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/
---

(Updated Jan. 5, 2016, 2:49 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Addressed comment.


Summary (updated)
-

Added `DEFAULT_ROLE` constant to persistent volume tests.


Repository: mesos


Description (updated)
---

Added `DEFAULT_ROLE` constant to persistent volume tests.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
2fb57814b2805bc76981d1877603a1a033f29289 

Diff: https://reviews.apache.org/r/41613/diff/


Testing
---

`GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---

(Updated Jan. 5, 2016, 2:48 a.m.)


Review request for mesos, Adam B, Jie Yu, and Michael Park.


Changes
---

Update documents.


Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210


Repository: mesos


Description
---

Disallow special characters in role name.


Diffs (updated)
-

  docs/roles.md af1adad7ec8122fd10f7de44848014b850416bcd 
  include/mesos/roles.hpp PRE-CREATION 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/common/roles.cpp PRE-CREATION 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
  src/tests/roles_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35711/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review112746
---


The summary needs to be updated to reflect your update "DEFAULT_ROLE" but not 
"defaultRole"

- Guangya Liu


On 一月 4, 2016, 4:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated 一月 4, 2016, 4:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 35711: Disallow special characters in role name.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---

(Updated Jan. 5, 2016, 2:42 a.m.)


Review request for mesos, Adam B, Jie Yu, and Michael Park.


Changes
---

Address @adam and @greggomann comments.


Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210


Repository: mesos


Description
---

Disallow special characters in role name.


Diffs (updated)
-

  include/mesos/roles.hpp PRE-CREATION 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/common/roles.cpp PRE-CREATION 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
  src/tests/roles_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35711/diff/


Testing
---

make -j8 check


Thanks,

haosdent huang

Re: Review Request 40429: Report executor exit to framework schedulers.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112740
---

Ship it!


Besides a few minor changes that I could make myself before committing, I'm now 
thinking that we should CHECK for the status in an event.failure() (with 
executorId present).
Either change it or convince me that an if/else is better.


src/sched/sched.cpp (lines 592 - 595)


`event.failure()` should always have a status if it has an executorId, 
since it comes from an ExitedExecutorMessage from the slave. I'm starting to 
think we should change this to a `CHECK(event.failure().has_status());`, since 
the -1 status is so arbitrary/meaningless anyway (and could conflict with a 
real -1 status).



src/tests/gc_tests.cpp (lines 652 - 653)


Swap.



src/tests/gc_tests.cpp (lines 799 - 800)


Swap



src/tests/slave_tests.cpp (line 1137)


s/containizer/containerizer/


- Adam B


On Jan. 4, 2016, 5:14 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Jan. 4, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 
> 4f048830a2c47f747033c60730cc770cb2578815 
>   src/python/interface/src/mesos/interface/__init__.py 
> 4be502fd83029ad5fc798696caf9e27fd95f7482 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 9afa826006fa7129da1a9c1ac8c389c0e051f717 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 
> 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41892: DockerContinerizer infers hostPath for persistent volumes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41892/#review112743
---


Patch looks great!

Reviews applied: [41892]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 9:15 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41892/
> ---
> 
> (Updated Jan. 4, 2016, 9:15 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3413
> https://issues.apache.org/jira/browse/MESOS-3413
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This diff makes DockerContainerizer infers hostPath for persistent volumes 
> from resources passed-in.
> 
> This allows current DockerContainerizer to use persistent volumes w/o hard 
> code slave's work_dir. I also checked that the inferred directory actually 
> exists to avoid framework messing up role or persistent id.
> 
> Note that some validation on the resource part should be done before we start 
> the container, which seems to belong to slave.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1 
>   src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8 
>   src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
>   src/docker/executor.cpp 7512d07de6c8324340e6b5f3e5162ef00efc47fc 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> cb58b7183c36d96b9ac4803c63980c278a50c97b 
>   src/tests/containerizer/docker_tests.cpp 
> 83eceacaddc38d0ccfc42e65e700a09406d8df36 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/41892/diff/
> 
> 
> Testing
> ---
> 
> New unit test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

[Joseph Wu]

> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotate.cpp, line 99
> > 
> >
> > Why abstract this?

At some point, this function was a bit longer than one statement.  Cleaned up...


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotate.cpp, line 121
> > 
> >
> > Why not just:
> > 
> > if ((bytesWritten + readSize) > maxSize) {
> > 
> > }
> > 
> > Instead of asking the reader to understand that you're calculating the 
> > number of bytes that would overflow maxSize and then checking if that's 
> > greater than 0?

Oops, this was also a leftover.  

At some earlier iteration, I considered writing the files exactly up to the 
configured log-size limit rather than by whatever `io::read` returns.  (You'll 
notice that the test checks `2040 < log-file-size < 2048`.)  This led to 
less-readable log files, particularly if a sentence is broken into two files 
and then one of those files is deleted.


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotate.cpp, lines 125-131
> > 
> >
> > Okay, IIUC then you'll have a moving window of log files, rather than 
> > rotating through log files .1, .2, .3, .4, .maxFiles, is that right?
> > 
> > Any reason not to do the latter?
> > 
> > Either way, this needs to be documented! Preferably at the begining of 
> > this class, with a basic comment here that reminds folks. This was not what 
> > I expected so I had to read the code carefuly.

We don't cycle through a finite set of files because this makes it easier to 
order the files.
i.e. Suppose maxFiles is 5.
1) The logger (over time) creates the files: `log`, `log.1`, `log.2`, `log.3`, 
`log.4`.
2) `log` fills up and `log.1` is deleted.
Current impl) `log` is renamed to `log.5`.
Cycle impl) `log` is renamed to `log.1`.  Someone reads `log.1` then `log.2` 
and gets confused.

I'll put the related documentation into the custom flags (`--log_filename`).


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotate.cpp, lines 174-179
> > 
> >
> > Woah! Why not use stout's `Flags`!!!??? We do this with our other 
> > executables and it makes the code much simpler!

Added :)  

(And some other flags too.)


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotating.cpp, line 162
> > 
> >
> > Why are we not using `Path`? Do we need to do more in the codebase to 
> > make us use `Path` everywhere?

We don't use `Path` mostly because the `path::` helpers return strings.
To use `Path` as it is, we'd need to do `Path(path::join(...))`.

For now, I'll drop this (and we can track the cleanup/refactor in MESOS-2995).


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotate.cpp, line 146
> > 
> >
> > What if this fails?

Added a comment.  And one for `os::rm` and `os::rename`.


> On Dec. 29, 2015, 4:38 p.m., Benjamin Hindman wrote:
> > src/slave/container_loggers/rotating.cpp, line 268
> > 
> >
> > Could we create a "flags" for these parameters? And parse the 
> > parameters as flags? That would be very clean!!! We could then 
> > retroactively clean up the other modules, it would set a clean precedent.
> > 
> > It's especially wierd in this circumstance to pass `Result` arguments 
> > into the logger and then later during initialize error out. It means that 
> > everywehre else in the logger you "know" that it's okay to just call 
> > `.get()` on the `Result` objects because you've already checked them, which 
> > is a nasty global invariant that people now have to remember! In your case 
> > you've dodged this bullet by having `RotatingContainerLogger::initialize` 
> > do the checks and error out there, but then what if you need to have 
> > `RotatingContainerLoggerProcess` do it's own initialization?
> > 
> > I'd rather see the `create` function passed to the `Module` return an 
> > `Error` ... which apparently is not allowed because we didn't pull in 
> > `stout` for modules? But we did pull in `stout` for the `ContainerLogger` 
> > module ... ???

Added flags.  Also added a few extra parameters.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/#review112260
-

Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/
---

(Updated Jan. 4, 2016, 6:21 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Update according to changes made in the next review (different parameters, more 
files).


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

Creates a new binary "mesos-rotate-logger" for use by the non-default 
"Rotating" ContainerLogger module.
Adds the `RotatingContainerLogger` to the test module configuration.


Diffs (updated)
-

  src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
  src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
  src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 

Diff: https://reviews.apache.org/r/41782/diff/


Testing
---

Note: Some of the files added to the makefile are created in the next review.


Thanks,

Joseph Wu

Re: Review Request 41781: Logger Module: Add test for behavior of the rotating container logger module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41781/
---

(Updated Jan. 4, 2016, 6:21 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Move in-test cleanup above sandbox check.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

This test loads a non-default ContainerLogger module that rotates logs (i.e. 
renaming the head log file) and constrains total log size.


Diffs (updated)
-

  src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640 

Diff: https://reviews.apache.org/r/41781/diff/


Testing
---

This test is run later in the review chain.


Thanks,

Joseph Wu

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/
---

(Updated Jan. 4, 2016, 6:21 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
---

Use stout::Flags.  Added lots more flags + comments.  A bunch of cleanup + 
addressing comments.


Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description
---

Adds a non-default ContainerLogger that constrains total log size by rotating 
logs (i.e. renaming the head log file).


Diffs (updated)
-

  src/slave/container_loggers/rotate.hpp PRE-CREATION 
  src/slave/container_loggers/rotate.cpp PRE-CREATION 
  src/slave/container_loggers/rotating.hpp PRE-CREATION 
  src/slave/container_loggers/rotating.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41783/diff/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/#review112741
---

Ship it!


Ship It!

- haosdent huang


On Dec. 9, 2015, 2:20 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40224/
> ---
> 
> (Updated Dec. 9, 2015, 2:20 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-3792
> https://issues.apache.org/jira/browse/MESOS-3792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix wrong flags infos in /state and /flags. We should convert protobuf type 
> flag to JSON object explicitly instead of relying on stringify
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 
>   src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 
> 
> Diff: https://reviews.apache.org/r/40224/diff/
> 
> 
> Testing
> ---
> 
> make & make check
> 
> ./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": 
> [{"principals": { "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": 
> [{"principals": { "values": ["a", "b"] },"users": { "values": ["c"] 
> }}],"shutdown_frameworks": [{"principals": { "values": ["a", "b"] 
> },"framework_principals": { "values": ["c"] }}]}'
> 
> curl http://master:5050/state
> curl http://master:5050/flag
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 41862: Fix containerizer-internals Posix launcher TBD.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41862/
---

(Updated Jan. 5, 2016, 2:11 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

Address @tnachen comments.


Bugs: MESOS-4268
https://issues.apache.org/jira/browse/MESOS-4268


Repository: mesos


Description
---

Fix containerizer-internals Posix launcher TBD.


Diffs (updated)
-

  docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c 

Diff: https://reviews.apache.org/r/41862/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/#review112704
---



docs/high-availability-framework-guide.md (line 81)


Can you please also identify "odd number" here, such as "three or five 
instances is typical but should be a odd number"



docs/high-availability-framework-guide.md (line 83)


s/Mesos/Mesos master?



docs/high-availability-framework-guide.md (lines 117 - 118)


What will be the final state of this task? Does the framework need to 
re-launch this task again even though this task might already been finished in 
agent. Can you please add some best practise for this case?


- Guangya Liu


On 一月 5, 2016, 12:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41896/
> ---
> 
> (Updated 一月 5, 2016, 12:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3936
> https://issues.apache.org/jira/browse/MESOS-3936
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added guide to writing highly available Mesos frameworks.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/high-availability-framework-guide.md PRE-CREATION 
>   docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
>   docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 
> 
> Diff: https://reviews.apache.org/r/41896/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> Note that there's a lot more that could be said here; also, at some point we 
> should probably unify the "reconciliation" page with this page, and perhaps 
> move some of the content in the "high-availability" page here (leaving the 
> "high-availability" page for the operator-centric parts of configuring Mesos 
> to run in HA mode).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112738
---



src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 81 - 82)


Can you move the comments right above:
```
if (executorInfo.container().mesos().has_image()) {
```



src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 91 - 93)


In fact, we don't support executorInfo.container().volumes() at all. Let's 
disallow that as well:

```
if (!executorInfo.container().volumes().empty()) {
  return Failure("Volumes in ContainerInfo is not supported");
}
```


- Jie Yu


On Jan. 5, 2016, 1:06 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> ---
> 
> (Updated Jan. 5, 2016, 1:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor 
> info, so this check should handle both command tasks and custom executors.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 
> 
> Diff: https://reviews.apache.org/r/41909/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers.

[Diogo Gomes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/
---

(Updated Jan. 4, 2016, 11:35 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Changing menu title to Offers again, as Vinod suggested. 
![index.html](https://www.evernote.com/l/AEsStl7ZRXZIspQXcCFKbgAkSyuThOOhRUcB/image.png)


Bugs: MESOS-3817
https://issues.apache.org/jira/browse/MESOS-3817


Repository: mesos


Description
---

Renaming offers to outstanding offers.


Diffs (updated)
-

  src/webui/master/static/offers.html cc199352fcf2074dcd0e8d24bb49651b38c41d86 

Diff: https://reviews.apache.org/r/41891/diff/


Testing
---

Can be tested running Mesos Master web-ui front page and offers page (now named 
as Outstanding Offers). Only html changed.


Thanks,

Diogo Gomes

Re: Review Request 41880: Removed redundant constructor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41880/#review112737
---


Patch looks great!

Reviews applied: [41880]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 8:28 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41880/
> ---
> 
> (Updated Jan. 4, 2016, 8:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-4276
> https://issues.apache.org/jira/browse/MESOS-4276
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed redundant constructor.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 
>   src/examples/event_call_framework.cpp 
> c7b4de225bc1731c3fae79b97864d426198cf671 
>   src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 
>   src/tests/master_maintenance_tests.cpp 
> a14435c0e3f44b5a61e2f5a9debd20f4e447491f 
> 
> Diff: https://reviews.apache.org/r/41880/diff/
> 
> 
> Testing
> ---
> 
> make check (Debian8 and OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41905: Added discussion of multiple frameworks sharing the same role.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41905/#review112735
---

Ship it!


Ship It!

- Qian Zhang


On Jan. 5, 2016, 8:10 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41905/
> ---
> 
> (Updated Jan. 5, 2016, 8:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4204
> https://issues.apache.org/jira/browse/MESOS-4204
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion of multiple frameworks sharing the same role.
> 
> 
> Diffs
> -
> 
>   docs/roles.md bbc52ac17c464837c87a845b7330f04b482c4392 
> 
> Diff: https://reviews.apache.org/r/41905/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41905: Added discussion of multiple frameworks sharing the same role.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41905/#review112736
---

Ship it!


Ship It!

- Guangya Liu


On 一月 5, 2016, 12:10 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41905/
> ---
> 
> (Updated 一月 5, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4204
> https://issues.apache.org/jira/browse/MESOS-4204
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion of multiple frameworks sharing the same role.
> 
> 
> Diffs
> -
> 
>   docs/roles.md bbc52ac17c464837c87a845b7330f04b482c4392 
> 
> Diff: https://reviews.apache.org/r/41905/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41869: Removed Docker auth server flag.

[Timothy Chen]

> On Jan. 4, 2016, 5:42 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 117
> > 
> >
> > Can we make this ```mutable``` and keep all the methods ```const``` ?

This is already mutable? I can't make them const if I want to modify a class's 
field variable right?


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112496
---


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41869: Removed Docker auth server flag.

[Timothy Chen]

> On Jan. 4, 2016, 6:33 a.m., Jojy Varghese wrote:
> > Thanks Tim for taking care of this. I have been thinking that we should 
> > have TokenManager keep a map of  -> . This 
> > would help us to have any realm being handled by the registry_client + 
> > token manager. This way, all pull requests will request the TokenManager 
> > for a token with ```getToken(realm, service, scope)```. TokenManager will 
> > lookup the cache and return the token or create a new item in the cache 
> > (after getting the token from realm).
> > 
> > What do you think?

My current thinking is that we create a token manager per realm and allow the 
registry client to talk to multiple registries. This patch I'm only creating 
one token manager for now, and will change this as soon as we start supporting 
private registries.
And also I think for the token manager we also need to allow the tuple 
(service, scope, user) to be the key.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112502
---


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Zhitao Li]

> On Jan. 4, 2016, 11:15 a.m., Adam B wrote:
> > Looks good, but you really need to set up your EXPECTations before you do 
> > the thing (e.g. `containerizer.destroy()`) that would trigger the 
> > EXPECTation. Fix these, and I'd feel comfortable committing it.
> > Any further thoughts from Vinod?
> 
> Vinod Kone wrote:
> Took a quick glance. Looks ok. I'll let Adam shepherd this to completion.
> 
> Was there an email sent to the dev list regarding this upcoming change?

Hi Vinod, I just sent out the email.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112541
---


On Jan. 5, 2016, 1:14 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> ---
> 
> (Updated Jan. 5, 2016, 1:14 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Report executor exit to framework schedulers. This is a MVP to start the work 
> of notifying scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting 
> Event::FAILURE for slave failure and executor termination.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
>   docs/app-framework-development-guide.md 
> 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 
> 4f048830a2c47f747033c60730cc770cb2578815 
>   src/python/interface/src/mesos/interface/__init__.py 
> 4be502fd83029ad5fc798696caf9e27fd95f7482 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 9afa826006fa7129da1a9c1ac8c389c0e051f717 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 
> 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> ---
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that 
> MockScheduler::executorLost is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 40429: Report executor exit to framework schedulers.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/
---

(Updated Jan. 5, 2016, 1:14 a.m.)


Review request for mesos, Adam B and Vinod Kone.


Changes
---

Addressing comments from Adam.


Bugs: MESOS-313
https://issues.apache.org/jira/browse/MESOS-313


Repository: mesos


Description
---

Report executor exit to framework schedulers. This is a MVP to start the work 
of notifying scheduler on scheduler refresh.

Next step would be sending this message reliabily, and/or splitting 
Event::FAILURE for slave failure and executor termination.


Diffs (updated)
-

  CHANGELOG 2aa083c85ae2a2f1392121b1d30d71376c01ffd7 
  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
  include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
  src/java/src/org/apache/mesos/Scheduler.java 
4f048830a2c47f747033c60730cc770cb2578815 
  src/python/interface/src/mesos/interface/__init__.py 
4be502fd83029ad5fc798696caf9e27fd95f7482 
  src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
  src/tests/fault_tolerance_tests.cpp ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
  src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
  src/tests/master_slave_reconciliation_tests.cpp 
9afa826006fa7129da1a9c1ac8c389c0e051f717 
  src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
  src/tests/scheduler_event_call_tests.cpp 
03f0332ef75bbe7c4947bd6daf55d40384570f18 
  src/tests/slave_tests.cpp 77750eda99184c0bf4404df8468461e3c7f8cde0 

Diff: https://reviews.apache.org/r/40429/diff/


Testing
---

Modified test for SchedulerDriverEventTest.Failure, which verifies that 
MockScheduler::executorLost is invoked.


Thanks,

Zhitao Li

Re: Review Request 41869: Removed Docker auth server flag.

[Timothy Chen]

> On Jan. 4, 2016, 5:42 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, lines 
> > 293-294
> > 
> >
> > These 2 lines can be combined as: 
> > 
> > ``` 
> > Try realmUrl = http::URL::parse(attributes.at("realm"));
> > ```

I'm using the realm variable later.


> On Jan. 4, 2016, 5:42 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 285
> > 
> >
> > Since realm is needed only for tokenmanager creation, this could be 
> > moved inside the block starting at L260.

technically but I think it's safe to check everytime since we're assuming it's 
always available!


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41869/#review112496
---


On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
> ---
> 
> (Updated Jan. 4, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently Docker auth server is being configured via docker_auth_server flag, 
> but we should actually get the docker auth server information from docker 
> registry. This allows us to remove one flag and also support both public and 
> private docker registry.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> e73d4d785bccf1d50af9e91d2d20dafb444bec68 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 4e305ade1f9f8b42de5c8db636c6d3f5d8e2444f 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
>   src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41869/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers.

[Diogo Gomes]

> On Jan. 4, 2016, 10:26 p.m., Vinod Kone wrote:
> > Can you attach the screenshot of the webui with these changes?
> 
> Diogo Gomes wrote:
> Sure:
> 
> index.html 
> 
> ![index.html](https://www.evernote.com/l/AEuvTZAB75dJHZCXhYl-o6kg_-QGxGC3Fu8B/image.png)
> 
> offers.html 
> 
> ![offers.html](https://www.evernote.com/l/AEvG7nUTwwVDoohVNfohbXih6iJlQgooz6IB/image.png)
> 
> Vinod Kone wrote:
> How about justing calling it "Offers" in the black band? That way it is 
> consistent with "Frameowrks" and "Slaves" which do not have any qualifiers. 
> Also, it leaves the door open for the "Offers" page to have more than 
> "Outstanding Offers" in the future (e.g., accepted offers, declined offers 
> etc).

Totally agree, I'll change the commit and update here


- Diogo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112710
---


On Jan. 4, 2016, 10:23 p.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 4, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112725
---

Ship it!


Ship It!

- Gilbert Song


On Jan. 4, 2016, 5:06 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> ---
> 
> (Updated Jan. 4, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor 
> info, so this check should handle both command tasks and custom executors.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 
> 
> Diff: https://reviews.apache.org/r/41909/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
---

(Updated Jan. 5, 2016, 1:06 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290


Repository: mesos


Description (updated)
---

Fixed posix filesystem isolator to not allow executors with image.
Note that command tasks with image also creates a volume in the executor info, 
so this check should handle both command tasks and custom executors.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 

Diff: https://reviews.apache.org/r/41909/diff/


Testing
---

make check


Thanks,

Timothy Chen

Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
---

Review request for mesos.


Repository: mesos


Description
---

Fixed posix filesystem isolator to not allow executors with image.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 

Diff: https://reviews.apache.org/r/41909/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 41909: Fixed posix filesystem isolator to not allow executors with image.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
---

(Updated Jan. 5, 2016, 1:04 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290


Repository: mesos


Description
---

Fixed posix filesystem isolator to not allow executors with image.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca 

Diff: https://reviews.apache.org/r/41909/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 41891: Renaming offers to outstanding offers.

[Vinod Kone]

> On Jan. 5, 2016, 12:26 a.m., Vinod Kone wrote:
> > Can you attach the screenshot of the webui with these changes?
> 
> Diogo Gomes wrote:
> Sure:
> 
> index.html 
> 
> ![index.html](https://www.evernote.com/l/AEuvTZAB75dJHZCXhYl-o6kg_-QGxGC3Fu8B/image.png)
> 
> offers.html 
> 
> ![offers.html](https://www.evernote.com/l/AEvG7nUTwwVDoohVNfohbXih6iJlQgooz6IB/image.png)

How about justing calling it "Offers" in the black band? That way it is 
consistent with "Frameowrks" and "Slaves" which do not have any qualifiers. 
Also, it leaves the door open for the "Offers" page to have more than 
"Outstanding Offers" in the future (e.g., accepted offers, declined offers etc).


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112710
---


On Jan. 5, 2016, 12:23 a.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 5, 2016, 12:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112717
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 54)


the current function is not os::rmdir.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 64)


What does "Previous" mean here? Should it be "Parent"?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 87)


os::rmdir is not the right func name. Also, "found it was not a valid 
directory" does not make sense because we only hit here when it's not a 
directory.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 96)


os::rmdir


- Yi Sun


On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 4, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

[James Peach]

> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [40975]
> > 
> > Failed command: ./support/apply-review.sh -n -r 40975
> > 
> > Error:
> >  2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ 
> > [1164/1164] -> "40975.patch" [1]
> > No files to lint
> > 
> > Error: Commit message summary (the first line) must end in a period.
> 
> James Peach wrote:
> Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a 
> period.
> 
> Vinod Kone wrote:
> the summary line above doesn't have a period. am i missing something?

``apply-review.sh`` is adding tht somehow. The commit that I fed to 
``post-reviews.sh`` doesn't have it.

```
mesos.git jpeach$ git show
commit efa6b867e7c421de3102bd00674ef2aa37610de8
Author: James Peach 
Date:   Fri Dec 4 09:31:44 2015 -0800

Document that libprocess ignores SIGPIPE.

Review: https://reviews.apache.org/r/40975

diff --git a/3rdparty/libprocess/README.md b/3rdparty/libprocess/README.md
index 6a47f67..3bd0c7c 100644
--- a/3rdparty/libprocess/README.md
+++ b/3rdparty/libprocess/README.md
@@ -30,6 +30,7 @@ At a higher level, functional composition of processes is 
facilitated using [fut
 * [HTTP](#http)
 * [Testing](#testing)
 * [Miscellaneous Primitives](#miscellaneous-primitives)
+* [Signal Handling](#signal-handling)

 ---

@@ -653,3 +654,13 @@ int main()
 ### `async`

 Async defines a function template for asynchronously executing function 
closures. It provides their results as [futures](#futures-and-promises).
+
+## Signal handling
+
+In general, libprocess does not depend on signals or interfere with
+the host processes signal handling policy. The exception is that
+it always ignores `SIGPIPE` globally, so the host process must not
+depend on `SIGPIPE` being delivered when performing I/O on disconnected
+pipes or sockets.  libprocess APIs that perform I/O will always
+return an appropriately wrapped EPIPE error code (usually a stout
+`ErrnoError` object) instead of raising `SIGPIPE`.
```


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
---


On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> ---
> 
> (Updated Jan. 4, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document that libprocess ignores SIGPIPE.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/40975/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 41905: Added discussion of multiple frameworks sharing the same role.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41905/#review112716
---

Ship it!


Ship It!

- Jie Yu


On Jan. 5, 2016, 12:10 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41905/
> ---
> 
> (Updated Jan. 5, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4204
> https://issues.apache.org/jira/browse/MESOS-4204
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion of multiple frameworks sharing the same role.
> 
> 
> Diffs
> -
> 
>   docs/roles.md bbc52ac17c464837c87a845b7330f04b482c4392 
> 
> Diff: https://reviews.apache.org/r/41905/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers.

[Diogo Gomes]

> On Jan. 4, 2016, 10:26 p.m., Vinod Kone wrote:
> > Can you attach the screenshot of the webui with these changes?

Sure:

index.html 
![index.html](https://www.evernote.com/l/AEuvTZAB75dJHZCXhYl-o6kg_-QGxGC3Fu8B/image.png)

offers.html 
![offers.html](https://www.evernote.com/l/AEvG7nUTwwVDoohVNfohbXih6iJlQgooz6IB/image.png)


- Diogo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112710
---


On Jan. 4, 2016, 10:23 p.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 4, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112710
---


Can you attach the screenshot of the webui with these changes?

- Vinod Kone


On Jan. 5, 2016, 12:23 a.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 5, 2016, 12:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers.

[Diogo Gomes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/
---

(Updated Jan. 4, 2016, 10:23 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-

Renaming offers to outstanding offers.


Bugs: MESOS-3817
https://issues.apache.org/jira/browse/MESOS-3817


Repository: mesos


Description (updated)
---

Renaming offers to outstanding offers.


Diffs
-

  src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
  src/webui/master/static/offers.html cc199352fcf2074dcd0e8d24bb49651b38c41d86 

Diff: https://reviews.apache.org/r/41891/diff/


Testing
---

Can be tested running Mesos Master web-ui front page and offers page (now named 
as Outstanding Offers). Only html changed.


Thanks,

Diogo Gomes

Re: Review Request 41454: Added initial draft of executor HTTP API user doc.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41454/#review112636
---



docs/executor-http-api.md (line 14)


put 4 spaces so that you get a shaded block around this. see 
https://github.com/apache/mesos/blob/master/docs/scheduler-http-api.md for 
reference.



docs/executor-http-api.md (line 30)


s/Alternatively/Additonally/



docs/executor-http-api.md (line 31)


"The executor is expected to keep running...". This sentence should be at 
the top of these two sub points. Also, the executor should keep running only if 
checkpointing is enabled right?

"These status update messages...". How about:
"The executor is expected to keep track of status updates not acknowledged 
by the agent via the ACKNOWLEDGE events."



docs/executor-http-api.md (line 32)


there should be no network intermediaries between an agent and an executor!

can you just re-use the comment in exec.cpp above `tasks` map instead?



docs/executor-http-api.md (lines 52 - 70)


looking at just the JSON, it's not very clear that `tasks` and `updates` 
correspond to unacknowledged tasks and updates. we should probably rename these 
fields as `unacknowledged_tasks` and `unacknowledged_updates`. what do you 
think?



docs/executor-http-api.md (line 131)


Is the retry by executor necessary? The current driver doesn't do retries 
for example. Are you anticipating a scenario where the executor is connected 
but messages are lost?



docs/executor-http-api.md (line 171)


s/message to the executor/message to the scheduler/



docs/executor-http-api.md (line 211)


s/messages/tasks/



docs/executor-http-api.md (line 247)


s/the resources/the task resources/



docs/executor-http-api.md (line 278)


Mention that `data` is raw bytes encoded in Base64?



docs/executor-http-api.md (line 293)


Also mention that TASK_LOST updates will be sent by the slave for any 
active tasks.



docs/executor-http-api.md (lines 332 - 333)


didn't we agree to rename these?



docs/executor-http-api.md (line 335)


s/all agent/all the agent's/



docs/executor-http-api.md (line 343)


what's the relation between MESOS_RETRY_INTERVAL_MAX and the duration after 
which the agent deems recovery process complete (EXECUTOR_REREGISTER_TIMEOUT)? 
AFAICT, currently the former is set to 15 min and the latter is 2s.



docs/executor-http-api.md (line 350)


s/then kill/then forcefully kill/

s/in forcefully/in/


- Vinod Kone


On Dec. 17, 2015, 1:07 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41454/
> ---
> 
> (Updated Dec. 17, 2015, 1:07 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4177
> https://issues.apache.org/jira/browse/MESOS-4177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is an initial draft for the user doc of Executor HTTP API. Some details 
> might change due to the pending executor library review chain: 
> https://reviews.apache.org/r/41275
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md PRE-CREATION 
>   docs/home.md a01612ec8347eb8a7a9277b829365b6c3a1fe9e3 
> 
> Diff: https://reviews.apache.org/r/41454/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/hatred/d35fdaa667203bf34a78
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review112701
---

Ship it!


Ship It!

- Yi Sun


On Jan. 5, 2016, 12:12 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 5, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41891: Renaming offers to outstanding offers

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112698
---


Bad patch!

Reviews applied: [41891]

Failed command: ./support/apply-review.sh -n -r 41891

Error:
 2016-01-05 00:12:44 URL:https://reviews.apache.org/r/41891/diff/raw/ 
[1331/1331] -> "41891.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 4, 2016, 8:20 p.m., Diogo Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> ---
> 
> (Updated Jan. 4, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
> https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renaming offers to outstanding offers
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> ---
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

(Updated Jan. 5, 2016, 12:12 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
5b38b9af654d7d1c574f0cc573083b66693ced1d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

> On Jan. 4, 2016, 11:30 p.m., Yi Sun wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp, line 
> > 86
> > 
> >
> > We are not calling lstat here.

Great catch. This should also not overwrite the error returned from our 
internal symlink API! It's an artifact from the POSIX code.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review112686
---


On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 4, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 41905: Added discussion of multiple frameworks sharing the same role.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41905/
---

Review request for mesos, Adam B, Jie Yu, and Joris Van Remoortere.


Bugs: MESOS-4204
https://issues.apache.org/jira/browse/MESOS-4204


Repository: mesos


Description
---

Added discussion of multiple frameworks sharing the same role.


Diffs
-

  docs/roles.md bbc52ac17c464837c87a845b7330f04b482c4392 

Diff: https://reviews.apache.org/r/41905/diff/


Testing
---

Previewed via site-docker.


Thanks,

Neil Conway

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

(Updated Jan. 5, 2016, 12:09 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Changes
---

Add JIRA link.


Bugs: MESOS-3936
https://issues.apache.org/jira/browse/MESOS-3936


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 41595: mesos: Updated `Master::Http::state` to use `jsonify`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41595/
---

(Updated Jan. 4, 2016, 11:53 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Rebase


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/common/http.hpp 4f4cbf6e53588b72204f9628dea5696c71eb66a5 
  src/common/http.cpp 7165551321bedb8a4d711a64d0d6d8fd15215424 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 

Diff: https://reviews.apache.org/r/41595/diff/


Testing
---

# Some preliminery numbers

These numbers are from my Ubuntu VM on my Mac OS X with @vinodkone's benchmark 
test: [r40844](https://reviews.apache.org/r/40844/).

### Before

```
[==] Running 36 tests from 1 test case.
[--] Global test environment set-up.
[--] 36 tests from SlaveAndFrameworkCount/MasterState_BENCHMARK_Test
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0
Added 1000 slaves and 1 frameworks
Received state.json response in 683.138216ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/0 (1436 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1
Added 1000 slaves and 50 frameworks
Received state.json response in 550.636939ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/1 (1474 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2
Added 1000 slaves and 100 frameworks
Received state.json response in 632.835236ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/2 (1491 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3
Added 1000 slaves and 200 frameworks
Received state.json response in 584.035771ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/3 (1431 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4
Added 1000 slaves and 500 frameworks
Received state.json response in 688.404348ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/4 (1586 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5
Added 1000 slaves and 1000 frameworks
Received state.json response in 666.713683ms
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/5 (1590 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6
Added 5000 slaves and 1 frameworks
Received state.json response in 3.916201532secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/6 (7852 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7
Added 5000 slaves and 50 frameworks
Received state.json response in 3.362618796secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/7 (8315 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8
Added 5000 slaves and 100 frameworks
Received state.json response in 3.126815189secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/8 (7153 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9
Added 5000 slaves and 200 frameworks
Received state.json response in 3.079956539secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/9 (7534 ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10
Added 5000 slaves and 500 frameworks
Received state.json response in 3.222014521secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/10 (8129 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11
Added 5000 slaves and 1000 frameworks
Received state.json response in 3.286657158secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/11 (8133 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12
Added 1 slaves and 1 frameworks
Received state.json response in 7.332592151secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/12 (15639 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13
Added 1 slaves and 50 frameworks
Received state.json response in 6.998751033secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/13 (17175 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14
Added 1 slaves and 100 frameworks
Received state.json response in 6.807456891secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/14 (15974 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15
Added 1 slaves and 200 frameworks
Received state.json response in 6.371190971secs
[   OK ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/15 (15772 
ms)
[ RUN  ] SlaveAndFrameworkCount/MasterState_BENCHMARK_Test.State/16
Added 1 slaves and 500 frameworks
Received state.json response in 6.613739531secs
[   OK ] SlaveAndFrameworkCo

Re: Review Request 41871: Replaced libtool with dolt to speed up compiler invocations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41871/#review112532
---


Patch looks great!

Reviews applied: [41871]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 8:01 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41871/
> ---
> 
> (Updated Jan. 4, 2016, 8:01 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4271
> https://issues.apache.org/jira/browse/MESOS-4271
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The added m4 macro definitions come from
> git://anongit.freedesktop.org/git/dolt revision
> 2eae53fa6d31175e9de62a312cc2191fd8a25cb7.
> 
> 
> Diffs
> -
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   m4/dolt.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41871/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41593: stout: Added `jsonify` function.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/
---

(Updated Jan. 4, 2016, 11:39 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
---

Moved `void json(const google::protobuf::Message&);` to ``.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
a2a3dc6120b10c8fe82088b9f0ebecfa5642f945 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
98ea47794b3a7c99b3cbd2418ba6e36eb5951259 

Diff: https://reviews.apache.org/r/41593/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

[Vinod Kone]

> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [40975]
> > 
> > Failed command: ./support/apply-review.sh -n -r 40975
> > 
> > Error:
> >  2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ 
> > [1164/1164] -> "40975.patch" [1]
> > No files to lint
> > 
> > Error: Commit message summary (the first line) must end in a period.
> 
> James Peach wrote:
> Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a 
> period.

the summary line above doesn't have a period. am i missing something?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
---


On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> ---
> 
> (Updated Jan. 4, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document that libprocess ignores SIGPIPE.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/40975/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review112686
---



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
(line 65)


typo: sybolic->symbolic



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 84)


We are not calling lstat here.


- Yi Sun


On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 4, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

> On Jan. 4, 2016, 10:33 p.m., Daniel Pravat wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line 
> > 94
> > 
> >
> > Can you use _rmdir() instead to avoid another deprecation warning ?

Just a brief comment here: in windows.hpp there are aliases mapping POSIX 
functions to their underscore versions (_e.g._, `open` -> `_open`), but this is 
for compatibility in files where POSIX and Windows implementations are the 
same, so that we don't have to fork the implementation just because the names 
are slightly different.

BUT, now that you point it out, I totally agree that we should call the actual 
function `_rmdir` instead when the file is Windows-specific.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112667
---


On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 4, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

(Updated Jan. 4, 2016, 11:26 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
e738cdbf5846950c475c159fb9a770acc45159f5 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

(Updated Jan. 4, 2016, 11:26 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
5b38b9af654d7d1c574f0cc573083b66693ced1d 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review112685
---

Ship it!


Ship It!

- Daniel Pravat


On Jan. 4, 2016, 11:46 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 4, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41881: Provided constexpr Duration min and max values.

[Benjamin Bannier]

> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote:
> > Looks good. How did you choose the particular functions to make constexpr. 
> > Why not the units for example? or others?
> 
> Benjamin Bannier wrote:
> The goal was to provide `constexpr` versions of `Duration::min`, 
> `Duration::max`, and `Duration::zero`. The latter requires a `constexpr` 
> default ctr for `Duration`, the two former ones `constexpr` ctrs for both 
> `NanoSeconds` and for `Duration(int64_t, int64_t)`. For consistency I made 
> most ctrs `constexpr`.
> 
> What do you mean by units here?
> 
> Joris Van Remoortere wrote:
> For example:
> `static std::string units() { return "hrs"; }`

Ah, I see. That would have extended the scope of this RR quite a bit.

Note that since `std::string` does not provide a `constexpr` ctr, we'd have to 
change to e.g.,

static constexpr const char* units() { return "hrs"; }

which would cut some runtime cost since the literal would come from the RO 
section. I am not sure the `constexpr` adds much though since I cannot imagine 
a use case where we'd use the value as e.g., a template argument.

Is that something which you think should be implemented here and now?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41881/#review112609
---


On Jan. 4, 2016, 6:43 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41881/
> ---
> 
> (Updated Jan. 4, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Till Toenshoff, and Jiang Yan 
> Xu.
> 
> 
> Bugs: MESOS-4277
> https://issues.apache.org/jira/browse/MESOS-4277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For that we need to provide a constexpr constructor for Nanoseconds at
> least; make all constructors of Duration types constexpr if possible.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 41877: Fixed libprocess build with libhttp-parser >= 2.0.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41877/#review112671
---

Ship it!


This was my bug, sorry about this and thanks for the fix!

- Ben Mahler


On Jan. 4, 2016, 10:25 a.m., Jocelyn De La Rosa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41877/
> ---
> 
> (Updated Jan. 4, 2016, 10:25 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4274
> https://issues.apache.org/jira/browse/MESOS-4274
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed libprocess build with libhttp-parser >= 2.0.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/decoder.hpp 
> 9a1ce0f3e7f4affc3e856c9754f5fbeecd244cdf 
> 
> Diff: https://reviews.apache.org/r/41877/diff/
> 
> 
> Testing
> ---
> 
> make check under 3rdparty/libprocess on archlinux
> 
> 
> Thanks,
> 
> Jocelyn De La Rosa
> 
>

Review Request 41896: Added guide to writing highly available Mesos frameworks.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41896/
---

Review request for mesos, Benjamin Hindman, Ben Mahler, and Joris Van 
Remoortere.


Repository: mesos


Description
---

Added guide to writing highly available Mesos frameworks.


Diffs
-

  docs/app-framework-development-guide.md 
4a43a93d080bdac37b8aee91748fea7552a1cc67 
  docs/high-availability-framework-guide.md PRE-CREATION 
  docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227 
  docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535 

Diff: https://reviews.apache.org/r/41896/diff/


Testing
---

Previewed via site-docker.

Note that there's a lot more that could be said here; also, at some point we 
should probably unify the "reconciliation" page with this page, and perhaps 
move some of the content in the "high-availability" page here (leaving the 
"high-availability" page for the operator-centric parts of configuring Mesos to 
run in HA mode).


Thanks,

Neil Conway

Re: Review Request 39834: Made `path_tests.cpp` standalone.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review112670
---


Bad patch!

Reviews applied: [39621, 39620, 39622, 39623, 39019, 39803]

Failed command: ./support/apply-review.sh -n -r 39803

Error:
 2016-01-04 22:34:07 URL:https://reviews.apache.org/r/39803/diff/raw/ 
[20944/20944] -> "39803.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp:118:
  Lines should be <= 80 characters long  [whitespace/line_length] [2]
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp:68:
  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Total errors found: 1
Checking 4 files

- Mesos ReviewBot


On Jan. 4, 2016, 7:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> ---
> 
> (Updated Jan. 4, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made `path_tests.cpp` standalone.
> 
> NB, more of these tests will move when `Hopcroft` is done with his 
> `os::symlink` changeset.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 821dbb185f09e2f279d95fd354ce2168cddf1bac 
> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112669
---

Ship it!


Ship It!

- Daniel Pravat


On Jan. 4, 2016, 12:02 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 4, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112667
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 94)


Can you use _rmdir() instead to avoid another deprecation warning ?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 127)


Can you use _rmdir() instead to avoid another deprecation warning ?


- Daniel Pravat


On Jan. 4, 2016, 12:02 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Jan. 4, 2016, 12:02 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> e738cdbf5846950c475c159fb9a770acc45159f5 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

[Gilbert Song]

> On Jan. 4, 2016, 2:06 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 
> > 257
> > 
> >
> > Should we also CHECK here fslayers_size() == history size?
> 
> Gilbert Song wrote:
> Actually it is validated spec::v2::parse in getManifest before we call 
> downloadLayers.
> 
> Timothy Chen wrote:
> I know it is, that's why I thought we can have a CHECK as it should be 
> validated.

Gotcha. Thanks for explaining. :)


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/#review112657
---


On Jan. 3, 2016, 10:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41861/
> ---
> 
> (Updated Jan. 3, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.
> 
> According to Docker v2 image manifest spec, v1Compatibility is a string 
> containing a raw JSON object. The raw JSON object is v1::ImageManifest. This 
> patch fixed the bug in the original code.
> 
> 
> Diffs
> -
> 
>   src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41861/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

[Timothy Chen]

> On Jan. 4, 2016, 10:06 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 
> > 257
> > 
> >
> > Should we also CHECK here fslayers_size() == history size?
> 
> Gilbert Song wrote:
> Actually it is validated spec::v2::parse in getManifest before we call 
> downloadLayers.

I know it is, that's why I thought we can have a CHECK as it should be 
validated.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/#review112657
---


On Jan. 3, 2016, 6:33 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41861/
> ---
> 
> (Updated Jan. 3, 2016, 6:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.
> 
> According to Docker v2 image manifest spec, v1Compatibility is a string 
> containing a raw JSON object. The raw JSON object is v1::ImageManifest. This 
> patch fixed the bug in the original code.
> 
> 
> Diffs
> -
> 
>   src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41861/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

[Gilbert Song]

> On Jan. 4, 2016, 2:06 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 
> > 257
> > 
> >
> > Should we also CHECK here fslayers_size() == history size?

Actually it is validated spec::v2::parse in getManifest before we call 
downloadLayers.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41861/#review112657
---


On Jan. 3, 2016, 10:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41861/
> ---
> 
> (Updated Jan. 3, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.
> 
> According to Docker v2 image manifest spec, v1Compatibility is a string 
> containing a raw JSON object. The raw JSON object is v1::ImageManifest. This 
> patch fixed the bug in the original code.
> 
> 
> Diffs
> -
> 
>   src/docker/spec.cpp 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/docker/v2.proto fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 049d46cad5cf94a3fb5d74cbfe649850311d35ad 
>   src/tests/containerizer/docker_spec_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 
> 
> Diff: https://reviews.apache.org/r/41861/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review112661
---



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 (line 30)


This well documented here: 
https://msdn.microsoft.com/en-us/library/cc232007.aspx


- Daniel Pravat


On Jan. 4, 2016, 11:46 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> ---
> 
> (Updated Jan. 4, 2016, 11:46 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
>  PRE-CREATION 
>   
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
> 5b38b9af654d7d1c574f0cc573083b66693ced1d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd 
> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 41888: Fix sandbox browse UI has path which is not selectable.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41888/#review112660
---


Patch looks great!

Reviews applied: [41888]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 6:07 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41888/
> ---
> 
> (Updated Jan. 4, 2016, 6:07 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-1976
> https://issues.apache.org/jira/browse/MESOS-1976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix sandbox browse UI has path which is not selectable.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/browse.html 
> 6b180569183086fe2debefa26d503015a42c253a 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41888/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41881: Provided constexpr Duration min and max values.

[Joris Van Remoortere]

> On Jan. 4, 2016, 6:26 p.m., Joris Van Remoortere wrote:
> > Looks good. How did you choose the particular functions to make constexpr. 
> > Why not the units for example? or others?
> 
> Benjamin Bannier wrote:
> The goal was to provide `constexpr` versions of `Duration::min`, 
> `Duration::max`, and `Duration::zero`. The latter requires a `constexpr` 
> default ctr for `Duration`, the two former ones `constexpr` ctrs for both 
> `NanoSeconds` and for `Duration(int64_t, int64_t)`. For consistency I made 
> most ctrs `constexpr`.
> 
> What do you mean by units here?

For example:
`static std::string units() { return "hrs"; }`


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41881/#review112609
---


On Jan. 4, 2016, 6:43 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41881/
> ---
> 
> (Updated Jan. 4, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Till Toenshoff, and Jiang Yan 
> Xu.
> 
> 
> Bugs: MESOS-4277
> https://issues.apache.org/jira/browse/MESOS-4277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For that we need to provide a constexpr constructor for Nanoseconds at
> least; make all constructors of Duration types constexpr if possible.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> dc610e697032f0d5d9c7a6524aeb34984041dec7 
> 
> Diff: https://reviews.apache.org/r/41881/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>