Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/#review115008 --- Patch looks great! Reviews applied: [42246] Passed command:

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/ --- (Updated Jan. 18, 2016, 10:19 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote: > > @Joseph/Vinod, would you help to review those patches move executor from > > slave to master? > > Joseph Wu wrote: > There are still several open issues open on each prior review. Can you > go through and make sure those are addressed? >

Re: Review Request 42140: Removed deprecated constructor of http::Unauthorized in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42140/#review115001 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Review Request 42457: Improved rakefile to allow for external .md file links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42457/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-4384

Re: Review Request 42458: Made links to .md files consistent across documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/ --- (Updated Jan. 18, 2016, 1:36 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review115003 --- Patch looks great! Reviews applied: [42247] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 18, 2016, 2:09 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114988 --- Ship it! Worked perfectly fine in my tests. Let's fix the nits

Re: Review Request 42347: Fixed broken link in scheduler-http-api.md and added anchor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42347/ --- (Updated Jan. 18, 2016, 3:29 p.m.) Review request for mesos and Bernd

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 18, 2016, 8:22 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 18, 2016, 8:14 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- (Updated Jan. 18, 2016, 8:13 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:32 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:33 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

> On Jan. 6, 2016, 10:09 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051 > > > > > > Does anything rely on this behavior of erasing 1.0s from the hashmap? I > > know it'll

Re: Review Request 42379: Add reverse_foreach in libprocess.

Added reverse adaptor: https://reviews.apache.org/r/42450 https://reviews.apache.org/r/42451 Ben, do you think it makes sense to add the above? - Jie On Sat, Jan 16, 2016 at 12:33 PM, Jie Yu wrote: > Maybe include boost::adaptor into stout under namespace adaptor? I

Re: Review Request 42451: Updated libprocess for the new adaptor::reverse in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42451/#review114964 --- Bad patch! Reviews applied: [42450, 42451] Failed command:

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review114966 --- src/tests/hierarchical_allocator_tests.cpp (line 2093)

Review Request 42450: Added adaptor::reverse to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42450/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos

Review Request 42451: Updated libprocess for the new adaptor::reverse in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42451/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Jan. 11, 2016, 10:13 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2218-2219 > > > > > > Why hardcode 3? I'd think you could just run a while loop and actually > > assert the size

Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4329

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Jan. 18, 2016, 8:29 a.m., Neil Conway wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2096-2101 > > > > > > I think we should make `i` an `int`, not `unsigned` -- unless we depend > > on the

Re: Review Request 42027: Changed HTTP responses from Unauthorized (401) to Forbidden (403).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/ --- (Updated Jan. 18, 2016, 11:52 a.m.) Review request for mesos, Alexander

Re: Review Request 42140: Removed deprecated constructor of http::Unauthorized in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42140/ --- (Updated Jan. 18, 2016, 11:53 a.m.) Review request for mesos, Benjamin

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:53 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 18, 2016, 8:54 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review114979 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Re: Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review114980 --- include/mesos/mesos.proto (line 241)

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review114974 --- Patch looks great! Reviews applied: [42235, 41961, 42236, 42237,

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

> On Jan. 18, 2016, 8:26 a.m., Till Toenshoff wrote: > > src/tests/fetcher_cache_tests.cpp, line 842 > > > > > > Given that pause() and resume() will always be used on the same thread, > > we dont have a race here

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review115038 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review114983 --- Ship it! Ship It! - Jan Schlicht On Jan. 18, 2016, 11:42 a.m.,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114994 --- src/tests/hook_tests.cpp (lines 396 - 399)

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/ --- (Updated Jan. 18, 2016, 12:14 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/ --- (Updated Jan. 18, 2016, 3:28 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 42255: Updated user documentation around HTTP response codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42255/ --- (Updated Jan. 18, 2016, 11:46 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 42246: Fixed support for non-HDFS URIs by Hadoop client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42246/ --- (Updated Jan. 18, 2016, 3:20 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review114999 --- Ship it! Ship It! - Alexander Rojas On Jan. 18, 2016, 12:28

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 一月 18, 2016, 4:03 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42458: Made links to .md files consistent across documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/#review115016 --- Bad patch! Reviews applied: [42457, 42458] Failed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 一月 18, 2016, 11:49 a.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, lines 396-399 > > > > > > Why do you need a loop here? Isn't it enought to advance once and then > > settle? Right...there is

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote: > > src/tests/hook_tests.cpp, line 389 > > > > > > If hookFuture never becomes ready that this blocks forever right? > > AWAIT_READY has a timeout built in, and

Re: Review Request 42255: Updated user documentation around HTTP response codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42255/#review115014 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 18, 2016, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/#review115023 --- Bad patch! Reviews applied: [41302, 41305] Failed command:

Re: Review Request 42457: Improved rakefile to allow for external .md file links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42457/#review115048 --- Ship it! Ship It! - Neil Conway On Jan. 18, 2016, 1:20 p.m.,

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Jan. 18, 2016, 8:29 a.m., Neil Conway wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2096-2101 > > > > > > I think we should make `i` an `int`, not `unsigned` -- unless we depend > > on the

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review115056 --- Patch looks great! Reviews applied: [42197] Passed command:

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

> On Jan. 18, 2016, 4:26 p.m., Till Toenshoff wrote: > > src/tests/fetcher_cache_tests.cpp, line 837 > > > > > > Lets either remove the brackets, making this an equally important > > comment, OR remove the second

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/#review115076 --- Ship it! Ship It! - Timothy Chen On Jan. 17, 2016, 9:50 p.m.,

Re: Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/#review115079 --- Patch looks great! Reviews applied: [42265] Passed command:

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/#review115094 --- Patch looks great! Reviews applied: [42379, 42389] Passed

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 18, 2016, 11:37 p.m.) Review request for mesos, Ben Mahler,

Review Request 42477: Corrected example in quota user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42477/ --- Review request for mesos, Joerg Schad and Joris Van Remoortere. Repository:

Re: Review Request 42183: Introduced HttpEvent based filters in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42183/ --- (Updated Jan. 19, 2016, 2:10 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115092 --- Patch looks great! Reviews applied: [42477, 42476] Passed

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 993 > > > > > > Can you pull this out into an entirely separate (not part of this > > review chain) review? > >

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/ --- (Updated Jan. 19, 2016, 12:10 a.m.) Review request for mesos, haosdent huang

Review Request 42478: Added missing `json` function for `ContainerStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42478/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-4238

Review Request 42481: Fixed a typo in the comments of parseImageReference().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42481/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41302/ --- (Updated Jan. 19, 2016, 10:56 a.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 42478: Added missing `json` function for `ContainerStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42478/#review115098 --- Patch looks great! Reviews applied: [42478] Passed command:

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/ --- (Updated Jan. 19, 2016, 10:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42358: Logger Module: Refactored Sandbox logger initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42358/#review115097 --- Ship it! I'll fix these up and commit, thanks!

Re: Review Request 42478: Added missing `json` function for `ContainerStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42478/#review115099 --- Ship it! Ship It! - Benjamin Hindman On Jan. 19, 2016, 12:17

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- (Updated Jan. 19, 2016, 3:20 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

> On Jan. 18, 2016, 10:41 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 911-914 > > > > > > I think you can use cgroups::processes here (see src/linux/cgroups.hpp) Didn't know

Re: Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review115103 --- Patch looks great! Reviews applied: [42415] Passed command:

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/ --- (Updated Jan. 19, 2016, 10:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/ --- (Updated Jan. 19, 2016, 10:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42374: Logger Module: Add test filter for tests requiring `logrotate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42374/#review115100 --- Ship it! src/tests/environment.cpp (line 365)

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/ --- (Updated Jan. 19, 2016, 3:23 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42458: Made links to .md files consistent across documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/ --- (Updated Jan. 19, 2016, 7:52 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review115059 --- Patch looks great! Reviews applied: [42149] Passed command:

Re: Review Request 41952: Added recommendations for programming with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41952/ --- (Updated Jan. 18, 2016, 10:18 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115064 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/#review115065 --- Ship it! src/tests/containerizer/isolator_tests.cpp (line 834)

Re: Review Request 42451: Updated libprocess for the new adaptor::reverse in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42451/#review115075 --- Ship it! Ship It! - Timothy Chen On Jan. 18, 2016, 8 a.m., Jie

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115074 --- src/tests/uri_fetcher_tests.cpp (line 216)

Re: Review Request 42444: Added an internet access test filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42444/#review115073 --- Ship it! Ship It! src/tests/environment.cpp (line 299)

Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4380

Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4403

Re: Review Request 42442: Made Docker::create return an Owned object instead of a raw pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42442/#review115069 --- Ship it! Ship It! - Timothy Chen On Jan. 17, 2016, 9:52 p.m.,

Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- Review request for mesos, Ben Mahler, Joerg Schad, and Joris Van Remoortere.

Re: Review Request 41952: Added recommendations for programming with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41952/#review115063 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 18, 2016,

Re: Review Request 42450: Added adaptor::reverse to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42450/#review115067 --- Ship it! Ship It!

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/#review115068 --- Ship it! src/tests/environment.cpp (line 388)

Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4378