Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121604 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/#review121553 --- Fix it, then Ship it! src/CMakeLists.txt (line 248)

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/#review121552 --- Ship it! - Joris Van Remoortere On March 1, 2016, 11:55

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121602 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu.

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 2, 2016, 7:26 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/ --- (Updated March 2, 2016, 7:26 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121598 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121596 --- Ship it! I'm voting ship it, but I do want to call out that I

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121595 --- Ship it! Ship It! - Klaus Ma On March 2, 2016, 2:21 p.m.,

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/ --- (Updated 三月 2, 2016, 6:21 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 6:21 a.m.) Review request for mesos and Joris Van

Re: Review Request 43684: Cleaned up allocator benchmark code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43684/ --- (Updated March 2, 2016, 6:20 a.m.) Review request for mesos, Joris Van

Re: Review Request 43686: Added allocator benchmark using labeled resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43686/ --- (Updated March 2, 2016, 6:20 a.m.) Review request for mesos, Joris Van

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 6:15 a.m.) Review request for mesos, Artem

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/#review121593 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/#review121585 --- Fix it, then Ship it! Thanks! I'll fix the issues for you and

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44250/#review121584 --- Ship it! - Joris Van Remoortere On March 2, 2016, 2:21 a.m.,

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121588 --- src/master/allocator/mesos/hierarchical.cpp (line 1226)

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121587 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44122/#review121583 --- Ship it! Ship It! - Jie Yu On March 2, 2016, 3:39 a.m.,

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121582 --- Ship it! Could you create a jira ticket for this? - haosdent

Re: Review Request 43686: Added allocator benchmark using labeled resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43686/#review121581 --- Fix it, then Ship it!

Re: Review Request 43685: Refactored test helper code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43685/#review121579 --- Ship it! - Joris Van Remoortere On March 2, 2016, 2:20 a.m.,

Re: Review Request 43684: Cleaned up allocator benchmark code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43684/#review121578 --- Fix it, then Ship it!

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 2, 2016, 5:18 a.m.) Review request for mesos, Greg Mann, Guangya

Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Jie Yu.

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/ --- (Updated 三月 2, 2016, 4:59 a.m.) Review request for mesos, Greg Mann, haosdent

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/ --- (Updated March 2, 2016, 4 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/ --- (Updated March 2, 2016, 3:55 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 172 > > > > > > What is this? THe remnants of a merge of two commits, unfortunately.

Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/#review121574 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48 > > > > > > style I'd just like to clarify that I made this line up in `git diff` because it

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/ --- (Updated March 1, 2016, 7:42 p.m.) Review request for mesos, Artem

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44122/ --- (Updated March 1, 2016, 7:39 p.m.) Review request for mesos, Artem

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

> On March 1, 2016, 10:56 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, lines > > 40-43 > > > > > > How is this different from `fts_open` returning null

Review Request 44199: Add .gitattributes file to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44199/ --- Review request for mesos. Repository: mesos Description --- Mesos added

Re: Review Request 44199: Add .gitattributes file to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44199/ --- (Updated March 2, 2016, 10:56 a.m.) Review request for mesos. Bugs:

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/#review121569 --- Ship it! Ship It! - Jie Yu On March 2, 2016, 1:42 a.m.,

Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4833

Re: Review Request 43686: Added allocator benchmark using labeled resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43686/ --- (Updated March 2, 2016, 2:21 a.m.) Review request for mesos, Joris Van

Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44250/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 43685: Refactored test helper code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43685/ --- (Updated March 2, 2016, 2:20 a.m.) Review request for mesos, Joris Van

Re: Review Request 43684: Cleaned up allocator benchmark code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43684/ --- (Updated March 2, 2016, 2:20 a.m.) Review request for mesos, Joris Van

Re: Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/#review121566 --- Patch looks great! Reviews applied: [44236] Passed command:

Re: Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44247/#review121564 --- Ship it! Ship It! - Timothy Chen On March 2, 2016, 1:44

Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44247/ --- Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Repository: mesos

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/ --- (Updated March 1, 2016, 5:42 p.m.) Review request for mesos, Artem

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

> On March 2, 2016, 1:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/docker.cpp, lines 585-586 > > > > > > It would be a slightly stronger check if you include this as well: > > ``` > >

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/ --- (Updated March 2, 2016, 1:11 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44196/ --- (Updated March 1, 2016, 5:11 p.m.) Review request for mesos, Artem

Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44243/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-4712

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/ --- (Updated March 2, 2016, 1:09 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

> On March 1, 2016, 10:32 p.m., Anand Mazumdar wrote: > > src/internal/devolve.cpp, line 123 > > > > > > Nit: s/but `Call::Subscribe` has// > > > > Since we are inside `devolve` for conversion to

Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44122/ --- (Updated March 1, 2016, 5:08 p.m.) Review request for mesos, Artem

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121561 --- 3rdparty/CMakeLists.txt (line 30)

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/#review121560 --- Ship it! - Alex Clemmer On March 2, 2016, 12:52 a.m., Diana

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ --- (Updated March 2, 2016, 12:52 a.m.) Review request for mesos, Artem

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121535 --- Ship it! Ship It! - Greg Mann On March 1, 2016, 7:47 p.m.,

Re: Review Request 44227: Added AWAIT_READY() call to reservation_endpoint_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44227/#review121557 --- Patch looks great! Reviews applied: [44227] Passed command:

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 2, 2016, 12:41 a.m.) Review request for mesos, Alex Naparu,

Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/#review121554 --- Ship it! Ship It! - Timothy Chen On March 1, 2016, 11:50

Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4834

Re: Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/ --- (Updated March 2, 2016, 8:01 a.m.) Review request for mesos and Joris Van

Review Request 44236: Update slave's version after re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44236/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated March 1, 2016, 11:58 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 1, 2016, 11:56 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated March 1, 2016, 11:54 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > > > > > The second param for strcpy_s is the number of chars to be copied. It > > doesn't seem right

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121543 --- Ship it! Ship It! - Yi Sun On March 1, 2016, 8:58 p.m.,

Re: Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/ --- (Updated March 1, 2016, 11:50 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121540 --- Bad patch! Reviews applied: [44141, 44140] Failed command:

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 --- 3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)

Re: Review Request 44226: Modified tests to remove `Shutdown` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44226/#review121531 --- Patch looks great! Reviews applied: [44222, 44224, 44223, 44225,

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121530 ---

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/#review121518 --- Fix it, then Ship it!

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/#review121519 --- Fix it, then Ship it! verified nothing changed in the posix

Re: Review Request 44231: Added rmdir error string to Appc store fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44231/#review121525 --- Ship it! Ship It! - Jie Yu On March 1, 2016, 10:02 p.m.,

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121516 --- Fix it, then Ship it! LGTM. src/internal/devolve.cpp (line

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/#review121524 --- Ship it! Ship It! - Jie Yu On March 1, 2016, 10:01 p.m.,

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/#review121521 --- Fix it, then Ship it! LGTM. docs/scheduler-http-api.md (line

Review Request 44232: Added a check when umounting persistent volumes in docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/ --- Review request for mesos, Joseph Wu and Timothy Chen. Bugs: MESOS-4832

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44182/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/ --- (Updated March 1, 2016, 10:17 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, > > line 30 > > > > > > remove newline I don't see it. Maybe in the old version

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated March 1, 2016, 10:08 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/ --- (Updated March 1, 2016, 10:07 p.m.) Review request for mesos, Alex Naparu,

Review Request 44231: Added rmdir error string to Appc store fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44231/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 44230: Added FS_DEFAULT case in rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44230/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/#review121508 --- Patch looks great! Reviews applied: [43914, 43915, 44182, 43916]

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated March 1, 2016, 9:42 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/ --- (Updated March 1, 2016, 9:39 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 44112: Updated tests to use /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44112/ --- (Updated March 1, 2016, 9:39 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44111/ --- (Updated March 1, 2016, 9:39 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/ --- (Updated March 1, 2016, 9:38 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121505 --- Fix it, then Ship it! Split the commit.

  1   2   >