Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140479 --- src/slave/containerizer/mesos/launcher.hpp (line 78)

Re: Review Request 49549: Used the launch helper binary to launch user task in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49549/#review140478 --- Bad patch! Reviews applied: [49549, 49548, 49542, 49541, 49540,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140476 --- Patch looks great! Reviews applied: [49464, 49465, 49487, 49488,

Re: Review Request 49544: Made stout::Path default constructible / assignable / copyable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49544/#review140474 --- @Ben, someone will faield to apply this patch as the commit

Re: Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/#review140473 --- Patch looks great! Reviews applied: [49543] Passed command:

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review140472 --- Patch looks great! Reviews applied: [45958, 45959, 48616, 45960,

Re: Review Request 49501: Added cmake target to build mesos-master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/#review140467 --- Ship it! LGTM! Tested this out locally. A couple minor nits

Re: Review Request 49547: Fixed dangerous use of Subprocess::PIPE as default Docker::run IO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49547/#review140471 --- Ship it! Ship It! - Joseph Wu On July 1, 2016, 5:55 p.m.,

Review Request 49549: Used the launch helper binary to launch user task in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49549/ --- Review request for mesos, Gilbert Song, Ian Downes, and Joris Van Remoortere.

Review Request 49548: Added devolve function for CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49548/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-5753

Review Request 49546: Added device support to Docker::run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49546/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 49545: Updated code to use Path::string() instead of Path::value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49545/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 49547: Fixed dangerous use of Subprocess::PIPE as default Docker::run IO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49547/ --- Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos

Review Request 49544: Made stout::Path default constructible / assignable / copyable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49544/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 49501: Added cmake target to build mesos-master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/ --- (Updated July 2, 2016, 12:37 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49518: Initial snapshot for v1 master event stream.

> On July 1, 2016, 7:41 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 595 > > > > > > just capture `http`? Also needed `ok`. - Zhitao --- This is

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 2, 2016, 12:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 2, 2016, 12:19 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review140466 --- Patch looks great! Reviews applied: [48313, 48314, 48315]

Re: Review Request 49390: Added test for container image command task with health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49534: Fixed linux filesystem test recover orphaned persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49534/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 49388: Added devolve method for TaskID and HealthCheck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49388/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49533: Added sleep binary to test rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49533/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, haosdent huang, Artem

Re: Review Request 49532: Fixed unit test os test nonblock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/ --- Review request for mesos, Benjamin Mahler and Artem Harutyunyan. Bugs:

Review Request 49542: Explicitly passed in launcher dir to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49542/ --- Review request for mesos, Gilbert Song, Joris Van Remoortere, and Timothy Chen.

Re: Review Request 49390: Added test for container image command task with health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/#review140463 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 11:34 p.m.,

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/ --- (Updated July 1, 2016, 11:45 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49509: Revised protobuf definition of GetState response.

> On July 1, 2016, 7:22 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto, lines 273-274 > > > > > > move this to GetLeadingMaster. Removed. If we want this in the other call, let's do it in a separate

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/ --- (Updated July 1, 2016, 11:43 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/ --- (Updated July 1, 2016, 11:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 11:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49390: Added test for container image command task with health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/ --- (Updated July 1, 2016, 4:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

> On July 1, 2016, 3:24 p.m., Jie Yu wrote: > > src/launcher/executor.cpp, lines 431-432 > > > > > > Hum, if `_check.isError()`, `checker->healthCheck()` below will abort. > > you should put

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 4:33 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49487: Refactor Master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 1, 2016, 11:32 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49541: Renamed healthCheckDir to launcherDir in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49541/ --- Review request for mesos, Gilbert Song, Joris Van Remoortere, and Timothy Chen.

Review Request 49540: Used the argv version for command that launches the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49540/ --- Review request for mesos, Gilbert Song, Ian Downes, and Vinod Kone. Bugs:

Re: Review Request 49472: Fixed some style issue in stout Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49472/#review140458 --- Ship it! Ship It! - Gilbert Song On June 30, 2016, 1:52

Re: Review Request 49425: Used os::raw::Argv in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49425/#review140457 --- Ship it! Ship It! - Gilbert Song On June 30, 2016, 9:18

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/#review140456 --- Ship it! LGTM! - Gilbert Song On June 30, 2016, 9:18 a.m.,

Re: Review Request 49390: Added test for container image command task with health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/#review140453 --- src/tests/health_check_tests.cpp (line 309)

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/ --- (Updated July 1, 2016, 10:32 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review140452 --- Patch looks great! Reviews applied: [49520] Passed command:

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated July 1, 2016, 10:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49472: Fixed some style issue in stout Makefile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49472/#review140450 --- Ship it! Ship It! - Joris Van Remoortere On June 30, 2016,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 457-467 > > > > > > For this we need to > > > > 1. Run existing benchmarks to see how much

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 1, 2016, 10:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated July 1, 2016, 10:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated July 1, 2016, 10:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/#review140444 --- Fix it, then Ship it! src/health-check/health_checker.hpp

Re: Review Request 49532: Fixed unit test os test nonblock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/#review140446 --- Ship it! Ship It! - Joris Van Remoortere On July 1, 2016,

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/#review140445 --- Ship it! Ship It! - Kapil Arya On June 30, 2016, 7:54 p.m.,

Re: Review Request 49533: Added sleep binary to test rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49533/#review140441 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49534: Fixed linux filesystem test recover orphaned persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49534/#review140442 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49388: Added devolve method for TaskID and HealthCheck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49388/#review140443 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 23, 2016, 5:35 p.m., Jiang Yan Xu wrote: > > src/slave/state.hpp, line 271 > > > > > > It looks a bit odd that we are explicitly initiating `target` but not > > `resources`. > > > > Note that

Re: Review Request 49532: Fixed unit test os test nonblock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/#review140440 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Review Request 49533: Added sleep binary to test rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49533/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and

Review Request 49534: Fixed linux filesystem test recover orphaned persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49534/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 2:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49390: Added test for container image command task with health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/ --- (Updated July 1, 2016, 2:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49388: Added devolve method for TaskID and HealthCheck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49388/ --- (Updated July 1, 2016, 2:54 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49532: Fixed unit test os test nonblock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, and

Re: Review Request 49531: Added 'systemGetDriverVersion' to NVML abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49531/#review140438 --- Ship it! Ship It! - Benjamin Mahler On July 1, 2016, 9:41

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

> On July 1, 2016, 7:30 a.m., Guangya Liu wrote: > > I think that this patch should be created after the function patches > > finished. @gyliu I have merged runtime implementation to here and moving the testing to another patch. - Srinivas

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 1, 2016, 9:44 p.m.) Review request for mesos. Summary

Review Request 49531: Added 'systemGetDriverVersion' to NVML abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49531/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5765

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated July 1, 2016, 9:41 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 23, 2016, 10:30 a.m., Neil Conway wrote: > > Can you write a unit test that verifies the main functional change in this > > review? That is, if the user attempts to create a persistent volume on a > > path that already contains files, the creation fails and the slave exits > > with

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 20, 2016, 5:16 p.m., Jiang Yan Xu wrote: > > In terms of testing, if we don't crash the agent within > > `syncCheckpointedResources()` but rather return a failure when its fails > > during recovery, we can capture this in `Slave::__recover` and verify the > > failed future right? >

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 1, 2016, 9:39 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 49415: Removed the argv parameter in command executor helper.

> On July 1, 2016, 2:33 p.m., Gilbert Song wrote: > > Do you miss `windows/executor.hpp`? Fix it, Ship it! :) - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49415/#review140433

Re: Review Request 49415: Removed the argv parameter in command executor helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49415/#review140433 --- Ship it! Do you miss `windows/executor.hpp`? - Gilbert Song

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/#review140432 --- Ship it! Ship It! - Joris Van Remoortere On July 1, 2016,

Re: Review Request 49524: Fixed a const ref issue in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/#review140431 --- Ship it! Ship It! - Joris Van Remoortere On July 1, 2016,

Re: Review Request 49530: Added 'nvidia-uvm-tools' as optional control device for Nvidia GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49530/#review140424 --- Ship it!

Re: Review Request 49524: Fixed a const ref issue in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/#review140428 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 11:02

Re: Review Request 49469: Added new utility function, `frameworkHasCapability()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49469/#review140427 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 10:59 a.m.,

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/#review140426 --- Patch looks great! Reviews applied: [49415, 49424, 49425, 49472,

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49446/ --- (Updated July 1, 2016, 8:20 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

> On June 30, 2016, 10:21 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 2813 > > > > > > Can we have an explicit defensive check here to ensure `result` does > > not have error set? > > > >

Review Request 49530: Added 'nvidia-uvm-tools' as optional control device for Nvidia GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49530/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5764

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/ --- (Updated July 1, 2016, 8:13 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49445/ --- (Updated July 1, 2016, 8:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

> On June 30, 2016, 9:45 p.m., Anand Mazumdar wrote: > > src/files/files.cpp, lines 104-106 > > > > > > See my earlier comments in the header file about this function and then > > modify this. If changed to

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

> On June 30, 2016, 9:45 p.m., Anand Mazumdar wrote: > > src/files/files.hpp, lines 103-105 > > > > > > hmm, wondering why is the return type a `std::map`. Why can't it be > > just a `std::list` of `FileInfo` with

Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49444/ --- (Updated July 1, 2016, 7:53 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49529: Remove jsonFileInfo implementation from files.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49529/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod

Re: Review Request 49443: Include a function to construct FileInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49443/ --- (Updated July 1, 2016, 7:49 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140416 --- include/mesos/master/master.proto (line 446)

Re: Review Request 49517: Implement GetState V1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140412 --- src/master/http.cpp (line 1428)

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140411 --- src/master/http.cpp (line 1428)

Re: Review Request 49509: Revised protobuf definition of GetState response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140409 --- include/mesos/master/master.proto (lines 273 - 274)

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140406 --- src/master/http.cpp (lines 1336 - 1339)

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140404 --- src/master/http.cpp (lines 1964 - 1967)

Re: Review Request 49487: Refactor master::Http::getTasks into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/#review140402 --- src/master/http.cpp (lines 3335 - 3336)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140403 --- Bad patch! Reviews applied: [49518, 49517, 49516, 49509, 49489,

Re: Review Request 49500: Moved TODO to correct place in master/http.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49500/#review140401 --- src/master/http.cpp (lines 3102 - 3139)

  1   2   >