Re: Review Request 50088: Added mesos-protobuf target to build protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50088/#review142694 --- Patch looks great! Reviews applied: [50088] Passed command:

Review Request 50179: Added mesos-logrotate-logger utility executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/ --- (Updated 七月 19, 2016, 3:35 a.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142689 --- Patch looks great! Reviews applied: [50002, 50003] Passed

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/#review142684 --- src/tests/sorter_tests.cpp (lines 504 - 506)

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/#review142683 --- Ship it! Ship It! - Benjamin Mahler On July 18, 2016, 10:16

Re: Review Request 43471: Added the zookeeper patch for the slow add_auth calls.

> On July 18, 2016, 9:05 p.m., Benjamin Mahler wrote: > > Thanks for tracking down the slowness issue. > > > > I'm a bit hesitant to pull in this patch without it being upstreamed yet. > > Have you tried asking on their mailing list if they can pick it back up? Yes, I sent to

Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 50163: Fixed a memory lifetime issue in LibeventSSLSocketImp::send.

> On July 18, 2016, 10:01 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, line 715 > > > > > > Let's pull out the side-effect and feed it to the check. In retrospect it seems

Re: Review Request 50163: Fixed a memory lifetime issue in LibeventSSLSocketImp::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50163/#review142677 --- Patch looks great! Reviews applied: [50163] Passed command:

Re: Review Request 50177: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50177/ --- (Updated July 19, 2016, 1:14 a.m.) Review request for mesos, David Robinson

Review Request 50177: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50177/ --- Review request for mesos, David Robinson and Ian Downes. Repository: mesos

Re: Review Request 49892: Removed unnecessary await from test.

> On July 12, 2016, 12:08 a.m., Vinod Kone wrote: > > ping? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review141806

Re: Review Request 50114: Added missing tables attributes in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50114/#review142675 --- Ship it! Ship It! - Vinod Kone On July 17, 2016, 9:26 p.m.,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142674 --- Ship it! This change looks ok to me and indepdendent of the

Re: Review Request 50072: Set allocation interval in 'Master Flags' for operator API reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/#review142673 --- src/tests/api_tests.cpp (lines 946 - 1041)

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/#review142672 --- src/tests/mesos.hpp (lines 610 - 615)

Re: Review Request 50078: Cleaned the arguments passed to health checker in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50078/#review142671 --- Ship it! Ship It! - Vinod Kone On July 18, 2016, 3:26 p.m.,

Re: Review Request 50062: Updated makePortRanges for variable types.

> On July 18, 2016, 7:07 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 85-114 > > > > > > Looks like we can simplify this like we did in sorter_tests? > > > > ``` > >

Re: Review Request 50162: Ignored /etc/hosts if it does not exist in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50162/#review142663 --- Ship it! Ship It! - Qian Zhang On July 19, 2016, 5:58 a.m.,

Re: Review Request 50088: Added mesos-protobuf target to build protobuf libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50088/ --- (Updated July 18, 2016, 10:59 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50062: Updated makePortRanges for variable types.

> On 七月 18, 2016, 7:07 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 85-114 > > > > > > Looks like we can simplify this like we did in sorter_tests? > > > > ``` > >

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 18, 2016, 10:30 p.m., Greg Mann wrote: > > src/tests/test_framework_test.sh, line 24 > > > > > > I see what you mean about the failure of these `atexit` statements - I > > also see lots of litter in my

Re: Review Request 49602: Removed a not-useful log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49602/#review142651 --- Ship it! Ship It! - Greg Mann On July 18, 2016, 5:53 p.m.,

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/ --- (Updated 七月 18, 2016, 10:16 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50163: Fixed a memory lifetime issue in LibeventSSLSocketImp::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50163/#review142646 --- Fix it, then Ship it!

Re: Review Request 50162: Ignored /etc/hosts if it does not exist in CNI isolator.

> On July 18, 2016, 9:47 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1465 > > > > > > shouldn't we just do > > if (flags.etc_hosts_path.isSome()) { > >

Re: Review Request 50162: Ignored /etc/hosts if it does not exist in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50162/#review142645 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Review Request 50163: Fixed a memory lifetime issue in LibeventSSLSocketImp::send.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50163/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository:

Review Request 50162: Ignored /etc/hosts if it does not exist in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50162/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-5806

Re: Review Request 50147: Simplified the checkpointed resources handling logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50147/#review142640 --- Patch looks great! Reviews applied: [50147] Passed command:

Re: Review Request 43477: Sped up GroupTest.* test cases by advance clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/#review142639 --- Can you reach out to see if Jiang Yan Xu to review this? -

Re: Review Request 43474: Sped up MasterDetectorExpireSlaveZKSession by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43474/#review142637 --- Can you reach out to see if Jiang Yan Xu to review this? -

Re: Review Request 43475: Sped up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43475/#review142638 --- Can you reach out to see if Jiang Yan Xu to review this? -

Re: Review Request 43473: Sped up ContenderDetectorShutdownNetwork by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43473/#review142636 --- Can you reach out to see if Jiang Yan Xu to review this? He wrote

Re: Review Request 43472: Sped up ZooKeeperTest.LeaderContender by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43472/#review142635 --- Can you reach out to see if Jiang Yan Xu to review this? He wrote

Re: Review Request 49843: Added benchmark test for sorter.

> On July 14, 2016, 7:14 p.m., Benjamin Mahler wrote: > > src/tests/sorter_tests.cpp, lines 504-542 > > > > > > It looks like we can simplify these two functions down to the following > > single function? > >

Re: Review Request 50138: Synced up common/values.cpp and v1/values.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50138/#review142620 --- Ship it! Thanks for doing this :) - Joseph Wu On July 18,

Re: Review Request 50138: Synced up common/values.cpp and v1/values.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50138/#review142615 --- Patch looks great! Reviews applied: [50138] Passed command:

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On July 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50117: Added more elapse time for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50117/#review142611 --- Ship it! Nice patch, thanks! - Benjamin Mahler On July 18,

Re: Review Request 50080: Updated Windows build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50080/ --- (Updated July 18, 2016, 12:14 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/#review142608 --- src/tests/hierarchical_allocator_tests.cpp (lines 3325 - 3326)

Re: Review Request 50062: Updated makePortRanges for variable types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/#review142607 --- src/tests/hierarchical_allocator_tests.cpp (lines 85 - 114)

Re: Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50060/#review142605 --- Ship it! Ship It! - Benjamin Mahler On July 15, 2016, 2:27

Re: Review Request 50147: Simplified the checkpointed resources handling logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50147/#review142591 --- Fix it, then Ship it! src/slave/slave.cpp (line 2599)

Re: Review Request 49602: Removed a not-useful log message.

> On July 15, 2016, 4:26 p.m., Greg Mann wrote: > > Neil I agree - not useful logging information :-) Shall we just remove it > > instead? > > Anand Mazumdar wrote: > +1 to killing the log message. Sounds good, updated the review. - Neil

Re: Review Request 49602: Removed a not-useful log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49602/ --- (Updated July 18, 2016, 5:53 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 50147: Simplified the checkpointed resources handling logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50147/ --- (Updated July 18, 2016, 10:42 a.m.) Review request for mesos, Anindya Sinha

Review Request 50147: Simplified the checkpoint resources handling logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50147/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-5448

Re: Review Request 50147: Simplified the checkpointed resources handling logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50147/ --- (Updated July 18, 2016, 10:40 a.m.) Review request for mesos, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations and shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review142584 --- Patch looks great! Reviews applied: [45959, 48616, 45960, 45961,

Re: Review Request 50145: Updated the 1.0.0 CHANGELOG for a bug fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50145/#review142583 --- Ship it! Ship It! - Vinod Kone On July 18, 2016, 4:50 p.m.,

Review Request 50145: Updated the 1.0.0 CHANGELOG for a bug fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50145/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50138: Synced up common/values.cpp and v1/values.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50138/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository:

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated July 18, 2016, 2:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 48616: Add v1 changes for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 18, 2016, 2:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 18, 2016, 2:29 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50017: WIP: Validated the resources when parsing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- (Updated 七月 18, 2016, 2:24 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50128: Added Parse() and Serialize() to Docker::Device.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review142543 --- Patch looks great! Reviews applied: [50123, 50124, 50125, 50126,

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- (Updated 七月 18, 2016, 10:13 a.m.) Review request for mesos, Benjamin Mahler

Review Request 50128: Added Parse() and Serialize() to Docker::Device.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Review Request 50126: Fixed tests interfaces for GPU docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50126/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Review Request 50125: Added mesos-docker-executor support for '--device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Review Request 50124: Added '--device' flag to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50124/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Review Request 50123: Added GPU scheduler for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. Bugs:

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142538 --- Bad patch! Reviews applied: [49914, 50072, 49913] Failed

Re: Review Request 50019: Ensured that framework IDs are quoted consistency in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50019/#review142536 --- Ship it! Ship It! - Till Toenshoff On July 14, 2016, 7:58

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 18, 2016, 8:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 18, 2016, 8:19 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50072: Set allocation interval in 'Master Flags' for operator API reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/ --- (Updated July 18, 2016, 8:16 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 18, 2016, 8:11 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50117: Added more elapse time for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50117/#review142535 --- Patch looks great! Reviews applied: [49943, 49781, 50060, 50061,