Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148462 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 7:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > prob

Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/#review148459 --- src/tests/environment.cpp (line 594)

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > pro

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 12, 2016, 3:09 a.m., Qian Zhang wrote: > > I think this patch is mainly for handling the case that agent is restarted > > with more cgroups subsystems enabled, but what if the agent is restarted > > with less cgroups subsystems enabled? In this case, it seems we may miss to > > dest

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 12, 2016, 4:57 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > >

Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/ --- (Updated Sept. 12, 2016, 4:48 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51790: Refactored the test cases for perf_event cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51790/ --- (Updated Sept. 12, 2016, 4:47 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51789: Refactored the test cases for net_cls cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51789/ --- (Updated Sept. 12, 2016, 4:47 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51788: Refactored mem isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51788/ --- (Updated Sept. 12, 2016, 4:47 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 51794: Updated `ROOT_CGROUPS_CFS_Big_Quota` to test a CFS quota with decimal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Re: Review Request 51787: Refactored cpu isolator associated test cases.

> On Sept. 12, 2016, 4:27 a.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, line 481 > > > > > > Good call removing `TEST_F(LimitedCpuIsolatorTest, > > ROOT_CGROUPS_CFS_Big_Quota)`. > >

Re: Review Request 51787: Refactored cpu isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51787/ --- (Updated Sept. 12, 2016, 4:45 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

> On Sept. 12, 2016, 4:03 a.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, lines 97-98 > > > > > > ``` > > vector subsystems = { > > CGROUP_SUBSYSTEM_CPU_NAME, > > CGROUP_SUB

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

> On Sept. 11, 2016, 2:28 p.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > I would suggest to still use test fixture name rather than test name to > > do the filter, please see my comment

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 12, 2016, 4:32 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51787: Refactored cpu isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51787/#review148451 --- Fix it, then Ship it! src/tests/containerizer/cgroups_isolator

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148450 --- src/tests/containerizer/cgroups_isolator_tests.cpp (line 89)

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148441 --- Fix it, then Ship it! Thanks for the cleanup! src/tests/conta

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148449 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/#review148448 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 3:59 p.m., hao

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/#review148446 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 3:59 p.m., hao

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/#review148447 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 3:59 p.m., hao

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/#review148445 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 3:59 p.m., hao

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review148444 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 4 p.m., haosde

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/#review148443 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 4 p.m., haosde

Re: Review Request 51782: Entered working directory before switch user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51782/#review148442 --- Ship it! Ship It! - Jie Yu On Sept. 11, 2016, 4:01 p.m., hao

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148440 --- I think this patch is mainly for handling the case that agent is r

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 7:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > > t

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 12, 2016, 2:49 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/ --- (Updated Sept. 12, 2016, 2:49 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51790: Refactored the test cases for perf_event cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51790/ --- (Updated Sept. 12, 2016, 2:49 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51789: Refactored the test cases for net_cls cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51789/ --- (Updated Sept. 12, 2016, 2:49 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51493: Add the query parameter in createRequest.

> On 九月 11, 2016, 5:26 p.m., haosdent huang wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 845 > > > > > > I think use `hashmap` as type here would be better? Thank haosdent for your comments, to keep

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/ --- (Updated Sept. 11, 2016, 5:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

> On Sept. 11, 2016, 4:44 p.m., Jie Yu wrote: > > Can you follow up with a patch in upgrades.md and CHANGELOG to call out > > this change? Already have a local patch, just need to create a JIRA. Will post soon. Thanks. - Gilbert --- Th

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

> On Sept. 6, 2016, 11:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 333 > > > > > > Any reason not use a 'vector'? IN fact, why not use hashset here? - Jie ---

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/#review148435 --- Fix it, then Ship it! Can you follow up with a patch in upgrade

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/ --- (Updated Sept. 11, 2016, 3:10 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/ --- (Updated Sept. 11, 2016, 8:17 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/#review148432 --- Bad patch! Reviews applied: [45492, 45491, 45874] Failed command

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/ --- (Updated Sept. 11, 2016, 12:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/ --- (Updated Sept. 11, 2016, 6:53 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/ --- (Updated Sept. 11, 2016, 6:51 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51786: Fixed Typo in subprocess.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51786/#review148430 --- Patch looks great! Reviews applied: [51786] Passed command: expo

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 5:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/#review148429 --- Fix it, then Ship it! Ship It! src/common/protobuf_utils.hpp

Re: Review Request 51493: Add the query parameter in createRequest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51493/#review148428 --- 3rdparty/libprocess/include/process/http.hpp (line 845)

Re: Review Request 51774: Implement AGENT_ADDED and AGENT_REMOVED events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review148427 --- Ship it! Ship It! - haosdent huang On Sept. 9, 2016, 10:26 p

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 7, 2016, 6:08 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 353-358 > > > > > > After moved these code, I think we may not need this method > > `CgroupsIso

Re: Review Request 51790: Refactored the test cases for perf_event cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51790/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51788: Refactored mem isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51788/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51789: Refactored the test cases for net_cls cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51789/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51787: Refactored cpu isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51787/ --- (Updated Sept. 11, 2016, 4:45 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > >

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

> On Sept. 11, 2016, 2:22 p.m., Qian Zhang wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, line 91 > > > > > > The test name `ROOT_CGROUPS_PERF_NET_CLS_UserCgroup` seems a bit weird > > to me, if we fo

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

> On Sept. 5, 2016, 10:48 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 197-212 > > > > > > I'd suggest we create a new file: > > ``` > > src/tests/containerizer/cpu_isolator_test

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 4:04 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 51789: Refactored the test cases for net_cls cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51789/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 51790: Refactored the test cases for perf_event cgroups isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51790/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 51788: Refactored mem isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51788/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Review Request 51787: Refactored cpu isolator associated test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51787/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository: mes

Re: Review Request 51782: Entered working directory before switch user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51782/ --- (Updated Sept. 11, 2016, 4:01 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 11, 2016, 4:01 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/ --- (Updated Sept. 11, 2016, 4 p.m.) Review request for mesos, Gilbert Song, Jie Yu

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Sept. 11, 2016, 4 p.m.) Review request for mesos, Gilbert Song, Jie Yu

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Sept. 11, 2016, 3:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Sept. 11, 2016, 3:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Sept. 11, 2016, 3:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Sept. 11, 2016, 3:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Sept. 11, 2016, 3:58 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 51786: Fixed Typo in subprocess.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51786/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Sept. 11, 2016, 2:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Sept. 11, 2016, 2:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 2:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Sept. 11, 2016, 2:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Sept. 11, 2016, 2:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 11, 2016, 2:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51782: Entered working directory before switch user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51782/ --- (Updated Sept. 11, 2016, 2:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Sept. 11, 2016, 2:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/ --- (Updated Sept. 11, 2016, 2:57 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Sept. 11, 2016, 2:56 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50758/ --- (Updated Sept. 11, 2016, 2:56 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/#review148421 --- src/tests/environment.cpp (line 438)

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148420 --- src/tests/containerizer/cgroups_isolator_tests.cpp (line 91)

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:22 p.m., Qian Zhang wrote: > > Can you please add a test for this? `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PERF_RollForward` have covered this. - haosdent --- This is an automatically generated e-mail.

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > pro

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51781/ --- (Updated Sept. 11, 2016, 10:30 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 51782: Entered working directory before switch user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51782/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

  1   2   >