Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/#review151916 --- Patch looks great! Reviews applied: [52597, 52596] Passed

Re: Review Request 52544: Introduced `FileDesc` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Oct. 8, 2016, 4:13 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52644: Fixed an incorrect comment for `AGENT_ADDED` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52644/#review151914 --- Patch looks great! Reviews applied: [52644] Passed command:

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/#review151909 --- Fix it, then Ship it! I would fix these while committing.

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On 十月 7, 2016, 7:31 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 3042-3053 > > > > > > It looks like we should just perform this portion > > (`superset.contains(subset)`) of the

Re: Review Request 52644: Fixed an incorrect comment for `AGENT_ADDED` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52644/#review151912 --- Ship it! Ship It! - Anand Mazumdar On Oct. 7, 2016, 6:32

Re: Review Request 52242: Refactored the test case `ROOT_CGROUPS_PERF_RollForward`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52242/#review151911 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2016, 8:22 p.m.,

Re: Review Request 52642: Improved the validation of RESERVE operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review151906 --- Patch looks great! Reviews applied: [52642] Passed command:

Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6329

Review Request 52658: Changed scheduler driver to send TASK_DROPPED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52658/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6331

Review Request 52657: Clarified a comment that occurs in several tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52657/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 52656: Cleaned up a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52656/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review151899 --- Patch looks great! Reviews applied: [52637, 52638, 52639]

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

> On 十月 7, 2016, 7:31 p.m., Benjamin Mahler wrote: > > Thanks looks pretty good! Just a few suggestions for simplifying things a > > bit below. > > > > Also, 42 seconds for these seems too long for a benchmark test, can you > > reduce it to be no more than a few seconds to run these? Sure, I

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review151890 --- Thanks Ilya. Looks pretty good! - Mostly minor comments around

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

> On Sept. 23, 2016, 6:42 p.m., Joseph Wu wrote: > > It's a bit odd that this function signature has a double. We should > > investigate why and decided whether or not we should change the interface > > to `uint64_t`. I double checked where we use the multiplication/division operators for

Re: Review Request 52651: Fixed agent to correctly handle kill task of unregistered executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52651/#review151893 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 10:08 p.m.,

Re: Review Request 52647: Fix new errors/warnings produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review151891 --- Mostly looks great, although it would be nice if we could

Review Request 52652: Changed Bytes operators to take unsigned integers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52652/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Michael Park.

Review Request 52653: Modified a test to use the updated Bytes operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52653/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Michael Park.

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review151886 --- 3rdparty/libprocess/Makefile.am (line 16)

Review Request 52651: Fixed agent to correctly handle kill task of unregistered executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52651/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6322

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review151885 --- Patch looks great! Reviews applied: [52288] Passed command:

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151872 --- Patch looks great! Reviews applied: [52250, 52251, 52560, 52561,

Re: Review Request 52632: Improved mesos.proto comments for partition-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52632/#review151859 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 2:18 p.m.,

Re: Review Request 52634: Synchronized unversioned and v1 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52634/#review151858 --- Ship it! Ship It! - Vinod Kone On Oct. 7, 2016, 2:18 p.m.,

Re: Review Request 51033: Added validation benchmark test for resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51033/#review151856 --- Looks pretty good, ditto my comments from the previous review. -

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/#review151854 --- Fix it, then Ship it! src/webui/master/static/js/app.js (line

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/#review151852 --- Thanks looks pretty good! Just a few suggestions for simplifying

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review151851 --- can you update tests to ensure we dont set executorid in http

Re: Review Request 52612: Added nested container tests for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52612/#review151842 --- src/tests/containerizer/runtime_isolator_tests.cpp (lines 342 -

Re: Review Request 52647: Fix new errors/warnings produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- (Updated Oct. 7, 2016, 7:22 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Oct. 7, 2016, 7:22 p.m.) Review request for mesos and Michael Park.

Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- Review request for mesos and Michael Park. Bugs: MESOS-6229

Review Request 52647: Fix new errors/warnings produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ --- Review request for mesos and Michael Park. Bugs: MESOS-6239

Re: Review Request 52599: Fixed a typo for resources benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52599/#review151844 --- Ship it! Ship It! - Benjamin Mahler On Oct. 6, 2016, 9:48

Re: Review Request 52622: Updated the way we bring up loopback for a container on a CNI network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52622/ --- (Updated Oct. 7, 2016, 6:55 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/#review151838 --- Ship it! The patch LGTM. I would suggest we add some tests in

Review Request 52644: Fixed an incorrect comment for `AGENT_ADDED` event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52644/ --- Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Vinod Kone.

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 7, 2016, 6:09 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 7, 2016, 6:09 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52520: Exposed the executor's type in the endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 7, 2016, 6:09 p.m.) Review request for mesos, Anand Mazumdar and

Review Request 52642: Improved the validation of RESERVE operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6142

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/ --- (Updated Oct. 7, 2016, 6:29 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review151823 --- ping, when do you plan to update this? we need this sooner than

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review151822 --- Given how similar the code in the new example framework is to the

Re: Review Request 51774: Added `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151820 --- include/mesos/master/master.proto (line 475)

Re: Review Request 52634: Synchronized unversioned and v1 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52634/#review151819 --- Patch looks great! Reviews applied: [52632, 52633, 52634]

Re: Review Request 52597: Added more detailed error message when failing in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52597/#review151817 --- src/linux/fs.cpp (lines 141 - 143)

Re: Review Request 52622: Updated the way we bring up loopback for a container on a CNI network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52622/#review151815 --- Fix it, then Ship it!

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review151802 --- - Can we move this patch to before the example framework so we

Re: Review Request 52635: Declared health HTTP and TCP checks experimental in 1.1.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52635/#review151810 --- Ship it! Ship It! - Till Toenshoff On Oct. 7, 2016, 2:47

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review151807 --- Ship it! I'll do some adjustment on the test when committing.

Re: Review Request 52081: Reorganized includes in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52081/#review151809 --- Ship it! Ship It! - Jie Yu On Oct. 6, 2016, 2:28 p.m.,

Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- Review request for mesos, Anand Mazumdar and Xiaojian Huang. Bugs: MESOS-6177

Review Request 52638: Populated `recovered` field in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/ --- Review request for mesos, Anand Mazumdar and Xiaojian Huang. Bugs: MESOS-6177

Review Request 52637: Added recovered `AgentID`s in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52637/ --- Review request for mesos, Anand Mazumdar and Xiaojian Huang. Bugs: MESOS-6177

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/ --- (Updated Oct. 7, 2016, 3:12 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- (Updated Oct. 7, 2016, 2:39 p.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 7, 2016, 2:40 p.m.) Review request for mesos, Alexander

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 7, 2016, 2:40 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test cases for HTTP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 7, 2016, 2:36 p.m.) Review request for mesos, Alexander

Review Request 52633: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52633/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 52634: Synchronized unversioned and v1 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52634/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review151789 --- Bad patch! Reviews applied: [52288] Failed command:

Re: Review Request 52628: Fixed typos in resources.hpp headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52628/#review151786 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 7, 2016,

Re: Review Request 52628: Fixed typos in resources.hpp headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52628/ --- (Updated Oct. 7, 2016, 12:57 p.m.) Review request for mesos and Alexander

Re: Review Request 52154: Avoided modifying process environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52154/ --- (Updated Oct. 7, 2016, 2:55 p.m.) Review request for mesos, Joris Van

Re: Review Request 52623: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder. On POSIX this should have no effect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52623/#review151783 --- Bad patch! Reviews applied: [52623, 52545, 52544, 52364, 52210,

Re: Review Request 52154: Avoided modifying process environment.

> On Sept. 23, 2016, 1:31 a.m., Joris Van Remoortere wrote: > > Why this solution as opposed to ensuring we initialize at the beginning of > > processes like we do with `process::initialize()`? > > Benjamin Bannier wrote: > Fixing the code in this spot is slightly easier as

Re: Review Request 52256: Made `FlagsBase::extract` publicly accessible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52256/#review151781 --- Ship it! Ship It! - Till Toenshoff On Sept. 26, 2016, 4:15

Re: Review Request 52625: Replaced POSIX `int` with `FileDesc` abstraction in `libprocess` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/#review151779 --- Bad patch! Reviews applied: [52625, 52624, 52545, 52544, 52364,

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/#review151776 --- Patch looks great! Reviews applied: [52347] Passed command:

Review Request 52626: Ensured allocations are processed before querying metrics in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52626/ --- Review request for mesos and Michael Park. Bugs: MESOS-6321

Re: Review Request 52622: Updated the way we bring up loopback for a container on a CNI network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52622/#review151771 --- Patch looks great! Reviews applied: [52622] Passed command:

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/ --- (Updated Oct. 7, 2016, 6:40 a.m.) Review request for mesos and Jiang Yan Xu.