Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/ --- (Updated Nov. 1, 2016, 2:58 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 691 > > > > > > This is OK since we do this the same in other functions for this class, > > but we should really wrap poi

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review154372 --- src/slave/containerizer/docker.cpp (lines 705 - 707)

Re: Review Request 53116: Removed `ProvisionerProcess::__provision()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53116/ --- (Updated Nov. 1, 2016, 2:45 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53115/ --- (Updated Nov. 1, 2016, 2:44 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 53115: Implemented handling AUFS whiteouts for copy backend.

> On Oct. 28, 2016, 10:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp, line 133 > > > > > > I am not sure if we need to pass in 'image' to backend. If we added OCI > > support

Re: Review Request 53161: Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/ --- (Updated Nov. 1, 2016, 2:42 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 52735: Removed TODO message for docker killing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/ --- (Updated Nov. 1, 2016, 6:13 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler, Ke

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/ --- (Updated Nov. 1, 2016, 6:12 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler, Ke

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated Nov. 1, 2016, 6:11 a.m.) Review request for mesos, Benjamin Mahler, Gu

Re: Review Request 50128: Added helper function to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Ke

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler, Ke

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/ --- (Updated Nov. 1, 2016, 2:08 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 53042: Added `FsTest.Xattr` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53042/ --- (Updated Nov. 1, 2016, 2:07 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- (Updated Nov. 1, 2016, 2:06 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 2161 > > > > > > Maybe consider using a ":" here instead of a comma? > > Guangya Liu wrote: > After a second thought

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154368 --- src/docker/docker.hpp (line 23)

Re: Review Request 53296: Added cgroup namespace support for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/#review154371 --- src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp (li

Re: Review Request 53296: Added cgroup namespace support for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/#review154370 --- src/slave/containerizer/mesos/isolators/namespaces/cgroup.cpp (li

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 388 > > > > > > Add an error here to verify correct set of permissions in the > > permissions field. > > > > Once we have don

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 2161 > > > > > > Maybe consider using a ":" here instead of a comma? After a second thought, I'm not sure if using a ":"

Re: Review Request 53306: Change unit test function for new user param in prepare func.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/#review154366 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 53285: Show the leader information in WebUI.

> On Oct. 31, 2016, 10:47 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/home.html, line 26 > > > > > > Since `hostname` is deprecated, use `address.hostname`? If that's not > > available, fall back to the cur

Re: Review Request 53324: Add a column for FrameworkID when displaying tasks in the WebUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53324/#review154362 --- src/webui/master/static/home.html (lines 167 - 169)

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review154359 --- src/tests/containerizer/cgroups_tests.cpp (line 184)

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53253/#review154358 --- We unfortunately have to copy the cleanup code from `Containerize

Re: Review Request 51609: Updated formatting in HealthChecker for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51609/#review154357 --- Patch looks great! Reviews applied: [51605, 51606, 51607, 51608,

Re: Review Request 52997: Improve Socket::connect error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/ --- (Updated Nov. 1, 2016, 12:22 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Oct. 31, 2016, 5:10 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review154346 --- Fix it, then Ship it! src/tests/cmake/MesosTestsConfigure.cmak

Review Request 53327: CMake: Added build variables for Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53327/ --- Review request for mesos, Artem Harutyunyan and Alex Clemmer. Repository: mesos

Review Request 53330: Add a pull timer for RegistryPuller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu.

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated Oct. 31, 2016, 11:43 p.m.) Review request for mesos, Xiaojian Huang, G

Re: Review Request 53324: Add a column for FrameworkID when displaying tasks in the WebUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53324/ --- (Updated Oct. 31, 2016, 4:41 p.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 53084: Support `LIBPROCESS_SSL_ENABLED` in the default executor and scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review154343 --- Ship it! Ship It! - Jie Yu On Oct. 31, 2016, 11:44 a.m., Gas

Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154342 --- src/tests/default_executor_tests.cpp (lines 210 - 220)

Re: Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53197/#review154341 --- Ship it! Ship It! - Jie Yu On Oct. 27, 2016, 4:19 p.m., Gast

Re: Review Request 53152: Added rlimit support to mesos-execute.

> On Oct. 31, 2016, 10:38 a.m., Benjamin Bannier wrote: > > src/cli/execute.cpp, lines 709-713 > > > > > > What's the order of enumeration here? IMHO we should either stick to > > alphabetical or alternatively the o

Re: Review Request 53309: Refactored `DefaultExecutorTest.ROOT_TaskUsesExecutor` [3/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53309/#review154336 --- Patch looks great! Reviews applied: [53266, 53303, 53309] Passed

Re: Review Request 53318: Fixed flaky MasterTest.OrphanTasksMultipleAgents test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53318/#review154335 --- Ship it! Ship It! - Anand Mazumdar On Oct. 31, 2016, 10:56 p

Re: Review Request 53285: Show the leader information in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53285/#review154334 --- src/webui/master/static/home.html (line 26)

Re: Review Request 52997: Improve Socket::connect error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/#review154332 --- Fix it, then Ship it! 3rdparty/libprocess/src/poll_socket.cpp

Re: Review Request 52997: Improve Socket::connect error message.

> On Oct. 18, 2016, 10:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, lines 133-141 > > > > > > Do we need to set these here...? If I understand correctly they already > > hold the correct

Re: Review Request 53136: Emit the build options at the end of configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/ --- (Updated Oct. 31, 2016, 10:27 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53138: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/ --- (Updated Oct. 31, 2016, 10:27 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53137: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/ --- (Updated Oct. 31, 2016, 10:27 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53124: Add documentation on Windows support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53124/ --- (Updated Oct. 31, 2016, 9:49 p.m.) Review request for mesos, Daniel Pravat, Ale

Re: Review Request 53308: Added new hook for modifying the executor environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53308/#review154322 --- Patch looks great! Reviews applied: [53308] Passed command: expo

Review Request 53318: Fixed flaky MasterTest.OrphanTasksMultipleAgents test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53318/ --- Review request for mesos. Bugs: MESOS-6519 https://issues.apache.org/jira/b

Re: Review Request 53313: Windows: Disable persistent state for Windows master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53313/#review154320 --- src/local/local.cpp (lines 214 - 228)

Re: Review Request 53124: Add documentation on Windows support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53124/#review154318 --- New docs should try to keep lines under 80 characters. This can't

Re: Review Request 53301: Fixed rlimit test for execution under OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53301/#review154311 --- Patch looks great! Reviews applied: [53301] Passed command: expo

Review Request 53313: Windows: Disable persistent state for Windows master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53313/ --- Review request for mesos, Daniel Pravat and Joseph Wu. Repository: mesos Desc

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 7:20 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 7:19 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53306: Change unit test function for new user param in prepare func.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for mesos. Summary (updated

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 7:17 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 7:17 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 7:17 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 51609: Updated formatting in HealthChecker for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51609/ --- (Updated Oct. 31, 2016, 6:56 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51608: Extracted "curl" binary into HTTP_CHECK_COMMAND constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51608/ --- (Updated Oct. 31, 2016, 6:56 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/ --- (Updated Oct. 31, 2016, 6:56 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/ --- (Updated Oct. 31, 2016, 6:55 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 51605: Added "mesos-tcp-connect" binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/ --- (Updated Oct. 31, 2016, 6:55 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review154291 --- Patch looks great! Reviews applied: [53299] Passed command: expo

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote: > > src/health-check/health_checker.cpp, line 520 > > > > > > This more of a question: > > Why is the --host hard coded to the `DEFAULT_DOMAIN`. What if the

Review Request 53310: Updated no-longer-accurate comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53310/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:16 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 5:10 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 52880: Added "launcher_dir" to the default executor flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52880/#review154279 --- Superseded by https://reviews.apache.org/r/53227/. - Gastón Kleim

Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53304/#review154276 --- Ship it! Ship It! - Neil Conway On Oct. 31, 2016, 4:04 p.m.,

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 4:18 p.m.) Review request for mesos. Bugs: MESOS-5856

Review Request 53309: Refactored `DefaultExecutorTest.ROOT_TaskUsesExecutor` [3/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53309/ --- Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu. Bugs: M

Review Request 53303: Refactored `DefaultExecutorTest.ROOT_KillTask` [2/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53303/ --- Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu. Bugs: M

Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/ --- (Updated Oct. 31, 2016, 4:08 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53304/ --- (Updated Oct. 31, 2016, 5:04 p.m.) Review request for mesos, Neil Conway and Ti

Re: Review Request 53269: Avoided needless copy inside `foreach` loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53269/#review154270 --- Patch looks great! Reviews applied: [53269] Passed command: expo

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 3:57 p.m.) Review request for mesos. Bugs: MESOS-5856

Re: Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- (Updated Oct. 31, 2016, 3:57 p.m.) Review request for mesos. Bugs: MESOS-5856

Review Request 53308: Added new hook for modifying the executor environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53308/ --- Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu. Bugs: MESO

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 3:50 p.m.) Review request for mesos. Bugs: MESOS-5856

Review Request 53305: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ --- Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/b

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Oct. 31, 2016, 3:47 p.m.) Review request for mesos and Joseph Wu. Bu

Review Request 53306: Modify prepare function of logrotate to accept new param user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/b

  1   2   >