Re: Review Request 58761: Added --secret-fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58761/#review173157 --- Bad patch! Reviews applied: [58761, 58760, 58759, 58758] Failed

Re: Review Request 58775: Added 'Secret' field config to Image::Docker protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58775/#review173150 --- Ship it! Ship It! - Jie Yu On April 27, 2017, 1:42 a.m.,

Re: Review Request 58689: MESOS-7323: Made `addSlave` not activate any frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/ --- (Updated April 26, 2017, 7:54 p.m.) Review request for mesos, Benjamin

Re: Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

> On April 25, 2017, 5:59 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 537-539 (patched) > > > > > > This comment seems to be inconsistent with what the test is doing? > > > >

Re: Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/#review173149 --- Bad review! Reviews applied: [58689, 58688, 58687, 57254, 58112,

Review Request 58775: Added 'Secret' field config to Image::Docker protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58775/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, and

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/#review173145 --- Ship it! - Jie Yu On April 26, 2017, 11:12 p.m., Gilbert

Re: Review Request 58748: Fixed the internet curl flaky test due to short timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58748/#review173144 --- Ship it! Ship It! - Jie Yu On April 26, 2017, 7:14 p.m.,

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

> On April 26, 2017, 5:13 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 542 (patched) > > > > > > Should we also trigger the failure when `!contentType.isSome()`? Thought about that. Let's

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173140 --- Do you know if an old registry (< 2.3) will be OK with this

Re: Review Request 58709: Prevent old Mesos agents from registering or re-registering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58709/#review173138 --- Fix it, then Ship it! Looks good, would be nice to pull out a

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 79-86 (patched) > > > > > > I think this got a bit out of date. We settled on `\...` being an > >

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/#review173136 --- src/uri/fetchers/docker.cpp Lines 542 (patched)

Review Request 58771: Added tests for usernamespace support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58771/ --- Review request for mesos. Repository: mesos Description --- WIP: Added

Review Request 58770: Enabled usernamespace support for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58770/ --- Review request for mesos. Repository: mesos Description --- WIP Enabled

Review Request 58769: Added userns flag to ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58769/ --- Review request for mesos. Repository: mesos Description --- WIP Added

Re: Review Request 58708: Checked validity of master and agent version numbers on startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58708/#review172996 --- src/master/main.cpp Lines 257-258 (patched)

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

> On April 26, 2017, 1:01 p.m., Ilya Pronin wrote: > > We can check if we got a schema 1 manifest by parsing manifest JSON first > > and checking `schemaVersion` field in it as I did here: > > https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic > > error message saying

Re: Review Request 58764: Fixed compilation error for libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58764/#review173132 --- Ship it! Ship It! - Michael Park On April 26, 2017, 4:22

Re: Review Request 58764: Fixed compilation error for libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58764/#review173131 --- Ship it! Ship It! - Vinod Kone On April 26, 2017, 11:22

Review Request 58761: Added --secret-fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58761/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 58760: Added default secret fetcher module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 58758: Added secret to Image.{docker, appc} and ContainerInfo.volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58758/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 58759: Introduced SecretFetcher module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

> On April 26, 2017, 8:01 p.m., Ilya Pronin wrote: > > We can check if we got a schema 1 manifest by parsing manifest JSON first > > and checking `schemaVersion` field in it as I did here: > > https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic > > error message saying

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

> On April 26, 2017, 7:16 p.m., Neil Conway wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 811 (patched) > > > > > > Wouldn't `path::join` be preferrable here? > > Chun-Hung Hsiao wrote:

Re: Review Request 58765: Fix build failure introduced in 8990ebb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58765/#review173128 --- Ship it! Ship It! - Vinod Kone On April 26, 2017, 11:32

Review Request 58766: Fixed a path join issue in ProvisionerDockerBackendTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58766/ --- Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway. Repository:

Review Request 58765: Fix build failure introduced in 8990ebb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58765/ --- Review request for mesos, Vinod Kone and Jiang Yan Xu. Repository: mesos

Review Request 58764: Fixed compilation error for libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58764/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 58708: Checked validity of master and agent version numbers on startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58708/#review172998 --- Fix it, then Ship it! Looks good, just seems to be in an

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/#review172994 --- Really happy to see these patches! At a high level the main

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173122 --- Ship it! Ship It! - Gilbert Song On April 26, 2017, 3:27

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/ --- (Updated April 26, 2017, 4:12 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58689/ --- (Updated April 26, 2017, 3:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 58689: MESOS-7323: Made `addSlave` conditionally activate the framework.

> On April 25, 2017, 5:59 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 379 (patched) > > > > > > Hm.. I was looking for a `framework.active = true` in activateFramework > >

Re: Review Request 58688: Removed an incorrect CHECK in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58688/ --- (Updated April 26, 2017, 3:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 58687: Made the activation of a client in `Sorter::add` explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58687/ --- (Updated April 26, 2017, 3:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 58687: Made the activation of a client in `Sorter::add` explicit.

> On April 25, 2017, 4:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 151-155 (original) > > > > > > Do we still want the CHECKs or some variant of the comment? Kept the

Re: Review Request 51258: Add documentation for the ExternalContainerLogger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51258/#review173118 --- This didn't build on master since the new objects use ContainerIO

Re: Review Request 58749: Fixed a typo in container-image.md doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58749/#review173117 --- Ship it! Ship It! - Chun-Hung Hsiao On April 26, 2017, 7:20

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

> On April 26, 2017, 1:01 p.m., Ilya Pronin wrote: > > We can check if we got a schema 1 manifest by parsing manifest JSON first > > and checking `schemaVersion` field in it as I did here: > > https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic > > error message saying

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 26, 2017, 7:28 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 504-505 (patched) > > > > > > I'd introduce: > > ``` > > class Headers { > > public: > > http::Headers

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/ --- (Updated April 26, 2017, 10:27 p.m.) Review request for mesos, Gilbert Song

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/#review173114 --- Ship it! Made some minor adjustments before committing. -

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

> On April 26, 2017, 3:58 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1396 (patched) > > > > > > I'd suggest we list the priority for environments for debug container > > here

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

> On April 13, 2017, 12:45 a.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1386-1389 (original), 1401-1404 (patched) > > > > > > Previously debug containers had this set in the

Re: Review Request 58718: Added a test that verifies a task's env var is seen by its check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58718/#review173111 --- Fix it, then Ship it! Nice test! src/tests/check_tests.cpp

Re: Review Request 58753: Concatenation for HTTP Headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58753/#review173103 --- Ship it! Ship It! - Jie Yu On April 26, 2017, 9:14 p.m.,

Review Request 58753: Concatenation for HTTP Headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58753/ --- Review request for mesos, Gilbert Song, Jie Yu, and Neil Conway. Repository:

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review173019 --- Ship it! Confirmed that this review chain works with a clean

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/#review173018 --- Ship it! The trailing whitespace in the patch breaks our

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

> On April 26, 2017, 8:01 p.m., Ilya Pronin wrote: > > We can check if we got a schema 1 manifest by parsing manifest JSON first > > and checking `schemaVersion` field in it as I did here: > > https://reviews.apache.org/r/53850/diff/1#0 Otherwise we may get a cryptic > > error message saying

Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/#review173016 --- Ship it! I'm going to make a couple minor whitespace additions

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

> On April 26, 2017, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 827 (patched) > > > > > > EXPECT_SOME > > Chun-Hung Hsiao wrote: > Should the `ASSERT_SOME` in

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

> On April 26, 2017, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 827 (patched) > > > > > > EXPECT_SOME Should the `ASSERT_SOME` in Line 813 be changed to

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

> On April 26, 2017, 7:28 p.m., Jie Yu wrote: > > Have you tested with all registries that we support? I've run the unit tests, which should cover all supported public registries. Also manually tested on a local private registry and Amazen ECR. - Chun-Hung

Re: Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/#review173085 --- We can check if we got a schema 1 manifest by parsing manifest

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173083 --- Fix it, then Ship it! Have you tested with all registries that

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

> On April 26, 2017, 7:16 p.m., Neil Conway wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 811 (patched) > > > > > > Wouldn't `path::join` be preferrable here? Let me open a new PR to fix

Re: Review Request 57935: Added a check to ensure scalar quantities match in `DRFSorter::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57935/#review173081 --- Hey Anindya -- can you rebase this RR for the recent sorter

Review Request 58749: Fixed a typo in container-image.md doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58749/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Repository: mesos

Re: Review Request 58533: Added a benchmark test for hierarchical sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58533/#review173080 --- Note that a made a few cosmetic fixes; see

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173079 --- src/tests/containerizer/provisioner_docker_tests.cpp Lines 811

Review Request 58747: Fixed docker uri fetcher strict v2 schema 1 check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58747/ --- Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, and Jie Yu. Bugs:

Review Request 58748: Fixed the internet curl flaky test due to short timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58748/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/#review173078 --- Fix it, then Ship it!

Re: Review Request 58533: Added a benchmark test for hierarchical sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58533/#review173074 --- Ship it! Ship It! - Neil Conway On April 20, 2017, 3:54

Re: Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review173070 --- Ship it! Ship It! - Neil Conway On March 31, 2017, 12:54

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/ --- (Updated April 26, 2017, 6:20 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57516/ --- (Updated April 26, 2017, 5:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

> On April 24, 2017, 9:11 p.m., Benjamin Mahler wrote: > > CHANGELOG > > Lines 16-17 (patched) > > > > > > It would also be nice to mention lack of the full plan here for > > reservations as well. E.g. we want

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated April 26, 2017, 10:53 a.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 58708: Checked validity of master and agent version numbers on startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58708/ --- (Updated April 26, 2017, 5:35 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated April 26, 2017, 5:35 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58706: Improved unit tests for Version in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58706/ --- (Updated April 26, 2017, 5:35 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review173064 --- Patch looks great! Reviews applied: [58262, 58718, 58263]

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173063 --- src/uri/fetchers/docker.cpp Lines 474 (patched)

Re: Review Request 58676: Logged when an agent (re-)registration request is received.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58676/#review173037 --- Bad patch! Reviews applied: [58676, 57731, 57730, 57710, 57535,