Re: Review Request 60871: Added double-checked locking for filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60871/#review180901 --- Ship it! - Benjamin Mahler On July 15, 2017, 12:13 a.m., Benj

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/ --- (Updated July 19, 2017, 3:05 a.m.) Review request for mesos, Joseph Wu and Jian

Review Request 60956: Refactored fetcher cache metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60956/ --- Review request for mesos, Joseph Wu and Jiang Yan Xu. Bugs: MESOS-7782 http

Re: Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60830/#review180896 --- Ship it! Ship It! - Benjamin Mahler On July 18, 2017, 11:44

Re: Review Request 60898: Added more tests for agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/#review180894 --- src/tests/slave_tests.cpp Lines 3327 (patched)

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 17th, 2017, 2:14 p.m. PDT, Jiang Yan Xu wrote: > > Clarified with Joseph offline. The proposal is to just fix this specific > situation in MESOS-7753 (I submitted /r/60917/ for review). I'll drop this > review for now and we can revisit this when we have another use case. > While I dr

Re: Review Request 60854: Changed the way tests capture agent state transitioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60854/#review180893 --- Ship it! Ship It! - James Peach On July 13, 2017, 11 p.m., J

Re: Review Request 60821: Introduced a "no sender" UPID.

> On July 12, 2017, 5:27 p.m., James Peach wrote: > > I think that a better approach is to define a static `UPID > > UPID::anonymous()` function that returns a well-defined anonymous UPID for > > the system. Remove all the sending functions that don't specify a `from` > > UPID and force them t

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 9:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 266-267 (original), 266-275 (patched) > > > > > > Outside the fetcher I think we use a convention like this: > > h

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180889 --- Patch looks great! Reviews applied: [60913] Passed command: expo

Review Request 60953: Updated libprocess for the new 3rdparty moodycamel/concurrentqueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60953/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Hindman. Repository

Re: Review Request 60831: Removed extra/unnecessary allocations of Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60831/ --- (Updated July 18, 2017, 11:44 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60830/ --- (Updated July 18, 2017, 11:44 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 60831: Removed extra/unnecessary allocations of Message.

> On July 15, 2017, 1:25 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 455 (original), 455 (patched) > > > > > > Why did you decide to take `Message` here instead of `Message&&`? It >

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 18, 2017, 10:50 p.m., Jiang Yan Xu wrote: > > Committing with these additional edits. Awesome, thanks! - Jacob --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180877 --

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180877 --- Ship it! Committing with these additional edits. src/slave/gc

Re: Review Request 60825: Performance optimizations for message passing.

> On July 15, 2017, 2:08 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 560 (original), 561-562 (patched) > > > > > > This seems to suggest there will be a comment about it in the > >

Re: Review Request 60825: Performance optimizations for message passing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60825/ --- (Updated July 18, 2017, 10:22 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 53479: Perform agent GC asynchronously.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/ --- (Updated July 18, 2017, 10:15 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 53479: Perform agent GC asynchronously.

> On July 17, 2017, 8:43 p.m., Jiang Yan Xu wrote: > > src/slave/gc.hpp > > Lines 114-117 (original), 115-118 (patched) > > > > > > I see that `promise == that.promise` here is required by the Multimap > > but does

Re: Review Request 60936: Removed stale FetcherProcess::setSpace declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60936/#review180873 --- Ship it! Ship It! - Jiang Yan Xu On July 17, 2017, 7:15 p.m.

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180872 --- Ship it! Ship It! - Greg Mann On July 18, 2017, 9:38 p.m., Q

Re: Review Request 60847: Added test cases for /slaves, /slave/containers, /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60847/#review180871 --- Ship it! Ship It! - Greg Mann On July 18, 2017, 9:38 p.m., Q

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180868 --- src/master/http.cpp Lines 444 (patched)

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180866 --- src/slave/http.cpp Line 2131 (original), 2127 (patched)

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180862 --- Haven't looked at tests but perhaps we can discuss the current iss

Re: Review Request 60847: Added test cases for /slaves, /slave/containers, /frameworks endpoints.

> On July 18, 2017, 8:23 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 2523-2524 (patched) > > > > > > Newline here. It makes the code look a little strange, one single line of comment surrounded

Review Request 60948: Updated test cases for the /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60948/ --- Review request for mesos, Alexander Rojas and Greg Mann. Bugs: MESOS-7630 h

Re: Review Request 60820: Added class definition for the IDAcceptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180859 --- Ship it! Ship It! - Greg Mann On July 18, 2017, 6:21 p.m., Q

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60847/#review180852 --- src/tests/master_tests.cpp Lines 2513 (patched)

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/#review180844 --- Could you update the Summary so that the endpoint paths are consis

Re: Review Request 60820: Added class definition for the IDAcceptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180841 --- src/common/http.hpp Lines 197-200 (original), 197-201 (patched) <

Re: Review Request 56611: Relax perf version check for Arch Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56611/#review180843 --- src/tests/containerizer/perf_tests.cpp Line 133 (original), 137-1

Re: Review Request 60847: Add test cases for /slaves, /slave/containers, /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60847/ --- (Updated July 18, 2017, 6:28 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60822/ --- (Updated July 18, 2017, 6:24 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60820: Added class definition for the IDAcceptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/ --- (Updated July 18, 2017, 6:21 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60820: Added class definition for the IDAcceptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/ --- (Updated July 18, 2017, 6:19 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

> On July 18, 2017, 5:54 p.m., Alexander Rojas wrote: > > src/common/http.hpp > > Lines 205 (patched) > > > > > > Why are these default constructors necesary? It used to be necessary because we were trying to get ri

Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60771/#review180835 --- Patch looks great! Reviews applied: [60768, 60769, 60770, 60771]

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180833 --- Could you reword the commit message with a little bit more of subs

Re: Review Request 60846: Retry logic for unsuccessful `docker rm` during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60846/ --- (Updated July 18, 2017, 5:49 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 60716: Cleaned up authentication acceptor to have one class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60716/#review180832 --- src/common/http.hpp Lines 176-183 (patched)

Re: Review Request 60887: Decoupling `Docker::rm` from `Docker::stop` in agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60887/ --- (Updated July 18, 2017, 5:46 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 60900: Updated Python linter to work with multiple directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review180823 --- Ship it! Ship It! - Eric Chung On July 18, 2017, 5:31 a.m.,

Re: Review Request 60400: Skipped consulting registry if the agent is in the `slaves.recovered`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/ --- (Updated July 18, 2017, 9:20 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180821 --- src/common/http.hpp Lines 197-198 (original), 197-211 (patched) <

Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.

> On July 17, 2017, 5:37 p.m., Joseph Wu wrote: > > src/log/network.hpp > > Line 247 (original), 248-250 (patched) > > > > > > I'd prefer this comment to be a `NOTE: ...` > > > > :) Sure :) - Jiang Yan

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60925/#review180813 --- Ship it! Committing with some minor edits. - Jiang Yan Xu On

Re: Review Request 60235: Linted support/test-upgrade.py.

> On July 17, 2017, 11:30 p.m., Joseph Wu wrote: > > support/test-upgrade.py > > Lines 114-115 (original), 142-147 (patched) > > > > > > This refactoring doesn't retain the original logic. > > > > The script

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review180796 --- src/linux/cgroups.hpp Lines 422 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 6:31 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2886 (patched) > > > > > > Just curious, the reason that this is a `repeated` field is there are 5 > > operations (total/read

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 18, 2017, 6:31 a.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Lines 2950 (patched) > > > > > > Why do we need this msg? I do not see it is used anywhere. This was left by Jason. Should be remov

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review180794 --- include/mesos/mesos.proto Lines 2886 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 17, 2017, 11:12 p.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Had an internal discussion on this with Jie, and seems like having > > different DNS options fo

Re: Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/#review180806 --- Looks good to me but it lacks an unit test. - Alexander Rojas O

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 18, 2017, 2:13 p.m.) Review request for mesos, Jie Yu and Till To