Re: Review Request 63900: Downgraded the logging level of socket shutdown failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63900/#review191304 --- Ship it! Ship It! - Zhitao Li On Nov. 17, 2017, 6:54 a.m.,

Re: Review Request 63853: Added the "task" prefix to the name of the status update manager files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/#review191303 --- PASS: Mesos patch 63853 was successfully built and tested.

Review Request 63900: Downgraded the logging level of socket shutdown failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63900/ --- Review request for mesos, Joseph Wu and Zhitao Li. Repository: mesos

Review Request 63895: Fixed flaky test UnreachableAgentReregisterAfterFailover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63895/ --- Review request for mesos, Alexander Rukletsov and James Peach. Bugs:

Re: Review Request 63897: WIP. Add prototype of master changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63897/#review191297 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 63888: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63888/#review191296 --- PASS: Mesos patch 63888 was successfully built and tested.

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review191288 --- src/tests/containerizer/mesos_containerizer_tests.cpp Lines 923

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review191286 ---

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 17, 2017, 1:53 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 166 (patched) > > > > > > `response.status != http::Status::OK` Cannot do this. `response.status` is a string. -

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review191283 --- Fix it, then Ship it!

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55727/ --- (Updated Nov. 16, 2017, 5:43 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/#review191282 --- Ship it! Ship It! - Gilbert Song On Nov. 15, 2017, 8:33

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191281 --- Ship it! Ship It! - Gilbert Song On Nov. 16, 2017, 1:34

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review191280 --- src/tests/containerizer/mesos_containerizer_tests.cpp Lines

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Nov. 17, 2017, 1:36 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review191277 --- src/slave/http.hpp Lines 306 (patched)

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 17, 2017, 12:57 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/#review191276 --- OK, i think we probably need to do the following given you're

Review Request 63897: WIP. Add prototype of master changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63897/ --- Review request for mesos. Repository: mesos Description --- WIP. Add

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 17, 2017, 12:19 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62636: Generated authentication tokens for local resource providers.

> On Nov. 7, 2017, 2:30 a.m., Joseph Wu wrote: > > src/resource_provider/daemon.cpp > > Lines 96-99 (original), 114-118 (patched) > > > > > > I'd consider an error at this step to be a fatal error (basically a > >

Re: Review Request 63376: Started `LocalResourceProviderDaemon` after obtaining the slave ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63376/ --- (Updated Nov. 17, 2017, 12:13 a.m.) Review request for mesos, Benjamin

Re: Review Request 63853: Added the "task" prefix to the name of the status update manager files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/ --- (Updated Nov. 16, 2017, 3:49 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63889: Use annotated tags in vote.sh and release.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63889/#review191271 --- Ship it! Ship It! - James Peach On Nov. 16, 2017, 8:46

Re: Review Request 63889: Use annotated tags in vote.sh and release.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63889/#review191270 --- PASS: Mesos patch 63889 was successfully built and tested.

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review191269 --- Fix it, then Ship it! src/hdfs/hdfs.cpp Line 119 (original),

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 50-61 (patched) > > > > > > Hum, so we assume v1 uses token based authentication? What if agent API > > uses basic authn?

Re: Review Request 63852: Added "Task" prefix to status update manager related classes/methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63852/ --- (Updated Nov. 16, 2017, 3:23 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63853: Added the "task" prefix to the name of the status update manager files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/ --- (Updated Nov. 16, 2017, 3:23 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review191265 --- Ship it! Ship It! - Michael Park On Nov. 7, 2017, 4:37

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review191264 --- Fix it, then Ship it! src/tests/fetcher_tests.cpp Line 469

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 157 (patched) > > > > > > i'd rename this to `launch`, and rename stop to `wait` Then what should be the name of the public

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review191257 --- src/slave/container_daemon.cpp Lines 50-61 (patched)

Re: Review Request 63652: Added d_type check in containerizer backend validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63652/#review191255 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/ --- (Updated Nov. 16, 2017, 9:36 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Nov. 16, 2017, 9:34 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 59687: Added tests for recovering ContainerConfig.

> On Nov. 16, 2017, 7:29 p.m., Gilbert Song wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Lines 1773 (patched) > > > > > > Did build you test and run it? Sorry missed this one. -

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 16, 2017, 9:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63862: Ported docker_tests.cpp to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review191248 --- PASS: Mesos patch 63862 was successfully built and tested.

Review Request 63889: Use annotated tags in vote.sh and release.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63889/ --- Review request for mesos, James Peach and Vinod Kone. Repository: mesos

Review Request 63888: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63888/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs:

Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63887/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 8:04 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 7:43 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 28, 2017, 9:32 p.m., James Peach wrote: > > src/master/master.cpp > > Lines 9476 (patched) > > > > > > This doesn't seem right to me. Even if the framework is not > > partition-aware, the master is

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 7171-7172 (patched) > > > > > > This could be shortened to one line. > > > > ``` > >

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191230 --- src/tests/containerizer/nested_mesos_containerizer_tests.cpp

Re: Review Request 63862: Ported docker_tests.cpp to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/#review191223 --- src/tests/containerizer/docker_tests.cpp Lines 62 (patched)

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/#review191226 --- Fix it, then Ship it! Ship It!

Re: Review Request 63652: Added d_type check in containerizer backend validation.

> On Nov. 14, 2017, 9:32 a.m., James Peach wrote: > > This is looking pretty good. > > > > You should be able to write a test for this using the > > [ROOT_XFS_TestBase](https://github.com/apache/mesos/blob/master/src/tests/containerizer/xfs_quota_tests.cpp) > > fixture. Probably a reasonable

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/ --- (Updated Nov. 16, 2017, 7:59 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 16, 2017, 6:54 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Line 86 (original), 84 (patched) > > > > > > `AF_UNSPEC` is default. You can just do `net::IP::parse` > > > > Also

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191196 --- src/checks/tcp_connect.cpp Line 86 (original), 84 (patched)

Re: Review Request 63853: Added the "task" prefix to the name of the status update manager files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63853/#review191224 --- Ship it! Ship It! - Greg Mann On Nov. 15, 2017, 11:42 p.m.,

Re: Review Request 63852: Added "Task" prefix to status update manager related classes/methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63852/#review191211 --- src/local/local.cpp Line 102 (original), 102 (patched)

Re: Review Request 63861: Updated networking doc for Windows docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review191218 --- Fix it, then Ship it! Nit: > Windows: Updated Docker

Re: Review Request 63860: Fixed docker network settings for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review191217 --- Fix it, then Ship it! Nit the review title (for consistency):

Re: Review Request 63859: Fixed signal vals & WEXITSTATUS on Windows stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review191213 --- The summary for this could be: > Windows: Fixed mock signal

Re: Review Request 63652: Added d_type check in containerizer backend validation.

> On Nov. 14, 2017, 5:32 p.m., James Peach wrote: > > This is looking pretty good. > > > > You should be able to write a test for this using the > > [ROOT_XFS_TestBase](https://github.com/apache/mesos/blob/master/src/tests/containerizer/xfs_quota_tests.cpp) > > fixture. Probably a reasonable

Review Request 63861: Updated networking doc for Windows docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs:

Review Request 63862: Ported docker_tests.cpp to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63862/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs:

Review Request 63860: Fixed docker network settings for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs:

Review Request 63859: Fixed signal vals & WEXITSTATUS on Windows stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/ --- Review request for mesos, Andrew Schwartzmeyer and John Kordich. Bugs:

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review191202 --- Fix it, then Ship it! src/tests/hdfs_tests.cpp Lines 55

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review191204 --- Ship it! Ship It! - Michael Park On Nov. 6, 2017, 10:09

Re: Review Request 60622: Added new stout functions for path and URI conversions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review191203 --- Fix it, then Ship it! 3rdparty/stout/include/stout/uri.hpp

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review191201 --- Fix it, then Ship it!

Re: Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Nov. 16, 2017, 5:02 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63798: Added resource provider support for all offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63798/ --- (Updated Nov. 16, 2017, 3:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63577: Fixed a task status update race in default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63577/#review191169 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 63796: Made `CheckerProcess` support IPv6 for HTTP/TCP check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63796/#review191171 --- PASS: Mesos patch 63796 was successfully built and tested.

Re: Review Request 63831: Fixed a bug that removed the suppressed framework from sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63831/#review191165 --- PASS: Mesos patch 63831 was successfully built and tested.