Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203641 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64074/#review203638 --- FAIL: Failed to apply the dependent review: 55323. Failed

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203632 --- PASS: Mesos patch 67241 was successfully built and tested.

Review Request 67261: Skipped `UpdateSlaveMessage` for an empty 1st `oversubscribedResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67261/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jie Yu. Bugs:

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/#review203630 --- PASS: Mesos patch 66962 was successfully built and tested.

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

> On May 21, 2018, 5:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp > > Lines 310-311 (patched) > > > > > > I'd print out some infomation that's relevant to this isolator for us > > to

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- (Updated May 22, 2018, 6:57 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 67258: Fixed flakiness for some `AgentResourceProviderConfigApiTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67258/#review203626 --- FAIL: Failed to apply the dependent review: 67224. Failed

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 9:21 p.m., Qian Zhang wrote: > > Can you please explain how the container will be cleaned up from the > > `containers_` map after agent recovery? > > Andrei Budnik wrote: > In the current implementation, a recovered container can be cleaned up > only when someone calls

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 23, 2018, 12:35 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 23, 2018, 12:27 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67175: Added support for marking slave mounts and creating non-existing paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67175/#review203620 --- src/linux/fs.hpp Lines 294 (patched)

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203623 --- PASS: Mesos patch 67235 was successfully built and tested.

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 23, 2018, 12:01 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Review Request 67258: Fixed flakiness for some `AgentResourceProviderConfigApiTest` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67258/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Greg Mann.

Review Request 67257: Fixed filters in test `ROOT_ReconcileDroppedOperation` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67257/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos

Review Request 67256: Added a unit test for CSI plugin RPC metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67256/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.

Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- (Updated May 22, 2018, 11:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/ --- (Updated May 22, 2018, 11:33 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 22, 2018, 11:32 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65900: Defer creation of volume target paths to container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65900/#review203611 --- This commit contains both refactoring and functional changes. We

Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66670/#review203618 --- Ship it! Ship It! - Greg Mann On April 17, 2018, 3:23 p.m.,

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 22, 2018, 11:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1053-1054 (patched) > > > > > > this is problematic? > > Jie Yu wrote: > At least the comment suggest

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 22, 2018, 11:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1053-1054 (patched) > > > > > > this is problematic? At least the comment suggest something different - Jie

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203615 --- src/slave/containerizer/mesos/launch.cpp Lines 1053-1054

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67243/#review203614 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 21, 2018,

Re: Review Request 67208: Windows: Updated information on docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67208/#review203613 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 18, 2018,

Re: Review Request 67207: Windows: Changed health check image to use an image hosted by Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67207/#review203612 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 18, 2018,

Re: Review Request 66962: Windows: Added tests for async IO functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66962/ --- (Updated May 22, 2018, 10:55 p.m.) Review request for mesos, Andrew

Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/ --- (Updated May 22, 2018, 10:54 p.m.) Review request for mesos, Andrew

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/ --- (Updated May 22, 2018, 10:53 p.m.) Review request for mesos, Andrew

Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/ --- (Updated May 22, 2018, 10:51 p.m.) Review request for mesos, Andrew

Re: Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66958/ --- (Updated May 22, 2018, 10:51 p.m.) Review request for mesos, Andrew

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- (Updated May 22, 2018, 10:47 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66956: Windows: Added overlapped support to `os::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/ --- (Updated May 22, 2018, 10:46 p.m.) Review request for mesos, Andrew

Re: Review Request 66955: Windows: Added overlapped support to `os::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66955/ --- (Updated May 22, 2018, 10:40 p.m.) Review request for mesos, Andrew

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203605 --- Please update the commit message to < 72 characters: ``` $

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203603 --- PASS: Mesos patch 67201 was successfully built and tested.

Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67118/#review203601 --- Jie brought it up that the `xz` archive contains GNU GPL licensed

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 22, 2018, 8:42 p.m.) Review request for mesos and Andrew

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67243/#review203597 --- Patch looks great! Reviews applied: [67207, 67208, 67243]

Re: Review Request 67228: Added allocator benchmark test for various simulations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67228/#review203596 --- src/tests/master_drf_benchmarks.cpp Lines 60 (patched)

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review203595 --- src/resource_provider/storage/provider.cpp Lines 3270 (patched)

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203594 --- PASS: Mesos patch 67059 was successfully built and tested.

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 1:21 p.m., Qian Zhang wrote: > > Can you please explain how the container will be cleaned up from the > > `containers_` map after agent recovery? In the current implementation, a recovered container can be cleaned up only when someone calls `destroy()`. I didn't change that

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203592 --- Patch looks great! Reviews applied: [67241] Passed command:

Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result.

> On May 10, 2018, 12:52 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Line 621 (original), 629-632 (patched) > > > > > > Similarly, I am wondering if we can reach here for a nested

Re: Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67248/#review203583 --- PASS: Mesos patch 67248 was successfully built and tested. All

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review203581 --- src/resource_provider/storage/provider.cpp Lines 3446-3467

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 1:21 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Lines 396-400 (original) > > > > > > Previously, in the case that `destroy-in-progress stopped an > >

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203578 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018,

Re: Review Request 67238: Fixed a quota-related metrics bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/#review203575 --- Ship it! Ship It! - Gaston Kleiman On May 21, 2018, 3:13

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated May 22, 2018, 3:55 p.m.) Review request for mesos, Andrew

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 21, 2018, 1:21 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Line 361 (original), 360-365 (patched) > > > > > > So besides removing the container from the `containers_` map, we also

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67099: Updated support scripts to check for Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67099/ --- (Updated May 22, 2018, 2:27 p.m.) Review request for mesos, Andrew

Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67247/#review203568 --- PASS: Mesos patch 67247 was successfully built and tested.

Re: Review Request 67135: Added test to verify presence of nested container termination status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67135/#review203567 --- Ship it! Ship It! - Qian Zhang On May 16, 2018, 12:10 a.m.,

Re: Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67248/#review203566 --- Ship it! Thanks a bunch Benjamin - guess I missed that in the

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review203565 --- src/tests/containerizer/nested_mesos_containerizer_tests.cpp

Review Request 67248: Fixed `pem_to_rsa` for older SSL versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67248/ --- Review request for mesos, Clement Michaud and Till Toenshoff. Repository:

Re: Review Request 67130: Updated comments related to `wait`, `destroy` containerizer methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67130/#review203564 --- Fix it, then Ship it!

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/ --- (Updated May 22, 2018, 12:43 p.m.) Review request for mesos, Benjamin Bannier

Review Request 67247: Added support script to check if Python >= 3.6 is available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67247/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8770

Re: Review Request 67128: Removed extra `containerizer->wait()` calls in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67128/#review203563 --- Ship it! Ship It! - Qian Zhang On May 15, 2018, 7:02 p.m.,

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203561 --- PASS: Mesos patch 67137 was successfully built and tested.

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/#review203560 --- Fix it, then Ship it! Looks great!

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 22, 2018, 12:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review203559 --- Ship it! Ship It! - Qian Zhang On May 11, 2018, 9:55 p.m.,

Re: Review Request 66671: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review203555 --- For the tests `DestroyDuringUnsupportedLaunchLoop` and

Re: Review Request 67238: Fixed a quota-related metrics bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/#review203558 --- Patch looks great! Reviews applied: [67238] Passed command:

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 19, 2018, 1:26 a.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 669 (original), 618 (patched) > > > > > > Why return `wait()` when the state is DESTROYING, rather than just > >

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203554 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822,