Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215081 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70550/#review215079 --- Patch looks great! Reviews applied: [70549, 70550] Passed

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/ --- (Updated May 6, 2019, 4 p.m.) Review request for mesos, Andrei Sekretenko and

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 10:04 p.m.) Review request for mesos, Alexander

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215075 --- Ship it! Ship It! - Chun-Hung Hsiao On May 6, 2019, 10:04

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 10:02 p.m.) Review request for mesos, Alexander

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215074 --- Fix it, then Ship it! Thanks for making this test more

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215073 --- include/mesos/authorizer/authorizer.proto Lines 142-143

Re: Review Request 70550: Added `UpdateQuotaConfig` authorization in the local authorizor.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70550/#review215072 --- include/mesos/authorizer/acls.proto Lines 135-143 (original),

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215071 --- Hm.. don't we need to track the amount held back during the quota

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215070 --- Patch looks great! Reviews applied: [70594, 70595] Passed

Re: Review Request 70591: Introduced struct RoleInfo to track reservations and framework IDs in one map.

2019-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215069 --- Regarding the commit message. We usually write the commit message

Re: Review Request 70591: Introduced struct RoleInfo to track reservations and framework IDs in one map.

2019-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215068 --- src/master/allocator/mesos/hierarchical.hpp Line 542 (original),

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- (Updated May 6, 2019, 6:34 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Benjamin Mahler
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70598/#review215065 --- Fix it, then Ship it! Thanks Benno! Showing stats seems

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Chun-Hung Hsiao
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70598/#review215062 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 70598: Added blogpost for 1.8.0 release.

2019-05-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70598/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 70596: Launched tasks with more memory in SLRP unit tests.

2019-05-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70596/#review215058 --- Fix it, then Ship it! Ship It!

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-06 Thread Alexander Rukletsov
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Lines 2092-2108 (patched) > > > > > > I tried this unit test w/o the fix in the following settings: > >

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review215060 --- Patch looks great! Reviews applied: [70184] Passed command:

Re: Review Request 70594: Fixed an issue where /__processes__ never returns a response.

2019-05-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70594/#review215059 --- Ship it! Slick solution, thanks, Ben! - Alexander Rukletsov

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

2019-05-06 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/ --- (Updated May 6, 2019, 11:48 a.m.) Review request for mesos and Chun-Hung