---
Thanks,
Alex Clemmer
, which will help us
to separate out Mesos builds into many libraries, rather than one
single, monolithic libmesos.
Diffs
-
3rdparty/stout/cmake/GroupSource.cmake PRE-CREATION
Diff: https://reviews.apache.org/r/55599/diff/
Testing
---
Thanks,
Alex Clemmer
t.cpp a9e217e8beb5a6aca456ff5379893953cafca135
Diff: https://reviews.apache.org/r/55548/diff/
Testing
---
Thanks,
Alex Clemmer
9
Diff: https://reviews.apache.org/r/55547/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
ce195e2820c70dd7ebec1f06a6382f58fc729af7
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
src/health-check/tcp_connect.cpp ad1e932da53c8f6b0ae77dfa6b6bb3d642273af9
Diff: https://reviews.apache.org/r/55549/diff/
Testing
---
Thanks,
Alex Clemmer
sting
---
Thanks,
Alex Clemmer
environment.hpp
b3e82ac8071b41748aeb098b7d5fcc210a1d3c43
3rdparty/stout/include/stout/os/windows/environment.hpp PRE-CREATION
3rdparty/stout/tests/os_tests.cpp 30735e28a26ff713469711d63538676ed4e327d9
Diff: https://reviews.apache.org/r/55547/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/55546/diff/
Testing
---
Thanks,
Alex Clemmer
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/55023/#review160115
---
On Jan. 15, 2017, 10:46 a.m., Alex Clemmer wrote:
>
> ---
> This is an automati
crash immediately upon invocation in all
executor tests.
This commit will fix this command.
Diffs (updated)
-
src/slave/containerizer/mesos/containerizer.cpp
8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4
Diff: https://reviews.apache.org/r/55023/diff/
Testing
---
Thanks,
Alex Clemmer
o.cpp c37ec1811fab7d8d33f0d5fd8703ab121d6db514
Diff: https://reviews.apache.org/r/55022/diff/
Testing
---
Thanks,
Alex Clemmer
src/slave/containerizer/mesos/launch.cpp
e482ab8bdfc358f695b87cda72ca59fb64cd8c4d
src/slave/containerizer/mesos/utils.hpp
a54106dc4893bb222f42ede936ac9029e817faf9
Diff: https://reviews.apache.org/r/55037/diff/
Testing
---
Thanks,
Alex Clemmer
ea91c71fdfac48a2fc1d31a0ee088a73244be367
src/slave/containerizer/mesos/launch.cpp
e482ab8bdfc358f695b87cda72ca59fb64cd8c4d
src/slave/containerizer/mesos/utils.hpp
a54106dc4893bb222f42ede936ac9029e817faf9
Diff: https://reviews.apache.org/r/55037/diff/
Testing
---
Thanks,
Alex Clemmer
55543/diff/
Testing
---
Thanks,
Alex Clemmer
out/windows.hpp
d89c70902cf6051608c2cb290b0727cbb45c
Diff: https://reviews.apache.org/r/55544/diff/
Testing
---
Thanks,
Alex Clemmer
/containerizer/mesos/isolators/network/cni/cni.cpp
ea91c71fdfac48a2fc1d31a0ee088a73244be367
src/slave/containerizer/mesos/launch.cpp
e482ab8bdfc358f695b87cda72ca59fb64cd8c4d
Diff: https://reviews.apache.org/r/55037/diff/
Testing
---
Thanks,
Alex Clemmer
rizer/mesos/isolators/network/cni/cni.cpp
ea91c71fdfac48a2fc1d31a0ee088a73244be367
src/slave/containerizer/mesos/launch.cpp
e482ab8bdfc358f695b87cda72ca59fb64cd8c4d
Diff: https://reviews.apache.org/r/55037/diff/
Testing
---
Thanks,
Alex Clemmer
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55037/#review160161
-------
On Dec. 26, 2016, 9:53 a.m., Alex Clemmer wrote:
>
> --
/src/tests/CMakeLists.txt
0b2660cb16f5d8d8dc66e6995061d0b832182351
Diff: https://reviews.apache.org/r/55030/diff/
Testing
---
Thanks,
Alex Clemmer
.
Diffs (updated)
-
3rdparty/libprocess/include/process/process.hpp
b118f1a2bf5aac12b53ae204253b88c9b1c65f46
3rdparty/libprocess/src/process.cpp f475fe78f801924f70f51fdc4ab190c2dbecd656
Diff: https://reviews.apache.org/r/55024/diff/
Testing
---
Thanks,
Alex Clemmer
` should probably perform the socket teardown, or at
> > least give the option to do so.
> >
> > Currently, very few of our processes call `process::finalize`. They
> > usually just rely on the OS cleaning up after them.
>
> Alex Clemmer wrote:
> I
47f2da1
3rdparty/stout/tests/os/rmdir_tests.cpp
988d41b7fdd11cc96ce005671a7c62d1b5a3615d
Diff: https://reviews.apache.org/r/55327/diff/
Testing
---
Thanks,
Alex Clemmer
mit message needs to be massaged for this
to make sense.)
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/#review161306
------
ply, visit:
https://reviews.apache.org/r/55026/#review161309
-------
On Dec. 24, 2016, 11:14 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically ge
mmitted, so a rebase will be
> especially useful now.
I'll do it tonight.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161170
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55024/#review161171
---
On Dec. 24, 2016, 10:46 a.m., Alex Clemmer wrote:
>
> --
the Agent sandbox
deletion to error out instead of completing successfully.
Diffs
-
src/tests/gc_tests.cpp c4841e85f785189681e218df714cac2038d77803
Diff: https://reviews.apache.org/r/55328/diff/
Testing
---
Thanks,
Alex Clemmer
2d1b5a3615d
Diff: https://reviews.apache.org/r/55327/diff/
Testing
---
Thanks,
Alex Clemmer
cpp 67a6aed8c66a21c94c106b52dff75cbdc41fcf69
Diff: https://reviews.apache.org/r/55314/diff/
Testing
---
Thanks,
Alex Clemmer
/diff/
Testing
---
Thanks,
Alex Clemmer
/r/55312/diff/
Testing
---
Thanks,
Alex Clemmer
/diff/
Testing
---
Thanks,
Alex Clemmer
2be2f8c3d58ee64410f87ee4a4b2bb54fe014748
3rdparty/stout/include/stout/windows/os.hpp
5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
---
Thanks,
Alex Clemmer
org/r/55006/#comment231798>
Same comment as in #55005. `libprocess` is a misnomer on Windows.
- Alex Clemmer
On Dec. 23, 2016, 2:22 a.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
)
<https://reviews.apache.org/r/55005/#comment231797>
As I said in response to Till's comment, I think it is better to call it
`process-tests`. We specifically call it this because on Windows, there is no
`libprocess`. There is only `process.lib`.
- Alex Clemmer
On Dec. 23, 201
isit:
> https://reviews.apache.org/r/55005/
> ---
>
> (Updated Dec. 23, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> See https://reviews.apache.org/r/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55004/#review160647
---
Ship it!
Ship It!
- Alex Clemmer
On Dec. 23, 2016, 2:09 a.m
/os.hpp
5cd92545a49648e39e8eb7cf131895e9cfc97902
Diff: https://reviews.apache.org/r/55162/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/55162/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54877/#review160444
---
Ship it!
Ship It!
- Alex Clemmer
On Jan. 3, 2017, 10:14 p.m
here.
>
> Andrew Schwartzmeyer wrote:
> What would you convert it to? It's currently in UTF-16, and Windows paths
> are allowed to have (almost) any Unicode character.
>
> Alex Clemmer wrote:
> I think he's saying that bad things will happen if you use string
here.
>
> Andrew Schwartzmeyer wrote:
> What would you convert it to? It's currently in UTF-16, and Windows paths
> are allowed to have (almost) any Unicode character.
>
> Alex Clemmer wrote:
> I think he's saying that bad things will happen if you use string
iff: https://reviews.apache.org/r/55038/diff/
Testing
---
Thanks,
Alex Clemmer
eLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84
Diff: https://reviews.apache.org/r/55040/diff/
Testing
---
Thanks,
Alex Clemmer
/AgentConfigure.cmake fcac980f55cf6f7a582053b786cf73c6515e3a0b
Diff: https://reviews.apache.org/r/55039/diff/
Testing
---
Thanks,
Alex Clemmer
, where a
user could mistakenly call it and expect the same output on all hosts.
Diffs
-
src/slave/containerizer/mesos/launch.cpp
e482ab8bdfc358f695b87cda72ca59fb64cd8c4d
Diff: https://reviews.apache.org/r/55037/diff/
Testing
---
Thanks,
Alex Clemmer
4b80c397381ca2c869cd6eb7507bb9df94ce3623
Diff: https://reviews.apache.org/r/55030/diff/
Testing
---
Thanks,
Alex Clemmer
smaller binaries (MESOS-3542).
Diffs
-
3rdparty/stout/cmake/StoutConfigure.cmake
04e0f2f0d464d6740055eb1db2a8d41349879171
3rdparty/stout/tests/CMakeLists.txt a09693d4b9a70faf1e4e337ec71ead2f0bbab0a2
Diff: https://reviews.apache.org/r/55029/diff/
Testing
---
Thanks,
Alex
---
Thanks,
Alex Clemmer
here.
>
> Andrew Schwartzmeyer wrote:
> What would you convert it to? It's currently in UTF-16, and Windows paths
> are allowed to have (almost) any Unicode character.
>
> Alex Clemmer wrote:
> I think he's saying that bad things will happen if you use string
order to avoid these errors.
Diffs
-
src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
Diff: https://reviews.apache.org/r/55026/diff/
Testing
---
Thanks,
Alex Clemmer
TestsConfigure.cmake
ca042bd3f7ebc339f1c342b1854a66e33ee9f20c
Diff: https://reviews.apache.org/r/55025/diff/
Testing
-------
Thanks,
Alex Clemmer
ing
-------
Thanks,
Alex Clemmer
/process.cpp 889a03444eaee7b5ad2be65bb414c30062d4a4f0
Diff: https://reviews.apache.org/r/55024/diff/
Testing
---
Thanks,
Alex Clemmer
.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
d9d5619e45ae1199fc91878f17a33b5647f48305
Diff: https://reviews.apache.org/r/55023/diff/
Testing
---
Thanks,
Alex Clemmer
,
and Joseph Wu.
Repository: mesos
Description
---
Windows: Cause errors to be correctly reported in `io::read`.
Diffs
-
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
Diff: https://reviews.apache.org/r/55022/diff/
Testing
---
Thanks,
Alex Clemmer
ange. This issue also resolves MESOS-6803.
Diffs
-
src/slave/slave.cpp a7a3a394e5e4b7f40a051663cd70add3890bdf18
Diff: https://reviews.apache.org/r/54928/diff/
Testing
---
`make check` on Unix and I ran the test suite 1000 times overnight, minus the
few flaky tests.
Thanks,
Alex Clemmer
tests/partition_tests.cpp e1e2025bd0f078836323cbd8c6d7836815c4c38d
Diff: https://reviews.apache.org/r/54927/diff/
Testing
---
`make check` and each test was run 1000 times to avoid flakey tests.
Thanks,
Alex Clemmer
ilures, which is how we caught the failing test in
`reservation_tests.cpp`. Note that this bug was discovered when we added a
`delay` to the call to `authenticate` in `slave::detected` (in order to get it
to match the behavior of the non-authenticated call to `doReliableRegistration`.
Thanks,
Alex Clemmer
ehavior of the non-authenticated call to `doReliableRegistration`.
Thanks,
Alex Clemmer
tests to
find failing tests in `SlaveTest.*`, then fixed, then ran again.
Thanks,
Alex Clemmer
mesos-tests --gtest_repeat=1000 --gtest_break_on_failure`
filtering on the tests in this review to catch intermittent failures.
Thanks,
Alex Clemmer
tests --gtest_repeat=1000 --gtest_break_on_failure`
filtering on the tests in this review to catch intermittent failures.
Thanks,
Alex Clemmer
here.
>
> Andrew Schwartzmeyer wrote:
> What would you convert it to? It's currently in UTF-16, and Windows paths
> are allowed to have (almost) any Unicode character.
>
> Alex Clemmer wrote:
> I think he's saying that bad things will happen if you use string
ow we caught the failing test in
`reservation_tests.cpp`. Note that this bug was discovered when we added a
`delay` to the call to `authenticate` in `slave::detected` (in order to get it
to match the behavior of the non-authenticated call to `doReliableRegistration`.
Thanks,
Alex Clemmer
ected` (in order to get it
to match the behavior of the non-authenticated call to `doReliableRegistration`.
Thanks,
Alex Clemmer
ache.org/r/54803/#review159732
---
On Dec. 20, 2016, 10:37 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
:
https://reviews.apache.org/r/54803/#review159647
-------
On Dec. 17, 2016, 11:01 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-
ling tests in `SlaveTest.*`, then fixed, then ran again.
Thanks,
Alex Clemmer
--
On Dec. 19, 2016, 11:20 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54877/
> ---
>
> (Up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54875/#review159664
---
Ship it!
Ship It!
- Alex Clemmer
On Dec. 19, 2016, 10:12
ected`, ran tests to
find failing tests in `SlaveTest.*`, then fixed, then ran again.
Thanks,
Alex Clemmer
stout/cmake/FindApr.cmake 9d55ba0f63d0215619472e86ade8c486364fae7e
3rdparty/stout/cmake/StoutConfigure.cmake
d8da0f0702eb5bde1e1105accdffb82abe0cd24b
Diff: https://reviews.apache.org/r/54827/diff/
Testing
---
`make check` on OS X and Windows.
Thanks,
Alex Clemmer
make/StoutConfigure.cmake
d8da0f0702eb5bde1e1105accdffb82abe0cd24b
Diff: https://reviews.apache.org/r/54827/diff/
Testing
---
`make check` on OS X and Windows.
Thanks,
Alex Clemmer
on OS X and Windows.
Thanks,
Alex Clemmer
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54803/#review159409
---
On Dec. 16, 2016, 2:47 a.m., Alex Clemmer wrote:
>
> --
hanks,
Alex Clemmer
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54803/#review159462
-------
On Dec. 16, 2016, 2:47 a.m., Alex Clemmer wrote:
>
> ---
> This is an
?
src/slave/paths.cpp (line 520)
<https://reviews.apache.org/r/54807/#comment230475>
If I'm reading this code correctly, it looks like we always log a warning
saying we failed to symlink. It seems like we want to have a different error
message for the Windows code path?
- Alex C
s.cpp fc6b56c074c71b827a9ee522cd715c0d15ecc7e3
Diff: https://reviews.apache.org/r/54803/diff/
Testing
---
Added `delay` to the call to `authenticate` in `Slave::detected`, ran tests to
find failing tests in `SlaveTest.*`, then fixed, then ran again.
Thanks,
Alex Clemmer
rc/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
ache.org/r/53706/.
Agreement is, Joseph will check this in under Daniel's name so he retains
credit.
Thanks,
Alex Clemmer
u.hpp
1bb70964adbb80aa6502fbfe69de2c34dc74e655
3rdparty/stout/tests/os_tests.cpp bed1449ef8855932a1fefd3aeb3386ab9abd0307
Diff: https://reviews.apache.org/r/54800/diff/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54792/#review159337
---
Ship it!
Ship It!
- Alex Clemmer
On Dec. 15, 2016, 6:07 p.m
> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 347
> > <https://reviews.apache.org/r/50415/diff/6/?file=1579858#file1579858line347>
> >
> > If I'm understanding this correctly, this will download a fresh copy of
&g
288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
ocess/src/tests/http_tests.cpp
822cdb3931d3e30713aa78995427f364e41bfb30
Diff: https://reviews.apache.org/r/54685/diff/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54678/#review158912
---
Ship it!
- Alex Clemmer
On Dec. 12, 2016, 10:26 p.m., John
32d9c39a415631d17b9a26941406e8
src/tests/status_update_manager_tests.cpp
38d8913a5b33aa5325d0bc632c0a1d80480eddf8
src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/#review158786
---
On Dec. 10, 2016, 10:51 p.m., Alex Clemmer wrote:
>
>
103f9
src/Makefile.am 5736349e9b898f0e46ccfdaa73d437e2bc4974dc
src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
support/windows-build.bat b3b6d0bbe877cf3794a5c616374ffce8c1b1552c
Diff: https://reviews.apache.org/r/54493/diff/
Testing
---
Thanks,
Alex Clemmer
Windows build.
Diffs (updated)
-
src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c
Diff: https://reviews.apache.org/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
mbiguity and causes most tests in `files_tests.cpp` to pass.
Diffs
-
3rdparty/stout/include/stout/os/write.hpp
24a69d8f60efd3c2888d464d75164c758b3701a2
Diff: https://reviews.apache.org/r/54631/diff/
Testing
---
Thanks,
Alex Clemmer
Windows build.
Diffs (updated)
-
src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c
Diff: https://reviews.apache.org/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
MSVC > 1900, and add the file to the Agent tests build.
Diffs
-
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
---
Thanks,
A
101 - 200 of 1316 matches
Mail list logo
