/53313/diff/
Testing
---
Thanks,
Alex Clemmer
ecedent for this because most lflags are defined by stout configuration.
- Alex Clemmer
On Nov. 15, 2016, 3:08 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
tps://reviews.apache.org/r/53754/#comment226375>
In the other blocks we seem to put this one first. Maybe consider putting
it first here, too?
- Alex Clemmer
On Nov. 15, 2016, 3:08 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically g
tps://reviews.apache.org/r/53759/#comment226376>
Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`?
- Alex Clemmer
On Nov. 15, 2016, 3:09 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/53761/#comment226377>
Hmm, can you explain the decision to add `ALL` here? It's not clear to me
what the implications are.
- Alex Clemmer
On Nov. 15, 2016, 3:11 a.m., Joseph Wu wrote:
>
> ---
> This is an aut
it might be easier to just `if` out the line that includes this
`CMakeLists.txt`?
- Alex Clemmer
On Nov. 15, 2016, 10:56 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261
Diff: https://reviews.apache.org/r/53313/diff/
Testing
---
Thanks,
Alex Clemmer
> On Nov. 17, 2016, 5:09 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/src/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/53759/diff/1/?file=1563860#file1563860line93>
> >
> > Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`?
> On Nov. 17, 2016, 5:19 p.m., Alex Clemmer wrote:
> > src/slave/container_loggers/CMakeLists.txt, line 30
> > <https://reviews.apache.org/r/53756/diff/2/?file=1564715#file1564715line30>
> >
> > Seems like it might be easier to just `if` out the line that i
he.org/r/53961/#comment227497>
Not your fault, but I believe this is not true with our current version of
gtest. :)
- Alex Clemmer
On Nov. 21, 2016, 10:08 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail
--
>
> (Updated Nov. 21, 2016, 10:08 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
&
)
<https://reviews.apache.org/r/53963/#comment227501>
Super tiny nit: we usually include these in the
`ProcessTestsConfigure.cmake` to miniimize the number of things we have to
include in order to configure a given tests package. I don't consider this a
ship-stopper though.
- Alex C
e conscious understanding that we're not supporting 12's default CMake
installation, which makes the barrier to entry higher.
[1] https://cmake.org/cmake/help/v2.8.7/cmake.html
[2] https://cmake.org/cmake/help/v2.8.11/cmake.html
- Alex Clemmer
On Nov. 15, 2016, 3:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53327/#review157093
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 21, 2016, 10:08
saying that I'm not super
informed on how the modules packages should work...
- Alex Clemmer
On Nov. 21, 2016, 10:13 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53755/#review157099
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 23, 2016, 9:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53756/#review157102
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 10:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53757/#review157103
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 10:56
ventions.
_i.e._ I personally don't consider the changes required to be a stop-ship, but
I do consider having a plan to be a stop ship. :)
- Alex Clemmer
On Nov. 22, 2016, 8 p.m., Joseph Wu wrote:
>
> ---
> This is an automa
/CMakeLists.txt (line 33)
<https://reviews.apache.org/r/53760/#comment227525>
Minor nit: probably want to move this directory to a variable?
- Alex Clemmer
On Nov. 15, 2016, 11:09 p.m., Joseph Wu wrote:
>
> ---
> This is a
)
<https://reviews.apache.org/r/53761/#comment227526>
Interesting, for my own education: is this the same in the AC build
solution? I don't see a target like this in the AC system, but I also don't
really know what to search for.
- Alex Clemmer
On Nov. 15, 2016, 3:11 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53762/#review157110
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 21, 2016, 10:15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53763/#review157112
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 10:57
tps://reviews.apache.org/r/53764/#comment227533>
Are we deleting this line because this is included also in the `src/`
directory? Do you think there is any benefit in having submodules include
everything they need to build, themselves, rather than depending on the `src/`
directory to set it up?
- Alex C
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53765/#review157116
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 10:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53766/#review157117
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 3:18 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53767/#review157118
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 3:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53769/#review157120
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 3:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53768/#review157119
---
Ship it!
Ship It!
- Alex Clemmer
On Nov. 28, 2016, 6:48 p.m
> On Nov. 28, 2016, 6:46 p.m., Alex Clemmer wrote:
> > src/tests/CMakeLists.txt, line 17
> > <https://reviews.apache.org/r/53963/diff/1/?file=1568208#file1568208line17>
> >
> > Super tiny nit: we usually include these in the
> > `ProcessTestsConf
> On Nov. 28, 2016, 6:46 p.m., Alex Clemmer wrote:
> > cmake/MesosConfigure.cmake, line 71
> > <https://reviews.apache.org/r/53753/diff/1/?file=1563833#file1563833line71>
> >
> > Hmm. I think this is not available in CMake 2.8.0, which is the minimum
> &
1/diff/
Testing
---
Thanks,
Alex Clemmer
Diffs
-
3rdparty/libprocess/src/http.cpp ac406e2e5c2d9b38ec453a74cf47ee5f80a875df
Diff: https://reviews.apache.org/r/54271/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
Joseph Wu.
Repository: mesos
Description
---
Fix namespace resolution issue for Windows builds.
Diffs (updated)
-
src/tests/common/recordio_tests.cpp 872a1dc6ad5238c29812590de2c60139caa91288
Diff: https://reviews.apache.org/r/53551/diff/
Testing
---
Thanks,
Alex Clemmer
che.org/r/53550/diff/
Testing
---
Thanks,
Alex Clemmer
change in this review, it causes MSVC to
explode.
This commit will remove these uses.
Diffs (updated)
-
src/master/allocator/mesos/hierarchical.cpp
3b759494071c4cae4b8b7dbcb0028df4146fc30e
Diff: https://reviews.apache.org/r/53552/diff/
Testing
---
Thanks,
Alex Clemmer
src/tests/mock_docker.hpp a24f87c87bbfac96a123204883fb1771f6993d89
src/tests/utils.cpp 0a9e5a867a46795f01fcf7030f50581b5ef1341f
Diff: https://reviews.apache.org/r/52778/diff/
Testing
---
Thanks,
Alex Clemmer
be canonized and encoded
as its own function in `stout/strings.hpp` or something. It seems like we don't
want to be hand-rolling a unicode conversion in every place we need to convert
from `wchar` -> `char`, as it's super error prone. Also, it will make it easier
to mana
isit:
> https://reviews.apache.org/r/54335/
> ---
>
> (Updated Dec. 5, 2016, 5:38 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Bugs: MESOS-6677
> https://issues.apache.org/jira/browse/MESOS-6677
>
>
> Repositor
bably should use `os::runstatedir`?
>
> Alex Clemmer wrote:
> +1, thanks for the helpful suggestion Jie. We were debating what to call
> this anyway. :)
But, actually, I think I spoke too soon. The idea is actually to use this for
all the places we use a directory rooted at `/var
g a `std::string`,
so unless I'm missing something important, it seems like this should actually
not build on Unix?
- Alex Clemmer
On Dec. 5, 2016, 5:38 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatical
/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50
Diff: https://reviews.apache.org/r/54395/diff/
Testing
---
Thanks,
Alex Clemmer
6a9d94b8ac3c8fd0428b7a67d1cb3f99a658fa9b
src/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50
Diff: https://reviews.apache.org/r/54395/diff/
Testing
---
Thanks,
Alex Clemmer
ointing out that some people would argue with me on this. :)
- Alex Clemmer
On Dec. 6, 2016, 1:06 a.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To r
src/tests/main.cpp c10eeac335b0c8cdb2ea6a0701915ec33f76a2b2
src/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50
Diff: https://reviews.apache.org/r/54395/diff/
Testing
---
Thanks,
Alex Clemmer
On Dec. 6, 2016, 1:06 a.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/543
es a recursive `mkdir` before using the
> > runtime directory.
> >
> > If this is the case, this review is probably the approach we want to
> > take: https://reviews.apache.org/r/53706/
>
> Alex Clemmer wrote:
> I actually don't see it this way. As I said
a7d511ce71e2789df50aef02d2d50b4c94f38a50
Diff: https://reviews.apache.org/r/54395/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/54415/diff/
Testing
---
Thanks,
Alex Clemmer
bably should use `os::runstatedir`?
>
> Alex Clemmer wrote:
> +1, thanks for the helpful suggestion Jie. We were debating what to call
> this anyway. :)
>
> Alex Clemmer wrote:
> But, actually, I think I spoke too soon. The idea is actually to use this
> for
---
Thanks,
Alex Clemmer
/tests/environment.cpp e08678c5610332b80ce7db47e697651fa0109502
src/tests/main.cpp c10eeac335b0c8cdb2ea6a0701915ec33f76a2b2
src/tests/test_helper_main.cpp a7d511ce71e2789df50aef02d2d50b4c94f38a50
Diff: https://reviews.apache.org/r/54395/diff/
Testing
---
Thanks,
Alex Clemmer
sting
---
Thanks,
Alex Clemmer
b2b1b884
src/tests/log_tests.cpp 99954388eb0fad2acde0cedfd7daa3c9379bfb03
Diff: https://reviews.apache.org/r/53550/diff/
Testing
---
Thanks,
Alex Clemmer
hanks,
Alex Clemmer
8fd8bcb033f47e2538aa36cd373c892a882afdfd
Diff: https://reviews.apache.org/r/54470/diff/
Testing
---
Thanks,
Alex Clemmer
p.hpp
d1169dfc1e8edebe998add6e53df9b63574d83df
3rdparty/stout/include/stout/posix/os.hpp
8443aa0cf0a8d8d52e36282611c2ab15ca4dd354
3rdparty/stout/include/stout/windows/os.hpp
2f20ccc64e255a60a1b7f33d684969942f12e45f
Diff: https://reviews.apache.org/r/54489/diff/
Testing
---
Thanks,
Alex Clemmer
Agent test harness, and into
Stout's `os::temp`. For a more detailed justification, see this review.
Diffs
-
src/tests/environment.cpp ba75043a2a3813c70ed99aecfd979ba305d7a383
Diff: https://reviews.apache.org/r/54490/diff/
Testing
---
Thanks,
Alex Clemmer
stout/posix/os.hpp
8443aa0cf0a8d8d52e36282611c2ab15ca4dd354
3rdparty/stout/include/stout/windows/os.hpp
2f20ccc64e255a60a1b7f33d684969942f12e45f
Diff: https://reviews.apache.org/r/54489/diff/
Testing
---
Thanks,
Alex Clemmer
1552c
Diff: https://reviews.apache.org/r/54493/diff/
Testing
---
Thanks,
Alex Clemmer
agreed, I will look at this a little closer today and file a bug if it
looks like they shouldn't pass, or if I can't tell if they should pass.
I will update this thread when I create the bug.
- Alex
---
This is an automat
rrent implementation, libprocess manages
the APR dependency for Stout, hence, we put this logic in libprocess.
Diffs
-
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
786e47e63dc03ab4851c93ec2030f85c049cebe9
Diff: https://reviews.apache.org/r/54462/diff/
Testing
---
Thanks,
stout/posix/os.hpp
8443aa0cf0a8d8d52e36282611c2ab15ca4dd354
3rdparty/stout/include/stout/windows/os.hpp
2f20ccc64e255a60a1b7f33d684969942f12e45f
Diff: https://reviews.apache.org/r/54489/diff/
Testing
---
Thanks,
Alex Clemmer
itionTest, DisconnectedFramework)
> >
> > reconciliation_tests.cpp:
> > - TEST_F(ReconciliationTest, ReconcileStatusUpdateTaskState)
> >
> > scheduler_event_call_tests.cpp:
> > - TEST_F(SchedulerDriverEventTest, SubscribedMasterFailover)
> >
> > scheduler_tests.cpp
atically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54462/#review158469
---
On Dec. 7, 2016, 11:06 p.m., Alex Clemmer wrote:
>
> ---
> This is an automa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54470/#review158434
-------
On Dec. 7, 2016, 5:09 a.m., Alex Clemmer wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54453/#review158448
-------
On Dec. 6, 2016, 10:34 p.m., Alex Clemmer wrote:
>
> ---
2f20ccc64e255a60a1b7f33d684969942f12e45f
Diff: https://reviews.apache.org/r/54519/diff/
Testing
---
Thanks,
Alex Clemmer
c
for selecting a temporary directory to `os::temp` in preparation for
removing it from `environment.cpp`.
Diffs (updated)
-
3rdparty/stout/include/stout/os/posix/temp.hpp
823c97b30d8d2a940b6735b6d28ba2d3614e0b98
Diff: https://reviews.apache.org/r/54489/diff/
Testing
---
Thanks,
it makes it easier to read the
`!= S_OK`.
I'm not opening this as an issue, but I'm still leaving this as a comment
to give Joseph the opportunity to set me straight here. :)
[1]
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/io.cpp#L91-L97
-
ship it!" My bad.
- Alex Clemmer
On Dec. 8, 2016, 1:49 a.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
switching to, or from, doesn't have access. If that is the case, should we be
checking this here, or after we get the path back?
- Alex Clemmer
On Dec. 8, 2016, 1:59 a.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automat
; contingent on #54514 shipping. Although I
do think that changes there could end up resulting in some minor changes here,
it's reasonable to argue that this review will probably end up being pretty
simple.
- Alex Clemmer
On Dec. 8, 2016, 2:03 a.m., Andrew
-
Thanks,
Alex Clemmer
> On Dec. 8, 2016, 6:45 a.m., Alex Clemmer wrote:
> > 3rdparty/stout/include/stout/posix/os.hpp, line 477
> > <https://reviews.apache.org/r/54514/diff/1/?file=1579536#file1579536line477>
> >
> > I'm wondering if someone can speak to how we expect `ru
otobuf
config, build, and install commands. For example:
```
set(PROTOBUF_BUILD_CMD ${PROTOBUF_BUILD_CMD} ${PROTOBUF_JAVA_BUILD_CMD})
```
This should cause the normal protobuf build to build the Java stuff as
well, no?
- Alex Clemmer
On Dec. 8,
p.hpp
d1169dfc1e8edebe998add6e53df9b63574d83df
Diff: https://reviews.apache.org/r/54489/diff/
Testing
---
Thanks,
Alex Clemmer
es, this was leftover from when I tried to make the flag
`-DHAS_AUTHENTICATION=${HAS_AUTHENTICATION}`, which ended up not working. I
should have changed it to `ON`.
- Alex
---
This is an automatically generated e-mail.
s.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
support/windows-build.bat b3b6d0bbe877cf3794a5c616374ffce8c1b1552c
Diff: https://reviews.apache.org/r/54493/diff/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54607/#review158721
---
Ship it!
Ship It!
- Alex Clemmer
On Dec. 9, 2016, 7:51 p.m
the Agent tests build.
Diffs
-
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
---
Thanks,
Alex Clemmer
ing
---
Thanks,
Alex Clemmer
eview158618
-------
On Dec. 9, 2016, 7:47 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54489/
MSVC > 1900, and add the file to the Agent tests build.
Diffs
-
src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75
src/tests/common/recordio_tests.cpp 63e284acced8ab0d3528e518ddf0a06c9cfa9777
Diff: https://reviews.apache.org/r/54611/diff/
Testing
---
Thanks,
A
/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
Windows build.
Diffs (updated)
-
src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c
Diff: https://reviews.apache.org/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
mbiguity and causes most tests in `files_tests.cpp` to pass.
Diffs
-
3rdparty/stout/include/stout/os/write.hpp
24a69d8f60efd3c2888d464d75164c758b3701a2
Diff: https://reviews.apache.org/r/54631/diff/
Testing
---
Thanks,
Alex Clemmer
Windows build.
Diffs (updated)
-
src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c
Diff: https://reviews.apache.org/r/54618/diff/
Testing
---
Thanks,
Alex Clemmer
103f9
src/Makefile.am 5736349e9b898f0e46ccfdaa73d437e2bc4974dc
src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
support/windows-build.bat b3b6d0bbe877cf3794a5c616374ffce8c1b1552c
Diff: https://reviews.apache.org/r/54493/diff/
Testing
---
Thanks,
Alex Clemmer
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54631/#review158786
---
On Dec. 10, 2016, 10:51 p.m., Alex Clemmer wrote:
>
>
32d9c39a415631d17b9a26941406e8
src/tests/status_update_manager_tests.cpp
38d8913a5b33aa5325d0bc632c0a1d80480eddf8
src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54678/#review158912
---
Ship it!
- Alex Clemmer
On Dec. 12, 2016, 10:26 p.m., John
ocess/src/tests/http_tests.cpp
822cdb3931d3e30713aa78995427f364e41bfb30
Diff: https://reviews.apache.org/r/54685/diff/
Testing
---
Thanks,
Alex Clemmer
288bb81ac9876c8b
Diff: https://reviews.apache.org/r/54677/diff/
Testing
---
Thanks,
Alex Clemmer
> On Dec. 8, 2016, 8:59 p.m., Alex Clemmer wrote:
> > 3rdparty/CMakeLists.txt, line 347
> > <https://reviews.apache.org/r/50415/diff/6/?file=1579858#file1579858line347>
> >
> > If I'm understanding this correctly, this will download a fresh copy of
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54792/#review159337
---
Ship it!
Ship It!
- Alex Clemmer
On Dec. 15, 2016, 6:07 p.m
u.hpp
1bb70964adbb80aa6502fbfe69de2c34dc74e655
3rdparty/stout/tests/os_tests.cpp bed1449ef8855932a1fefd3aeb3386ab9abd0307
Diff: https://reviews.apache.org/r/54800/diff/
Testing
---
Thanks,
Alex Clemmer
ache.org/r/53706/.
Agreement is, Joseph will check this in under Daniel's name so he retains
credit.
Thanks,
Alex Clemmer
801 - 900 of 1316 matches
Mail list logo
