Ubuntu 14.04.
Thanks,
Greg Mann
o use authentication when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new tests
were run 1000 times to look for flakiness.
Thanks,
Greg Mann
-website-container
Thanks,
Greg Mann
ws.apache.org/r/44515/
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review123146
---
On March 11, 2016, 3:52 p.m., Greg
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review123144
---
On March 11, 2016, 9:39 a.m., Greg Mann wrote:
&g
/diff/
Testing
---
Thanks,
Greg Mann
k for flakiness.
Thanks,
Greg Mann
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
> On March 10, 2016, 8:45 a.m., Adam B wrote:
> > src/tests/mesos.cpp, lines 182-184
> > <https://reviews.apache.org/r/44515/diff/2/?file=1293632#file1293632line182>
> >
> > Any reason you can't reuse the previous `path` and `fd` variables?
>
/diff/
Testing
---
Thanks,
Greg Mann
ace-delimited format. I changed the
comments to include the JSON array in a string representation.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review123158
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123168
---
Ship it!
Ship It!
- Greg Mann
On March 11, 2016, 4:48 p.m
ed to use authentication when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new tests
were run 1000 times to look for flakiness.
Thanks,
tps://reviews.apache.org/r/44186/#comment185365>
Also need to update the Docker tests:
grep -nr "\"state\"" src/tests/*
src/tests/containerizer/docker_containerizer_tests.cpp:512:
Future response = http::get(master.get(), "state");
- Greg Mann
agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
ince this file contains other tests which have nothing to do with HTTP
endpoints, perhaps this name should be a bit more descriptive? Something like
`RolesEndpointBadAuthentication`?
- Greg Mann
On March 10, 2016, 2:41 p.m., Joerg Schad wrote:
>
> --
called.
We should create a separate JIRA for making all of the messages metrics
consistent with respect to when they get incremented.
In a separate patch, could you add documentation for these metrics to
docs/monitoring.md?
- Greg Mann
On March 10, 201
tomatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44255/
> ---
>
> (Updated March 10, 2016, 2:42 a.m.)
>
>
> Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Ji
.
Diffs
-
Diff: https://reviews.apache.org/r/44590/diff/
Testing
---
Thanks,
Greg Mann
/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b
docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd
Diff: https://reviews.apache.org/r/44554/diff/
Testing
---
Viewed with the Mesos website container:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
cf2bb762272fa38e04e5c26aef2858300bbd0459
Diff: https://reviews.apache.org/r/44678/diff/
Testing
---
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
sting
---
Thanks,
Greg Mann
5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
aster/constants.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472
src/master/constants.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44523/diff/
Testing
---
`make check`
Thanks,
Greg Mann
when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
on realm."?
Good idea; done!
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review123316
---
On
s.hpp a188da30a8b55e884acc7e2f570ef0a9272e7472
Diff: https://reviews.apache.org/r/44523/diff/
Testing
---
`make check`
Thanks,
Greg Mann
cf2bb762272fa38e04e5c26aef2858300bbd0459
Diff: https://reviews.apache.org/r/44678/diff/
Testing
---
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
put parameters for any given HTTP authN module is defined arbitrarily by
the module's implementation, but perhaps that's not the case?
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/diff/
Testing
---
Thanks,
Greg Mann
.
Thanks,
Greg Mann
basic HTTP authenticator, and to adhere to the new credentials format in the
module parameters. A new test was also added:
`HttpAuthenticationTest.BasicWithoutRealm`
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
tps://reviews.apache.org/r/44767/#comment185758>
I wonder if the shorthand "iff" might be a bit too esoteric for these help
strings?
- Greg Mann
On March 14, 2016, 6:18 a.m., Joerg Schad wrote:
>
> ---
> This is an
To reply, visit:
> https://reviews.apache.org/r/44766/
> ---
>
> (Updated March 13, 2016, 10:31 p.m.)
>
>
> Review request for mesos, Adam B and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Enabled endpoint HELP stri
(https://github.com/mesosphere/mesos-website-container) and the newlines have
no effect, you need to explicitly include a line break with something like
``.
- Greg Mann
On March 15, 2016, 1:22 p.m., Alexander Rukletsov wrote:
>
> ---
7168/#comment185935>
Should this comment be a TODO?
src/examples/dynamic_reservation_framework.cpp (line 441)
<https://reviews.apache.org/r/37168/#comment185937>
Now that we have implicit roles, I don't think this is necessary?
- Greg Mann
On March 7, 2016, 9:20 a.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review123630
---
On March 14, 2016, 4:17 a.m., Greg Mann wrote:
>
> --
command-line
credentials to the agent with the `--http_credentials` flag. Depending on which
one of these lands first, the other one should be updated to remain consistent.
- Greg Mann
On March 15, 2016, 2:01 p.m., Jan Schlicht wrote
and Ubuntu 14.04.
Thanks,
Greg Mann
> On March 15, 2016, 6:53 p.m., Greg Mann wrote:
> > FYI, this review: https://reviews.apache.org/r/44515/ adds command-line
> > credentials to the agent with the `--http_credentials` flag. Depending on
> > which one of these lands first, the other one should
:
https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
does it make sense to only document the new json format here?
>
> Joerg Schad wrote:
> Mesos-2281
>
> Greg Mann wrote:
> Perhaps we should see which patch lands first, and update the other one
> accordingly? I can put a comment on Jan's review so that he'
ion
--next=/path/to/later/version`
Thanks,
Greg Mann
ation when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
o use authentication when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
> On March 16, 2016, 6:27 p.m., Greg Mann wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 119
> > <https://reviews.apache.org/r/37168/diff/12/?file=1300732#file1300732line119>
> >
> > Could you clarify for me how the slave gets into the RESER
when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
as bad as
I thought.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44989/#review124159
---
On March 18, 20
the authentication realm to the
basic HTTP authenticator, and to adhere to the new credentials format in the
module parameters. A new test was also added:
`HttpAuthenticationTest.BasicWithoutRealm`
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review124154
---
On March 18, 2016, 6:13 p.m., Greg Mann wrote:
>
> --
s.hpp 12a1fd70a06bb93331c2772b85769c35d0d9bf08
Diff: https://reviews.apache.org/r/44523/diff/
Testing
---
`make check`
Thanks,
Greg Mann
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
s that just mean
> > that nobody can authenticate? Is that still a valid authenticator?
>
> Greg Mann wrote:
> We have a test that explicitly tests for this case
> (`HttpAuthenticationTest.BasicWithoutCredentialsTest`), so it seems to be
> valid? I could imagine it as
w "authentication_realm" module parameter to the
> > Authenticator module interface?
> > Why not just use `BasicAuthenticatorFactory::create(const string realm,
> > const Parameters& parameters)`?
>
> Greg Mann wrote:
> One could certainly use the
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
/mesos-website-container
Thanks,
Greg Mann
_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15
Diff: https://reviews.apache.org/r/44989/diff/
Testing
---
`GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves"
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
seems to me we should have something here similar to what's in
the switch for `State::UNRESERVING`, i.e., check the offer and see if the
reserved resources are contained in it? The framework test passes for me
though, so it seems to be working nonetheless?
- Greg Mann
On March 16, 2016,
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review124151
---
On March 18, 2016, 5:28 p.m., Greg Mann wrote:
>
> ---
> This is an aut
improves readability slightly, as it announces up front that this test
will be run with the clock paused.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44989/#revi
Testing
---
`GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves"
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44678/#review124111
---
On March 18, 2016, 12:20 a.m., Greg Mann wrote:
>
> -
apache.org/r/44989/diff/
Testing
---
`GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves"
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
sting
---
Thanks,
Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review123800
---
On March 16, 2016, 12:18 a.m., Greg Mann wrote:
>
> ---
apache.org/r/44989/diff/
Testing
---
`GTEST_FILTER="ResourceOffersTest.ResourceOfferWithMultipleSlaves"
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
istent across the tests; I could have a look next week.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44989/#review124116
---
authentication realm to the
basic HTTP authenticator, and to adhere to the new credentials format in the
module parameters. A new test was also added:
`HttpAuthenticationTest.BasicWithoutRealm`
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
-container
Thanks,
Greg Mann
/diff/
Testing
---
Thanks,
Greg Mann
the authentication realm to the
basic HTTP authenticator, and to adhere to the new credentials format in the
module parameters. A new test was also added:
`HttpAuthenticationTest.BasicWithoutRealm`
`make check` was used to test on both OSX and CentOS 7.
Thanks,
Greg Mann
/diff/
Testing
---
Thanks,
Greg Mann
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review124387
---
On March 20, 2016, 5:27 p.m., Greg Mann wrote:
>
> ---
&
agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
ilure=1` was used to
test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
c flag of either the master or agent,
or they want to look over the entire list of flags for either the master or
agent. In either case, I think that splitting up the flags makes it a little
harder for them to find what they want. Thoughts?
- Greg Mann
On March 19, 2016,
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review124398
---
On March 18, 2016, 7:30 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/mesos-website-container
Thanks,
Greg Mann
text was improved slightly, and this patch edits the master's help
string to match that of the agent.
Diffs
-
src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
Diff: https://reviews.apache.org/r/45088/diff/
Testing
---
Thanks,
Greg Mann
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44515/#review124401
---
On March 20, 2016, 5:27 p.m., Greg Mann wrote:
>
> ---
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
/mesosphere/mesos-website-container
Thanks,
Greg Mann
4
src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
Diff: https://reviews.apache.org/r/45088/diff/
Testing
---
Thanks,
Greg Mann
o use authentication when hitting the affected agent
endpoints, and new tests were added to probe the endpoint behavior when invalid
credentials are supplied.
`sudo make check` was used to test on both OSX and Ubuntu 14.04. The new test
was run 1000 times to look for flakiness.
Thanks,
Greg Mann
------
On March 21, 2016, 4:24 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> ---
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg Mann
> On March 19, 2016, 10:03 a.m., Joerg Schad wrote:
> > src/slave/slave.cpp, line 373
> > <https://reviews.apache.org/r/44515/diff/11/?file=1306306#file1306306line373>
> >
> > Do we actually have to get the authenticator above if this flag is not
> &g
b77afa956834bb5b1f85301d7a5f386ab9da41e3
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5
Diff: https://reviews.apache.org/r/44515/diff/
Testing
---
`sudo make check` was used to test on both OSX and Ubuntu 14.04.
Thanks,
Greg
-------
On March 21, 2016, 3:42 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44515/
> --
/dynamic_reservation_framework.cpp (line 118)
<https://reviews.apache.org/r/37168/#comment187224>
s/launch task/launch a task/
src/examples/dynamic_reservation_framework.cpp (line 120)
<https://reviews.apache.org/r/37168/#comment187223>
s/lanuch/launch/
- Greg Mann
On March 18, 2016, 6:47 a.m., Kl
ly, i.e. the behavior of `Resources::find` with respect to
the framework's role?
- Greg Mann
On March 17, 2016, 1:39 a.m., Jian Qiu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
/to/later/version`
Thanks,
Greg Mann
ation, so the
credential file is now used.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review123800
---
On March 21,
)
<https://reviews.apache.org/r/44255/#comment187499>
Blank line after this?
- Greg Mann
On March 14, 2016, 5:50 a.m., fan du wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
401 - 500 of 3738 matches
Mail list logo
