Re: Review Request 50599: Added a new 'device' entry to 'docker::Flags'.

.org/r/50599/#comment210338> I'd prefer that you show an example here as the comment for the `nvidiaGpuDevices`. - Guangya Liu On 七月 29, 2016, 9:54 a.m., Yubo Li wrote: > > --- > This is an automatically generated

Re: Review Request 50128: Added helpful functions to 'Docker::Device'.

functions to 'Docker::Device'.` and add more detail in `Description` section for what does those helper function do. - Guangya Liu On 七月 29, 2016, 9:52 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 50128: Added helpful functions to 'Docker::Device'.

NFO) << "Parse device information error for '" << device << "', PathInHost:PathInContainer:Permission expected"; ``` src/docker/docker.cpp (lines 389 - 391) <https://reviews.apache.org/r/50128/#comment210324> We prefer ``` Device device = Devic

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1550-1561 > > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line1550> > > > > Why release the gpu resources here? The `update` will also be

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

Future> allocate = allocator->allocate(requested); allocate.await(); if (!allocate.isReady()) { return Failure("GPU allocator allocating GPU failed"); } ``` - Guangya Liu On 七月 29, 2016, 5:42 a.m., Yubo Li wrote: > >

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources ports(*):[3-5] Took 3.631125secs to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources ports(*):[3-5] [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (12961 ms) ``` Thanks, Guangya Liu

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

eve Klaus > > took this approach initially but I had removed 'initial' to simplify the > > patch. > > > > If we make it a parameter we can have initial ports only for the port > > test case. > > Guangya Liu wrote: > Hi Ben, one quick ques

Re: Review Request 50569: Checked if resource is negative scalar directly in subtract.

Took 9220us to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5817 ms) [--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (98270 ms total) ``` Thanks, Guangya Liu

Re: Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

> > if (negative || isEmpty(*resource)) { > > ... > > } > > ``` > > > > Since isNegative only applies to Scalar, it seems a bit odd to expose > > it as a function. Whereas isEmpty applies to all resource types.

Re: Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

uangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50569/#review144190 --- On 七月 29, 2016, 5:43 a.m., Guang

Re: Review Request 49571: Added a benchmark test for allocations.

6000U)) ); ``` - Guangya Liu On 七月 28, 2016, 10:46 p.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

`nonRevocale`, so I think the test case for it will be covered by `nonRevocable`. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/#review144179 -------

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/#review144175 ------- On 七月 25, 2016, 1:43 p.m., Guangya Liu wrote: > > ---

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review144060 --- On 七月 20, 2016, 3:22 a.m., Guangya Liu wrote: > > --- > This is

Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (32854 ms) ``` Thanks, Guangya Liu

Re: Review Request 49571: Added a benchmark test for allocations.

brace, I think it is not needed src/tests/hierarchical_allocator_tests.cpp (line 3604) <https://reviews.apache.org/r/49571/#comment210028> s/background/batch - Guangya Liu On 七月 28, 2016, 10:46 p.m., Anindya Sinha wrote: > > -

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

source( "256", "test", "persistentId", "/volume", None(), true); Parameter shared; shared.resources = Resources::parse("cpus:1;mem:128").get() + disk; shared.totalOperations = 5; ``` - Guang

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

--------- On 七月 29, 2016, 1:34 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50568/ > ---

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

3c85dc8aa8125962b44e60806ece83a7653d0dc7 Diff: https://reviews.apache.org/r/50568/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 49616: Add suppression benchmark.

g/r/49616/#comment209985> What about the following, I think this is good enough and also other benchmark test are using such format. ``` // Advance the clock and trigger a batch allocation. Clock::advance(flags.allocation_interval); Clock::settle(); ``` - Guangya Li

Review Request 50568: Updated -=/+= to subtract/add for resource object.

://reviews.apache.org/r/50568/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

, 4-5, 7-8, 10-11, 13-14, 16-17, 1... Took 3.699126secs to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (34789 ms) ``` Thanks, Guangya Liu

Re: Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

ions on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... Took 3.760281secs to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... Took 125159us to perform 1000 'r.nonRevocable()' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (35204 ms) ``` Thanks, Guangya Liu

Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

-17, 1... Took 3.760281secs to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... Took 125159us to perform 1000 'r.nonRevocable()' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (35204 ms) ``` Thanks, Guangya Liu

Re: Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

, 4-5, 7-8, 10-11, 13-14, 16-17, 1... Took 3.699126secs to perform 1000 'total = total - r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (34789 ms) ``` Thanks, Guangya Liu

Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

13-14, 16-17, 1... Took 8.517941secs to perform 1000 'r.nonRevocable()' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (43985 ms) [--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (219403 ms total) [--] Global test environment tear-down [==] 3 tests from 1 test case ran. (219420 ms total) [ PASSED ] 3 tests. ``` Thanks, Guangya Liu

Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (34789 ms) ``` Thanks, Guangya Liu

Review Request 50551: Added benchmark test for `Resources::contains`.

93001 ms total) [--] Global test environment tear-down [==] 3 tests from 1 test case ran. (193024 ms total) [ PASSED ] 3 tests. ``` Thanks, Guangya Liu

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

hy not construct the `docker run` parameters for `nvidia devices` directly in `launchTask`? - Guangya Liu On 七月 18, 2016, 9:17 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 50124: Added '--device' flag to mesos-docker-executor.

ker.cpp (line 1425) <https://reviews.apache.org/r/50124/#comment209613> same comment as https://reviews.apache.org/r/50123/ , put the logic of `nvidiaGpus` to a new patch - Guangya Liu On July 18, 2016, 9:20 a.m., Yubo Li wrote: > > --

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On July 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 349 > > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line349> > > > > Why do you add the comment here? This flag does not seems to related to

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

src/slave/containerizer/docker.cpp (lines 1550 - 1561) <https://reviews.apache.org/r/50123/#comment209601> Why release the gpu resources here? The `update` will also be called when the executor is launched. - Guangya Liu On 七月 18, 2016, 9:17 a.m., Yubo Li wrote: > >

Re: Review Request 49689: Added Appc runtime isolator tests.

me_isolator_tests.cpp (lines 346 - 347) <https://reviews.apache.org/r/49689/#comment209572> You should also call an `ASSERT_TRUE(os::exists(xxx))` here to make sure the image exist. src/tests/containerizer/appc_runtime_isolator_tests.cpp (line 4

Re: Review Request 43569: Updated log message if container not found.

: https://reviews.apache.org/r/43569/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

t209502> how about ``` allocator->deallocate(deallocated); ``` Why do you need a `.get()` at last? src/slave/containerizer/docker.cpp (lines 1917 - 1926) <https://reviews.apache.org/r/50123/#comment209507> ditto as above for the

Re: Review Request 43569: Updated log message if container not found.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review143602 --- On 三月 23, 2016, 1:50 p.m., Guangya Liu wrote: > > ---

Review Request 50441: Added a blank line in common/resources.cpp.

--- Added a blank line in common/resources.cpp to keep two lines between each method. Diffs - src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb Diff: https://reviews.apache.org/r/50441/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 49616: Add suppression benchmark.

> On 七月 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3637 > > <https://reviews.apache.org/r/49616/diff/5/?file=1452185#file1452185line3637> > > > > Add the elapse time of adding slave here, an example here > &g

Re: Review Request 49616: Add suppression benchmark.

``` Try<::mesos::Value::Ranges> ranges = fragment(createRange(31000, 32000), 16); ASSERT_SOME(ranges); ASSERT_EQ(16, ranges->range_size()); allocation += createPorts(ranges.get()); ``` - Guangya Liu On 七月 26, 2016, 7:03 a.m., Jacob Janco wrote: > > --

Re: Review Request 49616: Add suppression benchmark.

/tests/hierarchical_allocator_tests.cpp (line 3677) <https://reviews.apache.org/r/49616/#comment209300> add a `watch.stop()` here to be more accurate - Guangya Liu On 七月 26, 2016, 5:29 a.m., Jacob Janco wrote: > > ---

Re: Review Request 49616: Add suppression benchmark.

> On 七月 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3625 > > <https://reviews.apache.org/r/49616/diff/5/?file=1452185#file1452185line3625> > > > > What about adding some check for the ranges? &g

Re: Review Request 49616: Add suppression benchmark.

https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3714 - Guangya Liu On 七月 26, 2016, 5:29 a.m., Jacob Janco wrote: > > --- > This is an automatically generate

Re: Review Request 49616: Add suppression benchmark.

> On 七月 23, 2016, 1:37 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3574-3575 > > > > > > We use size_t as the type of "size" / "count" / "index" variables in > > general, as i

Review Request 50423: Avoided using integers as booleans.

/containerizer/mesos/containerizer.cpp 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 Diff: https://reviews.apache.org/r/50423/diff/ Testing --- make make check Thanks, Guangya Liu

Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (12501 ms total) [--] Global test environment tear-down [======] 1 test from 1 test case ran. (12518 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50387: Updated allocated number of range to 100 for sorter benchmark test.

ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Review Request 50387: Updated port range fragments to 100.

AgentAndClientCount/Sorter_BENCHMARK_Test (45996 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (46019 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

- r' operations on ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (6164 ms) [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (6164 ms total) [--] Global test environment tear-down [======] 1 test fr

Review Request 50382: Added number of filtered offers to allocator benchmark test.

15 allocate() took 725789us to make 1000 offers after filtered out 16000 offers round 16 allocate() took 736272us to make 1000 offers after filtered out 17000 offers round 17 allocate() took 758355us to make 1000 offers after filtered out 18000 offers ... ``` Thanks, Guangya Liu

Review Request 50374: Used `size_t` as the type of "size", "count" and "index".

erarchical_allocator_tests.cpp bb6947fcecb5b78047e98d10fc1278c612a69548 Diff: https://reviews.apache.org/r/50374/diff/ Testing --- make make check Thanks, Guangya Liu

Review Request 50365: Removed `C` framework support from framework developer guide.

, Guangya Liu

Re: Review Request 50062: Refactored `makePortRanges` for allocator benchmark test.

src/tests/hierarchical_allocator_tests.cpp befb94adb15e051abae135c7697538bd0cf83852 Diff: https://reviews.apache.org/r/50062/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

AgentAndClientCount/Sorter_BENCHMARK_Test (115 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (133 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Review Request 50261: Updated allocator test helper function `makeLabels` more readable.

2.488205secs to make 1000 offers round 4 allocate() took 2.479436secs to make 1000 offers ``` Thanks, Guangya Liu

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

ENCHMARK_Test.Arithmetic/2 (6164 ms) [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (6164 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (6187 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

AgentAndClientCount/Sorter_BENCHMARK_Test (115 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (133 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

m 3 to make sure there is no overlap, so what about the following logic: [1-10], 1 -> [1-2] [1-10], 2 -> [1-2,5-6] [1-10], 3 -> [1-2,4-5,7-8] [1-10], 4 -> [1-1,3-3,5-5,7-7] [1-10], 5 -> [1-1,3-3,5-5,7-7,9-9] ``` if (step < 3) { start = bounds.begin() + (i * 2); end = start; } else { start = bounds.begin() + (i * step);

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

test from AgentAndClientCount/Sorter_BENCHMARK_Test (115 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (133 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

=] 1 test from 1 test case ran. (133 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50062: Updated makePortRanges for variable types.

annot be satisfied. E.g. [1-10] can be fragmented into at most 5 ranges [1,3,5,7,9], so fragment([1-10], 6) returns an error. ``` - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/#review142607 -

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

me for this, hope it is OK. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/#review142608 --- On 七月 18, 2016, 3:32 a.m., Guangya L

Review Request 50138: Synced up common/values.cpp and v1/values.cpp.

3e0f739b69e680f9eb29ed36d4501c393758c861 Diff: https://reviews.apache.org/r/50138/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 50017: WIP: Validated the resources when parsing it.

esources_BENCHMARK_Test.Arithmetic/2 (5966 ms) [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (5966 ms total) [--] Global test environment tear-down [======] 1 test from 1 test case ran. (5988 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 50017: WIP: Validated the resources when parsing it.

lientCount/Sorter_BENCHMARK_Test.FullSort/35 (1057 ms) Thanks, Guangya Liu

Review Request 50117: Added more elapse time for allocator benchmark test.

from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (10055 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (10079 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 (4493 ms) [--] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (4495 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (4520 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 50062: Updated makePortRanges for variable types.

/ Testing --- make make check Thanks, Guangya Liu

Review Request 50062: Updated makePortRanges for variable types.

, Guangya Liu

Re: Review Request 49784: Increase framework numbers to allocator benchmarks.

> On 七月 12, 2016, 4:32 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3196 > > <https://reviews.apache.org/r/49784/diff/1/?file=1439341#file1439341line3196> > > > > Two issues for this patch: > > > > 1)

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

> On 七月 15, 2016, 1:42 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199 > > <https://reviews.apache.org/r/49232/diff/11/?file=1444089#file1444089line199> > > > > I recalled Gilbert asked why returning `Futu

Re: Review Request 50081: Refactored docker/docker.cpp to use path::absolute().

> (Updated 七月 15, 2016, 7:07 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy > Chen. > > > Repository: mesos > > > Description > --- > > Refactored docker/docker.cpp to use path::ab

Re: Review Request 50017: WIP: Validated the resources when parsing it.

Resources`'. > > > > However, we have to keep the validation in '`operator += (const > > Resource& r)`', since '`r`' is just a protobuf coming from an arbitrary > > caller, it may be invalid and we need to validate. > > &g

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

g/r/49232/#comment207932> move this before L213. src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 403) <https://reviews.apache.org/r/49232/#comment207936> 4 spaces for the indent - Guangya Liu On 七月 14, 2016, 5:28 p.m., Srinivas

Re: Review Request 50017: WIP: Validated the resources when parsing it.

rce` or `Resources` object. - Guangya ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review142257 ---

Re: Review Request 49843: Added benchmark test for sorter.

> > resource.set_type(Value::RANGES); > > resource.mutable_ranges()->CopyFrom(value.ranges()); > > > > return resource; > > } > > ``` > > > > Since we only care about the number of ranges, we don't need to s

Re: Review Request 50061: Removed the trailing semi-colon when parse resources.

, Guangya Liu

Re: Review Request 50061: Removed the trailing semi-colon when parse resources.

/nvidia_gpu_isolator_tests.cpp 7944c0da716b2438fa2b40f5504aefa346e31046 src/tests/hierarchical_allocator_tests.cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb Diff: https://reviews.apache.org/r/50061/diff/ Testing --- make make check Thanks, Guangya Liu

Review Request 50061: Removed the trailing semi-colon when parse resources.

: https://reviews.apache.org/r/50061/diff/ Testing --- make make check Thanks, Guangya Liu

Re: Review Request 49843: Added benchmark test for sorter.

er`, yes, we should also make the time of adding agents accurate. > On 七月 14, 2016, 7:14 p.m., Benjamin Mahler wrote: > > src/tests/sorter_tests.cpp, lines 515-516 > > <https://reviews.apache.org/r/49843/diff/3/?file=1442032#file1442032line515> > > > >

Review Request 50060: Always call watch.stop() to get an accurate time for benchmark test.

cpp 153c9b4cf4819e976910c5a7ad9602028e2d22eb Diff: https://reviews.apache.org/r/50060/diff/ Testing --- ./bin/mesos-tests.sh --benchmark --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.*/1" Thanks, Guangya Liu

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

-- > > (Updated 七月 14, 2016, 7:35 p.m.) > > > Review request for mesos, Guangya Liu, Klaus Ma, and Jiang Yan Xu. > > > Repository: mesos > > > Description > --- > > We now prefer to use vector rather tha

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

de ``` src/tests/sorter_tests.cpp (line 40) <https://reviews.apache.org/r/50044/#comment207890> remove this - Guangya Liu On 七月 14, 2016, 7:35 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated

Review Request 50017: WIP: Validated the resources when parsing it.

ullSort/35 Using 5 agents and 1000 clients Added 1000 clients in 21472us **Added 5 agents in 916653us** Sorted 1000 clients in 37369us [ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35 (1057 ms) Thanks, Guangya Liu

Re: Review Request 50022: Fixed incorrected command in documentation.

> On 七月 14, 2016, 10:35 a.m., Guangya Liu wrote: > > I think we should not merge this, the mesos-execute should use mesos > > containerizer but not docker containerizer here, comments? > > Joerg Schad wrote: > Good point. I was mostly concerned with the command not

Re: Review Request 50022: Fixed incorrected command in documentation.

mesos containerizer but not docker containerizer here, comments? - Guangya Liu On July 14, 2016, 8:32 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On 七月 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 568-570 > > <https://reviews.apache.org/r/49961/diff/1/?file=1442433#file1442433line568> > > > > why this does not work if I was using relative path for both? Here the &g

Re: Review Request 49961: Supported relative container path in docker containerizer.

> On 七月 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 562 > > <https://reviews.apache.org/r/49961/diff/1/?file=1442433#file1442433line562> > > > > what about `path::absolute(volume.container_path())`? > > Jie Yu wrote: >

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On 七月 13, 2016, 1:32 p.m., Guangya Liu wrote: > > @Lin Shuai, can you please help rebase this? I did some clean up before for src/tests/containerizer/filesystem_isolator_tests.cpp here https://reviews.apache.org/r/44160/ , for the new added test cases, instead of keeping consist

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

omment207557> ```javascript EXPECT_EQ(0, wait->status()); ``` src/tests/containerizer/provisioner_docker_tests.cpp (line 578) <https://reviews.apache.org/r/47095/#comment207558> ```javascript SlaveID slaveId = slaveRegisteredMessage->slave_id(); ``` - Guangya Liu On 五月

Re: Review Request 49232: Added appcManifest to ImageIt nfo and ProvisionInfo.

ne 70 src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 211 - 212) <https://reviews.apache.org/r/49232/#comment207539> a new line here - Guangya Liu On 七月 12, 2016, 4:14 p.m., Srinivas Brahmaroutu wrote: > >

Re: Review Request 49232: Added appcManifest to ImageIt nfo and ProvisionInfo.

> On 七月 12, 2016, 6:42 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 212-221 > > > > > > You just need to check isError here. Yes, you can refer to https://github.com

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

ttps://reviews.apache.org/r/49208/#comment207502> kill this line - Guangya Liu On 七月 12, 2016, 4:14 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an auto

Re: Review Request 49961: Supported relative container path in docker containerizer.

/reviews.apache.org/r/49961/#comment207495> what about print out the `host_path` and `container_path` in the log message? src/docker/docker.cpp (line 579) <https://reviews.apache.org/r/49961/#comment207493> not yours, but it is better do a clean up here: s/dirver/driver - Guan

Re: Review Request 49960: Added private registry with auth document and fixed correspondings.

tps://reviews.apache.org/r/49960/#comment207488> What about following update to make the document consistent. .docker/config.json => `.docker/config.json` .dockercfg => `.dockercfg` docs/docker-containerizer.md (line 107) <https://reviews.apache.org/r/49960/#comment207489>

<    1   2   3   4   5   6   7   8   9   10   >