://reviews.apache.org/r/60622/diff/5-6/
Testing
---
See upstream
Thanks,
Jeff Coffler
2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/6/
Changes: https://reviews.apache.org/r/60626/diff/5-6/
Testing
---
See upstream
Thanks,
Jeff Coffler
: https://reviews.apache.org/r/60624/diff/6/
Changes: https://reviews.apache.org/r/60624/diff/5-6/
Testing
---
See upstream
Thanks,
Jeff Coffler
df9d2d9586a6457004506c4e2a972ccfc912c7c5
Diff: https://reviews.apache.org/r/60628/diff/6/
Changes: https://reviews.apache.org/r/60628/diff/5-6/
Testing
---
See upstream.
Thanks,
Jeff Coffler
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60624/#review188418
-------
On Oct. 17, 2017, 1:18 a.m., Jeff Coffler wrote:
>
> ---
> This is
df9d2d9586a6457004506c4e2a972ccfc912c7c5
Diff: https://reviews.apache.org/r/60628/diff/5/
Changes: https://reviews.apache.org/r/60628/diff/4-5/
Testing
---
See upstream.
Thanks,
Jeff Coffler
t; <https://reviews.apache.org/r/60628/diff/4/?file=1858878#file1858878line925>
> >
> > Nit: s/doesns't/doesn't/
Ok.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
http
: https://reviews.apache.org/r/60624/diff/5/
Changes: https://reviews.apache.org/r/60624/diff/4-5/
Testing
---
See upstream
Thanks,
Jeff Coffler
623/diff/5/
Changes: https://reviews.apache.org/r/60623/diff/4-5/
Testing
---
See upstream
Thanks,
Jeff Coffler
one, dozen of another. I'll leave this one to Joe to change if he wants.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60626/#review188428
-------
2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/5/
Changes: https://reviews.apache.org/r/60626/diff/4-5/
Testing
---
See upstream
Thanks,
Jeff Coffler
haps mention why
> > we replace `` with `/` on Windows.
Ok.
- Jeff
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review188414
---
://reviews.apache.org/r/60622/diff/4-5/
Testing
---
See upstream
Thanks,
Jeff Coffler
nit: indentation
Fixed.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60621/#review188413
---
On Oct. 17, 2017,
Diff: https://reviews.apache.org/r/60621/diff/5/
Changes: https://reviews.apache.org/r/60621/diff/4-5/
Testing
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
ntroduced
Removed blank line.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review188412
---
On Oct.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64689/#review194167
---
Ship it!
Ship It!
- Jeff Coffler
On Dec. 19, 2017, 3:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/#review194165
---
Ship it!
Ship It!
- Jeff Coffler
On Dec. 19, 2017, 3:35 a.m
---
Thanks,
Jeff Coffler
visit:
https://reviews.apache.org/r/64720/#review194179
-------
On Dec. 19, 2017, 7:33 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generat
ges: https://reviews.apache.org/r/63253/diff/4-5/
Testing
---
Ran mesos-tests on both Windows and Linux with no errors.
Specifically ran mesos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
ndrew Schwartzmeyer wrote:
> Ah, thank you for the detailed explanation. Unfortunately, the existing
> error handling code was using the leaf approach, and we kept it consistent,
> but consistently wrong. We'll have to do a sweep to fix it.
>
> This explanation was
..)`, right?
> > I think for now we just use `strings::join('/', ...)`
> > in the codebase. Could we do that here and below, for now rather than
> > introducing a `url::join`?
>
> Jeff Coffler wrote:
> I guess, if we had a url::join(), but we don't, and I'm no
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review191264
---
On Nov. 6, 2017, 6:09 p.m., Jeff Coffler wrote:
>
> --
-------
On Nov. 6, 2017, 6:09 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60626/
> ---
://reviews.apache.org/r/60620/diff/8/
Changes: https://reviews.apache.org/r/60620/diff/7-8/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
ges: https://reviews.apache.org/r/63253/diff/5-6/
Testing
---
Ran mesos-tests on both Windows and Linux with no errors.
Specifically ran mesos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
that WSUCCEEDED is defined in
src/common/status_utils.hpp, and this is stout, so I can't include that here.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60621/#rev
PRE-CREATION
Diff: https://reviews.apache.org/r/60621/diff/7/
Changes: https://reviews.apache.org/r/60621/diff/6-7/
Testing
---
See upstream
Note that Joe made some changes to this, I ended up taking his changes as is.
Thanks,
Jeff Coffler
df9d2d9586a6457004506c4e2a972ccfc912c7c5
Diff: https://reviews.apache.org/r/60628/diff/7/
Changes: https://reviews.apache.org/r/60628/diff/6-7/
Testing
---
See upstream.
Thanks,
Jeff Coffler
..)`, right?
> > I think for now we just use `strings::join('/', ...)`
> > in the codebase. Could we do that here and below, for now rather than
> > introducing a `url::join`?
>
> Jeff Coffler wrote:
> I guess, if we had a url::join(), but we don't, and I'm no
/
Changes: https://reviews.apache.org/r/60622/diff/6-7/
Testing
---
See upstream
Thanks,
Jeff Coffler
e7154c75e663d9a98bec48be42a59b65c96f9515
Diff: https://reviews.apache.org/r/60624/diff/7/
Changes: https://reviews.apache.org/r/60624/diff/6-7/
Testing
---
See upstream
Thanks,
Jeff Coffler
__`, right?
Yup. And line 34 should have included `// __WINDOWS__` at the end.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review191203
------
rg/r/60623/diff/7/
Changes: https://reviews.apache.org/r/60623/diff/6-7/
Testing
---
See upstream
Thanks,
Jeff Coffler
/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
Diff: https://reviews.apache.org/r/60626/diff/7/
Changes: https://reviews.apache.org/r/60626/diff/6-7/
Testing
---
See upstream
Thanks,
Jeff Coffler
ache.org/r/63253/diff/3-4/
Testing
---
Ran mesos-tests on both Windows and Linux with no errors.
Specifically ran mesos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/63253/#review189252
---
On Oct. 25, 2017, 7:59 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To re
ache.org/r/63253/diff/2-3/
Testing
---
Ran mesos-tests on both Windows and Linux with no errors.
Specifically ran mesos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
rg/r/63253/diff/1-2/
Testing
---
Ran mesos-tests on both Windows and Linux with no errors.
Specifically ran mesos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
eviews.apache.org/r/63253/#review189210
---
On Oct. 24, 2017, 6:04 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To re
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63253/#review189201
-------
On Oct. 24, 2017, 6:04 p.m., Jeff Coffler wrote:
>
> ---
> Thi
ell.exe` directly, instead of under `cmd.exe`.
Yup, I knew that when I discussed this with Gaston. All set with this.
- Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63
esos-tests with
`--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the
modified tests ran properly.
Thanks,
Jeff Coffler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63272/#review189740
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 31, 2017, 5:51 p.m
/7/
Testing
---
Built successfully on both Linux (with autotools and cmake) and Windows (with
cmake).
Ran stout-tests and mesos-tests successfully on both Windows and Linux.
Thanks,
Jeff Coffler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63275/#review189355
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:31 p.m
)
<https://reviews.apache.org/r/63271/#comment266361>
I usually see NOLINT on a line of it's own. Is that a mistake, making the
line even longer with `NOLINT`?
- Jeff Coffler
On Oct. 26, 2017, 4:29 p.m., Andrew Schwartzmeyer
)
<https://reviews.apache.org/r/63272/#comment266362>
This line is > 80 bytes, needs `NOLINT` added.
- Jeff Coffler
On Oct. 26, 2017, 4:30 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63271/#review189347
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/#review189340
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63273/#review189346
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:31 p.m
ere by doing a lot of short sleeps, but that's generally
risky and unreliable (depends on kernel timing, speed of implementation, etc).
- Jeff Coffler
On Oct. 26, 2017, 4:33 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63278/#review189360
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63279/#review189362
---
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:40 p.m
)
<https://reviews.apache.org/r/63279/#comment266395>
Nit: Please fix commit message:
`Realistically, the safe mimimum is 512 MB of.`
Of what? (Memory, obviously, but please fix.)
- Jeff Coffler
On Oct. 26, 2017, 4:40 p.m., Andrew Schwartzmeyer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64961/#review194905
---
Ship it!
Ship It!
- Jeff Coffler
On Jan. 5, 2018, 9:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64962/#review194908
---
Ship it!
Ship It!
- Jeff Coffler
On Jan. 5, 2018, 9:50 p.m
)
<https://reviews.apache.org/r/64962/#comment273990>
I got the syntax straight from the help page from `help Expand-Archive`.
But I guess if you don't know the parameters and don't want to get help, this
will clarify.
- Jeff Coffler
On Jan. 5, 2018, 9:50 p.m., Andrew Schwartzmeyer
/
Testing
---
Thanks,
Jeff Coffler
/
Testing
---
Full build, unit tests on both Linux and Windows platform.
Thanks,
Jeff Coffler
8/#review196911
---
On Feb. 5, 2018, 6:12 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy
> > of the summary.
>
> Jeff Coffler wrote:
> This was a one-line commit, but I went ahead and added a second line. I'm
s platform.
Thanks,
Jeff Coffler
(it's a
build target), it will always exist for test purposes.
Diffs (updated)
-
src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd
Diff: https://reviews.apache.org/r/65509/diff/2/
Changes: https://reviews.apache.org/r/65509/diff/1-2/
Testing
---
Thanks,
Jeff
> On Feb. 6, 2018, 7:12 p.m., Andrew Schwartzmeyer wrote:
> > Nit: Fix summary to be in past tense, and fix description to not be a copy
> > of the summary.
>
> Jeff Coffler wrote:
> This was a one-line commit, but I went ahead and added a second line. I'm
.
Diffs (updated)
-
src/tests/uri_fetcher_tests.cpp 8a40f46b215bb1f267a59a9edfca83445f86b430
Diff: https://reviews.apache.org/r/65510/diff/2/
Changes: https://reviews.apache.org/r/65510/diff/1-2/
Testing
---
Thanks,
Jeff Coffler
---
Thanks,
Jeff Coffler
gt;if "version" == "version" (exit 0 )
[ OK ] HadoopFetcherPluginTest.InvokeFetchByName (217 ms)
[--] 3 tests from HadoopFetcherPluginTest (674 ms total)
[--] Global test environment tear-down
[==] 3 tests from 1 test case ran. (12790 ms total)
[ PASSED ] 3 tests.
```
Thanks,
Jeff Coffler
: https://reviews.apache.org/r/65617/diff/1/
Testing
---
Thanks,
Jeff Coffler
-----
On Feb. 12, 2018, 11:31 p.m., Jeff Coffler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65618/
>
: https://reviews.apache.org/r/65619/diff/2/
Changes: https://reviews.apache.org/r/65619/diff/1-2/
Testing
---
Thanks,
Jeff Coffler
] 3 tests from 1 test case ran. (12790 ms total)
[ PASSED ] 3 tests.
```
Thanks,
Jeff Coffler
)
-
src/tests/uri_fetcher_tests.cpp 0acb8545b390a9b641d774cf65803d97c6296135
Diff: https://reviews.apache.org/r/65620/diff/2/
Changes: https://reviews.apache.org/r/65620/diff/1-2/
Testing
---
Thanks,
Jeff Coffler
13c2d5499b6c551e1333a73e8473de308e6c3bc2
Diff: https://reviews.apache.org/r/65618/diff/1/
Testing
---
Thanks,
Jeff Coffler
0acb8545b390a9b641d774cf65803d97c6296135
Diff: https://reviews.apache.org/r/65620/diff/1/
Testing
---
Thanks,
Jeff Coffler
gt;if "version" == "version" (exit 0 )
[ OK ] HadoopFetcherPluginTest.InvokeFetchByName (217 ms)
[--] 3 tests from HadoopFetcherPluginTest (674 ms total)
[--] Global test environment tear-down
[==] 3 tests from 1 test case ran. (12790 ms total)
[ PASSED ] 3 tests.
```
Thanks,
Jeff Coffler
13a4c9514fcd3016fe623c597decd067457e86cd
Diff: https://reviews.apache.org/r/65509/diff/1/
Testing
---
Thanks,
Jeff Coffler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65467/#review197796
---
Ship it!
Ship It!
- Jeff Coffler
On Feb. 8, 2018, 10:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65469/#review197798
---
Ship it!
Ship It!
- Jeff Coffler
On Feb. 20, 2018, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65403/#review197795
---
Ship it!
Ship It!
- Jeff Coffler
On Feb. 8, 2018, 10:36 p.m
e fetcher output is slightly different within a container,
fetcher itself isn't (docker is sharing the same directory). But we don't have
any sort of tests to validate that - that I'm aware of anyway.
- Jeff Coffler
On Feb. 20, 2018, 7:40 p.m., Andrew Sch
> On Feb. 20, 2018, 7:43 p.m., Jeff Coffler wrote:
> > src/tests/fetcher_tests.cpp
> > Lines 132 (patched)
> > <https://reviews.apache.org/r/65624/diff/1/?file=1958439#file1958439line132>
> >
> > These tests pretty much check the fetcher in a "
> On March 14, 2018, 12:21 a.m., Jeff Coffler wrote:
> > 3rdparty/boost-1.65.0.patch
> > Lines 12 (patched)
> > <https://reviews.apache.org/r/66046/diff/1/?file=1974924#file1974924line12>
> >
> > I'm thinking the other way around. That is, if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65936/#review198904
---
Ship it!
Ship It!
- Jeff Coffler
On March 8, 2018, 7:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66002/#review199213
---
Ship it!
Ship It!
- Jeff Coffler
On March 9, 2018, 8:17 p.m
che.org/r/66046/#review199198
---
On March 13, 2018, 10:30 p.m., Andrew Schwartzmeyer wrote:
>
> -------
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66046/#review199215
---
Ship it!
Ship It!
- Jeff Coffler
On March 13, 2018, 10:30
g as it's >= the minimum compiler
version.
The way you have it now, we'd need to update this every single time a new
compiler came out. Yuck. I think we only care if new compiler is REQUIRED for
some reason.
- Jeff Coffler
On March 13, 2018, 10:30 p.m., Andrew Schwart
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65872/#review198488
---
Ship it!
Ship It!
- Jeff Coffler
On March 1, 2018, 11:57
101 - 190 of 190 matches
Mail list logo
