---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113318
---
Ship it!
- Joerg Schad
On Jan. 7, 2016, 8:29 p.m., Till
> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote:
> > src/master/master.cpp, line 527
> > <https://reviews.apache.org/r/42025/diff/5/?file=1186406#file1186406line527>
> >
> > Does it make sense to document this behavior (the master not starting
> > if
g/r/42025/#comment173833>
How about:
If true only authenticated requests for HTTP endpoint
requiring authentification are allowed.
'If false also unauthenticated requests for HTTP endpoint
requiring authentification are also allowed.'
- Joerg Schad
On Jan. 7
g/r/42025/#comment173831>
See proposal above...
src/master/master.cpp (line 527)
<https://reviews.apache.org/r/42025/#comment173825>
Does it make sense to document this behavior (the master not starting if
flag and no credentials) to either some documentation and/or flags?
-
/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd
src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8
Diff: https://reviews.apache.org/r/41649/diff/
Testing
---
make check
Thanks,
Joerg Schad
g/r/42025/#comment173766>
Please add to configuration.md
- Joerg Schad
On Jan. 7, 2016, 2:38 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41948/#review113060
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41947/#review113044
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:38 p.m
/diff/
Testing (updated)
---
make check
Thanks,
Joerg Schad
tps://reviews.apache.org/r/41938/#comment173525>
Shouldn't this be SetNonExistentRole?
src/tests/master_quota_tests.cpp (line 297)
<https://reviews.apache.org/r/41938/#comment173527>
SetResourcesSpecifyRole?
- Joerg Schad
On Jan. 5, 2016, 11:39 p.m., Alexande
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41648/#review113032
---
Ship it!
Ship It!
- Joerg Schad
On Jan. 5, 2016, 11:45 p.m
have a brief discussion on the dev mailing list?
- Joerg Schad
On Jan. 4, 2016, 8:01 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote:
> > This pretty much duplicates https://reviews.apache.org/r/39466/ (except
> > also has a test case). Even though the long term approach should be to
> > replace all the individual http method call with a general one (acc
/ (except also
has a test case). Even though the long term approach should be to replace all
the individual http method call with a general one (accepting a Request
object), we should decide which of these reviews we want to commit/focus on
right now.
- Joerg Schad
On Jan. 3, 2016, 10:38 a.m
nd in
> > the other `put` method? It looks like they are mostly concerned with
> > creating the `Request`.
>
> Joerg Schad wrote:
> I beleive a larger refactoring to just one common `Request` object would
> also adress this issue. See https://issues.apache.org/jira/bro
/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969
3rdparty/libprocess/src/tests/http_tests.cpp
19261502be220aaa40add7ce30a9b2b65d1d9fdc
Diff: https://reviews.apache.org/r/39466/diff/
Testing
---
make check
Thanks,
Joerg Schad
Do we have more documentation on this array of isolators?
- Joerg Schad
On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically genera
> On Dec. 27, 2015, 8:16 a.m., Joerg Schad wrote:
> > src/slave/flags.cpp, line 146
> > <https://reviews.apache.org/r/41731/diff/1/?file=1176474#file1176474line146>
> >
> > Do I understand correctly that we change the default from "Pull from
> >
on documentation
(https://github.com/apache/mesos/blob/master/docs/configuration.md)
- Joerg Schad
On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
we introduce the other containerizer (I
assume you went for alphabetical order)? Feel free to ignore if you disagree ...
- Joerg Schad
On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically gener
m "Pull from docker
registry" to "pull from a local file location"? Wouldn't that impact users
experimenting with Mesos? If this is not the case feel to drop.
- Joerg Schad
On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
>
> -
/diff/
Testing
---
viewed rendered doc.
Thanks,
Joerg Schad
: https://reviews.apache.org/r/41682/diff/
Testing
---
Viewed rendered doc.
Thanks,
Joerg Schad
Diff: https://reviews.apache.org/r/41680/diff/
Testing
---
make check and checked logs
Thanks,
Joerg Schad
tps://reviews.apache.org/r/41656/#comment171900>
Not yours, but didn't we want to remove such fully specified links to
github?
- Joerg Schad
On Dec. 22, 2015, 10:11 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically
o reply, visit:
> https://reviews.apache.org/r/41656/
> ---
>
> (Updated Dec. 22, 2015, 10:11 p.m.)
>
>
> Review request for mesos, Jie Yu and Joerg Schad.
>
>
> Repository: mesos
>
>
> Descri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41649/
---
(Updated Dec. 22, 2015, 5:33 p.m.)
Review request for mesos and Joerg Schad
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review111597
-------
On Dec. 22, 2015, 10:19 a.m., Joerg Schad wrote:
>
> ---
7f5e51948616036378b8993134ba6df09dad5d88
Diff: https://reviews.apache.org/r/40293/diff/
Testing
---
viewed rendered version.
Thanks,
Joerg Schad
89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in Review 39614.
Thanks,
Joerg Schad
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
---
On Dec. 22, 2015, 8:38 a.m., Joerg Sc
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing (updated)
---
Tests are in Review 39614.
Thanks,
Joerg Schad
/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in next Review.
Thanks,
Joerg
/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/40544/diff/
Testing
---
Test are in the next review.
Thanks,
Joerg Schad
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in next Review.
Thanks,
Joerg Schad
89130ce9b09afe7c6dd332c8b5278abe0d2674f1
Diff: https://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
tps://reviews.apache.org/r/41603/#comment171669>
Could you add a blank line between using and namespace? THX
- Joerg Schad
On Dec. 21, 2015, 1:30 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41603/#review111461
---
Ship it!
Ship It!
- Joerg Schad
On Dec. 21, 2015, 1:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41509/#review111218
---
Ship it!
Ship It!
- Joerg Schad
On Dec. 17, 2015, 2:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/#review71
---
Ship it!
Ship It!
- Joerg Schad
On Dec. 3, 2015, 7:02 p.m
g/r/40348/#comment170947>
s/Authorization allows/Authorization currently allows
docs/authorization.md (line 17)
<https://reviews.apache.org/r/40348/#comment170952>
s/For each of the 4 cases /For each of the above cases?
- Joerg Schad
On Dec. 15, 2015, 11:08 a.m., Jan Sc
tps://reviews.apache.org/r/40347/#comment170933>
Shouldn't this comment be above line 327?
- Joerg Schad
On Dec. 17, 2015, 9:26 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To r
> On Dec. 17, 2015, 10:20 a.m., Joerg Schad wrote:
> > include/mesos/authorizer/authorizer.hpp, lines 177-180
> > <https://reviews.apache.org/r/40346/diff/5/?file=1164652#file1164652line177>
> >
> > , otherwise ...
(Consistent w
- 180)
<https://reviews.apache.org/r/40346/#comment170927>
, otherwise ...
- Joerg Schad
On Dec. 15, 2015, 11:06 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
)
<https://reviews.apache.org/r/40345/#comment170921>
Not yours, but would it make sense to group the ACLs (and add some spacing)?
- Joerg Schad
On Dec. 4, 2015, 1:53 p.m., Jan Schlicht wrote:
>
> ---
> This is an automati
iew108007
---
On Dec. 16, 2015, 9:34 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in next Review.
Thanks,
Joerg Schad
---
make check
Thanks,
Joerg Schad
03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/40544/diff/
Testing
---
Test are in the next review.
Thanks,
Joerg Schad
---
make check
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Added remove quota test.
Diffs
-
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40580/diff/
Testing
---
make check
Thanks,
Joerg Schad
03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/40544/diff/
Testing
---
Test are in the next review.
Thanks,
Joerg Schad
/
Testing
---
viewed rendered doc.
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review107423
---
Ship it!
Ship It!
- Joerg Schad
On Nov. 16, 2015, 9:31 p.m
.
Repository: mesos
Description (updated)
---
Applied consistent number style in c++ styleguide.
Diffs
-
docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad
Diff: https://reviews.apache.org/r/40293/diff/
Testing
---
viewed rendered version.
Thanks,
Joerg
://reviews.apache.org/r/40293/diff/
Testing
---
viewed rendered version.
Thanks,
Joerg Schad
> On Nov. 17, 2015, 8:18 a.m., Alexander Rukletsov wrote:
> > What is the motivation for this? Are there any studies proving it
> > facilitates preception?
>
> Joerg Schad wrote:
> Motivation is the current inconsistent writing of numbers e.g. in the c++
>
.
Thanks,
Joerg Schad
-CREATION
Diff: https://reviews.apache.org/r/39614/diff/
Testing
---
make check
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
lt;> in ?
It is just to indicate that it is a ver long line
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40291/#review107223
-------
On Nov. 16, 2015, 5:32 p.m., Joerg Schad
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
tps://reviews.apache.org/r/39223/#comment166375>
Move before StartSlave here and below.
- Joerg Schad
On Nov. 19, 2015, 9:39 a.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/39614/#comment166373>
Move Expect call before StartSlave()
- Joerg Schad
On Nov. 19, 2015, 4:05 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
same here
src/tests/master_quota_tests.cpp (line 478)
<https://reviews.apache.org/r/40396/#comment166370>
same here
- Joerg Schad
On Nov. 17, 2015, 8:18 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automat
e we started expecting it).
src/tests/master_quota_tests.cpp (line 395)
<https://reviews.apache.org/r/38956/#comment166360>
Same here.
- Joerg Schad
On Nov. 17, 2015, 8:16 p.m., Alexander Rukletsov wrote:
>
> ---
> Thi
03cef4117c52da7599a2800060f65483ca33bc3f
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
.apache.org/r/40392/#review107265
---
On Nov. 19, 2015, 7:10 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
#x27;t that included in QuotaInfo already?
- Joerg Schad
On Nov. 17, 2015, 8:54 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
eviews.apache.org/r/39400/#comment166191>
s/an/the
- Joerg Schad
On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically gene
4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in next Review.
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
does not compile?
No.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review107181
---
On Nov. 19, 2
4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Tests are in next Review.
Thanks,
Joerg Schad
> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 732-734
> > <https://reviews.apache.org/r/39614/diff/2/?file=1106413#file1106413line732>
> >
> > Have you considered merging this test with
> > `AvailableRes
What am I missing?
The updated review :-).
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review107169
---
On Nov.
--
On Nov. 19, 2015, 12:44 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -
/
Testing
---
make check
Thanks,
Joerg Schad
------
On Oct. 24, 2015, 7:40 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review103933
---
On Oct. 24, 2015, 7:40 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically gener
4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing (updated)
---
Tests are in next Review.
Thanks,
Joerg Schad
4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing (updated)
---
Test
Thanks,
Joerg Schad
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107157
-------
On Nov. 16, 2015, 1:13 p.m., Joerg Schad wrote:
>
> ---
> This
> On Nov. 16, 2015, 2:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 188
> > <https://reviews.apache.org/r/40347/diff/1/?file=1126222#file1126222line188>
> >
> > Should this be part of the validation below?
>
> Jan Schli
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
> On Nov. 18, 2015, 5:08 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 224
> > <https://reviews.apache.org/r/40392/diff/2/?file=1128686#file1128686line224>
> >
> > As discussed offline I would prefere a single json object per request
>
Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review107041
-------
On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
>
> --
g/r/40392/#comment165946>
I will merge both functions.
- Joerg Schad
On Nov. 17, 2015, 5:38 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
me is already in use
> by another task.
+1
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39892/#review104887
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39892/
---
(Updated Nov. 18, 2015, 2:58 p.m.)
Review request for mesos and Joerg Schad
src/tests/master_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
-CREATION
Diff: https://reviews.apache.org/r/40392/diff/
Testing
---
make check.
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
701 - 800 of 1143 matches
Mail list logo
