Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-21 Thread Joerg Schad
-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

2015-10-19 Thread Joerg Schad
Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Joerg Schad
tps://reviews.apache.org/r/39452/#comment161115> independent - Joerg Schad On Oct. 19, 2015, 7:59 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39285: Added Quota Request Validation.

2015-10-19 Thread Joerg Schad
e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 39285: Added Quota Request Validation.

2015-10-15 Thread Joerg Schad
e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad
ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad
Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad
ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-14 Thread Joerg Schad
/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-13 Thread Joerg Schad
---- On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > ---

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

2015-10-13 Thread Joerg Schad
/ Testing --- Thanks, Joerg Schad

Re: Review Request 39223: WIP Added Quota related Tests.

2015-10-12 Thread Joerg Schad
/ Testing --- Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-11 Thread Joerg Schad
eviews.apache.org/r/36913/#review102159 --- On Oct. 11, 2015, 4:12 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-11 Thread Joerg Schad
/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-06 Thread Joerg Schad
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review97974 --- On Oct. 6, 2015, 9:31 a.m., Joerg Schad wrote: > > -

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-10-06 Thread Joerg Schad
--- make check Thanks, Joerg Schad

Re: Review Request 39042: Updated comment referencing deprecated and removed /master/shutdown endpoint.

2015-10-06 Thread Joerg Schad
://reviews.apache.org/r/39042/diff/ Testing --- Thanks, Joerg Schad

Review Request 39042: Updated comment referencing deprecated and removed /master/shutdown endpoint.

2015-10-06 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-26 Thread Joerg Schad
> On Sept. 23, 2015, 6:29 p.m., Ben Mahler wrote: > > Where is the benchmark for this change? :( > > Joerg Schad wrote: > We benchmarked the code with a proprietary benchmark. I added > https://issues.apache.org/jira/browse/MESOS-3502 aiming at adding an > open-s

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
t; ``` > > if (range->end() + 1 >= current.begin()) { > > range->set_end(std::max(range.end(), current.end())); > > deleteSet.insert(y); > > ++i; > > } else { > > break; > > } > > ``` > > Joerg S

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
- Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100261 --- On Sept. 23, 2015, 12:37 p.m., Joerg Sc

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100082 --- On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote: > > --- > This is an automaticall

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-23 Thread Joerg Schad
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100082 ------- On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
> ``` > > > > I think it would also clean up this code significantly, as we wouldn't > > need the `rangesSum` loop, The `fill` function wouldn't have to be factored > > out, wouldn't need the `offset` math, etc. > > Joerg Schad wrote: &g

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
> ``` > > > > I think it would also clean up this code significantly, as we wouldn't > > need the `rangesSum` loop, The `fill` function wouldn't have to be factored > > out, wouldn't need the `offset` math, etc. > > Joerg Schad wrote: &g

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-23 Thread Joerg Schad
sce(Value::Ranges* result, Value::Ranges ranges) { size_t rangesSum = result->range_size() + ranges->ranges_size(); ``` In that case I would probably leave fill factored out, but the rest (rangesSum, offset) would be simplified. - Joerg ------

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Joerg Schad
/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620

2015-09-22 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-22 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-17 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-17 Thread Joerg Schad
/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-17 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-15 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-10 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-09 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-09 Thread Joerg Schad
d the 2 distinct cases (especially with the range comments) more readable. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review98200 --

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
----- On Sept. 8, 2015, 7:25 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38158/ >

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
ndpoint." ranges is the Ranges object i.e. is, and otherwise I personally find range.begin() a more precise description - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review9

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-07 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-07 Thread Joerg Schad
fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-06 Thread Joerg Schad
h (line 30) <https://reviews.apache.org/r/37168/#comment153952> Do we need this here and below in script.cpp? - Joerg Schad On Sept. 6, 2015, 4:11 a.m., Klaus Ma wrote: > > --- > This is an automatically generated

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Joerg Schad
, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Joerg Schad
--- make check Thanks, Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-02 Thread Joerg Schad
include/mesos/master/quota.proto PRE-CREATION src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-02 Thread Joerg Schad
------ On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36908/ > ---

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-02 Thread Joerg Schad
visit: https://reviews.apache.org/r/36908/#review96299 ------- On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote: > > --- > This is an automatically generat

Re: Review Request 37168: MESOS-3063

2015-09-02 Thread Joerg Schad
start their own framework), would it make sense to add some more comments explaining especially the relevant bits here? - Joerg Schad On Aug. 28, 2015, 3:31 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-09-01 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-09-01 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-09-01 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Joerg Schad
Timothy Chen wrote: > Hi jie, thanks for chiming in. This should be ready after the comments > are addressed. I'll try to merge this as well when it's done. I'll ping Joerg > about this. > > Joerg Schad wrote: > Hi Jie, > I am not sure whether I

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96883 ------- On Aug. 28, 2015, 4:39 p.m., Joerg Schad wrote: > > -

Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Joerg Schad
204c53038a1ccfa693f4f2293488cff8cdd60835 src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37894/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal

2015-08-28 Thread Joerg Schad
204c53038a1ccfa693f4f2293488cff8cdd60835 src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37892/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal

2015-08-28 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37892/diff/ Testing --- Thanks, Joerg Schad

Review Request 37892: Renamed cgroups::kill to cgroups::signal

2015-08-28 Thread Joerg Schad
/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37892/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Joerg Schad
://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Joerg Schad
you don't need statuses to be an attribute nor do you need line > > 1672. see below and discussion offline. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review961

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Joerg Schad
tand something here- I would be happy to discuss it further! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96734 ---

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-24 Thread Joerg Schad
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96144 --- On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote: > > ---

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-20 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

2015-08-14 Thread Joerg Schad
443/#comment150347> s/framework/framework. - Joerg Schad On Aug. 13, 2015, 8:20 p.m., James DeFelice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-13 Thread Joerg Schad
b70e2fa0f500216c15f20907816874b9486826b8 3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-13 Thread Joerg Schad
e via a future. > > Marco Massenzio wrote: > +1 I added MESOS-3256 to track the renaming effort. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94388

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-08-13 Thread Joerg Schad
6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing (updated) --- sudo make check + manual tests Thanks, Joerg Schad

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-08-13 Thread Joerg Schad
eated MESOS-3255 to follow up with tests. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 --- On July 24, 2015,

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-09 Thread Joerg Schad
g/r/36049/#comment149277> Could we please add this flag to the documentation i.e. configuration.md - Joerg Schad On Aug. 5, 2015, 9:15 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2015-08-06 Thread Joerg Schad
g/r/37075/#comment148967> It reads somehow weird to start with the behavior if not present before knowing what the flag is about Could you add a short descriptive sentence (as above)... - Joerg Schad On Aug. 5, 2015, 11:37 a.m., Bernd Mathiske

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-05 Thread Joerg Schad
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

2015-08-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37123/#review94216 --- Ship it! Ship It! - Joerg Schad On Aug. 5, 2015, 9:35 a.m

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Joerg Schad
4dcbd74b894b483c4d166c23fac55ac8dba75166 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Joerg Schad
--- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
3772e39015a22655dcad00ad844dc5ddc90db43f src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
. This is correct syntax IMHO. See Bernds comment below. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review94030 --- On

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Joerg Schad
ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Joerg Schad
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
b8d930058aa3ae9d21ae0f7b420d49f2448f84b1 3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Joerg Schad
://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93923 ------- On July 29, 2015, 1:39 p.m., Joerg Schad wrote: > > --- >

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
leteRequest which people found to long/verbose and inconsistent... - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93923 -------

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-03 Thread Joerg Schad
src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-08-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93886 --- Ship it! Ship It! - Joerg Schad On Aug. 3, 2015, 8:43 a.m., Jan

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
3772e39015a22655dcad00ad844dc5ddc90db43f src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a src/master/quota_handler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/#review93473 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 4:58 p.m

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
-CREATION src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-07-29 Thread Joerg Schad
src/master/master.hpp 2331173fb9aeca77227fb09b899cb123eb205b4b src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a src/master/quota_handler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-29 Thread Joerg Schad
bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36889/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
://reviews.apache.org/r/36908/#review93432 ------- On July 29, 2015, 11:54 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93438 --- Ship it! Ship It! - Joerg Schad On July 29, 2015, 11:52 a.m

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad
/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Joerg Schad
tps://reviews.apache.org/r/36773/#comment147794> ++taskIndex - Joerg Schad On July 28, 2015, 2:04 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
d1685799f4c53e067d0812e037e171324ee7195f 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
9faed55247a3ccd629db7b85dbf31d3117e120e9 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445 Diff: https://reviews.apache.org/r/36847/diff/ Testing --- make check Thanks, Joerg Schad

<    5   6   7   8   9   10   11   12   >