://reviews.apache.org/r/34943/#comment139192
style question: Why not use static array declaration :
const char *args[] = {
/path/to/program,
blah
};
and also make the function argument const char**?
- Jojy Varghese
On June 5, 2015, 2:48 p.m., Benjamin Hindman
/3rdparty/stout/include/stout/utils.hpp
09a1dcd3b3a082544d221fbfeab9a3d3d9f85e2f
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
c2c6a6ac97044f2317418295f48d75e94de4112b
Diff: https://reviews.apache.org/r/35743/diff/
Testing
---
make check
Thanks,
Jojy Varghese
7584cb871d02ad01021f0c3439ea205736d4f6b4
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
c2c6a6ac97044f2317418295f48d75e94de4112b
Diff: https://reviews.apache.org/r/35743/diff/
Testing
---
make check
Thanks,
Jojy Varghese
.
Jojy Varghese wrote:
Not sure if adding a boost dependency just for size operator would get us
anything here.
Anand Mazumdar wrote:
Then can we change these to std::array and just invoke the size()
function ?
(Posting it again here , my bad , instead of adding a new
https://reviews.apache.org/r/34943/#comment139961
Style comment: Default captures are considered stylistically bad. Captures
should be explicit(Meyers, Effective Modern C++, Item 31).
- Jojy Varghese
On June 11, 2015, 1:52 p.m., Benjamin Hindman wrote
://reviews.apache.org/r/29406/#comment140298
General question about the net namespace in the code: why is the network
structure not templatized on the Layer 3(IP) family(inet/inet6 etc)? This would
make it easy to specialize on these families and also make Ipv6 easy.
- Jojy Varghese
On June 13, 2015
., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/
---
(Updated July 1, 2015, 9:38 p.m.)
Review
://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
---
make check
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90139
---
On July 1, 2015, 9:38 p.m., Jojy Varghese wrote
this and make it easier
for the reader. :)
Jojy Varghese wrote:
The only reason being that the way cpuacct creates Stat should be
encapsulated in the cpuacct::Stat. This is the same reason there is a parse
method in Stat. But I can change it to use cgroups::stat if absolutely
this and make it easier
for the reader. :)
Jojy Varghese wrote:
The only reason being that the way cpuacct creates Stat should be
encapsulated in the cpuacct::Stat. This is the same reason there is a parse
method in Stat. But I can change it to use cgroups::stat if absolutely
475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
this and make it easier
for the reader. :)
Jojy Varghese wrote:
The only reason being that the way cpuacct creates Stat should be
encapsulated in the cpuacct::Stat. This is the same reason there is a parse
method in Stat. But I can change it to use cgroups::stat if absolutely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90288
---
On July 2, 2015, 8:09 p.m., Jojy Varghese wrote
475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/#review90140
---
On July 1, 2015, 9:38 p.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106
.
Personally I don't think it provides any additional benefits here.
Jojy Varghese wrote:
The advantage is that otherwise we will end up copy-paste code of parsing
at two places(line 0 and line 1)
Timothy Chen wrote:
What I meant to compare with is having a another named function defined
On July 1, 2015, 9:46 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 2060
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060
Why add trailing underscore?
Jojy Varghese wrote:
As a member variable(is accepted according to mesos coding style
the logic to look for http server URL's domain first to populate the
Host field.
Diffs
-
3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166
Diff: https://reviews.apache.org/r/37426/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
.
Thanks,
Jojy Varghese
c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
c8c27a64c06cf37bdaa5b474ea25bd2e971c8fea
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
---
On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit
/r/37426/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
)
https://reviews.apache.org/r/37197/#comment149127
prefer using explicit captures.
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
https://reviews.apache.org/r/37197/#comment149114
What is the ownership model of Fetcher member? How do you know that the
pointer is valid through the life of StoreProcess object?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote
)
https://reviews.apache.org/r/37197/#comment149117
Why not use the new c++11 delete keyword?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
https://reviews.apache.org/r/37197/#comment149115
I think new files should have javadoc style comments.
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
---
This is an automatically generated e-mail. To reply, visit
)
https://reviews.apache.org/r/37197/#comment149125
Why extra newline?
- Jojy Varghese
On Aug. 6, 2015, 10:51 p.m., Lily Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197
. To reply, visit:
https://reviews.apache.org/r/37426/#review95281
---
On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95238
---
On Aug. 13, 2015, 8:29 a.m., Jojy Varghese wrote:
---
This is an automatically generated
://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/#review92966
---
On July 27, 2015, 1:56 p.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757
---
On July 27, 2015, 1:56 p.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757
: MESOS-3093
Diffs (updated)
-
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
Diff: https://reviews.apache.org/r/36757/diff/
Testing
---
make check
Thanks,
Jojy Varghese
words for variable names e.g. `responseBuffer`
Jojy Varghese wrote:
I will create tickets(JIRA) to address it?
Created MESOS-3153
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757
d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/ssl_tests.cpp
2fe50601615b0bee57bd3e05dc9c932f93ca7477
Diff: https://reviews.apache.org/r/36757/diff/
Testing
---
make check
Thanks,
Jojy Varghese
,
Jojy Varghese
/#comment147323
complexity of a function is measured by the nested if condition in it.
Maybe we accomplish the same using simple small functions ?
- Jojy Varghese
On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote
/#comment147318
Why not static initialization pattern :
OK ok = {
.type = Response::PIPE,
.reader = pipe.reader(),
};
Maybe its not allowed in the coding style but I would think it looks
elegant.
- Jojy Varghese
On July 25, 2015, 2:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
---
On July 24, 2015, 3:23 p.m., Jojy Varghese wrote
objects.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92966
---
On July 24, 2015, 5:49 p.m., Jojy Varghese wrote
Thanks,
Jojy Varghese
---
make check
Thanks,
Jojy Varghese
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
---
Thanks,
Jojy Varghese
iews.apache.org/r/39340/
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103740
---
On Oct. 21, 201
/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73
src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2
src/tests/containerizer/provisioner_docker_tests.cpp
822aa77d0be0797ab62a5798527618b2cc4f6bf0
Diff: https://reviews.apache.org/r/38580/diff/
Testing
---
make check.
Thanks,
Jojy
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103739
---
On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
>
> ---
> This is an automati
/
Testing
---
make check.
Thanks,
Jojy Varghese
src/tests/containerizer/provisioner_docker_tests.cpp
1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
---
Thanks,
Jojy Varghese
(line 360)
<https://reviews.apache.org/r/39579/#comment161883>
We are refactoring this code and have split the method into small chunks. I
was expecting this change as part of that.
- Jojy Varghese
On Oct. 23, 2015, 7:58 a.m., Timothy Chen
/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
src/tests/containerizer/provisioner_docker_tests.cpp
1b0c30450a07d01d1a38d460bc7d921c80be7e3b
Diff: https://reviews.apache.org/r/38654/diff/
Testing
---
Thanks,
Jojy Varghese
/provisioner/docker/registry_client.cpp
24aa95c5800ff4dfb37465b71421b014b5dd5998
Diff: https://reviews.apache.org/r/39518/diff/
Testing
---
Make check.
Thanks,
Jojy Varghese
---
make check.
Thanks,
Jojy Varghese
.
Thanks,
Jojy Varghese
and Timothy Chen.
Changes
---
made more updates
Repository: mesos
Description
---
Documentation: added containerizer internals
Diffs (updated)
-
docs/containerizer-internals.md PRE-CREATION
Diff: https://reviews.apache.org/r/39456/diff/
Testing
---
Thanks,
Jojy
136)
<https://reviews.apache.org/r/39331/#comment164661>
Wondering if you need to pass "recursive" (true) to mkdir. This flag
ensures that the the whole path of dierctory is created as needed. If its
already existing, it wont create one.
- Jojy Varghese
On Nov. 9, 2015, 7:
0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
---
ran script locally
Thanks,
Jojy Varghese
eviews.apache.org/r/38580/#review105579
-------
On Nov. 8, 2015, 4:58 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38580/
> ---
> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51
> > <https://reviews.apache.org/r/38580/diff/19/?file=1115760#file1115760line51>
> >
> > Didn''t you pull these out?
>
> J
ges and couldnt get a "empty" layer.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/#review105579
-------
On Nov. 8, 2015, 4:58 p.m., Jojy Varghese wrote:
>
> -
://reviews.apache.org/r/38747/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/
Testing
---
make check.
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40069/#review105652
---
Ship it!
Ship It!
- Jojy Varghese
On Nov. 9, 2015, 6:21 a.m
/docker/registry_puller.hpp (line 58)
<https://reviews.apache.org/r/40070/#comment164266>
i thought you wanted to add more to this comment. That it downloads
multiple layers for the image.
- Jojy Varghese
On Nov. 9, 2015, 6:24 a.m., Timothy Chen
iff: https://reviews.apache.org/r/40283/diff/
Testing
---
make check; manual end-to-end testing with mesos-execute.
Thanks,
Jojy Varghese
/containerizer/mesos/containerizer.cpp
08243b61c1c277da7609bc910323cc1e27ff5cd4
Diff: https://reviews.apache.org/r/40284/diff/
Testing
---
Thanks,
Jojy Varghese
;
Thanks,
Jojy Varghese
----
On Nov. 13, 2015, 8:13 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40284/#review106388
---
On Nov. 13, 2015, 8:12 a.m., Jojy Vargh
> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote:
> > Can we fix the underlying problem, as opposed to disabling SSL?
>
> Jojy Varghese wrote:
> Not sure if we should enforce SSL sockets in an executor unless being
> explicitly asked for (say using a flag)
&g
quot; for device
files. Maybe we should assert that here.
- Jojy Varghese
On Nov. 13, 2015, 8:49 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/40285/#review106457
---
On Nov. 13, 2015, 8:13 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Nov. 13, 2015, 9:59 a.m., Joris Van Remoortere wrote:
> > Can we fix the underlying problem, as opposed to disabling SSL?
>
> Jojy Varghese wrote:
> Not sure if we should enforce SSL sockets in an executor unless being
> explicitly asked for (say using a flag)
&g
13f5e2877f4d7951e79ba07073a42848217604b3
Diff: https://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
Diff: https://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
13f5e2877f4d7951e79ba07073a42848217604b3
Diff: https://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
0371/diff/
Testing
---
tested the two containerizer locally with simple commands.
Thanks,
Jojy Varghese
src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc
Diff: https://reviews.apache.org/r/40371/diff/
Testing
---
tested the two containerizer locally with simple commands.
Thanks,
Jojy Varghese
/containerizer/mesos/provisioner/docker/puller.cpp
13f5e2877f4d7951e79ba07073a42848217604b3
Diff: https://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
9a29fc
Diff: https://reviews.apache.org/r/40371/diff/
Testing
---
tested the two containerizer locally with simple commands.
Thanks,
Jojy Varghese
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106151
---
Ship it!
Ship It!
- Jojy Varghese
On Nov. 11, 2015, 9:09 p.m
eviews.apache.org/r/40371/#review106789
---
On Nov. 17, 2015, 3:01 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To re
/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3
Diff: https://reviews.apache.org/r/39914/diff/
Testing
---
ran script locally
Thanks,
Jojy Varghese
---
Updated docker build script to install libev package.
Diffs
-
support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef
Diff: https://reviews.apache.org/r/40162/diff/
Testing
---
tested locally and on jenkins.
Thanks,
Jojy Varghese
://reviews.apache.org/r/39250/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner_docker_tests.cpp
fe6a90fe32364eec8ef923a000db19183603c338
Diff: https://reviews.apache.org/r/40120/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
1 - 100 of 692 matches
Mail list logo
