/mesos/provisioner/docker/registry_client.cpp
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
src/tests/containerizer/provisioner_docker_tests.cpp
8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/39839/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/39840/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
-----
On Nov. 6, 2015, 6:56 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
>
/r/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/r/39840/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/r/39840/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
src/tests/containerizer/provisioner_docker_tests.cpp
8d90894410cd834edf49a2814d1b616718798fe8
Diff: https://reviews.apache.org/r/38580/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
29d4d4d6d60ec634efb21b951cf20ff90f6ffed6
Diff: https://reviews.apache.org/r/39840/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/registry_client.cpp
471783d88b73b62afacac3d7952ebb5d5f442097
src/tests/containerizer/provisioner_docker_tests.cpp
9c3c45a81be6398722a37911788e347a4e91cce8
Diff: https://reviews.apache.org/r/39156/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner_docker_tests.cpp
9c3c45a81be6398722a37911788e347a4e91cce8
Diff: https://reviews.apache.org/r/38579/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/39155/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/containerizer/provisioner/docker/registry_client.cpp
471783d88b73b62afacac3d7952ebb5d5f442097
src/tests/containerizer/provisioner_docker_tests.cpp
9c3c45a81be6398722a37911788e347a4e91cce8
Diff: https://reviews.apache.org/r/39014/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/registry_client.cpp
471783d88b73b62afacac3d7952ebb5d5f442097
src/tests/containerizer/provisioner_docker_tests.cpp
9c3c45a81be6398722a37911788e347a4e91cce8
Diff: https://reviews.apache.org/r/39068/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
)
<https://reviews.apache.org/r/39331/#comment160771>
Does this mean that any request to get an image A will always return the
same image?
I thought the idea was to prevent simultaneous downloads/fetching of the
same image.
- Jojy Varghese
On Oct. 14, 2015, 10:54 p.m., Gilber
---
RegistryClient: Added streaming response read
Diffs
-
src/slave/containerizer/provisioner/docker/registry_client.cpp
471783d88b73b62afacac3d7952ebb5d5f442097
Diff: https://reviews.apache.org/r/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
;
> > Just a comment.
Added comment on preliminary performance test.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review102302
-----
029aa1eb00e1aa3e92c2155925022c17fd905862
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38580/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39112/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/r/38747/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
105b4e75439c2ad4c08e2fd364f288f1d39b9b59
src/slave/containerizer/provisioner/docker/puller.cpp
cb05324689ffa26ce830b513e2d71b55517da3cb
src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39250/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
cb
> src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39250/diff/
>
>
> Testing
> ---
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
105b4e75439c2ad4c08e2fd364f288f1d39b9b59
src/slave/containerizer/provisioner/docker/puller.cpp
cb05324689ffa26ce830b513e2d71b55517da3cb
src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39250/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
make check.
Thanks,
Jojy Varghese
/38747/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
ng if we can use a regular
expression parser for parsing ?
- Jojy Varghese
On Oct. 15, 2015, 7:17 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/39340/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/38747/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
> On Oct. 15, 2015, 8:28 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioner/docker/message.hpp, line 46
> > <https://reviews.apache.org/r/39353/diff/1/?file=1099046#file1099046line46>
> >
> > How about handling parse errors ? Maybe change thi
---
Documentation: added containerizer internals
Diffs
-
docs/containerizer-internals.md PRE-CREATION
Diff: https://reviews.apache.org/r/39456/diff/
Testing
---
Thanks,
Jojy Varghese
/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38579/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
t; sha512sum are part of GNU coreutils while shasum is on every mac). The
> > linked review needs to address some comments but it's not far from ready
> > for shipit (it's not a priority for us right now but you can take it if you
> > like).
> >
> > Thanks!
&
/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review101451
---
On Oct. 12, 2015, 9:14 p.m., Jojy Varghese wrote:
>
> ---
o somewhere shared? We can create a
> > base puller class and move this there.
>
> Jojy Varghese wrote:
> Thought about it a little more and realized that the functionality of
> "untar a tarball into a dierctory" should belong in a common place like
> libprocess. Its n
/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
,
Jojy Varghese
/provisioner/docker/puller.cpp
cb05324689ffa26ce830b513e2d71b55517da3cb
src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39250/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
gt; This of course becomes a moot point is we don't use template as I was
> > suggesting above.
One of the reasons the templates are in header file is to allow client code
like:
```
DigestUtil::digest(string)
```
- Jojy
---
/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38580/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
RegistryClient refactor: refactored lambdas as per review comments.
Diffs
-
src/slave/containerizer/provisioner/docker/registry_client.cpp
c2040b48ea43fdb29766994c244273d3fa9ee3cd
Diff: https://reviews.apache.org/r/39016/diff/
Testing
---
Make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/39015/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/39013/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
c2040b48ea43fdb29766994c244273d3fa9ee3cd
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39014/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
src/slave/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39014/diff/
Testing
---
make check.
Thanks,
Jojy
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39068/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/slave/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38941/diff/
Testing
---
make check.
Thanks,
Jojy
/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39068/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
Diff: https://reviews.apache.org/r/39015/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
check.
Thanks,
Jojy Varghese
: https://reviews.apache.org/r/39016/diff/
Testing
---
Make check.
Thanks,
Jojy Varghese
/slave/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38941/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
://reviews.apache.org/r/39053/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
idea was to make it obvious 50 lines down from initialization. I can change
it and create another patch for replacing all xxxFuture with xxx for variable
names.
- Jojy
---
This is an automatically generated e-mail. To r
---
Provider tests: minor style fixes.
Diffs
-
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39197/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
---
Puller tests: removed extraneous sandbox directory
Diffs
-
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39196/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
Diff: https://reviews.apache.org/r/39015/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
src/slave/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
---
make check.
Thanks,
Jojy
/39155/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39112/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39014/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38579/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
,
Jojy Varghese
/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39068/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38941/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39156/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38580/diff/
Testing
---
make check.
Thanks,
Jojy
check.
Thanks,
Jojy Varghese
/
Testing
---
make check.
Thanks,
Jojy Varghese
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38579/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
Diff: https://reviews.apache.org/r/39184/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/containerizer/provisioner/docker/registry_client.cpp
4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38443/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
o somewhere shared? We can create a
> > base puller class and move this there.
>
> Jojy Varghese wrote:
> Thought about it a little more and realized that the functionality of
> "untar a tarball into a dierctory" should belong in a common place like
> libprocess. Its n
/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
' for these fields?
Jojy Varghese wrote:
1) Absolutely I can.
2) I wanted to reflect the semantics of the stats call. When you make a
stats call, the data you get is immutable. By forcing external const, it
would imply that the value is immutable.
3) Duration is a period ( i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36326/#review91342
---
On July 9, 2015, 8:38 p.m., Jojy Varghese wrote
have reasons to do this change.
Jojy Varghese wrote:
The thought was as follows:
- We called inspect to get the pid. So first we check for a pid. Then we
set the pid for the container (if the container exists). Then we call
collectUsage to collect stats.
- The check
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
4c006d0c7382b940a83359d636c0d48952cdbb00
src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a
Diff: https://reviews.apache.org/r/36106/diff/
Testing
---
make check
Thanks,
Jojy Varghese
(updated)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
(updated)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
, visit:
https://reviews.apache.org/r/36106/#review91168
---
On July 7, 2015, 12:26 a.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
-
src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f
src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba
Diff: https://reviews.apache.org/r/36326/diff/
Testing
---
make check
Thanks,
Jojy Varghese
---
On July 9, 2015, 8:38 p.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36326
://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
.apache.org/r/40285/#review106794
---
On Nov. 17, 2015, 6:41 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/40285/diff/
Testing
---
make check;
Thanks,
Jojy Varghese
/docker.cpp (line 221)
https://reviews.apache.org/r/37200/#comment152083
Use explicit capture.
src/slave/containerizer/provisioners/docker.cpp (line 251)
https://reviews.apache.org/r/37200/#comment152085
What happens on failure?
- Jojy Varghese
On Aug. 25, 2015, 8:59 p.m., Lily Chen wrote
it in cpp?
Jojy Varghese wrote:
The only reason being that this is a property of the TokenManager.
Timothy Chen wrote:
I see, does it need to be? Can't we define a static const in the cpp?
We could but then it wont be a class property. Here the constant reflects the
property of the class
---
On Aug. 28, 2015, 4:27 a.m., Jojy Varghese wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427
: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
reviews.apache.org/r/37773/#review97138
---
On Aug. 30, 2015, 3:12 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To re
Diff: https://reviews.apache.org/r/37427/diff/
Testing
---
make check.
Thanks,
Jojy Varghese
/libprocess/src/tests/ssl_tests.cpp
7a316bc10575325ffe732fcc87d72d15a4fc5eaf
Diff: https://reviews.apache.org/r/37871/diff/
Testing
---
make check
Thanks,
Jojy Varghese
> On Sept. 1, 2015, 9:13 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 61
> > <https://reviews.apache.org/r/37427/diff/17/?file=1060731#file1060731line61>
> >
> > Its effectively the same. const ref
ries created in the SSLTest setup.
- Jojy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review97331
---
On Sept. 1, 201
201 - 300 of 692 matches
Mail list logo
