---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123738
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 15, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44076/#review123159
---
Ship it!
- Joris Van Remoortere
On March 11, 2016, 9:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44077/#review123093
---
Ship it!
- Joris Van Remoortere
On Feb. 26, 2016, 4:11 p.m
0>
2 lines between functions in a namespace.
- Joris Van Remoortere
On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review123089
---
Ship it!
- Joris Van Remoortere
On March 11, 2016, 9:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44045/#review123090
---
Ship it!
- Joris Van Remoortere
On Feb. 25, 2016, 10:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44046/#review123091
---
Ship it!
- Joris Van Remoortere
On Feb. 26, 2016, 4:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44042/#review121558
---
Ship it!
- Joris Van Remoortere
On Feb. 25, 2016, 9:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/#review123167
---
Ship it!
- Joris Van Remoortere
On March 11, 2016, 9:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43707/#review123088
---
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 5:25 a.m
48 - 49)
<https://reviews.apache.org/r/43709/#comment185224>
Can we please alpabetize?
- Joris Van Remoortere
On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
70 - 71)
<https://reviews.apache.org/r/43708/#comment185223>
What does setting it twice do?
- Joris Van Remoortere
On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
src/module/manager.cpp (line 244)
<https://reviews.apache.org/r/44694/#comment185220>
do you need a whitespace at the end?
- Joris Van Remoortere
On March 11, 2016, 2:51 a.m., Kapil Arya wrote:
>
> ---
> This is an a
7;t fit on a single line.
src/module/manager.cpp (line 300)
<https://reviews.apache.org/r/44694/#comment185211>
new line after closing brace of an `if`
- Joris Van Remoortere
On March 11, 2016, 2:51 a.m., Kapil Arya wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44258/#review123064
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 9, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44537/#review123065
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 10, 2016
Does the order here matter?
If not can we make a note?
src/slave/containerizer/mesos/linux_launcher.cpp (lines 318 - 319)
<https://reviews.apache.org/r/44087/#comment185087>
Now that we've gutted the pipe logic, can we add a `NOTE:` that the child
process will be blocked u
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44463/#review122973
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 7, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44433/#review122972
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 8, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44407/#review122971
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 4, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44280/#review122970
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
are exiting less helpful to readers than *why*.
I think the implied invariant here (which we should call out explicitly) is
that any machine should only be "touched" by 1 of the 2 loops here. The exit
conditions between them are meant to enforce this exclusion?
- Joris Van Re
/hierarchical_allocator_tests.cpp (line 806)
<https://reviews.apache.org/r/44332/#comment183763>
Can you fix the extra `.` here as well?
- Joris Van Remoortere
On March 3, 2016, 1 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically g
- 4466)
<https://reviews.apache.org/r/44236/#comment183572>
Let's move this before reconcile so that if we added version specific logic
to it, it would use the correct version.
- Joris Van Remoortere
On March 2, 2016, 12:01 a.m., Kla
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44251/#review121757
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121604
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
tps://reviews.apache.org/r/40620/#comment183273>
Alphabetize.
- Joris Van Remoortere
On March 1, 2016, 11:58 p.m., Daniel Pravat wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40115/#review121552
---
Ship it!
- Joris Van Remoortere
On March 1, 2016, 11:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121602
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121603
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121598
---
Ship it!
Ship It!
- Joris Van Remoortere
On March 2, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/#review121584
---
Ship it!
- Joris Van Remoortere
On March 2, 2016, 2:21 a.m
e2` is now a
__quantity__, and that this invariant is maintained by only adding
`StrippedScalarQuantity`s to it?
src/master/allocator/sorter/drf/sorter.cpp (lines 374 - 375)
<https://reviews.apache.org/r/44251/#comment183328>
new line?
- Joris Van Remoortere
On March 2, 2016, 2:22
3 - 2634)
<https://reviews.apache.org/r/43686/#comment183319>
Can we add a TODO to factor this test out by parameterizing the
DeclineFilter test of which it is a copy?
- Joris Van Remoortere
On March 2, 2016, 2:21 a.m., Neil Conway wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/#review121579
---
Ship it!
- Joris Van Remoortere
On March 2, 2016, 2:20 a.m
/hierarchical_allocator_tests.cpp
<https://reviews.apache.org/r/43684/#comment183317>
Let's sync with James before removing this.
- Joris Van Remoortere
On March 2, 2016, 2:20 a.m., Neil Conway wrote:
>
> ---
> This is an automatically genera
of expression and brace. `){` => `) {`
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp
(lines 56 - 57)
<https://reviews.apache.org/r/41632/#comment183296>
`} else {`
- Joris Van Remoortere
On March 1, 2016, 11:56 p.m., Daniel Pravat wrote:
>
> --
are not covered by the tests your introduced.
- Joris Van Remoortere
On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
/rmdir.hpp (lines 40 -
43)
<https://reviews.apache.org/r/43907/#comment183250>
How is this different from `fts_open` returning null with errno set to
`ENOENT` below?
- Joris Van Remoortere
On Feb. 25, 2016, 7:41 p.m., Alex Clemmer
/include/Makefile.am (line 118)
<https://reviews.apache.org/r/40938/#comment183226>
style.
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp (line 19)
<https://reviews.apache.org/r/40938/#comment183227>
new line.
- Joris Van Remoortere
On March 1, 201
/40939/#comment183231>
Why does this file need to include these?
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp (lines 46 -
56)
<https://reviews.apache.org/r/40939/#comment183239>
2 new lines between functions in a namespace.
- Joris Van Remoortere
On Mar
/3rdparty/stout/include/stout/windows/os.hpp
<https://reviews.apache.org/r/43905/#comment183213>
Not sure how you were able to commit a stout change together with a mesos
change.
- Joris Van Remoortere
On Feb. 25, 2016, 7:17 p.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43903/#review121472
---
Ship it!
- Joris Van Remoortere
On Feb. 25, 2016, 7:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review121499
---
Ship it!
- Joris Van Remoortere
On Feb. 25, 2016, 7:17 p.m
23)
<https://reviews.apache.org/r/43689/#comment183027>
"Check that we are"
- Joris Van Remoortere
On Feb. 18, 2016, 2:29 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43699/#review121355
---
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 4:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review121348
---
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 2:31 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43695/#review121349
---
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 2:28 a.m
/cmake/StoutConfigure.cmake (line 49)
<https://reviews.apache.org/r/43697/#comment183028>
extra period.
- Joris Van Remoortere
On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43693/#review121352
---
Ship it!
- Joris Van Remoortere
On Feb. 18, 2016, 2:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/#review121354
---
Ship it!
- Joris Van Remoortere
On Feb. 29, 2016, 6:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43692/#review121353
---
Ship it!
- Joris Van Remoortere
On Feb. 29, 2016, 6:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43694/#review121351
---
Ship it!
- Joris Van Remoortere
On March 1, 2016, 8:38 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44113/#review121110
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 27, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43636/#review121109
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 27, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44126/#review121107
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 27, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44129/#review121060
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 27, 2016
tps://reviews.apache.org/r/43635/#comment182589>
Can we add a comment explaining why we use this quotient, remainder
approach?
- Joris Van Remoortere
On Feb. 26, 2016, 11:52 p.m., Neil Conway wrote:
>
> ---
> This is a
-
>
> (Updated Feb. 26, 2016, 9:38 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Bugs: MESOS-3271 and MESOS-4711
> https://issues.apache.org/jira/browse/MESOS-3271
> https://issues.apache.org/jira/browse/MESOS-4711
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43799/#review120998
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 26, 2016
)
<https://reviews.apache.org/r/43635/#comment182536>
How about if we re-construct the double from its whole and decimal parts
using `/1000` and `%1000`?
- Joris Van Remoortere
On Feb. 19, 2016, 10:27 p.m., Neil Conway
82518>
expected, actual ?
src/tests/resources_tests.cpp (lines 1592 - 1605)
<https://reviews.apache.org/r/43635/#comment182521>
Can you add another test like this that adds 100K times, and then subtracts
100K times? and checks between the top and bottom?
- Joris Van Remoortere
e.org/r/43799/#comment182461>
Please comment why we're using a weak_ptr here.
3rdparty/libprocess/src/libevent_poll.cpp (lines 91 - 93)
<https://reviews.apache.org/r/43799/#comment182462>
Please comment that this is the explicit order we want these 2 statements
in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/#review120671
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 25, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43974/#review120670
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 25, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43937/#review120665
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 24, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43035/#review120619
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 24, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42877/#review120618
---
Ship it!
rebased.
- Joris Van Remoortere
On Feb. 19, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43587/#review120571
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 15, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review120567
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 19, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120568
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 19, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43858/#review120221
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 23, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119736
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 18, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43633/#review119373
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 16, 2016
/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3
Diff: https://reviews.apache.org/r/43583/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/#review119351
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 3, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43065/#review119312
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 1, 2016, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43034/#review119313
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 1, 2016
/#comment180634>
Do you mean `Ensure that no pending messages are delivered.`?
Or `if any`, then what?
- Joris Van Remoortere
On Feb. 1, 2016, 9:40 p.m., Neil Conway wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43033/#review119308
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 31, 2016
docs/persistent-volume.md 4d7821fc4a18ab3c6261418fb8062e6bdf90d5a3
Diff: https://reviews.apache.org/r/43583/diff/
Testing
---
Thanks,
Joris Van Remoortere
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43583/#review119238
-----------
On Feb. 15, 2016, 7:42 p.m., Joris Van Remoortere wrote:
>
> --
://issues.apache.org/jira/browse/MESOS-4531
Repository: mesos
Description
---
See summary.
Diffs
-
docs/multiple-disk.md PRE-CREATION
Diff: https://reviews.apache.org/r/43583/diff/
Testing
---
Thanks,
Joris Van Remoortere
14ad4dcc0dfb1d7745e58e11e8f66386288395d7
src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64
Diff: https://reviews.apache.org/r/43582/diff/
Testing
---
run on systemd system with flag disabled.
Thanks,
Joris Van Remoortere
/43582/diff/
Testing
---
run on systemd system with flag disabled.
Thanks,
Joris Van Remoortere
20232d645175d0d574c6d896188435277619010d
src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7
src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64
Diff: https://reviews.apache.org/r/43582/diff/
Testing
---
run on systemd system with flag disabled.
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43432/#review118782
---
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 11, 2016
>
> (Updated Feb. 10, 2016, 4:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Bugs: MESOS-4636
> https://issues.apache.org/jira/browse/MESOS-4636
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Migrated linux launcher systemd executor logic into subprocess hook.
>
>
> Diffs
> -
>
> src/linux/systemd.cpp 5034308cb4d1bb0b66c097daf5ec53a880cf510a
> src/slave/containerizer/mesos/linux_launcher.cpp
> c2e252ec6ed0d6d4c47e244f700315bd340cee5f
>
> Diff: https://reviews.apache.org/r/43306/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
uncher.cpp
c2e252ec6ed0d6d4c47e244f700315bd340cee5f
Diff: https://reviews.apache.org/r/43304/diff/
Testing
---
Thanks,
Joris Van Remoortere
: https://reviews.apache.org/r/43309/diff/
Testing
---
make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
Thanks,
Joris Van Remoortere
01a3ff031b70366443214e2895803cd4b2606ad8
Diff: https://reviews.apache.org/r/43308/diff/
Testing
---
Thanks,
Joris Van Remoortere
Diff: https://reviews.apache.org/r/43307/diff/
Testing
---
Thanks,
Joris Van Remoortere
/containerizer/mesos/linux_launcher.cpp
c2e252ec6ed0d6d4c47e244f700315bd340cee5f
Diff: https://reviews.apache.org/r/43306/diff/
Testing
---
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/43305/diff/
Testing
---
Thanks,
Joris Van Remoortere
)
-
3rdparty/libprocess/include/process/subprocess.hpp
bb50cc3070245a294fa16efe44f14ae893bc5518
3rdparty/libprocess/src/subprocess.cpp
ff477e37a9619c780bddd5a8e629fa981b729715
Diff: https://reviews.apache.org/r/43303/diff/
Testing
---
Thanks,
Joris Van Remoortere
bb50cc3070245a294fa16efe44f14ae893bc5518
3rdparty/libprocess/src/subprocess.cpp
ff477e37a9619c780bddd5a8e629fa981b729715
Diff: https://reviews.apache.org/r/43302/diff/
Testing
---
Thanks,
Joris Van Remoortere
/
Testing
---
Thanks,
Joris Van Remoortere
---
make check
manual testing on systemd with agent-systemd-unit `KillMode=control-group`.
Thanks,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
c2e252ec6ed0d6d4c47e244f700315bd340cee5f
Diff: https://reviews.apache.org/r/43306/diff/
Testing
---
Thanks,
Joris Van Remoortere
701 - 800 of 1678 matches
Mail list logo
