Re: Review Request 46537: Added --enable-install-module-dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46537/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added --enable-install-module-dependencies. Diffs (updated) - 3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46528/ --- (Updated May 10, 2016, 5:47 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated stout/Makefile.am to reflect bundled dependencies. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am e944463aad69c70a2563b424f0b80f3e7f66b5aa 3rdparty/libprocess/3rdparty/stout/Makefile.am d523fb0a212228cc47537dc6e444be51941573cc Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46527/ --- (Updated May 10, 2016, 5:47 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- This will help getting us closer to a standalone stout library. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/configure.ac a1f86d0f943bbff91a8b021046eb66d624df7896 3rdparty/libprocess/3rdparty/stout/m4/ax_compare_version.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_vendor.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_version.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46526/ --- (Updated May 10, 2016, 5:46 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated 3rdparty paths in Python build scripts. Diffs (updated) - src/examples/python/test-containerizer.in 1516fd1fa02bafab502b185df9da63cfd6e10e5e src/examples/python/test-executor.in 93fd1756fdea09cb9efc4a7005d03c15683c2d70 src/examples/python/test-framework.in 22301fae22e25fbddb63d08bfe824fdd29c74637 src/python/native_common/ext_modules.py.in 4fd328fdbeb68ea2eeb464b6df552e0ef33d6ea9 Diff: https://reviews.apache.org/r/46526/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46525/ --- (Updated May 10, 2016, 5:45 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/. Diffs (updated) - 3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1 3rdparty/libprocess/3rdparty/Makefile.am e944463aad69c70a2563b424f0b80f3e7f66b5aa 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz 3rdparty/libprocess/3rdparty/gmock_sources.cc.in 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz 3rdparty/libprocess/3rdparty/http-parser-2.6.2.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 3rdparty/libprocess/3rdparty/libev-4.22.patch 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz 3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz 3rdparty/libprocess/3rdparty/protobuf-2.6.1.patch 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz 3rdparty/libprocess/3rdparty/versions.am 4699543557df4cb818bad8d61b5706c061beb0f5 3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 3rdparty/versions.am a00c3b0f14bb8c805545471ef9b6eb633f515d05 configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46523: Sanitized libprocess/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46523/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized libprocess/Makefile.am. Diffs (updated) - 3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd Diff: https://reviews.apache.org/r/46523/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized libprocess/3rdparty/Makefile.am. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am e944463aad69c70a2563b424f0b80f3e7f66b5aa Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46521/
---
(Updated May 10, 2016, 5:43 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Changes
---
rebased
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Added --with-{libproces,stout} flags to top-level configure.ac.
Diffs (updated)
-
configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe
src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd
Diff: https://reviews.apache.org/r/46521/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46524: Sanitized src/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46524/ --- (Updated May 10, 2016, 5:44 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized src/Makefile.am. Diffs (updated) - src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd Diff: https://reviews.apache.org/r/46524/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46519/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Copied libprocess-specific configure options to top-level configure.ac. Diffs (updated) - configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe Diff: https://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46520: Added --with-stout flag to libprocess configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46520/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney and Joris Van Remoortere. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added --with-stout flag to libprocess configure. Diffs (updated) - 3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46518: Sorted option checks for top-level configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46518/ --- (Updated May 10, 2016, 5:42 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sorted option checks for top-level configure.ac. Diffs (updated) - configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe Diff: https://reviews.apache.org/r/46518/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46516: Sorted option checks for libprocess configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46516/ --- (Updated May 10, 2016, 5:40 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Changes --- rebased Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sorted option checks for libprocess configure.ac. Diffs (updated) - 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated May 10, 2016, 5:38 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Libprocess: Renamed --without-zlib to --disable-zlib. Diffs (updated) - 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 Diff: https://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46514/
---
(Updated May 10, 2016, 5:37 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Libprocess: Sorted configure.ac AC_ARG_{ENABLE,WITH} entries.
Diffs (updated)
-
3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46514/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/#review132543 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:36 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46869/ > --- > > (Updated May 10, 2016, 4:36 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > The test cluster initialization code was altered > to enable authorization of libprocess-level HTTP > endpoints when a master or agent is launched > with authorization enabled. > > > Diffs > - > > src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 > src/tests/cluster.cpp db7262868164b1966a9824b8aa53dbe9c5af7c2f > > Diff: https://reviews.apache.org/r/46869/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46870: Added MetricsTests with authorization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46870/#review132538 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:36 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46870/ > --- > > (Updated May 10, 2016, 4:36 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > New tests were added: `MetricsTest.AgentAuthorizationEnabled` > and `MetricsTest.MasterAuthorizationEnabled`. They verify > that unauthorized requests to the '/metrics/snapshot' > endpoints are rejected. > > > Diffs > - > > src/tests/metrics_tests.cpp 2ff6bb5b9ff6040009cb58730f09d6727fb9627c > > Diff: https://reviews.apache.org/r/46870/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/#review132537 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:31 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46883/ > --- > > (Updated May 10, 2016, 4:31 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > This patch adds a callback to the generating > function `CreateAuthorizationCallbacks` for the > '/metrics/snapshot' endpoint. > > > Diffs > - > > src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f > > Diff: https://reviews.apache.org/r/46883/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46881: Added authorization callback for '/logging/toggle'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/#review132532 --- Ship it! src/common/http.cpp (lines 590 - 592) <https://reviews.apache.org/r/46881/#comment196764> Maybe move this closer to AuthorizationCallbacks declaration? - Kapil Arya On May 10, 2016, 4:38 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46881/ > --- > > (Updated May 10, 2016, 4:38 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > This patch adds an authorization callback to the > generating function `CreateAuthorizationCallbacks` > for the '/logging/toggle' endpoint. > > > Diffs > - > > src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f > > Diff: https://reviews.apache.org/r/46881/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46882: Added a LoggingTest with authorization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/#review132540 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:38 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46882/ > --- > > (Updated May 10, 2016, 4:38 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > A new test, `LoggingTest.ToggleAuthorizationEnabled`, > was added which checks that the '/logging/toggle' > endpoint correctly rejects unauthorized requests. > > > Diffs > - > > src/tests/logging_tests.cpp 541274460f7d623eedca4d5c4780015e1bd4f961 > > Diff: https://reviews.apache.org/r/46882/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review132536 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46867/ > --- > > (Updated May 10, 2016, 4:30 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > Code is added to the common headers and the > master/agent executables which sets authorization > callbacks for libprocess-level HTTP endpoints. > This allows these endpoints to be authorized. > > > Diffs > - > > src/common/http.hpp 6c6f2840bbf49d198b1db876cdf4af5ef49b0e27 > src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f > src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 > src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d > > Diff: https://reviews.apache.org/r/46867/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/#review132535 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46866/ > --- > > (Updated May 10, 2016, 4:30 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > This patch enables libprocess to store and execute > authorization callbacks provided by a client > application. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > 3b7e2c42d4ac3d1e38e1ac82ddb58ff6dc8ad0af > 3rdparty/libprocess/src/process.cpp > a9bb27f034fc3795674d44b58bf4d3f5e92ee67c > > Diff: https://reviews.apache.org/r/46866/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46538: Install module dependencies in build/3rdparty as well.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46538/ --- (Updated May 10, 2016, 3:26 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- If configured with --enable-install-module-dependencies, install 3rdparty dependencies in build/3rdparty. Diffs (updated) - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46537: Added --enable-install-module-dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46537/ --- (Updated May 10, 2016, 3:26 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added --enable-install-module-dependencies. Diffs (updated) - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46532: Updated LDADD flags for libprocess tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46532/ --- (Updated May 10, 2016, 3:25 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated LDADD flags for libprocess tests. Diffs (updated) - 3rdparty/libprocess/Makefile.am 51f62aa636900c05ba970a0551558db813ce1dfd Diff: https://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated May 10, 2016, 3:23 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized libprocess/3rdparty/Makefile.am. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 83bd38acb32aca63af45ee5d58825ef2be656a03 Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46521/
---
(Updated May 10, 2016, 3:23 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Added --with-{libproces,stout} flags to top-level configure.ac.
Diffs (updated)
-
configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
Diff: https://reviews.apache.org/r/46521/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated May 10, 2016, 3:23 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Libprocess: Renamed --without-zlib to --disable-zlib. Diffs (updated) - 3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7 Diff: https://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya
Review Request 46520: Added --with-stout flag to libprocess configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46520/ --- Review request for mesos, Cody Maloney and Joris Van Remoortere. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added --with-stout flag to libprocess configure. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 47161: Fixed replica log restore tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132445 --- Ran make check locally and it succeeded. src/tests/log_tests.cpp (lines 444 - 446) <https://reviews.apache.org/r/47161/#comment196617> Move this description before the first scope level? And maybe, add a comment about this test itself? - Kapil Arya On May 10, 2016, 5:02 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47161/ > --- > > (Updated May 10, 2016, 5:02 a.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-2201 > https://issues.apache.org/jira/browse/MESOS-2201 > > > Repository: mesos > > > Description > --- > > Per design leveldb can only be held open by a single process > at the time. In tests two instances of replica log were created > and lived at same time. Now there is one instance that create > db and second that restore it. > > > Diffs > - > > src/tests/log_tests.cpp 4cd6bc359d481c065d9647b3d5f0154cb5cb2503 > > Diff: https://reviews.apache.org/r/47161/diff/ > > > Testing > --- > > Tested with leveldb v1.18 before this patch tests failed with ` error: lock > already held by process` after this patch all tests passed. > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 9, 2016, 1:10 p.m.) Review request for mesos, Cody Maloney and Till Toenshoff. Bugs: MESOS-5173 https://issues.apache.org/jira/browse/MESOS-5173 Repository: mesos Description --- This allows the operator to use separate manifest JSON files for each module. Previously, one had to merge all module manifest files into a single JSON file before passing on to the master/agent. Diffs (updated) - src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 Diff: https://reviews.apache.org/r/47123/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya
Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 9, 2016, 1:05 p.m.) Review request for mesos, Cody Maloney and Till Toenshoff. Bugs: MESOS-5173 https://issues.apache.org/jira/browse/MESOS-5173 Repository: mesos Description --- This allows the operator to use separate manifest JSON files for each module. Previously, one had to merge all module manifest files into a single JSON file before passing on to the master/agent. Diffs (updated) - src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 Diff: https://reviews.apache.org/r/47123/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya
Review Request 47123: Added --modules_dir flag to read module manifests from a directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- Review request for mesos, Cody Maloney and Till Toenshoff. Bugs: MESOS-5173 https://issues.apache.org/jira/browse/MESOS-5173 Repository: mesos Description --- This allows the operator to use separate manifest JSON files for each module. Previously, one had to merge all module manifest files into a single JSON file before passing on to the master/agent. Diffs - src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 Diff: https://reviews.apache.org/r/47123/diff/ Testing --- Manual testing with: 1. --module_dir 2. --modules 3. --module_dir in conjunction with --modules The first two succeeded while the third failed as expected. Thanks, Kapil Arya
Re: Review Request 46920: Added validation hook inside Slave::runTask.
> On May 6, 2016, 3:37 a.m., Adam B wrote: > > Please create a JIRA with motivation for this hook. I don't want a new hook > > to slip into a release without a JIRA in the changelog to document it. Good point. I meant to add it to the RR, but it slipped :-). - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131997 --- On May 5, 2016, 12:01 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46920/ > --- > > (Updated May 5, 2016, 12:01 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to > inspect the contents of a task and potentially reject the task with a > `TASK_ERROR`. > > > Diffs > - > > include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca > src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 > src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 > src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 > > Diff: https://reviews.apache.org/r/46920/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/#review132085 --- 3rdparty/libprocess/src/process.cpp (lines 3299 - 3308) <https://reviews.apache.org/r/46989/#comment196173> Can we simplify the logic a bit here and add some explanation? 3rdparty/libprocess/src/process.cpp (lines 3315 - 3318) <https://reviews.apache.org/r/46989/#comment196174> Simplify this too so that callback_path is set iff there is a callback for the requested URL. - Kapil Arya On May 5, 2016, 4:15 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46989/ > --- > > (Updated May 5, 2016, 4:15 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > This patch adds the handling of authorization calls > for libprocess-level HTTP endpoints into the > `ProcessBase::visit` method. The authorization results > are sequenced to assure that operations are execute in > the same order in which they are received. > > > Diffs > - > > 3rdparty/libprocess/src/process.cpp > dcaa64633d1eea330649c563635642928164d73c > > Diff: https://reviews.apache.org/r/46989/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46920: Added validation hook inside Slave::runTask.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131966 --- Ship it! Ship It! - Kapil Arya On May 5, 2016, 12:01 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46920/ > --- > > (Updated May 5, 2016, 12:01 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to > inspect the contents of a task and potentially reject the task with a > `TASK_ERROR`. > > > Diffs > - > > include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca > src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 > src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 > src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 > > Diff: https://reviews.apache.org/r/46920/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 46920: Added validation hook inside Slave::runTask.
> On May 5, 2016, 1:27 p.m., Kapil Arya wrote: > > The hooks looks good but I have a high-level question. Instead of having > > two separate hooks for validation and label-decoration, I am wondering, if > > we can have one consolidated hook. That hook would then update the labels > > (and any other fields that we might want to in future) and also validate a > > task at the same time. > > > > Any thoughts? > > Joseph Wu wrote: > That might work, but I'm worried that this would make the semantics of > the hook somewhat odd. > > Most of the hooks have the `Result` return type, where `None` implies no > change, and `Error` implies the *hook errored*. This new hook introduces a > hook where an `Error` implies the *task errored*. To combine the two hooks > an maintain semantics, we'd have a return type of `tuple<Result, > Try>` or something... > > Not to mention combining the hooks would be a breaking module interface > change... I agree about the breaking changes. However, we might consider creating a protobuf, say SlaveTaskHookInfo, which would contain several optional fields including labels, Error, etc. In anycase, let's not worry about it for now. In future, if the need arises, we can reconsider the alternate. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131869 --- On May 5, 2016, 12:01 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46920/ > --- > > (Updated May 5, 2016, 12:01 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to > inspect the contents of a task and potentially reject the task with a > `TASK_ERROR`. > > > Diffs > - > > include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca > src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 > src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 > src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 > > Diff: https://reviews.apache.org/r/46920/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 46920: Added validation hook inside Slave::runTask.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131869 --- The hooks looks good but I have a high-level question. Instead of having two separate hooks for validation and label-decoration, I am wondering, if we can have one consolidated hook. That hook would then update the labels (and any other fields that we might want to in future) and also validate a task at the same time. Any thoughts? - Kapil Arya On May 5, 2016, 12:01 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46920/ > --- > > (Updated May 5, 2016, 12:01 p.m.) > > > Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya. > > > Repository: mesos > > > Description > --- > > Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to > inspect the contents of a task and potentially reject the task with a > `TASK_ERROR`. > > > Diffs > - > > include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca > src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 > src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 > src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 > src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 > src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 > > Diff: https://reviews.apache.org/r/46920/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 46540: Updated pkg-config file to include module dependency info.
> On May 4, 2016, 11:33 a.m., James Peach wrote: > > configure.ac, line 591 > > <https://reviews.apache.org/r/46540/diff/1/?file=1355759#file1355759line591> > > > > So in practice, libraries would be installed in either > > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both? > > > > Is there a libtool or autoconf variable to figure that out? On 32-bit, they'll be installed in lib. On 64-bit, it could be either :-(. I believe there might be a way to figure it out but I am not so sure given that we are talking about 3rdparty software (with their own configure scripts) here. I'll try to think of a better alternative. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/#review131691 ------- On May 4, 2016, 11:22 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46540/ > --- > > (Updated May 4, 2016, 11:22 a.m.) > > > Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and > Timothy St. Clair. > > > Bugs: MESOS-5250 > https://issues.apache.org/jira/browse/MESOS-5250 > > > Repository: mesos > > > Description > --- > > Updated pkg-config file to include module dependency info. > > > Diffs > - > > configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 > mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 > > Diff: https://reviews.apache.org/r/46540/diff/ > > > Testing > --- > > > Thanks, > > Kapil Arya > >
Re: Review Request 46540: Updated pkg-config file to include module dependency info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/ --- (Updated May 4, 2016, 11:22 a.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated pkg-config file to include module dependency info. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46883/#review131616
---
src/common/http.cpp (line 599)
<https://reviews.apache.org/r/46883/#comment195636>
Does non-existing `subject` mean "ANY"?
src/common/http.cpp (line 602)
<https://reviews.apache.org/r/46883/#comment195635>
const?
- Kapil Arya
On May 1, 2016, 8:03 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46883/
> ---
>
> (Updated May 1, 2016, 8:03 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Kapil Arya.
>
>
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch adds a callback to the generating
> function `CreateAuthorizationCallbacks` for the
> '/metrics/snapshot' endpoint.
>
>
> Diffs
> -
>
> src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f
>
> Diff: https://reviews.apache.org/r/46883/diff/
>
>
> Testing
> ---
>
> `make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/#review131613 --- 3rdparty/libprocess/include/process/http.hpp (lines 89 - 91) <https://reviews.apache.org/r/46866/#comment195628> Is that the correct line-break here? Can we make it better? 3rdparty/libprocess/include/process/http.hpp (lines 89 - 100) <https://reviews.apache.org/r/46866/#comment195629> Since this is a public header, let's add comment blocks. 3rdparty/libprocess/src/process.cpp (line 484) <https://reviews.apache.org/r/46866/#comment195630> Having non-pod global vars isn't good! Maybe use a pointer instead? - Kapil Arya On May 1, 2016, 6:28 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46866/ > --- > > (Updated May 1, 2016, 6:28 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > This patch enables libprocess to store and execute > authorization callbacks provided by a client > application. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > 8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 > 3rdparty/libprocess/src/process.cpp > dcaa64633d1eea330649c563635642928164d73c > > Diff: https://reviews.apache.org/r/46866/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/#review131617 --- src/tests/scheduler_driver_tests.cpp (line 99) <https://reviews.apache.org/r/46876/#comment195640> Why this change? - Kapil Arya On May 1, 2016, 6:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46876/ > --- > > (Updated May 1, 2016, 6:30 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > Some tests hit the '/metrics/snapshot' endpoint and > must be updated to accomodate authorization. In > particular, an authorizer had to be explicitly > instantiated and used to initialize the master/agent > in some tests so that they share the same authorizer. > > > Diffs > - > > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2 > src/tests/mesos.cpp 036c589f5aafc8c804b0fb4e5ad62df70e471e88 > src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1 > src/tests/scheduler_driver_tests.cpp > 217185780e3576faf633dd9629ae93a275fac284 > src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb > > Diff: https://reviews.apache.org/r/46876/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review131614 --- src/common/http.cpp (lines 587 - 588) <https://reviews.apache.org/r/46867/#comment195632> Fix continuation. src/common/http.cpp (lines 590 - 592) <https://reviews.apache.org/r/46867/#comment195633> Coalesce? - Kapil Arya On May 1, 2016, 6:43 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46867/ > --- > > (Updated May 1, 2016, 6:43 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > Code is added to the common headers and the > master/agent executables which sets authorization > callbacks for libprocess-level HTTP endpoints. > This allows these endpoints to be authorized. > > > Diffs > - > > src/common/http.hpp 6c6f2840bbf49d198b1db876cdf4af5ef49b0e27 > src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f > src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 > src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d > > Diff: https://reviews.apache.org/r/46867/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46813: Update distribute to setuptools.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131165 --- Ship it! Ship It! - Kapil Arya On April 29, 2016, 5:13 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46813/ > --- > > (Updated April 29, 2016, 5:13 a.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5244 > https://issues.apache.org/jira/browse/MESOS-5244 > > > Repository: mesos > > > Description > --- > > Update distribute to setuptools. > > > Diffs > - > > 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 > 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 > 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION > 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 > LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d > configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 > mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee > src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 > src/examples/python/test-containerizer.in > b8258e75a3cd5f8d18ab8eff8196c5374db4f629 > src/examples/python/test-executor.in > 6be0ad2d339ff43d074e9688978af1ddf956803c > src/examples/python/test-framework.in > 59bab82962c5846c6be288f3d392986e146e9da6 > support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 > > Diff: https://reviews.apache.org/r/46813/diff/ > > > Testing > --- > > make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5. > > NOTE: I tested on my RHEL 6.6 and failed, because the package > pytz-2010h-2.el6.noarch was installed, when I removed this package verything > ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think > it's ok for this patch. > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46805: Added backport of MESOS-5018 to 0.27.3.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46805/#review131019 --- Ship it! Ship It! - Kapil Arya On April 28, 2016, 7:38 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46805/ > --- > > (Updated April 28, 2016, 7:38 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > This reflects the backport of MESOS-5018 to the 0.27.x branch. > > > Diffs > - > > CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb > > Diff: https://reviews.apache.org/r/46805/diff/ > > > Testing > --- > > N/A > > > Thanks, > > Ben Mahler > >
Re: Review Request 46804: Patched glog to eliminate system-level gflag library detection.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46804/#review131010
---
Ship it!
Ship It!
- Kapil Arya
On April 28, 2016, 7:32 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46804/
> ---
>
> (Updated April 28, 2016, 7:32 p.m.)
>
>
> Review request for mesos, Kapil Arya and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The glog library will attempt to detect whether the gflag library
> is installed on the system. However, glog can compile correctly
> when gflags is absent, due to a compatiblity layer:
>
> https://github.com/google/glog/blob/v0.3.3/src/base/commandlineflags.h
>
> We do not want a 3rd party dependency on the host to be picked up
> by glog in general. In the case of gflags, it turns out that this
> may break the build (when the gflag headers are incompatible).
>
> There is no configure flag for disabling this auto-detection, so
> we patch glog to remove it.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch
> f05f4b56bfc217f3fb82c32b56a950e0fc9956f2
>
> Diff: https://reviews.apache.org/r/46804/diff/
>
>
> Testing
> ---
>
> `make check` succeeds with an installed gflags library.
>
> Previously, the following occurs:
>
> ```
> g++ -DHAVE_CONFIG_H -I. -I./src -I./src -pthread-Wall -Wwrite-strings
> -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER -g1 -O0
> -Wno-unused-local-typedefs -std=c++11 -MT logging_unittest-logging_unittest.o
> -MD -MP -MF .deps/logging_unittest-logging_unittest.Tpo -c -o
> logging_unittest-logging_unittest.o `test -f 'src/logging_unittest.cc' ||
> echo './'`src/logging_unittest.cc
> src/logging_unittest.cc: In function ‘int main(int, char**)’:
> src/logging_unittest.cc:179:43: error: ‘ParseCommandLineFlags’ was not
> declared in this scope
>ParseCommandLineFlags(, , true);
>^
> src/logging_unittest.cc:179:43: note: suggested alternative:
> In file included from src/glog/logging.h:85:0,
> from src/utilities.h:82,
> from src/logging_unittest.cc:33:
> /usr/include/gflags/gflags.h:346:15: note: ‘gflags::ParseCommandLineFlags’
> extern GFLAGS_DLL_DECL uint32 ParseCommandLineFlags(int *argc, char*** argv,
> bool remove_flags);
>^
> src/logging_unittest.cc: In static member function ‘static void
> Test_DeathNoAllocNewHook_logging::Run()’:
> src/logging_unittest.cc:296:130: error: ‘FlagSaver’ was not declared in this
> scope
> TEST(DeathNoAllocNewHook, logging) {
>
> ^
> src/logging_unittest.cc:296:130: note: suggested alternative:
> In file included from src/glog/logging.h:85:0,
> from src/utilities.h:82,
> from src/logging_unittest.cc:33:
> /usr/include/gflags/gflags.h:277:7: note: ‘gflags::FlagSaver’
> class GFLAGS_DLL_DECL FlagSaver {
>^
> src/logging_unittest.cc:296:140: error: expected ‘;’ before ‘fs’
> TEST(DeathNoAllocNewHook, logging) {
>
> ^
> src/logging_unittest.cc: In function ‘void TestRawLogging()’:
> src/logging_unittest.cc:308:3: error: ‘FlagSaver’ was not declared in this
> scope
>FlagSaver saver;
>^
> src/logging_unittest.cc:308:3: note: suggested alternative:
> In file included from src/glog/logging.h:85:0,
> from src/utilities.h:82,
> from src/logging_unittest.cc:33:
> /usr/include/gflags/gflags.h:277:7: note: ‘gflags::FlagSaver’
> class GFLAGS_DLL_DECL FlagSaver {
>^
> src/logging_unittest.cc:308:13: error: expected ‘;’ before ‘saver’
>FlagSaver saver;
> ^
> src/logging_unittest.cc: In function ‘void LogWithLevels(int, int, bool,
> bool)’:
> src/logging_unittest.cc:363:3: error: ‘FlagSaver’ was not declared in this
> scope
>FlagSaver saver;
>^
> src/logging_unittest.cc:363:3: note: suggested alternative:
> In file included from src/glog/logging.h:85:0,
> from src/utilities.h:82,
> from src/logging_unittest.cc:33:
> /usr/include/gflags/gflags.h:277:7: note:
Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130619 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:25 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46461/ > --- > > (Updated April 25, 2016, 1:25 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-3319 > https://issues.apache.org/jira/browse/MESOS-3319 > > > Repository: mesos > > > Description > --- > > Updated gperftools to version 2.5 (libprocess). > > > Diffs > - > > 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz > 13b03cae44e5e6dcfdec4756b975f425b2ea73cf > 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am 5506eb3 > > Diff: https://reviews.apache.org/r/46461/diff/ > > > Testing > --- > > `sudo make check` > > > Thanks, > > Greg Mann > >
Re: Review Request 46647: Added the '--enable-perftools' flag to configure docs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46647/#review130482 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:45 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46647/ > --- > > (Updated April 25, 2016, 1:45 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-3319 > https://issues.apache.org/jira/browse/MESOS-3319 > > > Repository: mesos > > > Description > --- > > Added the '--enable-perftools' flag to configure docs. > > > Diffs > - > > docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 > > Diff: https://reviews.apache.org/r/46647/diff/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
Re: Review Request 46643: Fixed the build when perftools is enabled.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46643/#review130481 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 1:19 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46643/ > --- > > (Updated April 25, 2016, 1:19 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-3319 > https://issues.apache.org/jira/browse/MESOS-3319 > > > Repository: mesos > > > Description > --- > > Fixed the build when perftools is enabled. > > > Diffs > - > > 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa > 3rdparty/libprocess/src/profiler.cpp > 58cf2fec119e65a74a3c75561ba0866ec88897d0 > > Diff: https://reviews.apache.org/r/46643/diff/ > > > Testing > --- > > `sudo make check` on OSX, after both `../configure` and `../configure > --enable-perftools`. > > > Thanks, > > Greg Mann > >
Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46462/#review130437 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 12:22 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46462/ > --- > > (Updated April 21, 2016, 12:22 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-3319 > https://issues.apache.org/jira/browse/MESOS-3319 > > > Repository: mesos > > > Description > --- > > Updated gperftools to version 2.5 (Mesos). > > > Diffs > - > > src/python/native_common/ext_modules.py.in > ad98a576ee3662ccb5b8900a339e530089f41355 > > Diff: https://reviews.apache.org/r/46462/diff/ > > > Testing > --- > > `sudo make check` > > > Thanks, > > Greg Mann > >
Re: Review Request 46461: Updated gperftools to version 2.5 (libprocess).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/#review130436 --- LGTM modulo the comment. Also, have you done a grep for HAS_GPERFTOOLS to ensure that there aren't any leftovers? 3rdparty/libprocess/configure.ac (line 853) <https://reviews.apache.org/r/46461/#comment194178> I am wondering if we should split out this patch into two: one that updates bundled version, and second that does the HAS_GPERTOOL->ENABLE_GPERFTOOLS transition. - Kapil Arya On April 21, 2016, 4:29 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46461/ > --- > > (Updated April 21, 2016, 4:29 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-3319 > https://issues.apache.org/jira/browse/MESOS-3319 > > > Repository: mesos > > > Description > --- > > Updated gperftools to version 2.5 (libprocess). > > > Diffs > - > > 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz > 13b03cae44e5e6dcfdec4756b975f425b2ea73cf > 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am 5506eb3 > 3rdparty/libprocess/configure.ac d27e46e > 3rdparty/libprocess/src/profiler.cpp 58cf2fe > > Diff: https://reviews.apache.org/r/46461/diff/ > > > Testing > --- > > `sudo make check` > > > Thanks, > > Greg Mann > >
Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46497/#review130429 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:02 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46497/ > --- > > (Updated April 25, 2016, 10:02 a.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > Added authentication to the '/profiler/*' endpoints. > > > Diffs > - > > 3rdparty/libprocess/include/process/profiler.hpp > b305f1148ad6b623c75facc4abd0269c13017bab > 3rdparty/libprocess/src/process.cpp > 8727eb202e9699f0ac3c95788257cf1a22b0da7b > 3rdparty/libprocess/src/profiler.cpp > 58cf2fec119e65a74a3c75561ba0866ec88897d0 > > Diff: https://reviews.apache.org/r/46497/diff/ > > > Testing > --- > > `sudo make check` on OSX. The endpoints were also tested by configuring with > `../configure --enable-perftools`, and then hitting `/profiler/start` and > `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER` environment variable > set to 1. > > > Thanks, > > Greg Mann > >
Re: Review Request 46262: Added a LoggingTest with authentication.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46262/#review130427 --- Ship it! Ship It! - Kapil Arya On April 15, 2016, 3:01 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46262/ > --- > > (Updated April 15, 2016, 3:01 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > The test `LoggingTest.ToggleAuthenticationEnabled` > is added in this patch. > > > Diffs > - > > src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 > > Diff: https://reviews.apache.org/r/46262/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46260: Added a MetricsTest with authentication to libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46260/#review130426 --- Ship it! Ship It! - Kapil Arya On April 22, 2016, 3:14 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46260/ > --- > > (Updated April 22, 2016, 3:14 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > The test `MetricsTest.SnapshotAuthenticationEnabled` > is added to the libprocess tests in this patch. > > > Diffs > - > > 3rdparty/libprocess/src/tests/metrics_tests.cpp > b84dc8d858f58bc9f52b218b7153510417cf34c2 > > Diff: https://reviews.apache.org/r/46260/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46261: Added new MetricsTests with authentication to Mesos tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46261/#review130425 --- Ship it! src/tests/metrics_tests.cpp (line 85) <https://reviews.apache.org/r/46261/#comment194173> Newline? - Kapil Arya On April 21, 2016, 1:58 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46261/ > --- > > (Updated April 21, 2016, 1:58 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > The tests `MetricsTest.AgentAuthenticationEnabled` and > `MetricsTest.MasterAuthenticationEnabled` are added in > this patch. > > > Diffs > - > > src/tests/metrics_tests.cpp eacff678d06da7ba8afee6ab68261968561dffc3 > > Diff: https://reviews.apache.org/r/46261/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130423 --- Ship it! Ship It! - Kapil Arya On April 25, 2016, 10:21 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46259/ > --- > > (Updated April 25, 2016, 10:21 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > This patch adds authentication to the `/metrics/snapshot` > endpoint on the master and agent. > > > Diffs > - > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 7abfadf6d030c52b7e03e773b67c74db6ad5b5df > 3rdparty/libprocess/src/metrics/metrics.cpp > 7677dffed98153bc6276aad492a6815e67740ea3 > 3rdparty/libprocess/src/process.cpp > 8727eb202e9699f0ac3c95788257cf1a22b0da7b > > Diff: https://reviews.apache.org/r/46259/diff/ > > > Testing > --- > > `sudo make check` on OSX > > > Thanks, > > Greg Mann > >
Re: Review Request 46259: Added authentication to `/metrics/snapshot` endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46259/#review130206 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (lines 55 - 58) <https://reviews.apache.org/r/46259/#comment193914> trailing underscore? 3rdparty/libprocess/include/process/metrics/metrics.hpp (line 67) <https://reviews.apache.org/r/46259/#comment193916> Any reason for not making it 'None()' by default to simplify the call site. - Kapil Arya On April 15, 2016, 2:57 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46259/ > --- > > (Updated April 15, 2016, 2:57 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > This patch adds authentication to the `/metrics/snapshot` > endpoint on the master and agent. > > > Diffs > - > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 7abfadf6d030c52b7e03e773b67c74db6ad5b5df > 3rdparty/libprocess/src/metrics/metrics.cpp > 7677dffed98153bc6276aad492a6815e67740ea3 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46259/diff/ > > > Testing > --- > > `sudo make check` on OSX > > > Thanks, > > Greg Mann > >
Re: Review Request 46258: Added authentication to `/logging/toggle` endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 --- Fix it, then Ship it! Ship It! 3rdparty/libprocess/include/process/logging.hpp (lines 28 - 31) <https://reviews.apache.org/r/46258/#comment193913> Don't we prefere trailing underscores? 3rdparty/libprocess/include/process/logging.hpp (line 59) <https://reviews.apache.org/r/46258/#comment193911> Just wondering if it makes more sense to have a default 'None()' here and simplify the `initialize` function? - Kapil Arya On April 15, 2016, 2:56 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46258/ > --- > > (Updated April 15, 2016, 2:56 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > --- > > This patch adds authentication to the `/logging/toggle` > HTTP endpoint on the master and agent. > > > Diffs > - > > 3rdparty/libprocess/include/process/logging.hpp > 0c0774647d8048a9d8d395141a5864eadc64f8ef > 3rdparty/libprocess/src/logging.cpp > bdbf716ee46a459f1004f0f4b72c23aae135f347 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46258/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46255: Added a realm parameter to 'process::initialize' (Mesos).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/#review130180 --- src/slave/main.cpp (line 232) <https://reviews.apache.org/r/46255/#comment193901> slave->agent? src/tests/main.cpp (lines 34 - 35) <https://reviews.apache.org/r/46255/#comment193865> Alphabetize? src/tests/main.cpp (line 79) <https://reviews.apache.org/r/46255/#comment193904> Why not check the return value here too? - Kapil Arya On April 21, 2016, 4:39 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46255/ > --- > > (Updated April 21, 2016, 4:39 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4951 > https://issues.apache.org/jira/browse/MESOS-4951 > > > Repository: mesos > > > Description > --- > > In order to enable authentication on libprocess-level > HTTP endpoints, this patch adds code to the master and > agent's main.cpp file which makes use of the new > `authenticationRealm` argument to `process::initialize` > which allows the authentication realm of such endpoints > to be set when libprocess is initialized. The argument is > added to libprocess initialization in the tests as well. > > > Diffs > - > > src/master/main.cpp 7bbc982192b96eed32674070e16575902af80c6d > src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 > src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46255/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46254/#review130201 --- Ship it! Ship It! - Kapil Arya On April 21, 2016, 4:21 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46254/ > --- > > (Updated April 21, 2016, 4:21 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4951 > https://issues.apache.org/jira/browse/MESOS-4951 > > > Repository: mesos > > > Description > --- > > In order to enable authentication on libprocess-level > HTTP endpoints, this patch adds a parameter to > process::initialize which allows the authentication > realm of such endpoints to be set when libprocess is > initialized. > > > Diffs > - > > 3rdparty/libprocess/include/process/gtest.hpp > 3e0887257e1484813b3547170a5a1b9bb89de0d2 > 3rdparty/libprocess/include/process/process.hpp > 77e96957ca556cf9a7e2bf427d6762572fe48c51 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > 3rdparty/libprocess/src/tests/main.cpp > 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 > > Diff: https://reviews.apache.org/r/46254/diff/ > > > Testing > --- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.
You caught it in between the updates :-). They all refer to
https://issues.apache.org/jira/browse/MESOS-5250 now.
On Thu, Apr 21, 2016 at 6:52 PM, haosdent huang <haosd...@gmail.com> wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46514/#review129976
> ---
>
>
>
> The issue MESOS-5245 seems not found here.
>
> - haosdent huang
>
>
> On April 21, 2016, 10:01 p.m., Kapil Arya wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/46514/
> > ---
> >
> > (Updated April 21, 2016, 10:01 p.m.)
> >
> >
> > Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and
> Timothy St. Clair.
> >
> >
> > Bugs: MESOS-5245
> > https://issues.apache.org/jira/browse/MESOS-5245
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > ---
> >
> > Libprocess: Sorted configure.ac AC_ARG_{ENABLE,WITH} entries.
> >
> >
> > Diffs
> > -
> >
> > 3rdparty/libprocess/configure.ac
> d27e46e37d4f341258cfa983b4b066973bab89fa
> >
> > Diff: https://reviews.apache.org/r/46514/diff/
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > Kapil Arya
> >
> >
>
>
Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya
Review Request 46540: Updated pkg-config file to include module dependency info.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/ --- Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated pkg-config file to include module dependency info. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640 Diff: https://reviews.apache.org/r/46540/diff/ Testing --- Thanks, Kapil Arya
Review Request 46538: Install module dependencies in build/3rdparty as well.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46538/ --- Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- If configured with --enable-install-module-dependencies, install 3rdparty dependencies in build/3rdparty. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 Diff: https://reviews.apache.org/r/46538/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46536: Updated stout path in newbie-guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46536/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated stout path in newbie-guide. Diffs - docs/newbie-guide.md 5375fb0598766c1c8bcba39ce552df1405f94a39 Diff: https://reviews.apache.org/r/46536/diff/ Testing --- Thanks, Kapil Arya
Review Request 46537: Added --enable-install-module-dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46537/ --- Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added --enable-install-module-dependencies. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46537/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46521/
---
(Updated April 21, 2016, 6:53 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Added --with-{libproces,stout} flags to top-level configure.ac.
Diffs
-
configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9
src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff
Diff: https://reviews.apache.org/r/46521/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46533: Stopped using libprocess/stout configure scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46533/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Instead, we now use top-level configure script directly to generate libprocess/stout Makefiles. As a result, all configure flags are handled at one place to generate appropriate Makefiles. With this approach, we need to explicitly ask libprocess Makefile to generate a static library instead of a shared one. Previously, this was done via libprocess' configure script. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46533/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46539/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Removed libprocess/3rdparty references from misc files. Diffs - LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d Makefile.am 2b43854b0d36e4ee9c24a0c6f67480c697b8684a mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 support/tag.sh 3136abe894bbb80754f68ce883c224280f9383de support/vote.sh 04bfc09f94aa8ac9418e77db5e99874a60f6d3de Diff: https://reviews.apache.org/r/46539/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46518: Sorted option checks for top-level configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46518/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sorted option checks for top-level configure.ac. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46518/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46528/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated stout/Makefile.am to reflect bundled dependencies. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46523: Sanitized libprocess/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46523/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized libprocess/Makefile.am. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46523/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46530/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- The variable $(top_srcdir) causes compilation failure if the Makefile is generated by top-level configure script instead of libprocess-specific configure script. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46526/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated 3rdparty paths in Python build scripts. Diffs - src/examples/python/test-containerizer.in b8258e75a3cd5f8d18ab8eff8196c5374db4f629 src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c src/examples/python/test-framework.in 59bab82962c5846c6be288f3d392986e146e9da6 src/python/native_common/ext_modules.py.in ad98a576ee3662ccb5b8900a339e530089f41355 Diff: https://reviews.apache.org/r/46526/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46534: Updated stout path for mesos_split.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46534/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated stout path for mesos_split.py. Diffs - support/mesos_split.py be30bd59a951483846dc2314606d1c7a6a019729 Diff: https://reviews.apache.org/r/46534/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46535: Updated stout path for doxygen main page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46535/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Updated stout path for doxygen main page. Diffs - src/main.dox a6765f6f1535146b76488464e674f8d86f5835ba Diff: https://reviews.apache.org/r/46535/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46524: Sanitized src/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46524/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized src/Makefile.am. Diffs - src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46524/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Libprocess: Renamed --without-zlib to --disable-zlib. Diffs - 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46515/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46527/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- This will help getting us closer to a standalone stout library. Diffs - 3rdparty/libprocess/3rdparty/stout/configure.ac a1f86d0f943bbff91a8b021046eb66d624df7896 3rdparty/libprocess/3rdparty/stout/m4/ax_compare_version.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_vendor.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_compiler_version.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/46527/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46531/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Added explicit ldflags '-static -fpic' to libprocess.la. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46531/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46519/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Copied libprocess-specific configure options to top-level configure.ac. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46525/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz 3rdparty/libprocess/3rdparty/gmock_sources.cc.in 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 3rdparty/libprocess/3rdparty/http-parser-2.6.2.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 3rdparty/libprocess/3rdparty/libev-4.22.patch 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz 3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz 3rdparty/libprocess/3rdparty/versions.am 5506eb3aeafb09226ba5b90dae194ece31285412 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sanitized libprocess/3rdparty/Makefile.am. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46517/
---
(Updated April 21, 2016, 6:53 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Sorted top-level configure.ac AC_ARG_{ENABLE,WITH} entries.
Diffs
-
configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9
Diff: https://reviews.apache.org/r/46517/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46514/
---
(Updated April 21, 2016, 6:53 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5250
https://issues.apache.org/jira/browse/MESOS-5250
Repository: mesos
Description
---
Libprocess: Sorted configure.ac AC_ARG_{ENABLE,WITH} entries.
Diffs
-
3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa
Diff: https://reviews.apache.org/r/46514/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46516: Sorted option checks for libprocess configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46516/ --- (Updated April 21, 2016, 6:53 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5250 https://issues.apache.org/jira/browse/MESOS-5250 Repository: mesos Description --- Sorted option checks for libprocess configure.ac. Diffs - 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46516: Sorted option checks for libprocess configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46516/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5245 https://issues.apache.org/jira/browse/MESOS-5245 Repository: mesos Description --- Sorted option checks for libprocess configure.ac. Diffs - 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46516/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46524: Sanitized src/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46524/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Sanitized src/Makefile.am. Diffs - src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46524/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46519/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5245 https://issues.apache.org/jira/browse/MESOS-5245 Repository: mesos Description --- Copied libprocess-specific configure options to top-level configure.ac. Diffs - configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 Diff: https://reviews.apache.org/r/46519/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Sanitized libprocess/3rdparty/Makefile.am. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd Diff: https://reviews.apache.org/r/46522/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/try_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46529/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46528/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Updated stout/Makefile.am to reflect bundled dependencies. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/stout/Makefile.am 10be36652034ea5860f122ffb45ee50cc72ffdb3 Diff: https://reviews.apache.org/r/46528/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46525/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 3rdparty/libprocess/3rdparty/Makefile.am f7aa579f133d19c3ef252773c5ed868c977785cd 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz 3rdparty/libprocess/3rdparty/gmock_sources.cc.in 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 3rdparty/libprocess/3rdparty/http-parser-2.6.2.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 3rdparty/libprocess/3rdparty/libev-4.22.patch 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz 3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz 3rdparty/libprocess/3rdparty/versions.am 5506eb3aeafb09226ba5b90dae194ece31285412 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff Diff: https://reviews.apache.org/r/46525/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46535: Updated stout path for doxygen main page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46535/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Updated stout path for doxygen main page. Diffs - src/main.dox a6765f6f1535146b76488464e674f8d86f5835ba Diff: https://reviews.apache.org/r/46535/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46536: Updated stout path in newbie-guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46536/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Updated stout path in newbie-guide. Diffs - docs/newbie-guide.md 5375fb0598766c1c8bcba39ce552df1405f94a39 Diff: https://reviews.apache.org/r/46536/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46514/
---
(Updated April 21, 2016, 6:01 p.m.)
Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy
St. Clair.
Bugs: MESOS-5245
https://issues.apache.org/jira/browse/MESOS-5245
Repository: mesos
Description
---
Libprocess: Sorted configure.ac AC_ARG_{ENABLE,WITH} entries.
Diffs
-
3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa
Diff: https://reviews.apache.org/r/46514/diff/
Testing
---
Thanks,
Kapil Arya
Re: Review Request 46520: Added --with-stout flag to libprocess configure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46520/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, Timothy St. Clair, and Vinod Kone. Bugs: MESOS-5246 https://issues.apache.org/jira/browse/MESOS-5246 Repository: mesos Description --- Added --with-stout flag to libprocess configure. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa Diff: https://reviews.apache.org/r/46520/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46532: Updated LDADD flags for libprocess tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46532/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- Updated LDADD flags for libprocess tests. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46532/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46530/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney, Alex Clemmer, James Peach, and Timothy St. Clair. Bugs: MESOS-5248 https://issues.apache.org/jira/browse/MESOS-5248 Repository: mesos Description --- The variable $(top_srcdir) causes compilation failure if the Makefile is generated by top-level configure script instead of libprocess-specific configure script. Diffs - 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 Diff: https://reviews.apache.org/r/46530/diff/ Testing --- Thanks, Kapil Arya
