AS_GPERTOOL->ENABLE_GPERFTOOLS
transition.
- Kapil Arya
On April 21, 2016, 4:29 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46462/#review130437
---
Ship it!
Ship It!
- Kapil Arya
On April 21, 2016, 12:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46643/#review130481
---
Ship it!
Ship It!
- Kapil Arya
On April 25, 2016, 1:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46647/#review130482
---
Ship it!
Ship It!
- Kapil Arya
On April 25, 2016, 1:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130619
---
Ship it!
Ship It!
- Kapil Arya
On April 25, 2016, 1:25 p.m
ne 116)
<https://reviews.apache.org/r/46641/#comment194437>
ditto
- Kapil Arya
On April 25, 2016, 4:47 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46804/#review131010
---
Ship it!
Ship It!
- Kapil Arya
On April 28, 2016, 7:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46805/#review131019
---
Ship it!
Ship It!
- Kapil Arya
On April 28, 2016, 7:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46813/#review131165
---
Ship it!
Ship It!
- Kapil Arya
On April 29, 2016, 5:13 a.m
tps://reviews.apache.org/r/46867/#comment195632>
Fix continuation.
src/common/http.cpp (lines 590 - 592)
<https://reviews.apache.org/r/46867/#comment195633>
Coalesce?
- Kapil Arya
On May 1, 2016, 6:43 p.m., Greg Mann wrote:
>
> --
tps://reviews.apache.org/r/46876/#comment195640>
Why this change?
- Kapil Arya
On May 1, 2016, 6:30 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g/r/46883/#comment195636>
Does non-existing `subject` mean "ANY"?
src/common/http.cpp (line 602)
<https://reviews.apache.org/r/46883/#comment195635>
const?
- Kapil Arya
On May 1, 2016, 8:03 p.m., Greg Mann wrote:
>
>
dd comment blocks.
3rdparty/libprocess/src/process.cpp (line 484)
<https://reviews.apache.org/r/46866/#comment195630>
Having non-pod global vars isn't good! Maybe use a pointer instead?
- Kapil Arya
On May 1, 2016, 6:28 p.m., Greg Mann wrote:
>
>
mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640
Diff: https://reviews.apache.org/r/46540/diff/
Testing
---
Thanks,
Kapil Arya
--
On May 4, 2016, 11:22 a.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46540/
>
having two
separate hooks for validation and label-decoration, I am wondering, if we can
have one consolidated hook. That hook would then update the labels (and any
other fields that we might want to in future) and also validate a task at the
same time.
Any thoughts?
- Kapil Arya
On May 5
> On May 5, 2016, 1:27 p.m., Kapil Arya wrote:
> > The hooks looks good but I have a high-level question. Instead of having
> > two separate hooks for validation and label-decoration, I am wondering, if
> > we can have one consolidated hook. That hook would then update the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46920/#review131966
---
Ship it!
Ship It!
- Kapil Arya
On May 5, 2016, 12:01 p.m
s a callback for
the requested URL.
- Kapil Arya
On May 5, 2016, 4:15 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46920/
> ---
>
> (Updated May 5, 2016, 12:01 p.m.)
>
>
> Review request for m
. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
/log_tests.cpp (lines 444 - 446)
<https://reviews.apache.org/r/47161/#comment196617>
Move this description before the first scope level?
And maybe, add a comment about this test itself?
- Kapil Arya
On May 10, 2016, 5:02 a.m., Tomasz Janiszewski
d27e46e37d4f341258cfa983b4b066973bab89fa
Diff: https://reviews.apache.org/r/46520/diff/
Testing
---
Thanks,
Kapil Arya
9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46515/diff/
Testing
---
Thanks,
Kapil Arya
ae91a07e2bafd97566ac6e6873990302acad14c9
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
Diff: https://reviews.apache.org/r/46521/diff/
Testing
---
Thanks,
Kapil Arya
83bd38acb32aca63af45ee5d58825ef2be656a03
Diff: https://reviews.apache.org/r/46522/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
Diff: https://reviews.apache.org/r/46532/diff/
Testing
---
Thanks,
Kapil Arya
configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9
Diff: https://reviews.apache.org/r/46537/diff/
Testing
---
Thanks,
Kapil Arya
)
-
3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7
Diff: https://reviews.apache.org/r/46538/diff/
Testing
---
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/#review132535
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46867/#review132536
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46882/#review132540
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:38 p.m
tps://reviews.apache.org/r/46881/#comment196764>
Maybe move this closer to AuthorizationCallbacks declaration?
- Kapil Arya
On May 10, 2016, 4:38 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46883/#review132537
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46870/#review132538
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46869/#review132543
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 4:36 p.m
9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46514/diff/
Testing
---
Thanks,
Kapil Arya
9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46515/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
Diff: https://reviews.apache.org/r/46517/diff/
Testing
---
Thanks,
Kapil Arya
9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46516/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
Diff: https://reviews.apache.org/r/46518/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
Diff: https://reviews.apache.org/r/46519/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46520/diff/
Testing
---
Thanks,
Kapil Arya
e944463aad69c70a2563b424f0b80f3e7f66b5aa
Diff: https://reviews.apache.org/r/46522/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd
Diff: https://reviews.apache.org/r/46521/diff/
Testing
---
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/46524/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
Diff: https://reviews.apache.org/r/46523/diff/
Testing
---
Thanks,
Kapil Arya
configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe
src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd
Diff: https://reviews.apache.org/r/46525/diff/
Testing
---
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/46526/diff/
Testing
---
Thanks,
Kapil Arya
/3rdparty/stout/m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION
3rdparty/libprocess/3rdparty/stout/m4/ax_pthread.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/46527/diff/
Testing
---
Thanks,
Kapil Arya
/3rdparty/Makefile.am
e944463aad69c70a2563b424f0b80f3e7f66b5aa
3rdparty/libprocess/3rdparty/stout/Makefile.am
d523fb0a212228cc47537dc6e444be51941573cc
Diff: https://reviews.apache.org/r/46528/diff/
Testing
---
Thanks,
Kapil Arya
configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe
Diff: https://reviews.apache.org/r/46537/diff/
Testing
---
Thanks,
Kapil Arya
akefile.am 51f62aa636900c05ba970a0551558db813ce1dfd
3rdparty/libprocess/configure.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
Diff: https://reviews.apache.org/r/46531/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/46536/diff/
Testing
---
Thanks,
Kapil Arya
51f62aa636900c05ba970a0551558db813ce1dfd
Diff: https://reviews.apache.org/r/46532/diff/
Testing
---
Thanks,
Kapil Arya
re.ac 9bdd2f6b9f17b1ca3b6331082777e3136e8838a7
configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe
Diff: https://reviews.apache.org/r/46533/diff/
Testing
---
Thanks,
Kapil Arya
0b9683be6f8d0805f2c04797e839f3578a57efbe
mesos.pc.in a0cc66a77058bf4beaa21d7dd4208654c6185640
Diff: https://reviews.apache.org/r/46540/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/46535/diff/
Testing
---
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/46539/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/46530/diff/
Testing
---
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
)
-
3rdparty/Makefile.am c9b3a25bfeb51dd5c4eb04136b324d454e286ea1
Diff: https://reviews.apache.org/r/46538/diff/
Testing
---
Thanks,
Kapil Arya
: https://reviews.apache.org/r/46534/diff/
Testing
---
Thanks,
Kapil Arya
b64`` or ``3rdparty/lib``, but not both?
> >
> > Is there a libtool or autoconf variable to figure that out?
>
> Kapil Arya wrote:
> On 32-bit, they'll be installed in lib. On 64-bit, it could be either
> :-(. I believe there might be a way to figure it out but I am no
/
Testing
---
Local build succeeds.
Thanks,
Kapil Arya
e now that we have a flat
3rdparty structure. The dependencies can be built before anything having
anything to do with libprocess and so on.
- Kapil Arya
On May 11, 2016, 10:54 p.m., Alex Clemmer wrote:
>
> ---
> This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47285/#review132835
---
Ship it!
Ship It!
- Kapil Arya
On May 11, 2016, 10:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46904/#review134044
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2016, 3:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46900/#review134046
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2016, 2:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46901/#review134047
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2016, 2:34 p.m
https://reviews.apache.org/r/47123/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47123/#review132372
---
On May 19, 2016, 5:51 p.m., Kapil Arya wrote:
>
> -
://reviews.apache.org/r/47123/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
/47752/diff/
Testing
---
Thanks,
Kapil Arya
/47754/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in stout succeeds with this patch.
Thanks,
Kapil Arya
: https://reviews.apache.org/r/47755/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
://reviews.apache.org/r/47753/diff/
Testing
---
`make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this
patch.
Thanks,
Kapil Arya
dependencies.
Diffs
-
3rdparty/Makefile.am fb4a37d50e751703b4ccddb0e004b58560707067
Diff: https://reviews.apache.org/r/47752/diff/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/47756/diff/
Testing
---
`make tests` works without first doing a `make` in 3rdparty.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47149/#review134497
---
Ship it!
- Kapil Arya
On May 10, 2016, 10:13 p.m., Joseph Wu
tps://reviews.apache.org/r/47205/#comment199362>
Can we keep just a simple `add` here and move this logic to the cpp file?
- Kapil Arya
On May 11, 2016, 4:03 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/47212/#comment199363>
Would there be any difference in the computed environment here vs in
container constructor?
- Kapil Arya
On May 10, 2016, 10:13 p.m., Joseph Wu wrote:
>
> ---
> This is an automatica
1027)
<https://reviews.apache.org/r/47213/#comment199366>
Just curious, will it do the right thing for boolean flags such as
`--quiet`, `--no-quiet`, `--version` and `--no-version`?
- Kapil Arya
On May 16, 2016, 2 p.m., Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47214/#review134503
---
Ship it!
Ship It!
- Kapil Arya
On May 16, 2016, 2:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47215/#review134504
---
Ship it!
Ship It!
- Kapil Arya
On May 10, 2016, 10:13 p.m
src/examples/test_hook_module.cpp (line 188)
<https://reviews.apache.org/r/47150/#comment199367>
s/an/a/
src/examples/test_hook_module.cpp (line 202)
<https://reviews.apache.org/r/47150/#comment199369>
It could be my screen, but could you double-check the alignment here?
- Kapi
tps://reviews.apache.org/r/47216/#comment199375>
Can we bring the RHS on the next line and adjust the rest to make it
slightly more readable?
- Kapil Arya
On May 11, 2016, 3:30 p.m., Joseph Wu wrote:
>
> ---
> This is an automatica
---
Removed unneeded #includes from type_utils.hpp.
Diffs
-
include/mesos/type_utils.hpp 27fa8c9256c24b5ec6f5d259305ea66b5f556673
Diff: https://reviews.apache.org/r/47786/diff/
Testing
---
make check
Thanks,
Kapil Arya
rated e-mail. To reply, visit:
https://reviews.apache.org/r/47753/#review134732
-------
On May 23, 2016, 10:49 p.m., Kapil Arya wrote:
>
> ---
> This is an automatical
could you also move `fetcher` close to `containerizer`
initialization?
src/slave/main.cpp (lines 309 - 323)
<https://reviews.apache.org/r/47892/#comment199981>
I am wondering if we should move it right next to the
`ModuleManager::load()` call above. Is there a reason for not doing so?
- Kapil
/47123/diff/
Testing
---
Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules
The first two succeeded while the third failed as expected.
Thanks,
Kapil Arya
---
See summary
Diffs
-
src/tests/module_tests.cpp 950d8e4ac49bc081df5cdf6850b4a5b438e67737
Diff: https://reviews.apache.org/r/47905/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
See summary.
Diffs
-
docs/modules.md cf80e1cd0eb86a2652bb99884989ecffdbba4778
Diff: https://reviews.apache.org/r/47906/diff/
Testing
---
Thanks,
Kapil Arya
check
Thanks,
Kapil Arya
> On May 26, 2016, 11:52 a.m., Kapil Arya wrote:
> > src/slave/main.cpp, lines 309-323
> > <https://reviews.apache.org/r/47892/diff/1/?file=1395393#file1395393line309>
> >
> > I am wondering if we should move it right next to the
> > `ModuleManager::lo
://issues.apache.org/jira/browse/MESOS-5416
Repository: mesos
Description
---
Stout: Prepare for standalone compilation.
Diffs
-
3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00
Diff: https://reviews.apache.org/r/47931/diff/
Testing
---
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-5415
Repository: mesos
Description
---
Libprocess: Fixed a typo in Makefile.am.
Diffs
-
3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0
Diff: https://reviews.apache.org/r/47925/diff/
Testing
---
Thanks,
Kapil Arya
601 - 700 of 825 matches
Mail list logo
