ing at L260.
technically but I think it's safe to check everytime since we're assuming it's
always available!
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
---------
On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41869/
>
https://reviews.apache.org/r/41869/#review112496
-------
On Jan. 4, 2016, 2:13 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-m
---
make check
Thanks,
Timothy Chen
tasks and custom executors.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
Diff: https://reviews.apache.org/r/41909/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41953/#review112973
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 5, 2016, 11:48 p.m
tps://reviews.apache.org/r/42030/#comment174273>
IMO there seems to be too much irrelevant code to make the point, can we
collapse all the unnecessary code and just keep the ones that can illustrate
the problem?
- Timothy Chen
On Jan. 8, 2016, 5:01 p.m., Greg Mann
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41429/#review113535
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 8, 2016, 4:24 p.m
tps://reviews.apache.org/r/41962/#comment174276>
Do we need to check that the correct container id is passed?
- Timothy Chen
On Jan. 6, 2016, 2:19 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
he.org/r/41961/#comment174278>
Should we also comment that we only return the first response even if there
are multiples?
- Timothy Chen
On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generat
tps://reviews.apache.org/r/41961/#comment174279>
Why don't we return the failure message?
- Timothy Chen
On Jan. 6, 2016, 1:44 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41960/#review113541
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 6, 2016, 1:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41957/#review113542
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 6, 2016, 1:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41956/#review113543
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 6, 2016, 1:31 a.m
ymore.
- Timothy Chen
On July 7, 2015, 7:43 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37075/#review113546
---
Is this still relevant?
- Timothy Chen
On Aug. 5, 2015, 11:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42093/#review113579
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 8, 2016, 11:42 p.m
yourself and
see if you can repro?
- Timothy Chen
On Dec. 9, 2015, 5:42 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/37703/#comment174388>
I'll fix this myself, but comments should end with period.
- Timothy Chen
On Jan. 9, 2016, 10:35 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42208/#review114102
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 12, 2016, 8:46 p.m
tps://reviews.apache.org/r/42236/#comment175096>
Should we provide the default port for https here?
- Timothy Chen
On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42237/#review114277
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 6:23 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41820/#review114279
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 11, 2016, 8:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42215/#review114285
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 12:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42269/#review114296
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 10:06 p.m
org/r/42238/#comment175141>
End with period.
src/uri/fetchers/docker.cpp (line 532)
<https://reviews.apache.org/r/42238/#comment175142>
Is it possible to have multiple images/manifests per directory? Assuming a
task with multiple volumes and multiple images?
- Timothy Chen
---
Add mount_all to linux fs.
Diffs
-
src/linux/fs.hpp 76c72930724b882d3b74edb3a91d5988fcbfc2ed
src/linux/fs.cpp bfcf97186cd1b0696a9537c4a332083def6b462e
Diff: https://reviews.apache.org/r/42277/diff/
Testing
---
make check
Thanks,
Timothy Chen
5bb85034c22caef64054c1629f6fd55d227e48b1
Diff: https://reviews.apache.org/r/42278/diff/
Testing
---
make check
Thanks,
Timothy Chen
759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
src/tests/containerizer/filesystem_isolator_tests.cpp
5bb85034c22caef64054c1629f6fd55d227e48b1
Diff: https://reviews.apache.org/r/42278/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42030/#review114514
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 12, 2016, 11:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42216/#review114601
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 10:20 p.m
org/r/42314/#comment175468>
This seems unncessary, even if there is duplicate I think we simply just
override the entry when we register the scheme.
- Timothy Chen
On Jan. 14, 2016, 7:09 p.m., haosdent huang wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39172/#review114630
---
Ship it!
Ship It!
- Timothy Chen
On Dec. 20, 2015, 4:20 p.m
istry client.
- Timothy Chen
On Dec. 11, 2015, 12:40 p.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42264/#review114632
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 9:23 p.m
dvance once and then AWAIT?
- Timothy Chen
On Jan. 15, 2016, 6:20 p.m., Jian Qiu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
tps://reviews.apache.org/r/42238/#comment175620>
I think we should leave a TODO that we need to support credentials to get
auth, and even custom SSL certificates in the future.
- Timothy Chen
On Jan. 13, 2016, 11:14 p.m., Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114766
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 11:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42275/#review114767
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 11:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/#review114808
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 15, 2016, 5:09 a.m
7;t really speed up
anything, just adding a comment.
- Timothy Chen
On Jan. 15, 2016, 5:09 a.m., Jian Qiu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
)
<https://reviews.apache.org/r/38164/#comment175666>
s/maybe/may/g
I'll fix this myself
- Timothy Chen
On Jan. 16, 2016, 12:49 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-m
---
Add reverse_foreach in libprocess.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp
7fb0044790ee249b69e07b81a26851bd5bfb110f
Diff: https://reviews.apache.org/r/42379/diff/
Testing
---
make check
Thanks,
Timothy Chen
.
Repository: mesos
Description
---
Add mount_all to linux fs.
Diffs
-
src/linux/fs.hpp 76c72930724b882d3b74edb3a91d5988fcbfc2ed
src/linux/fs.cpp bfcf97186cd1b0696a9537c4a332083def6b462e
Diff: https://reviews.apache.org/r/42277/diff/
Testing
---
make check
Thanks,
Timothy
://reviews.apache.org/r/42277/diff/
Testing
---
make check
Thanks,
Timothy Chen
,
Timothy Chen
/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a
src/tests/containerizer/filesystem_isolator_tests.cpp
f0c5b511ae20c720541351aba93f358ce26e0d51
Diff: https://reviews.apache.org/r/42278/diff/
Testing
---
make check
Thanks,
Timothy Chen
fix.
- Timothy Chen
On Jan. 16, 2016, 12:49 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/r/42389/diff/
Testing
---
make check
Thanks,
Timothy Chen
/stout/adaptor.hpp (line 24)
<https://reviews.apache.org/r/42450/#comment175919>
Remove reversed as suggested by bmahler
- Timothy Chen
On Jan. 18, 2016, 7:59 a.m., Jie Yu wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42442/#review115069
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 17, 2016, 9:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42443/#review115070
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 17, 2016, 9:52 p.m
tps://reviews.apache.org/r/42444/#comment175924>
s/because no internet access/because internet is not accessible/g
- Timothy Chen
On Jan. 17, 2016, 9:53 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e
he.org/r/42239/#comment175926>
should we check that the manifest is referring to busybox:latest?
src/tests/uri_fetcher_tests.cpp (line 275)
<https://reviews.apache.org/r/42239/#comment175928>
We should check for the blob too right?
- Timothy Chen
On Jan. 18, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42451/#review115075
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 18, 2016, 8 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41961/#review115076
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 17, 2016, 9:50 p.m
ace9e305c24a9841f1716c9bf40cd13b16ef0cec
Diff: https://reviews.apache.org/r/42389/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42509/#review115186
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 19, 2016, 4:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42265/#review115286
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 18, 2016, 9:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42239/#review115586
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 21, 2016, 12:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42605/#review115895
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 22, 2016, 3:57 p.m
Description
---
Fixed filesystem isolator tests timing out.
Diffs
-
src/tests/containerizer/filesystem_isolator_tests.cpp
f0c5b511ae20c720541351aba93f358ce26e0d51
Diff: https://reviews.apache.org/r/42670/diff/
Testing
---
make check
Thanks,
Timothy Chen
/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
Diff: https://reviews.apache.org/r/42674/diff/
Testing
---
make check
Thanks,
Timothy Chen
ge here too?
Sorry that was a mistake.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115956
---
On Jan. 23
3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2
Diff: https://reviews.apache.org/r/42674/diff/
Testing
---
make check
Thanks,
Timothy Chen
://reviews.apache.org/r/42674/#review115959
-------
On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> ---
/docker.cpp (line 1370)
<https://reviews.apache.org/r/42288/#comment177131>
I don't think this comment means much here. Let's remove it
- Timothy Chen
On Jan. 21, 2016, 6:18 a.m., Andy Pang wrote:
>
> ---
>
pine only because the actual filesystem
image is causing problems with the docker daemon in some configurations.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4267
---
make check
Thanks,
Timothy Chen
-------
On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> ---
/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
src/tests/containerizer/filesystem_isolator_tests.cpp
496275a73601664b51155ef1373d8d46b9069613
Diff: https://reviews.apache.org/r/42278/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42673/#review116737
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 22, 2016, 11:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/#review116856
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 27, 2016, 8:38 p.m
)
<https://reviews.apache.org/r/42914/#comment178012>
then files with a recognized extension
- Timothy Chen
On Jan. 28, 2016, 6:17 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On Jan. 29, 2016, 7:40 a.m., Timothy Chen wrote:
> > docs/fetcher.md, line 119
> > <https://reviews.apache.org/r/42914/diff/2/?file=1225096#file1225096line119>
> >
> > then files with a recognized extension
>
> Bernd Mathiske wrote:
> Soryy,
/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
tps://reviews.apache.org/r/43015/#comment178219>
It can't
- Timothy Chen
On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
-----
On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> --
/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
g/r/42516/#comment179576>
Can you put a more elaborate message here?
i.e: "User network mode requires Docker version higher than 1.9.0."
- Timothy Chen
On Feb. 4, 2016, 10:04 a.m., Ezra Silvera wrote:
>
> ---
>
2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
> On Feb. 9, 2016, 2:17 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 525
> > <https://reviews.apache.org/r/42516/diff/7/?file=1229690#file1229690line525>
> >
> > Can you put a more elaborate message here?
> > i.e: "User network mo
g/r/43093/#comment180321>
Fix the formatting of this as well, replace the + with <<
- Timothy Chen
On Feb. 4, 2016, 9:27 p.m., Travis Hegner wrote:
>
> ---
> This is an automatically generated e-mail. To
= strings::remove(
strings::remove(i.., "[", strings::PREFIX),
"]",
strings::SUFFIX);
src/tests/containerizer/docker_tests.cpp (line 139)
<https://reviews.apache.org/r/43032/#comment180325>
You need to EXPECT_SOME on the find first, other wise it's
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review118285
---
On Feb. 9, 2016, 2:32 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generate
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
)
<https://reviews.apache.org/r/43293/#comment180455>
Is this even a valid docker inspect output?
In what situations will we get this?
- Timothy Chen
On Feb. 7, 2016, 9:40 a.m., Guangya Liu wrote:
>
> ---
> This is a
this moment. Can you
rebase?
- Timothy Chen
On Jan. 24, 2016, 3:45 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
> On Feb. 14, 2016, 8:42 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, lines 506-507
> > <https://reviews.apache.org/r/43293/diff/2/?file=1237051#file1237051line506>
> >
> > Is this even a valid docker inspect output?
> >
atement already checks for this.
src/slave/containerizer/mesos/containerizer.cpp (line 1616)
<https://reviews.apache.org/r/43569/#comment180491>
This as well
- Timothy Chen
On Feb. 15, 2016, 4:17 a.m., Guangya Liu wrote:
>
>
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
://reviews.apache.org/r/43015/#review119208
-------
On Feb. 14, 2016, 8:38 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. T
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
we only LOG(ERROR) with custom executors case.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119250
-------
On Feb. 15, 2016, 3:39 p.m., Timothy Chen wrote:
>
>
/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43592/#review119260
---
Ship it!
Ship It!
- Timothy Chen
On Feb. 16, 2016, 3:31 a.m
WARNING) will be
more appropriate as well. Can you also log the image name? Same as above one.
src/docker/docker.cpp (line 398)
<https://reviews.apache.org/r/43293/#comment180569>
Actually shouldn't we take the latest value? What does Docker do when it
have duplicated env var?
-
g/r/43093/#comment180573>
This can fit in 80 char width line right?
src/docker/docker.cpp (line 314)
<https://reviews.apache.org/r/43093/#comment180572>
Also fix the formatting for the strings concat. Move
networkModeValue.get().value aligned with the "NetworkSettings"
/#comment180576>
Space between next if
src/docker/docker.cpp (line 530)
<https://reviews.apache.org/r/42516/#comment180577>
Fix the formatting, need to move one more char to the right.
- Timothy Chen
On Feb. 11, 2016, 1:51
701 - 800 of 828 matches
Mail list logo
