: https://reviews.apache.org/r/40429/diff/
Testing
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
me to send that out too.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review109593
---
On Dec. 14, 2015, 8:09 p
f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
Diff: https://reviews.apache.org/r/41892/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
nod, I just sent out the email.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review112541
-------
O
77750eda99184c0bf4404df8468461e3c7f8cde0
Diff: https://reviews.apache.org/r/40429/diff/
Testing
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
03f0332ef75bbe7c4947bd6daf55d40384570f18
src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7
Diff: https://reviews.apache.org/r/40429/diff/
Testing
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review111871
---
- Zhitao Li
On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote
--------
On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> --
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review110348
---
On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote:
>
> ---
>
ostSlave()`
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107122
---
On Nov. 18, 2015
: https://reviews.apache.org/r/40429/diff/
Testing
---
Modified test for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
for SchedulerDriverEventTest.Failure, which verifies that
MockScheduler::executorLost is invoked.
Thanks,
Zhitao Li
7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
.apache.org/r/48902/#review138709
---
On June 22, 2016, 6:19 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
tps://reviews.apache.org/r/48751/#comment204229>
Agreed. I think changing `required` mentioned in this patch to `optional`
is good since the API here is still progressing.
@vinodkone, what's your opinion?
- Zhitao Li
On June 22, 2016, 6:13 a.m., Zhitao Li
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review139019
-------
On June 22, 2016, 6:13 a.m., Zhitao Li wrote:
>
> ---
in MasterAPITest.
Thanks,
Zhitao Li
unds good for top level in this file. Will do.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48751/#review138723
---------
g/r/48879/#comment203482>
How will the `devolve()` handle the enum value that's not declared in its
own enum?
This switch/case block is strange anyway in that enum values could belong
to different namespaces...
- Zhitao Li
On June 17, 2016, 8:16 p.m., Anand Mazumdar
in
src/internal/evolve.hpp, since it's pretty common that we need to promote
`Task` to `v1::Task`.
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To rep
://reviews.apache.org/r/48902/diff/
Testing (updated)
---
run `make` on Mac.
Thanks,
Zhitao Li
/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9
src/tests/reservation_tests.cpp 2cc352d230f5ba8ca15698b09a44377c6af53913
Diff: https://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
/master.proto 11dfab318eb073908a9e302afa33b274fec63a16
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2
Diff: https://reviews.apache.org/r/49129/diff/
Testing
---
make check
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/49130/diff/
Testing
---
make check
Thanks,
Zhitao Li
overs;
> ...
> return collect(approvers);
> }
> ```
Created https://reviews.apache.org/r/49130 to fix in separate patch.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.ap
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48879/
> ---
>
> (Updated June 17, 2016, 8:52 p.m.)
>
>
> Review requ
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> ---
>
> (Updated June 19, 2016, 7:30 p.m.)
>
>
> Review request for meso
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48875/#review138602
---
Ship it!
Ship It!
- Zhitao Li
On June 17, 2016, 8:17 p.m
----
On June 18, 2016, 6:36 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48902/
> ---
&g
gt; allocator is the master-only component.
>
> Zhitao Li wrote:
> Alexander, so what's your recommendation here? Given that there is only
> one public visible message `InverseOfferStatus` in this protobuf at the
> moment, I'd like to have a quick fix to make sure its namespa
://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
cpp db625f0d656f207a89fcc14b18ae2fc31d30e673
src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720
src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0
Diff: https://reviews.apache.org/r/48751/diff/
Testing
---
New test in MasterAPITest.
Thanks,
Zhitao Li
about what to do with agents.
What do you think?
- Zhitao Li
On June 22, 2016, 5 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
tps://reviews.apache.org/r/49136/#comment204580>
Given current conversations with Vinod and Anand, we still want to keep
fileds that always have a value as `required`, and the leave the task of
upgrading to proto3 in a separate sweeping epic.
This also has the benefit of clear API.
- Zhi
three resources fiels split by use cases,
- Zhitao Li
On June 23, 2016, 5:13 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
/r/48902/diff/
Testing
---
run `make` on Mac.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/48877/#comment203478>
Move this line next to `v1::master::Response` so it's easy to find?
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail.
.
- Zhitao Li
On June 17, 2016, 8:17 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
g/r/49166/#comment204495>
This shouldn't be here
- Zhitao Li
On June 23, 2016, 8:07 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
: https://reviews.apache.org/r/49118/diff/
Testing
---
`make && make check` on mac.
Thanks,
Zhitao Li
u take a look at new messages defined at
https://reviews.apache.org/r/48751/ and comment on what additions or changes we
need for them?
- Zhitao Li
On June 23, 2016, 3:15 p.m., Jay Guo wrote:
>
> ---
> This is an automatically g
dea for
logging/clarity purpose.
Please let me know if I didn't understand your suggestion, or if you think
we should explore the other alternative (passing `hostPath` earlier in resource
offer).
- Zhitao Li
On Jan. 4, 2016, 9:15 p.m.,
> On June 27, 2016, 4:36 p.m., Zhitao Li wrote:
> > include/mesos/v1/master/master.proto, line 287
> > <https://reviews.apache.org/r/48841/diff/5/?file=1430819#file1430819line287>
> >
> > Should we use `VersionInfo` for `version`?
>
> Vinod
to unblock me for GetState. Thanks.
include/mesos/v1/master/master.proto (line 296)
<https://reviews.apache.org/r/49136/#comment204841>
Should this be required? I guess that's the case for any custom executor
type, but I'm not sure about CommandExecutor.
- Zhitao Li
On June 27, 2016
tps://reviews.apache.org/r/48841/#comment204844>
Should we use `VersionInfo` for `version`?
- Zhitao Li
On June 27, 2016, 9:01 a.m., zhou xing wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote:
> > src/docker/docker.cpp, lines 410-420
> > <https://reviews.apache.org/r/41892/diff/1/?file=1181052#file1181052line410>
> >
> > (Sorry I just got time to come back to this).
> >
> > I d
> On Jan. 15, 2016, 12:03 a.m., Zhitao Li wrote:
> > src/docker/docker.cpp, lines 410-420
> > <https://reviews.apache.org/r/41892/diff/1/?file=1181052#file1181052line410>
> >
> > (Sorry I just got time to come back to this).
> >
> > I d
g/r/41892/#comment177639>
@jieyu, this would be a better place to implement the inferring of host
paths for persistent volumes, comparing to the current draft.
- Zhitao Li
On Jan. 4, 2016, 9:15 p.m., Zhitao Li
g/r/44810/#comment186269>
Note that this part is unsettled. Will update once consensus is reached in
design doc.
- Zhitao Li
On March 15, 2016, 3:12 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e
implementations to follow once we reach
consensus on the this plan.
Diffs
-
docs/quota.md 12696bf805d43f997d80149e56281c5e7dc0557e
Diff: https://reviews.apache.org/r/44810/diff/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/45932/diff/
Testing
---
Added new test to verify ResourceUsage sees task labels.
Thanks,
Zhitao Li
---
Added a test in oversubciption_tests to make sure executor labels are visible
to ResourceEstimator and QoSController.
Thanks,
Zhitao Li
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45932/#review127933
---
On April 12, 2016, 5 a.m., Zhitao Li wrote:
>
>
/
Testing
---
Added new test to verify ResourceUsage sees task labels.
Thanks,
Zhitao Li
/oversubscription_tests.cpp 23671746da2ac505d75bc2bd59114697d9161d52
Diff: https://reviews.apache.org/r/45932/diff/
Testing
---
Added new test to verify ResourceUsage sees task labels.
Thanks,
Zhitao Li
ng input as revocable
> > // rather than rejecting and crashing here.
> > ```
I'll move it.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45941/#review127914
---
On April 8, 2016, 8:02 p
f090c853b8affc4be5eecb4f616ec881fc2b60c3
Diff: https://reviews.apache.org/r/45941/diff/
Testing
---
Running existing test, and verify manually that offending resource crashes the
agent.
(Any suggestion to test `CHECK` is welcomed).
Thanks,
Zhitao Li
f090c853b8affc4be5eecb4f616ec881fc2b60c3
Diff: https://reviews.apache.org/r/45941/diff/
Testing
---
Running existing test, and verify manually that offending resource crashes the
agent.
(Any suggestion to test `CHECK` is welcomed).
Thanks,
Zhitao Li
sees task labels.
Thanks,
Zhitao Li
, visit:
https://reviews.apache.org/r/45572/#review127918
-------
On April 1, 2016, 1:42 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically gener
to ResourceEstimator and QoSController.
Thanks,
Zhitao Li
rect and I'll
happily drop this change.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45572/#review126862
---
On Ap
/47400/diff/
Testing
---
Thanks,
Zhitao Li
e ones without.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
---
On May 18, 2016, 4:53 p.m., Zhit
in MasterQuotaTest.
Thanks,
Zhitao Li
9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
testing using local authorizer.
Thanks,
Zhitao Li
Should be get_quotas.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47399/#review133537
---
On May 17,
://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
iff: https://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
://reviews.apache.org/r/47400/diff/
Testing
---
Thanks,
Zhitao Li
To reply, visit:
https://reviews.apache.org/r/47399/#review133615
---
On May 17, 2016, 6:26 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/diff/
Testing (updated)
---
1. Unit tests;
2. Manually tested cases: authorized and forbidden under both deprecated
set_quotas/remove_quotas and new update_quotas, as well as the case that
specifying both triggers master crash.
Thanks,
Zhitao Li
/
Testing
---
Unit test.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/47274/#comment197960>
It'll be great if we can either catch this in linter/commit hook during
`git commit`, or publish .vimrc/etc so contributors don't need to remember this.
- Zhitao Li
On May 17, 2016, 5:06 a.m., Zhitao Li
---
On May 17, 2016, 5:06 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47274/
>
vector::const_iterator to loop in it. It
should be no difference interface wise.
- Zhitao Li
On May 12, 2016, 12:48 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/diff/
Testing
---
Thanks,
Zhitao Li
/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47222/diff/
Testing
---
Adding tests in MasterQuotaTest.
Thanks,
Zhitao Li
tps://reviews.apache.org/r/47222/#comment196868>
Please advise if we should define "/quota" as a member const of
`QuotaHandler` class.
- Zhitao Li
On May 11, 2016, 6:14 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically g
3e55114ee7866e06513071e86e15608099dae052
src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
3e55114ee7866e06513071e86e15608099dae052
src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47274/diff/
Testing
---
Unit test.
Thanks,
Zhitao Li
/quota.md 797e134605381ae576d9aa93875e0314889ab047
docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9
Diff: https://reviews.apache.org/r/47400/diff/
Testing
---
Thanks,
Zhitao Li
6590519d8440f352f5bf00fda805414a5aad725c
src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011
src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64
Diff: https://reviews.apache.org/r/47399/diff/
Testing
---
Unit tests.
Thanks,
Zhitao Li
,
Zhitao Li
veTest` below.
> >
> > What do you think?
As discussed in the workgroup, I'll only test one endpoint in each realm.
- Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50223/#review143110
-------
On July 21, 2016, 4:33 a.m., Zhitao Li wrote:
>
>
a03dbc4ab46747003d8b11d22f2dc136293264ec
3rdparty/libprocess/src/tests/metrics_tests.cpp
d4d99de6d3bd9249e7b65e6be5841fbdb670a744
3rdparty/libprocess/src/tests/profiler_tests.cpp
bf7a37536a7d15a03d1a88258f8cfb1f4b56bce8
Diff: https://reviews.apache.org/r/50277/diff/
Testing
---
Thanks,
Zhitao Li
/r/50320/diff/
Testing
---
`make check`
Thanks,
Zhitao Li
48c002d1dc371c285b9421ef5a2c57250d270fa8
src/tests/slave_tests.cpp 60f9e1644efaeba893f4ff38b6d5a07087d1a355
Diff: https://reviews.apache.org/r/50223/diff/
Testing
---
`make check` on Mac OS.
Thanks,
Zhitao Li
Zhitao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50223/#review143153
---
On July 22, 2016, 12:25 a.m., Zhitao Li wrote:
>
>
48c002d1dc371c285b9421ef5a2c57250d270fa8
src/tests/slave_tests.cpp 60f9e1644efaeba893f4ff38b6d5a07087d1a355
Diff: https://reviews.apache.org/r/50223/diff/
Testing
---
`make check` on Mac OS.
Thanks,
Zhitao Li
m., Adam B wrote:
> > src/master/master.cpp, line 386
> > <https://reviews.apache.org/r/50223/diff/4/?file=1448832#file1448832line386>
> >
> > This now applies to `http_authenticators` and
> > `http_framework_authenticators`
>
> Zhitao Li wrote:
> I
/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9
Diff: https://reviews.apache.org/r/50992/diff/
Testing (updated)
---
make on Mac OS and Linux.
Thanks,
Zhitao Li
---------
On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> -
://reviews.apache.org/r/51009/diff/
Testing
---
Run agent with cfs quota enabled, and observe that throttle related metrics are
in `/containers` and `/monitoring/statistics`
Thanks,
Zhitao Li
1 - 100 of 907 matches
Mail list logo
