Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 25, 2015, 4:09 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review108004 --- src/tests/master_quota_tests.cpp

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review108006 --- Please adjust the JIRA ticket: MESOS-3983 - Alexander Rukletsov

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 20, 2015, 9:49 a.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 19, 2015, 9:39 a.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review107314 --- src/tests/master_quota_tests.cpp (line 332)

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 17, 2015, 3:44 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 17, 2015, 10:29 a.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 16, 2015, 12:48 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 13, 2015, 2:23 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 201-203 > > > > > > This format may be better? > >

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 15, 2015, 6:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review106356 --- src/tests/master_quota_tests.cpp (lines 196 - 198)

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 12, 2015, 3:22 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review106038 --- src/tests/master_quota_tests.cpp (line 288)

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 463 > > > > > > We try to keep tests atomic: testing one thing at a time. However, I > > think it does make sense

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 10, 2015, 10:27 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 10, 2015, 2:05 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review105844 --- src/tests/master_quota_tests.cpp (line 449)

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 9, 2015, 10:45 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 8, 2015, 2:24 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 209-210 > > > > > > Can you please make this comments limit in 70 per line and ditto for > > the following? > >

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 8, 2015, 2:24 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 209-210 > > > > > > Can you please make this comments limit in 70 per line and ditto for > > the following? Why do you

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 9, 2015, 7:29 a.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review105600 --- src/tests/master_quota_tests.cpp (lines 209 - 210)

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 431 > > > > > > It looks like this comment is a victim of partial refactoring : ). > > Could you please udpate

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 6, 2015, 5:02 p.m.) Review request for mesos, Alexander

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 463 > > > > > > We try to keep tests atomic: testing one thing at a time. However, I > > think it does make sense

Re: Review Request 39223: Added Quota Request Validation Tests.

> On Oct. 25, 2015, 8:31 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 564 > > > > > > We should unify if use "role1" or role1 for all of the tests I vote for variables, since they were

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review104894 --- Great tests, thanks a lot Jörg! src/tests/master_quota_tests.cpp

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review103945 --- src/tests/master_quota_tests.cpp (line 433)

Re: Review Request 39223: Added Quota Request Validation Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 23, 2015, 9:10 p.m.) Review request for mesos, Alexander