Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 6, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127465 --- Fix it, then Ship it!

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 6, 2016, 6:42 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On April 5, 2016, 10:25 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 286 > > > > > > `s/directory/path`. As discussed, we only accept directories now. > On April 5,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11:15 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 5, 2016, 11 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review127166 --- Fix it, then Ship it! Looking good. Just a few minor comments,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 4, 2016, 5:27 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126496 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp (lines 45

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated April 1, 2016, 12:01 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 31, 2016, 5:12 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, line 336 > > > > > > Plural? > > > > We often use a trailing understore: `char* directory_[]`.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 31, 2016, 10:12 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp, lines 366-368 > > > > > > In this method we can just validate the projectId first and then > > >

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review126200 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp (line 17)

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 30, 2016, 10:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 29, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 26, 2016, 5:06 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 17 > > > > > > Move this after below stout headers. > > James Peach wrote: > The Mesos C++ style guide says that this should come first.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review125072 --- src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp (line

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 23, 2016, 5:39 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs/utils.cpp, lines 17-19 > > > > > > So this is bug of the xfs headers? > > > > I guess it's still not

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 22, 2016, 4:46 p.m., Gilbert Song wrote: > > BTW, should we also add `utils.cpp` to `CMakeList.txt`? Cmake support is going to need a lot more than that :-/ - James --- This is an automatically generated e-mail. To reply,

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124827 --- BTW, should we also add `utils.cpp` to `CMakeList.txt`?

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 6:30 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 53 > > > > > > Instead of relying on parameter, can we use os::stat::isdir here? > > James Peach wrote: > ``isdir`` always follows

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 6:18 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 17 > > > > > > Move this after below stout headers. > > James Peach wrote: > The Mesos C++ style guide says that this should come first.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 17 > > > > > > Move this after below stout headers. The Mesos C++ style guide says that this should come first. > On March 19, 2016, 10:10

Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 17, 2016, 10:43 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124427 --- src/linux/xfs.cpp (line 17)

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang