Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review182068 --- Ship it! Ship It! - Avinash sridharan On Aug. 3, 2017, 2:57

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated Aug. 3, 2017, 10:57 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181437 --- Ship it! Ship It! - Avinash sridharan On July 26, 2017,

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 11:33 p.m., Avinash sridharan wrote: > > src/slave/main.cpp > > Lines 411-457 (patched) > > > > > > Shouldn't this be a \lambda? > > > > Similar to how we do error handling for the flags

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 26, 2017, 10:41 a.m.) Review request for mesos, Avinash

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181349 --- src/slave/main.cpp Lines 411-457 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 25, 2017, 2:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 1:46 a.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 41 (patched) > > > > > > I'd s/MesosDNS/MesosInfo/ here. Same for DockerDNS below. This seems to > > be consistent with what's

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 25, 2017, 1:42 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp > > Lines 773 (patched) > > > > > > We need a validation for the `HOST` mode here? Yeah, I have it here:

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181233 --- Fix it, then Ship it! The protobuf looks good to me! Thanks

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181234 --- src/slave/flags.cpp Lines 773 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 23, 2017, 3:22 p.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 69 (patched) > > > > > > Qian, sorry, should have pointed this out earlier. I think we decided > > that for Docker we

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 24, 2017, 9:39 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 23, 2017, 11:22 p.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 69 (patched) > > > > > > Qian, sorry, should have pointed this out earlier. I think we decided > > that for Docker we

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181181 --- src/messages/flags.proto Lines 69 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 22, 2017, 12:34 a.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 44 (patched) > > > > > > I know we are using this `USER` mode from the docker terminology, but I > > would really like

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 23, 2017, 5:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review181121 --- src/messages/flags.proto Lines 41 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 20, 2017, 8:21 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 17, 2017, 11:12 p.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Had an internal discussion on this with Jie, and seems like having > > different DNS options

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 18, 2017, 7:12 a.m., Avinash sridharan wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Had an internal discussion on this with Jie, and seems like having > > different DNS options

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180764 --- src/messages/flags.proto Lines 56 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180728 --- src/messages/flags.proto Lines 56 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 14, 2017, 6:31 p.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Any reason we seperate 'mesos' from 'docker'? Can we use the same? > > Qian Zhang wrote: > The reason

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 15, 2017, 2:31 a.m., Jie Yu wrote: > > src/messages/flags.proto > > Lines 56 (patched) > > > > > > Any reason we seperate 'mesos' from 'docker'? Can we use the same? The reason that we have 'mesos' and

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review180566 --- src/messages/flags.proto Lines 56 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > > > > > `ContainerInfo.docker.parameter` > > Qian Zhang wrote: > The field name is `parameters`

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179992 --- Ship it! Ship It! - Avinash sridharan On July 5, 2017, 7:03

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 3, 2017, 5:22 p.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > > > > > `ContainerInfo.docker.parameter` > > Qian Zhang wrote: > The field name is `parameters`

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 5, 2017, 3:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 3, 2017, 5:22 p.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1329 (patched) > > > > > > This is interesting. I think this example highlights a subtle > > difference between the

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1329 (patched) > > > > > > This is interesting. I think this example highlights a subtle > > difference between the

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > > > > > `ContainerInfo.docker.parameter` The field name is `parameters` rather than `parameter`. > On

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179533 --- src/messages/flags.hpp Lines 58 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179520 --- docs/configuration.md Lines 1309 (patched)

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179178 --- Bad patch! Reviews applied: [60500] Failed command: python

Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709