Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188814 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Oct. 19, 2017, 10:44 p.m., Gaston Kleiman wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1133 (patched) > > > > > > Nit: I prefer `ASSERT_FALSE(offers->offers().empty());` Yes

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188777 --- I love the new helper ;-).

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188751 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Oct. 18, 2017, 8:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1225 (patched) > > > > > > Why do we need the `slaveId`? Can we just call `StartSlave()` like what >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188461 --- Fix it, then Ship it!

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188458 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188422 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Oct. 17, 2017, 7:15 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185641 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185506 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 9 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185032 --- ERROR: Failed to apply patch 60491. Please check

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Sept. 8, 2017, 10:44 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184920 --- ERROR: Failed to apply patch 60491. Please check

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184913 --- ERROR: Failed to apply patch 60491. Please check

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Sept. 7, 2017, 9:57 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 9 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184660 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 910

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184218 --- Failed to apply patch! Reviews applied: [60491, 60493, 60494,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184217 --- Bad patch! Reviews applied: [62003, 60593, 60765, 60903, 60766,

Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- Review request for mesos, Qian Zhang and Jiang Yan Xu. Bugs: MESOS-7675