[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27635315 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -144,6 +145,12 @@ private[sql] class SQLConf extends Serializable {

[GitHub] spark pull request: [SPARK-6492][CORE] SparkContext.stop() can dea...

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5277#issuecomment-88802613 Any other comments? I'd like to merge today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-88803199 [Test build #29597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29597/consoleFull) for PR 5208 at commit

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5303#issuecomment-88820325 [Test build #29598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29598/consoleFull) for PR 5303 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27639338 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -93,6 +91,9 @@ class SparkHadoopUtil extends Logging { if

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88820468 oops, forgot to include fixed test code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-88839061 [Test build #29597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29597/consoleFull) for PR 5208 at commit

[GitHub] spark pull request: [SPARK-4346][SPARK-3596][YARN] Commonize the m...

2015-04-02 Thread Sephiroth-Lin
Github user Sephiroth-Lin commented on the pull request: https://github.com/apache/spark/pull/5305#issuecomment-88838919 @srowen unit tests failed at run Python app on yarn-cluster mode, I think this didn't cause by this PR, please ask jenkins to retest, thank you. --- If your

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-88849749 [Test build #29605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29605/consoleFull) for PR 5330 at commit

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88851996 [Test build #29599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29599/consoleFull) for PR 5227 at commit

[GitHub] spark pull request: [SPARK-6663] [SQL] use Literal.create instread...

2015-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5320#issuecomment-88758764 Thanks. Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4233] [SQL] WIP:Simplify the UDAF API (...

2015-04-02 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/3247#issuecomment-88771801 Is it not possible to create that simple patch that removes DISTINCT aggregation expressions? We only add `distinct` as a field value in `AggregateExpresion`, and then

[GitHub] spark pull request: [SPARK-6627] Some clean-up in shuffle code.

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27635297 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -75,9 +76,9 @@ class JoinSuite extends QueryTest with BeforeAndAfterEach {

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-88772266 @adrian-wang I leave some comments, but I need some more time in review the code of `SortMergeJoin`, will keep add more comments later. BTW, can you double check

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88812118 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88812193 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88812169 [Test build #29595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29595/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88812095 [Test build #29589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29589/consoleFull) for PR 5324 at commit

[GitHub] spark pull request: Add status command to spark-daemon

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5327#issuecomment-88812019 Please update the title according to https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5227#discussion_r27640700 --- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java --- @@ -101,12 +101,9 @@ public static void main(String[] argsArray) throws Exception {

[GitHub] spark pull request: Add status command to spark-daemon

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5327#issuecomment-88769600 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3596][YARN]Support changing the yarn cl...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5292#discussion_r27638683 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -125,6 +125,7 @@ private[spark] class

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88817260 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88817225 [Test build #29596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29596/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5328#issuecomment-88829933 CC @vanzin; I tend to trust your judgment about this and it does seem like Windows should have the same script. Does this only affect `master` / 1.4? --- If your project

[GitHub] spark pull request: [SPARK-4346][SPARK-3596][YARN] Commonize the m...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5305#issuecomment-88841360 [Test build #29604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29604/consoleFull) for PR 5305 at commit

[GitHub] spark pull request: [SPARK-3591][YARN]fire and forget for YARN clu...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5297#issuecomment-88756937 [Test build #29588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29588/consoleFull) for PR 5297 at commit

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88762001 [Test build #29591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29591/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88771516 [Test build #29591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29591/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88771528 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88782152 [Test build #29587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29587/consoleFull) for PR 5324 at commit

[GitHub] spark pull request: [SPARK-3596][YARN]Support changing the yarn cl...

2015-04-02 Thread Sephiroth-Lin
Github user Sephiroth-Lin commented on a diff in the pull request: https://github.com/apache/spark/pull/5292#discussion_r27636093 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -125,6 +125,7 @@ private[spark] class

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88799355 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88799332 [Test build #29590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29590/consoleFull) for PR 5227 at commit

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88823718 [Test build #29602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29602/consoleFull) for PR 5329 at commit

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88839207 The `streaming` failure may be transient, but tests in `repl`, `mllib` and `core` are failing consistently, 3 times now, while other test runs for other PRs do not show

[GitHub] spark pull request: [SPARK-4346][SPARK-3596][YARN] Commonize the m...

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5305#issuecomment-88839296 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-88839067 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-02 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-88848340 ping @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-02 Thread MechCoder
GitHub user MechCoder opened a pull request: https://github.com/apache/spark/pull/5330 [SPARK-5972] [MLlib] Cache residuals and gradient in GBT during training and validation The previous PR https://github.com/apache/spark/pull/4906 helped to extract the learning curve giving the

[GitHub] spark pull request: [SPARK-6676][BUILD] add more hadoop version su...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5331#issuecomment-88852916 [Test build #29606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29606/consoleFull) for PR 5331 at commit

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88853097 [Test build #29601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29601/consoleFull) for PR 5329 at commit

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27634669 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -144,6 +145,12 @@ private[sql] class SQLConf extends Serializable {

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27635035 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -0,0 +1,164 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-6578] Small rewrite to make the logic m...

2015-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5319#issuecomment-88779113 @vanzin do you mind making a PR for 1.2 branch for this fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread tsudukim
GitHub user tsudukim opened a pull request: https://github.com/apache/spark/pull/5328 [SPARK-6673] spark-shell.cmd can't start in Windows even when spark was built added equivalent script to load-spark-env.sh You can merge this pull request into a Git repository by running: $

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88783273 [Test build #29594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29594/consoleFull) for PR 5329 at commit

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88785248 [Test build #29596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29596/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5328#issuecomment-88820960 [Test build #29593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29593/consoleFull) for PR 5328 at commit

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5328#issuecomment-88820978 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88821153 [Test build #29599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29599/consoleFull) for PR 5227 at commit

[GitHub] spark pull request: [SPARK-5794] [SQL] [WIP] fix add jar

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4586#issuecomment-88821144 [Test build #29600 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29600/consoleFull) for PR 4586 at commit

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88826195 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88826438 [Test build #29603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29603/consoleFull) for PR 5115 at commit

[GitHub] spark pull request: [MLLib]SPARK-6348:Enable useFeatureScaling in ...

2015-04-02 Thread tanyinyan
Github user tanyinyan commented on the pull request: https://github.com/apache/spark/pull/5055#issuecomment-88834566 If featureScaling is false, then we scale features internally but also adjust regularization. This will improve optimization behavior but will not change the optimal

[GitHub] spark pull request: [SPARK-6676][BUILD] add more hadoop version su...

2015-04-02 Thread liyezhang556520
GitHub user liyezhang556520 opened a pull request: https://github.com/apache/spark/pull/5331 [SPARK-6676][BUILD] add more hadoop version support for maven profile support `-Phadoop-2.5` and `-Phadoop-2.6` when building and testing Spark You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-5794] [SQL] [WIP] fix add jar

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4586#issuecomment-88851541 [Test build #29600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29600/consoleFull) for PR 4586 at commit

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88852034 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5303#issuecomment-88851513 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5794] [SQL] [WIP] fix add jar

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4586#issuecomment-88851557 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6627] Some clean-up in shuffle code.

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-88752957 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6627] Some clean-up in shuffle code.

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-88752937 [Test build #29585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29585/consoleFull) for PR 5286 at commit

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88761331 Ah @vanzin, I didn't understand your suggestion. `CommandBuilderUtils` needs modified to escape comma. But I think we still need to modify `spark-class2.cmd` as

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/5326 [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin for LeftSemi Inner JOIN Assume we have table `x`, `y`, `z`, and the `x` is the fact table with large mount of data, and `y`, `z` are

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5303#issuecomment-88770218 [Test build #29586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29586/consoleFull) for PR 5303 at commit

[GitHub] spark pull request: Add status command to spark-daemon

2015-04-02 Thread pchanumolu
GitHub user pchanumolu opened a pull request: https://github.com/apache/spark/pull/5327 Add status command to spark-daemon SPARK-6671 Currently using the spark-daemon.sh script we can start and stop the spark demons. But we cannot get the status of the daemons. It will be nice

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5303#issuecomment-88770278 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27635442 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88778174 [Test build #29592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29592/consoleFull) for PR 5324 at commit

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88782202 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88789246 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88837195 [Test build #29603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29603/consoleFull) for PR 5115 at commit

[GitHub] spark pull request: [SPARK-6440][CORE]Handle IPv6 addresses proper...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5115#issuecomment-88837205 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/5328#issuecomment-88838658 This problem is introduced by https://github.com/apache/spark/commit/e3eb393961051a48ed1cac756ac1928156aa161f https://issues.apache.org/jira/browse/SPARK-6406 So

[GitHub] spark pull request: [SPARK-6663] [SQL] use Literal.create instread...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5227#issuecomment-88759471 [Test build #29590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29590/consoleFull) for PR 5227 at commit

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88759230 [Test build #29589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29589/consoleFull) for PR 5324 at commit

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-88776457 Since the behavior is undefined in Scala, I think it is ok to return anything, as I stated in comment. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/5329 [SPARK-6672][SQL] convert row to catalyst in createDataFrame(RDD[Row], ...) We assume that `RDD[Row]` contains Scala types. So we need to convert them into catalyst types in createDataFrame.

[GitHub] spark pull request: [SPARK-3862] [SQL] [WIP] MultiWayBroadcastJoin...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5326#issuecomment-88784043 [Test build #29595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29595/consoleFull) for PR 5326 at commit

[GitHub] spark pull request: [SPARK-3591][YARN]fire and forget for YARN clu...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5297#issuecomment-88792995 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3591][YARN]fire and forget for YARN clu...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5297#issuecomment-88792907 [Test build #29588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29588/consoleFull) for PR 5297 at commit

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88789227 [Test build #29594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29594/consoleFull) for PR 5329 at commit

[GitHub] spark pull request: [SPARK-4233] [SQL] WIP:Simplify the UDAF API (...

2015-04-02 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3247#issuecomment-88792541 OK, I got your mean, as I put into the description of this PR, we want to make a unified UDAF interface in this PR, `DISTINCT` is quite critical for this purpose,

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88819914 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5324#issuecomment-88819896 [Test build #29592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29592/consoleFull) for PR 5324 at commit

[GitHub] spark pull request: [SPARK-6672][SQL] convert row to catalyst in c...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5329#issuecomment-88822244 [Test build #29601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29601/consoleFull) for PR 5329 at commit

[GitHub] spark pull request: [SPARK-6435] spark-shell --jars option does no...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5227#discussion_r27640645 --- Diff: launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java --- @@ -260,15 +260,14 @@ static String quoteForBatchScript(String arg) {

[GitHub] spark pull request: [SPARK-3596][YARN]Support changing the yarn cl...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5292#discussion_r27643046 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -125,6 +125,7 @@ private[spark] class

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-02 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r27634876 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -75,9 +76,9 @@ class JoinSuite extends QueryTest with BeforeAndAfterEach

[GitHub] spark pull request: [SPARK-6673] spark-shell.cmd can't start in Wi...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5328#issuecomment-88779434 [Test build #29593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29593/consoleFull) for PR 5328 at commit

[GitHub] spark pull request: [SPARK-6492][CORE] SparkContext.stop() can dea...

2015-04-02 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/5277#issuecomment-88807658 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: Add status command to spark-daemon

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5327#discussion_r27638972 --- Diff: sbin/spark-daemon.sh --- @@ -195,6 +195,23 @@ case $option in fi ;; + (status) + +if [ -f $pid ]; then +

[GitHub] spark pull request: [SPARK-3596][YARN]Support changing the yarn cl...

2015-04-02 Thread Sephiroth-Lin
Github user Sephiroth-Lin commented on a diff in the pull request: https://github.com/apache/spark/pull/5292#discussion_r27642711 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -125,6 +125,7 @@ private[spark] class

[GitHub] spark pull request: [MLLib][FPGrowth] Possibility to specify minSu...

2015-04-02 Thread kretes
Github user kretes commented on the pull request: https://github.com/apache/spark/pull/5246#issuecomment-89025763 I've expressed my opinion in that JIRA - what can I say.. I think it's worth it, you think its' not. Stalemate --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-3591][YARN]fire and forget for YARN clu...

2015-04-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5297#discussion_r27696007 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -609,6 +593,26 @@ private[spark] class Client( throw new

[GitHub] spark pull request: [SPARK-6604][PySpark]Specify ip of python serv...

2015-04-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5256#issuecomment-89049353 There was some previous discussion of localhost vs 127.0.0.1 at #3425 and I think the conclusion there was against this change. @davies, do your comments there about

[GitHub] spark pull request: [SPARK-4194] [core] Make SparkContext initiali...

2015-04-02 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/5335 [SPARK-4194] [core] Make SparkContext initialization exception-safe. SparkContext has a very long constructor, where multiple things are initialized, multiple threads are spawned, and multiple

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5236#issuecomment-89052524 Thanks for working on this @ilganeli. I will take a look at this in the next day or two. --- If your project is set up for it, you can reply to this email and have

  1   2   3   4   5   >