Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12527#issuecomment-213037505
Just want to add a note. For that test case, we have a join that only
shuffle one side of the input, so we have both preferred locations of original
input files as well a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12257#issuecomment-213037359
**[Test build #56561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56561/consoleFull)**
for PR 12257 at commit
[`c09e17c`](https://gi
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60625828
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9441#issuecomment-213036192
**[Test build #56560 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56560/consoleFull)**
for PR 9441 at commit
[`9e05eba`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9441#issuecomment-213036211
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9441#issuecomment-213036217
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9441#issuecomment-213035265
**[Test build #56560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56560/consoleFull)**
for PR 9441 at commit
[`9e05eba`](https://gith
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60624962
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -182,7 +182,7 @@ private[spark] class BlockManager(
val shuffleC
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12527#issuecomment-213034425
The root cause of the deadlock has been found. Essentially, we should
prevent "localhost" to be returned as `FileScanRDD` preferred locations. Here's
a detailed descr
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12579#issuecomment-213032974
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user xwu0226 opened a pull request:
https://github.com/apache/spark/pull/12579
[SPARK-14346][SQL] Show Create Table (Native)
This is a rebased version of
[#12132](https://github.com/apache/spark/pull/12132) and
[#12406](https://github.com/apache/spark/pull/12406)
##
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12548#issuecomment-213032298
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60623283
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -182,7 +182,7 @@ private[spark] class BlockManager(
val shuffleConfi
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60623144
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -186,7 +186,12 @@ public void tes
Github user dusenberrymw commented on a diff in the pull request:
https://github.com/apache/spark/pull/9441#discussion_r60622845
--- Diff: python/pyspark/mllib/linalg/distributed.py ---
@@ -151,6 +153,151 @@ def numCols(self):
"""
return self._java_matrix_w
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60622806
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -49,7 +49,7 @@
public class
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12566#issuecomment-213029923
The current changes look good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60622768
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleCleanupSuite.java
---
@@ -37,19 +37,20 @@
// Same-threa
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60622524
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -149,16 +149,23 @@ public void regis
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12578#issuecomment-213026193
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user dusenberrymw commented on a diff in the pull request:
https://github.com/apache/spark/pull/9441#discussion_r60621403
--- Diff: python/pyspark/mllib/linalg/distributed.py ---
@@ -297,6 +444,20 @@ def numCols(self):
"""
return self._java_matrix_wr
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213026077
I'm not very against it (though Maven should ideally change to check style
as well on 'pre-compile'). I remember someone arguing that they didn't want to
have to pass al
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12578#issuecomment-213026200
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12544#discussion_r60621196
--- Diff: examples/pom.xml ---
@@ -35,6 +35,10 @@
examples
none
package
+provided
--- End diff --
Yeah, these d
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12527#issuecomment-213025638
**[Test build #56559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56559/consoleFull)**
for PR 12527 at commit
[`e0bfa3e`](https://gi
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12544#issuecomment-213025682
> Is there any documentation that needs to be updated
There isn't any explicit documentation about how to run streaming examples
(that I can find). The pyspark b
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12578#issuecomment-213025805
**[Test build #56551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56551/consoleFull)**
for PR 12578 at commit
[`97af903`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213025184
Yea I think the main thing is that this will be more integrated and more
automated. Many pull requests when they were first submitted fail our style
checker, both from lon
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12559#issuecomment-213025223
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-213024675
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-213024678
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-213024453
**[Test build #56553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56553/consoleFull)**
for PR 12500 at commit
[`ec54d74`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12565#issuecomment-213024169
**[Test build #56558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56558/consoleFull)**
for PR 12565 at commit
[`64447a4`](https://gi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213023963
(Can it be done without all this code though?)
You can run style checks before submitting of course, and they do get run
by the PR builder. Does it change much except
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12560#issuecomment-213023729
Thanks all for your comments! Let me figure out how to collect the
information without slowing the algorithm. @MLnick The names are passed to the
log. For example,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12562#discussion_r60620112
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala
---
@@ -128,4 +131,21 @@ class OptimizeInSuite extends Plan
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/12481#issuecomment-213022550
> @BryanCutler Fixed it in this PR. Outbox should not close the client
since it will be reused by others.
I confirmed this fix takes care of the error in the app
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12498#issuecomment-213022286
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12498#issuecomment-213022233
**[Test build #56554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56554/consoleFull)**
for PR 12498 at commit
[`5081e2c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12498#issuecomment-213022288
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12562#issuecomment-213021952
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12562#issuecomment-213021953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213021785
I was concerned about this increasing the time but last night I had 3 prs
that failed style checkers and now do think it would've been great if the
checking was more autom
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60619566
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12562#issuecomment-213021683
**[Test build #56550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56550/consoleFull)**
for PR 12562 at commit
[`9df35bb`](https://g
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/12536#issuecomment-213021639
Oh sorry, I had not realized that @jkbradley had asked you to remove the
parameter. @jkbradley there is no performance issue doing that?
---
If your project is set u
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12559#issuecomment-213021325
@ueshin in the pr description can you elaborate the approach taken in this
pr?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12559#issuecomment-213021087
cc @davies and @sameeragarwal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/12536#issuecomment-213020180
@BenFradet thanks for the PR. I have one comment about performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12536#discussion_r60618838
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -610,7 +604,9 @@ private[spark] object RandomForest extends Logging
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12536#discussion_r60618857
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -668,6 +664,7 @@ private[spark] object RandomForest extends Logging
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12536#discussion_r60618828
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -80,6 +80,7 @@ private[spark] object RandomForest extends Logging {
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12536#discussion_r60618750
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -94,17 +94,33 @@ final class DecisionTreeClassifier
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12536#discussion_r60618432
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -94,17 +94,33 @@ final class DecisionTreeClassifier
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12566#issuecomment-213018745
cc @yhuai
This one doesn't yet remove the dependency, but puts everything in one
line. I think the next step is to make MetastoreRelation also a CatalogRelation.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12564#issuecomment-213017489
**[Test build #56557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56557/consoleFull)**
for PR 12564 at commit
[`a38eaf1`](https://gi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10024#issuecomment-213017267
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213016020
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213016016
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12565#discussion_r60617642
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -140,7 +140,7 @@ class HiveSqlAstBuilder(conf: SQLConf) extend
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12539#issuecomment-213015476
**[Test build #56556 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56556/consoleFull)**
for PR 12539 at commit
[`fd8c75c`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213015581
**[Test build #56547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56547/consoleFull)**
for PR 12568 at commit
[`1b9eaa8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12537#issuecomment-213015363
**[Test build #2845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2845/consoleFull)**
for PR 12537 at commit
[`d48b19e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12561#issuecomment-213015461
**[Test build #56555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56555/consoleFull)**
for PR 12561 at commit
[`f74b381`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12567#issuecomment-213015412
**[Test build #2846 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2846/consoleFull)**
for PR 12567 at commit
[`0a6bf1a`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12563#issuecomment-213015390
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12578#issuecomment-213013699
Thanks for contributing, but isn't this similar to just window function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213011318
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213011309
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213010394
**[Test build #56546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56546/consoleFull)**
for PR 12568 at commit
[`9a01db7`](https://g
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/12560#issuecomment-213009688
@wangmiao1981 thanks for the PR. Can you see if you could make it work
without having to evaluate the input data?
---
If your project is set up for it, you can reply
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12560#discussion_r60616196
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -395,13 +395,21 @@ class ALS(@Since("1.4.0") override val uid: String)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12498#issuecomment-213008407
**[Test build #56554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56554/consoleFull)**
for PR 12498 at commit
[`5081e2c`](https://gi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12498#discussion_r60615930
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -66,8 +83,9 @@ class HashingTF(val numFeatures: Int) extends
Seriali
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/12560#discussion_r60615798
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -395,13 +395,21 @@ class ALS(@Since("1.4.0") override val uid: String)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12573#issuecomment-213006740
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12573#issuecomment-213006737
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12573#issuecomment-213006612
**[Test build #56552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56552/consoleFull)**
for PR 12573 at commit
[`c1df7d2`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-213006241
**[Test build #56553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56553/consoleFull)**
for PR 12500 at commit
[`ec54d74`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-213003134
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-213003138
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-213002570
**[Test build #56548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56548/consoleFull)**
for PR 12469 at commit
[`8b64a1d`](https://g
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60613929
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -183,12 +190,7 @@ public Managed
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/12568#issuecomment-213000250
Thanks for picking this up, @lianhuiwang I didn't get a chance to work on
this yesterday, so I am very glad you are picked this up, thanks! Left some
comments.
---
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60613362
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -186,7 +186,12 @@ public void
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60613340
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -186,7 +186,12 @@ public void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/12239#discussion_r60611716
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -259,4 +261,78 @@ class InsertIntoHiveTableSuite extends Qu
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/12239#discussion_r60611545
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -414,8 +414,42 @@ class Analyzer(
}
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/12239#discussion_r60612218
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -414,8 +414,42 @@ class Analyzer(
}
Github user a-roberts commented on the pull request:
https://github.com/apache/spark/pull/12327#issuecomment-212991789
@cloud-fan I've had a closer look at this and think a more robust method
would be to use weak references to identify when an object is out of scope,
with IBM Java we
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12402#discussion_r60611229
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala ---
@@ -105,6 +108,15 @@ class GaussianMixtureModel private[ml] (
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-212990210
A couple minor syntax comments, other than that LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/12500#issuecomment-212990133
@MLnick @sethah thanks for the reviews, will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12500#discussion_r60610289
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -92,21 +111,28 @@ object MLTestingUtils extends SparkFunSuite {
t
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/12309#discussion_r60610117
--- Diff: core/src/main/scala/org/apache/spark/rdd/PipedRDD.scala ---
@@ -17,10 +17,7 @@
package org.apache.spark.rdd
-import java.io.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12573#issuecomment-212988976
**[Test build #56552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56552/consoleFull)**
for PR 12573 at commit
[`c1df7d2`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12578#issuecomment-212987557
**[Test build #56551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56551/consoleFull)**
for PR 12578 at commit
[`97af903`](https://gi
801 - 900 of 1279 matches
Mail list logo
