[GitHub] [spark] beliefer commented on pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
beliefer commented on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661611000 @dongjoon-hyun @maropu Thanks for your help! This is an automated message from the Apache Git Service. To

[GitHub] [spark] imback82 commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
imback82 commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661610269 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] dongjoon-hyun closed pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
dongjoon-hyun closed pull request #29161: URL: https://github.com/apache/spark/pull/29161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661609307 Thank you for the review with the alternative. Also, cc @gatorsmile This is an automated message from

[GitHub] [spark] SparkQA commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661573402 **[Test build #126205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126205/testReport)** for PR 29169 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661478293 **[Test build #126208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126208/testReport)** for PR 29152 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661334281 **[Test build #126202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661572619 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
SparkQA commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661572406 **[Test build #126208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126208/testReport)** for PR 29152 at commit

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457813266 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
SparkQA commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661572597 **[Test build #126202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661572619 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-20 Thread GitBox
AngersZh edited a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-661597390 @maropu ArrayType/MapType/StructType data format show as below ``` test("SPARK-32106: TRANSFORM support complex data types as input and ouput type (hive

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r457795979 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionInfo.scala ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] [spark] HyukjinKwon commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
HyukjinKwon commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661605706 If `originalMap` doesn't matter much, I think It's good enough to go with the current PR. If `originalMap` matters, we should think about a different approach but can't

[GitHub] [spark] AmplabJenkins commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661604955 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661604955 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
HyukjinKwon commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661604611 Okay, I realised that why it's tricky. My concern about this patch is, `originalMap` will lose the duplicated instances when it adds now. I came up with a bit

[GitHub] [spark] SparkQA commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
SparkQA commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661604422 **[Test build #126215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126215/testReport)** for PR 29104 at commit

[GitHub] [spark] leanken commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661602530 > comment > > @agrawaldevesh @cloud-fan > > for BroadcasthashJoinExec, how about this > > ``` > > if (isNullAwareAntiJoin) { > >

[GitHub] [spark] gatorsmile commented on a change in pull request #28764: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-07-20 Thread GitBox
gatorsmile commented on a change in pull request #28764: URL: https://github.com/apache/spark/pull/28764#discussion_r457802957 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala ## @@ -1325,3 +1325,99 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661602334 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661602334 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] leanken commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661586173 @agrawaldevesh @clou for BroadcasthashJoinExec, how about this ``` if (isNullAwareAntiJoin) { require(leftKeys.length == 1, "leftKeys length should be 1")

[GitHub] [spark] SparkQA commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
SparkQA commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661601896 **[Test build #126214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126214/testReport)** for PR 29104 at commit

[GitHub] [spark] gatorsmile commented on a change in pull request #28764: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-07-20 Thread GitBox
gatorsmile commented on a change in pull request #28764: URL: https://github.com/apache/spark/pull/28764#discussion_r457802310 ## File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md ## @@ -291,6 +291,7 @@ |

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661600387 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661600383 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661600383 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661355673 **[Test build #126204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126204/testReport)** for PR 29067 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-661599711 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-661599639 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-20 Thread GitBox
SparkQA commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-661599833 **[Test build #126204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126204/testReport)** for PR 29067 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-661599711 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-661599639 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-661598793 **[Test build #126213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126213/testReport)** for PR 29014 at commit

[GitHub] [spark] SparkQA commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-20 Thread GitBox
SparkQA commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-661598746 **[Test build #126212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126212/testReport)** for PR 29032 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661579791 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661579791 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] agrawaldevesh commented on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
agrawaldevesh commented on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661598557 > @agrawaldevesh @cloud-fan > for BroadcasthashJoinExec, how about this > > ``` > if (isNullAwareAntiJoin) { > require(leftKeys.length == 1, "leftKeys

[GitHub] [spark] AngersZhuuuu commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-20 Thread GitBox
AngersZh commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-661597390 @maropu ArrayType/MapType/StructType data format show as below ``` test("SPARK-32106: TRANSFORM support complex data types as input and ouput type (hive serde)")

[GitHub] [spark] SparkQA removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661457578 **[Test build #126206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126206/testReport)** for PR 28977 at commit

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661578468 **[Test build #126206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126206/testReport)** for PR 28977 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661577908 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
SparkQA commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661576957 **[Test build #126211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126211/testReport)** for PR 29152 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661577908 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661593227 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661593224 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661593224 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661574355 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661574340 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661573542 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661574340 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661464775 **[Test build #126207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126207/testReport)** for PR 28977 at commit

[GitHub] [spark] leanken edited a comment on pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken edited a comment on pull request #29104: URL: https://github.com/apache/spark/pull/29104#issuecomment-661586173 @agrawaldevesh @cloud-fan for BroadcasthashJoinExec, how about this ``` if (isNullAwareAntiJoin) { require(leftKeys.length == 1, "leftKeys length should

[GitHub] [spark] SparkQA removed a comment on pull request #29169: [SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29169: URL: https://github.com/apache/spark/pull/29169#issuecomment-661450980 **[Test build #126205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126205/testReport)** for PR 29169 at commit

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-20 Thread GitBox
SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-661592197 **[Test build #126207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126207/testReport)** for PR 28977 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661573525 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661572632 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29167: URL: https://github.com/apache/spark/pull/29167#issuecomment-661573525 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661566689 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661566494 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661566689 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661566494 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661312692 **[Test build #126199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126199/testReport)** for PR 29145 at commit

[GitHub] [spark] SparkQA commented on pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
SparkQA commented on pull request #29161: URL: https://github.com/apache/spark/pull/29161#issuecomment-661565693 **[Test build #126210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126210/testReport)** for PR 29161 at commit

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457778500 ## File path: core/src/test/scala/org/apache/spark/deploy/DecommissionWorkerSuite.scala ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] [spark] SparkQA commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-20 Thread GitBox
SparkQA commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-661565209 **[Test build #126199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126199/testReport)** for PR 29145 at commit

[GitHub] [spark] beliefer commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-20 Thread GitBox
beliefer commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-661562454 cc @jiangxb1987 @Ngone51 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] beliefer commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
beliefer commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457792887 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
beliefer commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457792805 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29161: [SPARK-32365][SQL] Add a boundary condition for negative index in regexp_extract

2020-07-20 Thread GitBox
beliefer commented on a change in pull request #29161: URL: https://github.com/apache/spark/pull/29161#discussion_r457792605 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -426,6 +428,14 @@ object

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457792288 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -912,13 +914,39 @@ private[spark] class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457776625 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -1007,6 +1035,8 @@ private[spark] class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457791845 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -912,13 +914,39 @@ private[spark] class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457791849 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -385,55 +408,101 @@ case class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457791246 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1767,10 +1767,18 @@ private[spark] class DAGScheduler(

[GitHub] [spark] viirya commented on a change in pull request #29139: [SPARK-32339][ML][DOC] Improve MLlib BLAS native acceleration docs

2020-07-20 Thread GitBox
viirya commented on a change in pull request #29139: URL: https://github.com/apache/spark/pull/29139#discussion_r457788794 ## File path: docs/ml-linalg-guide.md ## @@ -0,0 +1,105 @@ +--- +layout: global +title: MLlib Linear Algebra Acceleration Guide +displayTitle: MLlib

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457786737 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2671,6 +2671,25 @@ object SQLConf { .checkValue(_ >

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457786215 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -44,7 +45,7 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457784068 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2671,6 +2671,25 @@ object SQLConf { .checkValue(_ >

[GitHub] [spark] xuanyuanking commented on pull request #24173: [SPARK-27237][SS] Introduce State schema validation among query restart

2020-07-20 Thread GitBox
xuanyuanking commented on pull request #24173: URL: https://github.com/apache/spark/pull/24173#issuecomment-661528439 Sorry for the late, I'll review this one in this week. I think it's the other necessary guard for state store format together with #28707.

[GitHub] [spark] HeartSaVioR commented on pull request #29149: [SPARK-32350][CORE] Add batch-write on LevelDB to improve performance of HybridStore

2020-07-20 Thread GitBox
HeartSaVioR commented on pull request #29149: URL: https://github.com/apache/spark/pull/29149#issuecomment-661527330 @mridulm @tgravescs I'm planning to merge this in tomorrow. Please comment if you'd like to have time to review. Thanks!

[GitHub] [spark] xuanyuanking commented on a change in pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-20 Thread GitBox
xuanyuanking commented on a change in pull request #28904: URL: https://github.com/apache/spark/pull/28904#discussion_r457778586 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala ## @@ -106,10 +106,8 @@ abstract

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457778500 ## File path: core/src/test/scala/org/apache/spark/deploy/DecommissionWorkerSuite.scala ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457778416 ## File path: core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala ## @@ -245,8 +249,8 @@ class AppClientSuite

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457776625 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -1007,6 +1035,8 @@ private[spark] class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-20 Thread GitBox
agrawaldevesh commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r457776437 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ## @@ -912,13 +914,39 @@ private[spark] class

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

2020-07-20 Thread GitBox
dongjoon-hyun edited a comment on pull request #29142: URL: https://github.com/apache/spark/pull/29142#issuecomment-661517034 Thank you for closing, @ulysses-you . This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on pull request #29142: [SPARK-32360][SQL] Add MaxMinBy to support eliminate sorts

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29142: URL: https://github.com/apache/spark/pull/29142#issuecomment-661517034 Thank you, @ulysses-you . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661516112 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661516112 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
SparkQA removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661305415 **[Test build #126197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126197/testReport)** for PR 29168 at commit

[GitHub] [spark] SparkQA commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-20 Thread GitBox
SparkQA commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-661514577 **[Test build #126197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126197/testReport)** for PR 29168 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29172: URL: https://github.com/apache/spark/pull/29172#discussion_r457773370 ## File path: sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala ## @@ -40,7 +40,7 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661504894 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
dongjoon-hyun commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661504976 We need to fix this fundamental bug first. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
AmplabJenkins commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661504894 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29172: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

2020-07-20 Thread GitBox
SparkQA commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661503811 **[Test build #126209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126209/testReport)** for PR 29172 at commit

[GitHub] [spark] ueshin closed pull request #29138: [SPARK-32338] [SQL] Overload slice to accept Column for start and length

2020-07-20 Thread GitBox
ueshin closed pull request #29138: URL: https://github.com/apache/spark/pull/29138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

<    1   2   3   4   5   6   7   8   9   >