Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15171
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -36,6 +36,7 @@ import
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -142,8 +145,12 @@ class SessionCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79752423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -142,8 +145,12 @@ class SessionCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79744373
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -111,7 +111,8 @@ statement
| ALTER TABLE
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r79744336
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala ---
@@ -33,7 +33,7 @@ class ListTablesSuite extends QueryTest
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15171
@cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/15171
[SPARK-17617][SQL] Remainder(%) expression.eval returns incorrect result on
double value
## What changes were proposed in this pull request?
Remainder(%) expression's `eval()` returns
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15099
@cloud-fan, since this bug fix is important that other patches depends on
this, I am +1 on current approach. Maybe in future, we should consider making
TableIdentifier a unique identifier for all
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15099
My comments:
# 1. There are too many hack about TableIdentifier.
## Problem:
Currently, our current use of TableIdentifier is kind of ambiguous.
```
case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15099#discussion_r79124795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -325,6 +325,21 @@ class SessionCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15099#discussion_r79126002
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -47,7 +47,11 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15099#discussion_r79126355
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -140,7 +146,9 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15099#discussion_r79122189
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -47,7 +47,11 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15099#discussion_r79122636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -188,7 +196,7 @@ case class
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14990
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78666218
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -93,8 +92,11 @@ private[spark] class HiveExternalCatalog(conf
Github user clockfly closed the pull request at:
https://github.com/apache/spark/pull/14968
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14750
By the way, can you elaborate more on the benefits of this change?
Since we are using abstract interface ExternalCatalog for represents
external catalog like hive, user can only see
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14750
Here is my two cents:
### 1. About case sensitivity
Before this change, the column name we stored in Hive meta store is always
lower case for Hive serde table (Hive Metastore
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14750
@cloud-fan
Seems the SessionCatalog is converting all database/table name to lower
case by default config (case sensitivity = false). So, we are not preserving
the case, at least
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78659438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -373,7 +373,7 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78494405
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -93,8 +92,11 @@ private[spark] class HiveExternalCatalog(conf
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78493500
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -435,13 +435,13 @@ case class DataSource
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78493170
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -204,13 +194,21 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78493048
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -204,13 +194,21 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78484539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -665,15 +665,7 @@ case class AlterTableSetLocationCommand
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78474805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
@@ -245,4 +245,28 @@ object DataType {
case (fromDataType
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78474538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -253,6 +266,7 @@ class InMemoryCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78473168
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -410,15 +417,22 @@ private[spark] class HiveExternalCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78472441
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ---
@@ -262,11 +262,13 @@ class CatalogImpl(sparkSession: SparkSession
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78472272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -435,13 +435,13 @@ case class DataSource
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78472224
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -435,13 +435,13 @@ case class DataSource
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78471429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -665,15 +665,7 @@ case class AlterTableSetLocationCommand
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78471303
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -204,13 +194,21 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78471240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -204,13 +194,21 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78471137
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -154,13 +149,8 @@ case class
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78469005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -253,6 +266,7 @@ class InMemoryCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78468230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -195,18 +195,31 @@ class InMemoryCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78468181
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -195,18 +195,31 @@ class InMemoryCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r78468093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -195,18 +195,31 @@ class InMemoryCatalog
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15056
@yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/15056
[SPARK-17503][Core] Fix memory leak in Memory store when unable to cache
the whole RDD
## What changes were proposed in this pull request?
Memory store may throws OutOfMemoryError
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15006
@hvanhovell
How do you think the case @dilipbiswal posted?
Currently, there is a semantic mismatch between Spark and Postgres.
In Spark 1.6/2.0, `SELECT 123X` is interpreted
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15006
@dilipbiswal Thanks for this. Yes, I also tried to do this at Parser level,
but found it would requires us to change the visitor code, which is not very
clean.
The current `lexer rule
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77958425
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -626,189 +626,25 @@ abstract class TreeNode[BaseType
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15006
Besides, Spark 1.6, Spark 2.0, supports syntax like `select * from
123_LIST`, so maybe we should keep it compatible so that we can also support
syntax like `select * from default.123_LIST
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/15006
@gatorsmile
We are not "more flexible than Hive". We are as flexible as Hive. With this
PR, we only treats a string as an IDENTIFIER if there is no ambiguity th
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77953015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -597,7 +597,10 @@ abstract class TreeNode[BaseType
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77952732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -626,189 +629,25 @@ abstract class TreeNode[BaseType
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77952714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -626,189 +629,25 @@ abstract class TreeNode[BaseType
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14976#discussion_r77952226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -59,9 +59,14 @@ class QuantileSummaries
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/15006#discussion_r77942481
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -897,43 +921,41 @@ STRING
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14990
@cloud-fan Can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/15006
[SPARK-17364][SQL][WIP][Don't MERGE][POC] Allow number to be used in
identifier
## What changes were proposed in this pull request?
This is a proof of concept.
With this PR, we can
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14990
[SPARK-17426][SQL] Refactor `TreeNode.toJSON` to avoid OOM when converting
unknown fields to JSON
## What changes were proposed in this pull request?
This PR is a follow up of SPARK
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77745578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -72,9 +72,7 @@ class SessionCatalog
Github user clockfly closed the pull request at:
https://github.com/apache/spark/pull/14973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14976#discussion_r77727133
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -59,9 +59,14 @@ class QuantileSummaries
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14976#discussion_r77726882
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -59,9 +59,14 @@ class QuantileSummaries
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14929
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14973
@hvanhovell, the meta data is still kept in the plan. MLLib doesn't use
toJSON directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14973
[SPARK-17356][SQL][1.6] Fix out of memory issue when generating JSON for
TreeNode
This is a backport of PR https://github.com/apache/spark/pull/14915 to
branch 1.6.
## What changes were
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77574630
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -617,7 +617,9 @@ abstract class TreeNode[BaseType
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14968
Target 2.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14968
[SPARK-17369][SQL][2.0] MetastoreRelation toJSON throws AssertException due
to missing otherCopyArgs
backport https://github.com/apache/spark/pull/14928 to 2.0
## What changes were
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77560363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -72,9 +72,7 @@ class SessionCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77559438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -604,6 +604,7 @@ abstract class TreeNode[BaseType
Github user clockfly closed the pull request at:
https://github.com/apache/spark/pull/14756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14928
Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14850
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14929#discussion_r77416301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -62,8 +68,39 @@ class JacksonParser
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14929
@cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77301211
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -604,6 +604,7 @@ abstract class TreeNode[BaseType
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14929#discussion_r77300596
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -62,8 +68,35 @@ class JacksonParser
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14773#discussion_r77295324
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -90,17 +90,31 @@ case class RefreshResource(path: String
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14773#discussion_r77294893
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -90,17 +90,31 @@ case class RefreshResource(path: String
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14809#discussion_r77294000
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -272,17 +282,11 @@ private[spark] class HiveExternalCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14809#discussion_r77293800
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -241,10 +241,21 @@ private[spark] class HiveExternalCatalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14850#discussion_r77292898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -1039,9 +1033,18 @@ case class ScalaUDF
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14921
@cloud-fan Can you update the PR tile and PR description to be more
user-facing.
For example, it is better to use "CREATE TABLE ..USING.." in the PR title.
It is also bett
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14921#discussion_r77292448
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -314,12 +314,8 @@ case class DataSource
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14921
ï¼1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14921#discussion_r77290803
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -314,12 +314,8 @@ case class DataSource
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14921#discussion_r77290773
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -314,12 +314,8 @@ case class DataSource
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77288334
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77287956
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14929
[Don't merge][WIP] Better error message for JSON file format reader when
finding malformed line in PERMISSIVE parser mode
## What changes were proposed in this pull request?
For JSON
GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14928
[SPARK-17369][SQL] MetastoreRelation toJSON should not throws exception
## What changes were proposed in this pull request?
Fix the issue that `MetastoreRelation.toJSON` fails because
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77265693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -255,3 +287,43 @@ case class AlterViewAsCommand
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77265560
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -198,10 +219,12 @@ case class CreateViewCommand
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77264967
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -25,7 +25,41 @@ import
org.apache.spark.sql.catalyst.catalog
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77264028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14897#discussion_r77263886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14915#discussion_r77261626
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -274,6 +274,13 @@ abstract class QueryTest extends PlanTest {
val
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14850
@cloud-fan
There are two branches to execute an UDF.
1. Call `override def eval(input: InternalRow): Any` directly. For this
code branch, I don't think there is any barrier
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14850#discussion_r77184294
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -1057,5 +1059,19 @@ case class ScalaUDF
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14850#discussion_r77182217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -1039,9 +1032,18 @@ case class ScalaUDF
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14850#discussion_r77177520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -1057,5 +1059,19 @@ case class ScalaUDF
Github user clockfly commented on the issue:
https://github.com/apache/spark/pull/14915
@mengxr @yhuai, comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 326 matches
Mail list logo
