Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r151607724
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -727,8 +769,8 @@ private[spark] class AppStatusListener
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r151607855
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -40,8 +41,8 @@ private[spark] abstract class LiveEntity
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r151324714
--- Diff:
core/src/main/scala/org/apache/spark/status/ElementTrackingStore.scala ---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r151445965
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -93,9 +93,9 @@ class JobProgressListener(conf: SparkConf
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r151321285
--- Diff:
core/src/main/scala/org/apache/spark/status/ElementTrackingStore.scala ---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19751
@vanzin looks like this PR has conflicts now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
Hi @sathiyapk , it is from `InferFiltersFromConstraints`.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18692#discussion_r144734911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +152,71 @@ object EliminateOuterJoin extends
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18692#discussion_r144466472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +152,71 @@ object EliminateOuterJoin extends
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19475
@jiangxb1987 @gatorsmile @cloud-fan @maropu
Thanks for the comments. I have remove the irrelevant override.
---
-
To
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
LGTM.
@gatorsmile please help check again.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19478
@viirya @hvanhovell @gatorsmile
Thanks, I have attached the performance result in the description in this
PR.
Overall I don't see any downside of the code change.
Also
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19478
[SPARK-22263][SQL]Refactor deterministic as lazy value
## What changes were proposed in this pull request?
The method `deterministic` is frequently called in optimizer.
Refactor
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144186680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,9 +81,13 @@ class ExpressionSet
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19475
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144184258
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,9 +81,13 @@ class ExpressionSet
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144184155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,9 +81,13 @@ class ExpressionSet
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144182958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -46,14 +47,20 @@ object ExpressionSet
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144182675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,9 +81,13 @@ class ExpressionSet
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19475
[SPARK-22257][SQL]Reserve all non-deterministic expressions in ExpressionSet
## What changes were proposed in this pull request?
For non-deterministic expressions, they should be
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
@sathiyapk You are right about the style, I didn't notice that.
I just left some more comments. I think this is good to me after you fix
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r144136759
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,57 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r144136954
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceOperatorSuite.scala
---
@@ -50,6 +52,25 @@ class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r144136322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,57 @@ object
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19451
@sathiyapk Yes you're right, I have some misunderstandings.
Still, I have other comments.
---
-
To unsubscri
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143870225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,54 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143874162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,54 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143871478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,54 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143871562
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,54 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143804627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143803904
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143810078
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143808170
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143809031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143810175
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143805303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r143803469
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1242,6 +1243,53 @@ object
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19399#discussion_r143591603
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -833,10 +850,12 @@ private[history] class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19399#discussion_r143589483
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -850,6 +869,18 @@ private[history] class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19399#discussion_r143589815
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -833,10 +850,12 @@ private[history] class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19399#discussion_r143591399
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -794,6 +800,17 @@ private[history] class
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19379
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19379
[SPARK-22141][Followup][SQL] Add comments for the order of batches
## What changes were proposed in this pull request?
Add comments for specifying the position of batch "Check Cart
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19362#discussion_r141406147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -136,6 +134,8 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19362#discussion_r141404707
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -136,6 +134,8 @@ abstract class Optimizer
Github user gengliangwang closed the pull request at:
https://github.com/apache/spark/pull/19366
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19362
@hvanhovell Got it, I have created
https://github.com/apache/spark/pull/19366 for the back port.
---
-
To unsubscribe, e
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19366
[Backport][SPARK-22141][SQL] Propagate empty relation before checking
Cartesian products
Back port https://github.com/apache/spark/pull/19362 to branch-2.2
## What changes were
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19362
[SPARK-22141][SQL] Propagate empty relation before checking Cartesian
products
## What changes were proposed in this pull request?
When inferring constraints from children, Join&#
Github user gengliangwang closed the pull request at:
https://github.com/apache/spark/pull/19253
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19253
@gatorsmile @viirya Thanks. I should close this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19253
[SPARK-22037][SQL] Collapse Project if it is the child of Aggregate
## What changes were proposed in this pull request?
If Aggregate's child is Project, collapse the Project int
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Yes, I agree. But constraints is used in filter inference only, and it
works now. The code changes in this PR make the logic complex.
I think we should make the logic simpler, if we decide
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Thanks.
I run the test case with the rule "InferFiltersFromConstraints", the result
has `c > 5`.
The rule will be executed m
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
```
a === b && a === 1 && b === 5
```
The result is always False.
---
-
To unsubscribe,
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Hi @viirya ,
could you find a better example?
The one in the description/test case should be optimized to False
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19201#discussion_r138409695
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
---
@@ -106,91 +106,48 @@ trait
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19201
[SPARK-21979][SQL]Improve QueryPlanConstraints framework
## What changes were proposed in this pull request?
Improve QueryPlanConstraints framework, make it robust and simple.
In
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18471
Close this for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gengliangwang closed the pull request at:
https://github.com/apache/spark/pull/18471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19064
[SPARK-21848][SQL] Add trait UDFType to identify user-defined functions
## What changes were proposed in this pull request?
Add trait UDFType to identify user-defined functions
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18499#discussion_r131119963
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -194,30 +194,26 @@ private[spark] object JettyUtils extends Logging
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18499#discussion_r131085567
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -194,30 +194,26 @@ private[spark] object JettyUtils extends Logging
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18499#discussion_r131118306
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -194,30 +194,26 @@ private[spark] object JettyUtils extends Logging
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18499
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18560
Revise rand comparison in BatchEvalPythonExecSuite
## What changes were proposed in this pull request?
Revise rand comparison in BatchEvalPythonExecSuite
In
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18549
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18549#discussion_r125811566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/ValueInterval.scala
---
@@ -38,46 +38,49 @@ case
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18548
cc @rxin @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18549
cc @rxin @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18549
rename plans.logical.statsEstimation.Range to ValueInterval
## What changes were proposed in this pull request?
Rename
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18548
[SPARK-21273][SQL][Follow-up] Add missing test cases back and revise code
style
## What changes were proposed in this pull request?
Add missing test cases back and revise code style
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18471#discussion_r124964773
--- Diff: scalastyle-config.xml ---
@@ -245,7 +245,13 @@ This file is divided into 3 sections:
- COMMA
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18471#discussion_r124952579
--- Diff: scalastyle-config.xml ---
@@ -46,7 +46,7 @@ This file is divided into 3 sections:
-
+
--- End diff
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18471
Most changes are done by my ruby script:
```ruby
lines = `./dev/lint-scala 2>&1 | grep "before\\|after"`.split("\n")
lines.each do |line|
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18471
[SPARK-21259] More rules for scalastyle
## What changes were proposed in this pull request?
Add more rules for scalastyle
During code review, we spent so much time on code style
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124460130
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,19 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124455883
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,19 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124454937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,19 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124453937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,19 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124434769
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateDistinctSuite.scala
---
@@ -0,0 +1,56
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124434727
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateDistinctSuite.scala
---
@@ -0,0 +1,56
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124432003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -40,6 +40,7 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124432068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -152,6 +153,17 @@ abstract class Optimizer
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18429#discussion_r124178339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateDistinceSuite.scala
---
@@ -0,0 +1,56
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18429
Hi @gatorsmile ,
Thanks for the comments. I have just pushed code changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18429
[SPARK-21222] Move elimination of Distinct clause from analyzer to optimizer
## What changes were proposed in this pull request?
Move elimination of Distinct clause from analyzer to
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18409
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18387
@cloud-fan The error message comes from AstBuilder. The code change in
SqlBase.g4 allows tablesample to process negative number, and throw
ParseException in AstBuilder.
We can't
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18409
@gatorsmile Thanks, I have revised the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18409
Example:
```java
codegenStringSeq(sql("select 1").queryExecution.executedPlan)
```
The example will return Seq[(String, String)] of length 1, containing the
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18409
[SPARK-21196] Split codegen info of query plan into sequence
## What changes were proposed in this pull request?
add method codegenToSeq: Split codegen info of query plan into sequence
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18387
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123640089
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -457,6 +457,29 @@ class DatasetSuite extends QueryTest with
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123634463
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/tablesample-negative.sql ---
@@ -0,0 +1,13 @@
+-- Negative testcases for tablesample
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123631124
--- Diff:
sql/core/src/test/resources/sql-tests/results/tablesample-negative.sql.out ---
@@ -0,0 +1,62 @@
+-- Automatically generated by
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123571267
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -817,6 +818,18 @@ case class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123451274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -817,6 +818,18 @@ case class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123450399
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1805,9 +1805,6 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18387#discussion_r123435434
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/tablesample-negative.sql ---
@@ -0,0 +1,13 @@
+-- Negative testcases for tablesample
701 - 800 of 801 matches
Mail list logo
