Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/22095
@holdenk @felixcheung small change to separate from SparkR PR. Ready for
merge
---
-
To unsubscribe, e-mail: reviews
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/22095
[SPARK-23984][K8S] Changed Python Version config to be camelCase
## What changes were proposed in this pull request?
Small formatting change to have Python Version be camelCase as per
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r208558956
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -212,6 +212,60 @@ private[spark] object
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r208257021
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -336,7 +336,7 @@ private[spark] class SparkSubmit extends Logging
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r207605696
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -205,7 +218,7 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21977
This seems very applicable to add to Kubernetes as well. We already
increased the DEFAULT_MEMORY_OVERHEAD to account for memory issues that arise
with users forgetting to increase the memory
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r207382976
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
---
@@ -0,0 +1,29 @@
+#
+# Licensed
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r207281949
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
---
@@ -107,7 +109,14
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r205928623
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -205,7 +218,7 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21748#discussion_r205752304
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21748
@mccheah the integration tests did not include the ClientModeTestsSuite.
Can you add `with ClientModeTestsSuite` else, the PRB doesn't actually test the
client mode support accurately
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r205132947
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -71,8 +75,9
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r204713851
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
---
@@ -0,0 +1,29 @@
+#
+# Licensed
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
@felixcheung the PRB isnât currently configured with capability to build
âr distributions. Waiting on @shaneknapp, which is why it is unable to build
the image. With an R supported
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
Ready for merge upon PRB passing the tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
All tests pass locally. Waiting on PRB to be configured.
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203446470
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203178554
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105805
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -29,25
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21652#discussion_r203105117
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
---
@@ -0,0
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21517
Is this stale now? Can we close?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21652
I refactored stale tests and added a few more in for PySpark in my most
recent PR, apologise for the resulting merge conflicts. Otherwise, this LGTM
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
@mccheah
@foxish
Can we merge?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r201696463
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -81,4 +83,35 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
@felixcheung The integration tests already run `docker-image-tool.sh -t
testing build` which build the `spark-base`, `spark-py`, and `spark-r` images.
At which point integration tests would
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
@shaneknapp this problem does not occur on Docker version 18.xxx which is
running on my local setup. The error is distinctively the:
â
Please provide a source image with `from` prior
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
@foxish The problem is the same as described here:
https://github.com/moby/moby/issues/32457 which should have been solved in
`Docker 17.05`. As such, this is prompted by a deprecated version
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r200401350
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -81,4 +83,35 @@ private[spark] object
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r200399452
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -211,6 +211,51 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
@felixcheung @mccheah by that logic.. should then both Python and R images
be version configurable? This is all handled in the `bin/docker-image-tool.sh`
? Aren't those configurations just way
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/13599
Is there any work being done on this PR at this point in time?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21660#discussion_r199596586
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -21,17
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
The problem is due to the version of Docker @foxish Can we update the
Docker version on the nodes? @shaneknapp
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/21669
[SPARK-23257][K8S][WIP] Kerberos Support for Spark on K8S
## What changes were proposed in this pull request?
This is the work on setting up Secure HDFS interaction with Spark-on-K8S
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21462
@skonto can we hold off on that until I merge Kerberos support? It is in
the works :)
---
-
To unsubscribe, e-mail: reviews
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21555
@mccheah Good note. As this is a blocker for other PRs. It is probably best
to refactor the `docker-image-tool.sh` in a separate PR for that is the not the
focus of this PR
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21555
Good to merge with tests success. @mccheah and @foxish please merge
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21584#discussion_r196577500
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
---
@@ -0,0 +1,29 @@
+#
+# Licensed
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21555
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21555
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21555
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r196249925
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
This PR is now just waiting on appropriate changes to
`bin/docker-image-tool.sh` which are contained in the following PR: #21551 .
Will wait until that is merged
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21584
@felixcheung for initial review
There is still a need for the integration testing environment to be setup
on the PRB side. But I would like community opinion on the format of the
Dockerfile
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/21584
[SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on K8s
## What changes were proposed in this pull request?
Introducing R Bindings for Spark R on K8s
- [ ] Running SparkR
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
I don't know if Jenkins build a distribution with `--pip`. TBD based on
success. But locally, this worked when I ran:
`dev/make-distribution.sh --pip --tgz -Phadoop-2.7 -Pkubernetes
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21583
@ssuchter @holdenk @mccheah for review
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ifilonenko opened a pull request:
https://github.com/apache/spark/pull/21583
[SPARK-23984][K8S][Test] Added Integration Tests for PySpark on Kubernetes
## What changes were proposed in this pull request?
I added integration tests for PySpark ( + checking JVM
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919967
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195920245
--- Diff: python/pyspark/context.py ---
@@ -1035,6 +1044,46 @@ def getConf(self):
conf.setAll(self._conf.getAll())
return conf
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919580
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919982
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919958
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919848
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195920107
--- Diff: core/src/main/scala/org/apache/spark/deploy/PythonRunner.scala ---
@@ -39,12 +39,17 @@ object PythonRunner {
val pyFiles = args(1
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195920034
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195919641
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195920098
--- Diff:
core/src/main/scala/org/apache/spark/api/python/VirtualEnvFactory.scala ---
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/13599#discussion_r195920112
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -475,6 +475,19 @@ object SparkSubmit extends CommandLineUtils
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21572
Error from QA is unrelated to PR. We will need to wait for the PRB to be
reconfigured for this to be properly tested. What integration tests have you
run to handle this change
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r195900804
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
SPARK_CLASSPATH
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r195900749
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -45,12 +45,10 @@ shift 1
SPARK_CLASSPATH
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/20697
@mccheah will do. also will investigate the remote test issue.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21511#discussion_r194128417
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -172,7 +184,7
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20697#discussion_r194124004
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -0,0
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194117385
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -88,15 +90,42 @@ class
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193913624
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193801841
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193796798
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/20697#discussion_r192274844
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
---
@@ -0,0
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192245644
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,33 @@
+#
+# Licensed
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192245626
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192241796
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -48,7 +48,8
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192241158
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,6 +53,28 @@ if [ -n "$SPARK_MOUNTED_FILE
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
Will resolve comments today @mccheah
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187811483
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,8
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186793604
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -44,11 +44,16
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21202
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186329528
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186321782
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -63,10 +67,17 @@ private[spark] case
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186298350
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -88,15 +94,22
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186266469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186254991
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ifilonenko commented on the issue:
https://github.com/apache/spark/pull/21092
@shaneknapp @ssuchter integration tests seem to be failing not due to this
PR, but in general. Please investigate, because this PR does pass integration
tests + an extra PySpark test
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r183163821
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -62,6 +69,14 @@ case "$SPARK_K8
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r183163103
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -87,11 +89,37 @@ class
201 - 300 of 331 matches
Mail list logo
