Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r235198775
--- Diff: dev/create-release/release-build.sh ---
@@ -110,16 +110,18 @@ fi
# Depending on the version being built, certain extra profiles need
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r235198880
--- Diff: project/MimaExcludes.scala ---
@@ -375,993 +375,10 @@ object MimaExcludes {
ProblemFilters.exclude[FinalMethodProblem
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r235199020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -939,11 +939,9 @@ trait ScalaReflection extends Logging
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23098#discussion_r235198325
--- Diff: bin/load-spark-env.cmd ---
@@ -21,37 +21,42 @@ rem This script loads spark-env.cmd if it exists, and
ensures it is only loaded
rem spark
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23098
[WIP][SPARK-26132][BUILD][CORE] Remove support for Scala 2.11 in Spark 3.0.0
## What changes were proposed in this pull request?
Remove Scala 2.11 support in build files and docs
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23097
[SPARK-26043][HOTFIX] Hotfix a change to SparkHadoopUtil that doesn't work
in 2.11
## What changes were proposed in this pull request?
Hotfix a change to SparkHadoopUtil that doesn't work
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23081
Jenkins, add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23090
Why not just hard-code a much higher limit? what's the consequence? in a
generic public web server I can see that this defends against malicious or
malformed requests, but that's much less an issue
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22994
I don't know this script well enough nor Python to really comment, but if
it works, push it.
---
-
To unsubscribe, e-mail
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22875
Ah OK I wasn't reading that carefully.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22875
How about BisecingKMeansModel? That's what I was looking at. That
computeCost is also deprecated.
---
-
To unsubscribe, e-mail
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r235033743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23048#discussion_r235031986
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -370,14 +370,19 @@ object Vectors {
case (v1: DenseVector
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23049
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23030
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23093#discussion_r235019790
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -91,7 +91,7 @@ class DecisionTreeClassifier @Since
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23087
It's OK; it clearly does merge cleanly and tests pass. I have seen
apparently spurious "does not merge cleanly" messages before and I assume it's
because something else transient
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23093#discussion_r235015293
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -91,7 +91,7 @@ class DecisionTreeClassifier @Since
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234861969
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,35 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234859506
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,35 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234858573
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,35 @@ object TestingUDT
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23069
Yeah, or at least so claims Scala 2.12. Java evidently doesn't object.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234846910
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,35 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234846234
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234846491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23087
Will do. I'm going to update some SBT plugins too. Many we can't update
because they kind of go hand-in-hand with SBT 1.x, and those versions in turn
seem to go with Scala 2.12, so they may all have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234833024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234834497
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,64 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234834269
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,64 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234834453
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,64 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234833180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -462,12 +462,12 @@ case class NewInstance
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234834318
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,64 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234834550
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -109,6 +109,64 @@ object TestingUDT
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234833053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -973,8 +998,19 @@ trait ScalaReflection extends Logging
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234832389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23087
[MINOR][BUILD] Update plugins to latest versions
## What changes were proposed in this pull request?
Update plugins we use to the latest version.
## How was this patch tested
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22683
@wangyum @httfighter what do you think?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/23069
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/23066
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23065
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23066
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23069
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23065
Hm, Kinesis tests are failing. They pass locally when I set my credentials
and enable the tests. They also seem to pass on Jenkins, like on this recent
PR:
https://amplab.cs.berkeley.edu/jenkins
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23069
How do we check if doc artifacts were built? well, honestly we (meaning, I)
should have noticed this in our releases. Docs were obviously generated for the
public site, just not the artifacts
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r234412163
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {
private[ml
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22986
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23016
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r234405667
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {
private[ml
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23069
[SPARK-26026][BUILD] Published Scaladoc jars missing from Maven Central
## What changes were proposed in this pull request?
This restores scaladoc artifact generation, which got dropped
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22779
@10110346 are you in a position to update this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404797
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -453,7 +453,7 @@ case class NewInstance
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -498,6 +504,7 @@ case class NewInstance
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23062#discussion_r234404888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -788,12 +788,37 @@ object ScalaReflection extends
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23066
CC @vanzin . I took the liberty of simplifying a few other bits of the file
too.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23066
[SPARK-26043][CORE] Make SparkHadoopUtil private to Spark
## What changes were proposed in this pull request?
Make SparkHadoopUtil private to Spark
## How was this patch tested
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22995#discussion_r234396107
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -93,7 +96,14 @@ private[spark] class TorrentBroadcast[T: ClassTag
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23016#discussion_r234395721
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -174,6 +174,10 @@ class PrefixSpan private (
val freqSequences
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393692
--- Diff: common/unsafe/pom.xml ---
@@ -89,6 +89,11 @@
commons-lang3
test
+
+ org.apache.commons
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393727
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
@@ -138,7 +138,7 @@ class AvroSuite extends QueryTest
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393870
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
---
@@ -48,7 +45,7 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393768
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/LabeledPoint.scala ---
@@ -30,8 +28,12 @@ import org.apache.spark.ml.linalg.Vector
* @param
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393704
--- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
@@ -30,7 +30,7 @@ import org.apache.spark.storage.RDDInfo
@DeveloperApi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393743
--- Diff:
external/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -105,25 +105,22 @@ public static void
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393799
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -276,10 +276,10 @@ class QuantileDiscretizerSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393720
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala
---
@@ -56,7 +56,7 @@ trait KafkaContinuousTest
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393826
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -601,7 +601,7 @@ class ALSSuite extends MLTest
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393755
--- Diff:
external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java
---
@@ -49,13 +51,14 @@ public
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/23065
[SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous deprecation and
build warnings for Spark 3
## What changes were proposed in this pull request?
The build has a lot of deprecation
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23043
They do, FWIW:
```
scala> java.lang.Double.doubleToLongBits(0.0)
res1: Long = 0
scala> java.lang.Double.doubleToLongBits(-0.0)
res2: Long = -9223372036854
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22937
Merged to master/2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22937
If there are no further comments from Mesos experts and you're confident in
the change; it seems reasonable to me
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23030#discussion_r234232203
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -735,18 +744,8 @@ private[yarn] class YarnAllocator
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23013
Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23049#discussion_r234003620
--- Diff: bin/load-spark-env.sh ---
@@ -42,19 +42,20 @@ fi
# Setting SPARK_SCALA_VERSION if not already set.
if [ -z "$SPARK_SCALA_VE
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23043
@kiszk This spun out of https://issues.apache.org/jira/browse/SPARK-24834
and https://github.com/apache/spark/pull/21794 ; is that what you may be
thinking of? I'm not aware of others
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23009
Merged to master/2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23013
@tgravescs @mccheah @rvesse is this pretty much OK with all of you?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23024
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16732#discussion_r233901615
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -275,22 +275,33 @@ class BlockMatrix @Since("
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23030#discussion_r233901330
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -598,13 +598,24 @@ private[yarn] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23049#discussion_r233900961
--- Diff: bin/load-spark-env.sh ---
@@ -47,8 +47,8 @@ if [ -z "$SPARK_SCALA_VERSION" ]; then
ASSEMBLY_DIR1="${SPARK_HOME}/assembly/ta
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23030#discussion_r233887452
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -378,14 +380,16 @@ class YarnAllocatorSuite
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22974
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16732#discussion_r233879857
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -275,22 +275,33 @@ class BlockMatrix @Since("
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16732#discussion_r233879830
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -275,22 +275,33 @@ class BlockMatrix @Since("
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23048#discussion_r233866690
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -370,14 +370,19 @@ object Vectors {
case (v1: DenseVector
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22989#discussion_r233842829
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -39,7 +39,9 @@ public static int getSize(Object object, long
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22989#discussion_r233713175
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -39,7 +39,9 @@ public static int getSize(Object object, long
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23016
I'm not sure about that, because the returned PrefixSpanModel has an RDD
that depends on that RDD. We could cache the final RDD instead and materialize
it; that could make more sense
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22989
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/22993
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22993
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23024#discussion_r233556532
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala
---
@@ -92,16 +93,7 @@ private[ui] class ExecutorTable(stage: StageData, store
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22986#discussion_r233506625
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {
private[ml
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22779#discussion_r233504880
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -338,7 +338,7 @@ private[spark] class KryoSerializerInstance(ks
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22779#discussion_r233502464
--- Diff:
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
@@ -41,7 +41,7 @@ import org.apache.spark.internal.Logging
import
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16732
Looks good @uzadude ; just saw this very old PR. However what about
@akaltsikis 's comment?
---
-
To unsubscribe, e-mail
201 - 300 of 15282 matches
Mail list logo
