Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-161054543
Thanks, merging to master and 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9840
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46225749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale: Int)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160843886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160843848
**[Test build #46927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46927/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160843885
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160826945
**[Test build #46927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46927/consoleFull)**
for PR 9840 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46222924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -88,7 +88,8 @@ class Analyzer(
Batch("UDF",
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46226934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale: Int)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46226311
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46224339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46225847
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale: Int)
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46226966
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale:
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160811887
Other than @davies concerns this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160844844
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160866429
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160866430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160866370
**[Test build #46937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46937/consoleFull)**
for PR 9840 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160846885
**[Test build #46937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46937/consoleFull)**
for PR 9840 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160622335
A little bit off topic but related. Currently, our casting rules (either
implicit or explicit casting) are defined as full functions, thus it's hard to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46015611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -85,12 +85,24 @@ case class DecimalType(precision: Int, scale:
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160036107
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160036089
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160036090
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160037107
**[Test build #46801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46801/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160050723
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160050677
**[Test build #46801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46801/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-160050725
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159878842
**[Test build #46764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46764/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159880666
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159880647
**[Test build #46764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46764/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159880670
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46001855
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46002027
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -235,12 +236,13 @@ case class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46002504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -235,12 +236,13 @@ case class ExpressionEncoder[T](
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r46002594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -235,12 +236,13 @@ case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159524728
**[Test build #4 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/4/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159524808
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159524810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45768920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,34 @@ object ComputeCurrentTime extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45769130
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -235,12 +236,13 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45769310
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolveSuite.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45769885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,34 @@ object ComputeCurrentTime extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159356404
This is going to be a huge usability improvement. Thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45770895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +123,46 @@ object ScalaReflection extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45770937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +123,46 @@ object ScalaReflection extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45770991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +123,46 @@ object ScalaReflection extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45771035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,34 @@ object ComputeCurrentTime extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45770730
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolveSuite.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45830352
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45830487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1169,3 +1170,31 @@ object ComputeCurrentTime extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45830606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -235,12 +236,13 @@ case class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159495265
**[Test build #4 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/4/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159220529
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159220531
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159220389
**[Test build #46583 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46583/consoleFull)**
for PR 9840 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159163316
**[Test build #46583 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46583/consoleFull)**
for PR 9840 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159115247
**[Test build #46569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46569/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159134874
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159134875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-159181742
It's blocked by https://github.com/apache/spark/pull/9928
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45569682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +124,46 @@ object ScalaReflection extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r45562684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +124,46 @@ object ScalaReflection extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158735571
**[Test build #46486 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46486/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158735602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158735601
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/9840#discussion_r4624
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -124,17 +124,46 @@ object ScalaReflection extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158714817
**[Test build #46486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46486/consoleFull)**
for PR 9840 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158463259
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158462653
**[Test build #46424 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46424/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158495010
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158495014
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158494955
**[Test build #46424 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46424/consoleFull)**
for PR 9840 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158595407
**[Test build #46470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46470/consoleFull)**
for PR 9840 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158595475
**[Test build #46470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46470/consoleFull)**
for PR 9840 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158595479
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9840#issuecomment-158595477
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
77 matches
Mail list logo
