Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r91006319
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -346,6 +346,31 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r91006034
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -346,6 +346,31 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r91001189
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -346,6 +346,31 @@ abstract class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90788135
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90756432
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl(
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90681188
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90582264
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90582154
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -346,6 +346,31 @@ abstract class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90503688
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClient.scala ---
@@ -155,6 +155,25 @@ private[hive] trait HiveClient {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90181898
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClient.scala ---
@@ -155,6 +155,25 @@ private[hive] trait HiveClient {
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90181774
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +924,25 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +483,19 @@ class InMemoryCatalog(
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog(
}
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,11 +189,28 @@ abstract class ExternalCatalog
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90103384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,11 +189,28 @@ abstract class ExternalCatalog {
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90092477
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90097773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +482,19 @@ class InMemoryCatalog(
}
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90114390
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -408,14 +411,18 @@ class HiveCommandSuite extends
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90092813
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89909840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89906448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog(
}
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89839435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89681535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog(
}
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89680470
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89679682
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89679527
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89679485
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89679477
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,6 +189,21 @@ abstract class ExternalCatalog {
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89678628
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +482,19 @@ class InMemoryCatalog(
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89678259
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89678233
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +482,19 @@ class InMemoryCatalog(
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89656487
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +482,19 @@ class InMemoryCatalog(
}
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89656749
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89656509
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,6 +189,21 @@ abstract class ExternalCatalog {
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89656787
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -922,6 +923,29 @@ private[spark] class HiveExternalCatalog(conf:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r89411482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,6 +189,38 @@ abstract class ExternalCatalog {
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/15998
[SPARK-18572][SQL] Add a method `listPartitionName` to `ExternalCatalog`
(Link to Jira issue: https://issues.apache.org/jira/browse/SPARK-18572)
## What changes were proposed in this pull
38 matches
Mail list logo
